[go] path/filepath: reject Windows volume names containing ..

3 views
Skip to first unread message

Quim Muntal (Gerrit)

unread,
Jun 9, 2026, 9:58:00 AM (22 hours ago) Jun 9
to goph...@pubsubhelper.golang.org, Damien Neil, Alex Brainman, golang-co...@googlegroups.com
Attention needed from Alex Brainman and Damien Neil

Quim Muntal voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Alex Brainman
  • Damien Neil
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: Iab11823905c2dbc2ac1571ad7ff81d02cdbab055
Gerrit-Change-Number: 788701
Gerrit-PatchSet: 1
Gerrit-Owner: Quim Muntal <quimm...@gmail.com>
Gerrit-Reviewer: Alex Brainman <alex.b...@gmail.com>
Gerrit-Reviewer: Damien Neil <dn...@google.com>
Gerrit-Reviewer: Quim Muntal <quimm...@gmail.com>
Gerrit-Attention: Damien Neil <dn...@google.com>
Gerrit-Attention: Alex Brainman <alex.b...@gmail.com>
Gerrit-Comment-Date: Tue, 09 Jun 2026 13:57:53 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
unsatisfied_requirement
satisfied_requirement
open
diffy

Damien Neil (Gerrit)

unread,
Jun 9, 2026, 2:02:56 PM (17 hours ago) Jun 9
to Quim Muntal, goph...@pubsubhelper.golang.org, golang...@luci-project-accounts.iam.gserviceaccount.com, Alex Brainman, golang-co...@googlegroups.com
Attention needed from Alex Brainman and Quim Muntal

Damien Neil voted and added 1 comment

Votes added by Damien Neil

Code-Review+2

1 comment

File src/internal/filepathlite/path_windows.go
Line 222, Patchset 1 (Latest): case pathHasPrefixFold(path, `\\.\UNC`):
Damien Neil . unresolved

Should this also handle `\\?\unc` and `\??\unc` ?

Open in Gerrit

Related details

Attention is currently required from:
  • Alex Brainman
  • Quim Muntal
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: Iab11823905c2dbc2ac1571ad7ff81d02cdbab055
Gerrit-Change-Number: 788701
Gerrit-PatchSet: 1
Gerrit-Owner: Quim Muntal <quimm...@gmail.com>
Gerrit-Reviewer: Alex Brainman <alex.b...@gmail.com>
Gerrit-Reviewer: Damien Neil <dn...@google.com>
Gerrit-Reviewer: Quim Muntal <quimm...@gmail.com>
Gerrit-Attention: Quim Muntal <quimm...@gmail.com>
Gerrit-Attention: Alex Brainman <alex.b...@gmail.com>
Gerrit-Comment-Date: Tue, 09 Jun 2026 18:02:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Quim Muntal (Gerrit)

unread,
3:39 AM (4 hours ago) 3:39 AM
to goph...@pubsubhelper.golang.org, Damien Neil, golang...@luci-project-accounts.iam.gserviceaccount.com, Alex Brainman, golang-co...@googlegroups.com
Attention needed from Alex Brainman

Quim Muntal added 1 comment

File src/internal/filepathlite/path_windows.go
Line 222, Patchset 1 (Latest): case pathHasPrefixFold(path, `\\.\UNC`):
Damien Neil . resolved

Should this also handle `\\?\unc` and `\??\unc` ?

Quim Muntal

Good catch, yes. Will do that in a follow-up PR.

Open in Gerrit

Related details

Attention is currently required from:
  • Alex Brainman
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: Iab11823905c2dbc2ac1571ad7ff81d02cdbab055
Gerrit-Change-Number: 788701
Gerrit-PatchSet: 1
Gerrit-Owner: Quim Muntal <quimm...@gmail.com>
Gerrit-Reviewer: Alex Brainman <alex.b...@gmail.com>
Gerrit-Reviewer: Damien Neil <dn...@google.com>
Gerrit-Reviewer: Quim Muntal <quimm...@gmail.com>
Gerrit-Attention: Alex Brainman <alex.b...@gmail.com>
Gerrit-Comment-Date: Wed, 10 Jun 2026 07:39:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Damien Neil <dn...@google.com>
satisfied_requirement
unsatisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages