[go] runtime/secret: reorganize tests to fix -buildmode=shared
4 views
Skip to first unread message
Daniel Morsing (Gerrit)
Nov 27, 2025, 2:03:49 AM (3 days ago) Nov 27
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Daniel Morsing has uploaded the change for review![]( "Open in Gerrit")
Commit message
runtime/secret: reorganize tests to fix -buildmode=shared
The testing assembly methods had some linknames that were implicitly
satisfied during the regular build but not there during the shared
build. Fix by moving the testing routine into the package itself.
For good measure, section off the assembly files from the non-experiment
build. Should prevent further build failures as we work on this.
Change-Id: I2b45668e44641ae7880ff14f6402d982c7eaedd7
Change diff
diff --git a/src/runtime/secret/asm_amd64.s b/src/runtime/secret/asm_amd64.s
index 7011afc..0f2a474 100644
--- a/src/runtime/secret/asm_amd64.s
+++ b/src/runtime/secret/asm_amd64.s
@@ -2,6 +2,8 @@
// Use of this source code is governed by a BSD-style
// license that can be found in the LICENSE file.
+//go:build goexperiment.runtimesecret
+
// Note: this assembly file is used for testing only.
// We need to access registers directly to properly test
// that secrets are erased and go test doesn't like to conditionally
@@ -208,6 +210,6 @@
// registers contain secrets.
// It also tests the path from G stack to M stack
// to scheduler and back.
- CALL ·delay(SB)
+ CALL runtime∕secret·delay(SB)
RET
diff --git a/src/runtime/secret/asm_arm64.s b/src/runtime/secret/asm_arm64.s
index 1d7f7c1..6fa625a 100644
--- a/src/runtime/secret/asm_arm64.s
+++ b/src/runtime/secret/asm_arm64.s
@@ -2,6 +2,8 @@
// Use of this source code is governed by a BSD-style
// license that can be found in the LICENSE file.
+//go:build goexperiment.runtimesecret
+
// Note: this assembly file is used for testing only.
// We need to access registers directly to properly test
// that secrets are erased and go test doesn't like to conditionally
diff --git a/src/runtime/secret/stubs.go b/src/runtime/secret/stubs.go
index ec66ef2..3438d97 100644
--- a/src/runtime/secret/stubs.go
+++ b/src/runtime/secret/stubs.go
@@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style
// license that can be found in the LICENSE file.
-//go:build arm64 || amd64
+//go:build goexperiment.runtimesecret && (arm64 || amd64)
// testing stubs, these are implemented in assembly in
// asm_$GOARCH.s
@@ -13,7 +13,10 @@
package secret
-import "unsafe"
+import (
+ "time"
+ "unsafe"
+)
// Load data from p into test registers.
//
@@ -30,3 +33,8 @@
//
//go:noescape
func useSecret(secret []byte)
+
+// callback from assembly
+func delay() {
+ time.Sleep(1 * time.Millisecond)
+}
diff --git a/src/runtime/secret/testdata/crash.go b/src/runtime/secret/testdata/crash.go
index cf48fb7..1ee1ea6 100644
--- a/src/runtime/secret/testdata/crash.go
+++ b/src/runtime/secret/testdata/crash.go
@@ -18,13 +18,6 @@
"weak"
)
-// callback from assembly
-//
-//go:linkname delay main.delay
-func delay() {
- time.Sleep(1 * time.Millisecond)
-}
-
// Same secret as in ../../crash_test.go
var secretStore = [8]byte{
0x00,
Change information
Files:
- M src/runtime/secret/asm_amd64.s
- M src/runtime/secret/asm_arm64.s
- M src/runtime/secret/stubs.go
- M src/runtime/secret/testdata/crash.go
Change size: S
Delta: 4 files changed, 15 insertions(+), 10 deletions(-)
Related details
Attention set is empty
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Daniel Morsing (Gerrit)
Nov 27, 2025, 2:26:58 AM (3 days ago) Nov 27
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Attention needed from Austin Clements, Keith Randall and Michael Knyszek
Daniel Morsing uploaded new patchset![]( "Open in Gerrit")
Daniel Morsing uploaded patch set #2 to this change.
Related details
Attention is currently required from:
- Austin Clements
- Keith Randall
- Michael Knyszek
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Daniel Morsing (Gerrit)
Nov 27, 2025, 2:29:19 AM (3 days ago) Nov 27
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Attention needed from Austin Clements, Keith Randall and Michael Knyszek
Daniel Morsing uploaded new patchset![]( "Open in Gerrit")
Daniel Morsing uploaded patch set #3 to this change.
Related details
Attention is currently required from:
- Austin Clements
- Keith Randall
- Michael Knyszek
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Filippo Valsorda (Gerrit)
Nov 27, 2025, 5:45:04 AM (3 days ago) Nov 27
to Filippo Valsorda, Daniel Morsing, goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Attention needed from Austin Clements, David Chase, Filippo Valsorda, Keith Randall and Michael Knyszek
Filippo Valsorda uploaded new patchset![]( "Open in Gerrit")
Filippo Valsorda uploaded patch set #4 to the change originally created by Daniel Morsing.
Related details
Attention is currently required from:
- Austin Clements
- David Chase
- Filippo Valsorda
- Keith Randall
- Michael Knyszek
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Filippo Valsorda (Gerrit)
Nov 27, 2025, 5:50:19 AM (3 days ago) Nov 27
to Filippo Valsorda, Daniel Morsing, goph...@pubsubhelper.golang.org, Go LUCI, David Chase, Austin Clements, Keith Randall, Michael Knyszek, Gopher Robot, golang-co...@googlegroups.com
Attention needed from Austin Clements, Daniel Morsing, David Chase, Keith Randall and Michael Knyszek
Filippo Valsorda voted Code-Review+2![]( "Open in Gerrit")
Attention is currently required from:
- Austin Clements
- Daniel Morsing
- David Chase
- Keith Randall
- Michael Knyszek
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
David Chase (Gerrit)
Nov 27, 2025, 8:46:24 AM (3 days ago) Nov 27
to Filippo Valsorda, Daniel Morsing, goph...@pubsubhelper.golang.org, Go LUCI, Austin Clements, Keith Randall, Michael Knyszek, Gopher Robot, golang-co...@googlegroups.com
Attention needed from Austin Clements, Daniel Morsing, Filippo Valsorda, Keith Randall and Michael Knyszek
David Chase voted Code-Review+2![]( "Open in Gerrit")
| Code-Review | +2 |
Related details
Attention is currently required from:
- Austin Clements
- Daniel Morsing
- Filippo Valsorda
- Keith Randall
- Michael Knyszek
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dmitri Shuralyov (Gerrit)
Nov 27, 2025, 8:52:12 AM (3 days ago) Nov 27
to Filippo Valsorda, Daniel Morsing, goph...@pubsubhelper.golang.org, Dmitri Shuralyov, David Chase, Go LUCI, Austin Clements, Keith Randall, Michael Knyszek, Gopher Robot, golang-co...@googlegroups.com
Attention needed from Austin Clements, Daniel Morsing, Filippo Valsorda, Keith Randall and Michael Knyszek
Dmitri Shuralyov voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Austin Clements
- Daniel Morsing
- Filippo Valsorda
- Keith Randall
- Michael Knyszek
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gopher Robot (Gerrit)
Nov 27, 2025, 8:54:31 AM (3 days ago) Nov 27
to Daniel Morsing, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Dmitri Shuralyov, Dmitri Shuralyov, David Chase, Filippo Valsorda, Go LUCI, Austin Clements, Keith Randall, Michael Knyszek, golang-co...@googlegroups.com
Gopher Robot submitted the change![]( "Open in Gerrit")
Change information
Commit message:
runtime/secret: reorganize tests to fix -buildmode=shared
The testing assembly methods had a linkname that was implicitly
satisfied during the regular build but not there during the shared
build. Fix by moving the testing routine into the package itself.
For good measure, section off the assembly files from the non-experiment
build. Should prevent further build failures as we work on this.
Cq-Include-Trybots: luci.golang.try:gotip-linux-amd64-longtest,gotip-linux-arm64-longtest
Change-Id: I2b45668e44641ae7880ff14f6402d982c7eaedd7
Reviewed-on: https://go-review.googlesource.com/c/go/+/724001
Reviewed-by: David Chase <drc...@google.com>
Auto-Submit: Filippo Valsorda <fil...@golang.org>
Reviewed-by: Filippo Valsorda <fil...@golang.org>
LUCI-TryBot-Result: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Dmitri Shuralyov <dmit...@google.com>
Files:
- M src/runtime/secret/asm_amd64.s
- M src/runtime/secret/asm_arm64.s
- M src/runtime/secret/stubs.go
- M src/runtime/secret/testdata/crash.go
Change size: S
Delta: 4 files changed, 17 insertions(+), 9 deletions(-)
Branch: refs/heads/master
Submit Requirements:
Code-Review: +2 by Filippo Valsorda, +2 by David Chase, +1 by Dmitri Shuralyov
TryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages