[go] net: fix TestLookupCNAME
0 views
Skip to first unread message
Nicholas Husin (Gerrit)
Jun 30, 2026, 4:22:52 PM (8 hours ago) Jun 30
to Damien Neil, goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Attention needed from Damien Neil
Nicholas Husin has uploaded the change for review![]( "Open in Gerrit")
Nicholas Husin would like Damien Neil to review this change.
Commit message
net: fix TestLookupCNAME
The CNAME record for www.iana.org seems to have been changed, causing
test failures.
Change the test to just use www.golang.org, so we have more control and
awareness of such changes in the future.
Fixes #80212
Change-Id: I7b11bb8f90fe366db019dab1f8d9a1cf6a6a6964
Change diff
diff --git a/src/net/lookup_test.go b/src/net/lookup_test.go
index 42211ed..afa7e4c 100644
--- a/src/net/lookup_test.go
+++ b/src/net/lookup_test.go
@@ -335,8 +335,8 @@
var lookupCNAMETests = []struct {
name, cname string
}{
- {"www.iana.org", "icann.org."},
- {"www.iana.org.", "icann.org."},
+ {"www.golang.org", "golang.org."},
+ {"www.golang.org.", "golang.org."},
{"www.google.com", "google.com."},
{"google.com", "google.com."},
{"cname-to-txt.go4.org", "test-txt-record.go4.org."},
Change information
Files:
- M src/net/lookup_test.go
Change size: XS
Delta: 1 file changed, 2 insertions(+), 2 deletions(-)
Related details
Attention is currently required from:
- Damien Neil
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Russ Cox (Gerrit)
Jun 30, 2026, 4:28:13 PM (8 hours ago) Jun 30
to Nicholas Husin, goph...@pubsubhelper.golang.org, Russ Cox, golang...@luci-project-accounts.iam.gserviceaccount.com, Damien Neil, golang-co...@googlegroups.com
Attention needed from Damien Neil and Nicholas Husin
Russ Cox voted Code-Review+2![]( "Open in Gerrit")
Attention is currently required from:
- Damien Neil
- Nicholas Husin
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nicholas Husin (Gerrit)
Jun 30, 2026, 4:28:47 PM (8 hours ago) Jun 30
to Nicholas Husin, goph...@pubsubhelper.golang.org, Russ Cox, golang...@luci-project-accounts.iam.gserviceaccount.com, Damien Neil, golang-co...@googlegroups.com
Attention needed from Damien Neil and Nicholas Husin
Nicholas Husin voted![]( "Open in Gerrit")
| Auto-Submit | +1 |
| Code-Review | +1 |
Related details
Attention is currently required from:
- Damien Neil
- Nicholas Husin
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Damien Neil (Gerrit)
Jun 30, 2026, 4:30:37 PM (8 hours ago) Jun 30
to Nicholas Husin, goph...@pubsubhelper.golang.org, Nicholas Husin, Russ Cox, golang...@luci-project-accounts.iam.gserviceaccount.com, golang-co...@googlegroups.com
Attention needed from Nicholas Husin
Damien Neil voted Code-Review+2![]( "Open in Gerrit")
Attention is currently required from:
- Nicholas Husin
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nicholas Husin (Gerrit)
Jun 30, 2026, 4:35:45 PM (8 hours ago) Jun 30
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Nicholas Husin has uploaded the change for review![]( "Open in Gerrit")
Commit message
[release-branch.go1.26] net: fix TestLookupCNAME
The CNAME record for www.iana.org seems to have been changed, causing
test failures.
Change the test to just use www.golang.org, so we have more control and
awareness of such changes in the future.
For #80212
Fixes #80217
Change-Id: I7b11bb8f90fe366db019dab1f8d9a1cf6a6a6964
Change diff
diff --git a/src/net/lookup_test.go b/src/net/lookup_test.go
index 42211ed..afa7e4c 100644
--- a/src/net/lookup_test.go
+++ b/src/net/lookup_test.go
@@ -335,8 +335,8 @@
var lookupCNAMETests = []struct {
name, cname string
}{
- {"www.iana.org", "icann.org."},
- {"www.iana.org.", "icann.org."},
+ {"www.golang.org", "golang.org."},
+ {"www.golang.org.", "golang.org."},
{"www.google.com", "google.com."},
{"google.com", "google.com."},
{"cname-to-txt.go4.org", "test-txt-record.go4.org."},
Change information
Files:
- M src/net/lookup_test.go
Change size: XS
Delta: 1 file changed, 2 insertions(+), 2 deletions(-)
Related details
Attention set is empty
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nicholas Husin (Gerrit)
Jun 30, 2026, 4:36:38 PM (8 hours ago) Jun 30
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Nicholas Husin has uploaded the change for review![]( "Open in Gerrit")
Commit message
[release-branch.go1.25] net: fix TestLookupCNAME
The CNAME record for www.iana.org seems to have been changed, causing
test failures.
Change the test to just use www.golang.org, so we have more control and
awareness of such changes in the future.
For #80212
Fixes #80216
Change-Id: I7b11bb8f90fe366db019dab1f8d9a1cf6a6a6964
Change diff
diff --git a/src/net/lookup_test.go b/src/net/lookup_test.go
index b9a33ac..ecbcd16 100644
Nicholas Husin (Gerrit)
Jun 30, 2026, 4:36:56 PM (8 hours ago) Jun 30
to goph...@pubsubhelper.golang.org, Dmitri Shuralyov, golang-co...@googlegroups.com
Attention needed from Dmitri Shuralyov
Nicholas Husin voted Commit-Queue+1![]( "Open in Gerrit")
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nicholas Husin (Gerrit)
Jun 30, 2026, 4:37:03 PM (8 hours ago) Jun 30
to goph...@pubsubhelper.golang.org, Dmitri Shuralyov, golang-co...@googlegroups.com
Attention needed from Dmitri Shuralyov
Nicholas Husin voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Dmitri Shuralyov
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dmitri Shuralyov (Gerrit)
Jun 30, 2026, 4:43:26 PM (8 hours ago) Jun 30
to Nicholas Husin, goph...@pubsubhelper.golang.org, Junyang Shao, golang...@luci-project-accounts.iam.gserviceaccount.com, Dmitri Shuralyov, golang-co...@googlegroups.com
Attention needed from Junyang Shao
Dmitri Shuralyov voted and added 1 comment![]( "Open in Gerrit")
Votes added by Dmitri Shuralyov
| Code-Review | +2 |
Related details
Attention is currently required from:
- Junyang Shao
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dmitri Shuralyov (Gerrit)
Jun 30, 2026, 4:43:47 PM (8 hours ago) Jun 30
to Nicholas Husin, goph...@pubsubhelper.golang.org, Junyang Shao, golang...@luci-project-accounts.iam.gserviceaccount.com, Dmitri Shuralyov, golang-co...@googlegroups.com
Attention needed from Junyang Shao
Dmitri Shuralyov voted Code-Review+2![]( "Open in Gerrit")
| Code-Review | +2 |
Related details
Attention is currently required from:
- Junyang Shao
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gopher Robot (Gerrit)
Jun 30, 2026, 4:43:57 PM (8 hours ago) Jun 30
to Nicholas Husin, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, golang...@luci-project-accounts.iam.gserviceaccount.com, Damien Neil, Nicholas Husin, Russ Cox, golang-co...@googlegroups.com
Gopher Robot submitted the change![]( "Open in Gerrit")
Change information
Commit message:
net: fix TestLookupCNAME
The CNAME record for www.iana.org seems to have been changed, causing
test failures.
Change the test to just use www.golang.org, so we have more control and
awareness of such changes in the future.
Fixes #80212
Change-Id: I7b11bb8f90fe366db019dab1f8d9a1cf6a6a6964
Reviewed-on: https://go-review.googlesource.com/c/go/+/795840
Auto-Submit: Nicholas Husin <hu...@google.com>
LUCI-TryBot-Result: golang...@luci-project-accounts.iam.gserviceaccount.com <golang...@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Russ Cox <r...@golang.org>
Reviewed-by: Damien Neil <dn...@google.com>
Reviewed-by: Nicholas Husin <hu...@google.com>
Files:
- M src/net/lookup_test.go
Change size: XS
Delta: 1 file changed, 2 insertions(+), 2 deletions(-)
Branch: refs/heads/master
Submit Requirements:
Code-Review: +1 by Nicholas Husin, +2 by Russ Cox, +2 by Damien Neil
TryBots-Pass: LUCI-TryBot-Result+1 by golang...@luci-project-accounts.iam.gserviceaccount.com
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nicholas Husin (Gerrit)
Jun 30, 2026, 4:47:41 PM (8 hours ago) Jun 30
to Nicholas Husin, goph...@pubsubhelper.golang.org, Junyang Shao, Dmitri Shuralyov, golang...@luci-project-accounts.iam.gserviceaccount.com, Dmitri Shuralyov, golang-co...@googlegroups.com
Attention needed from Junyang Shao and Nicholas Husin
Nicholas Husin voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Junyang Shao
- Nicholas Husin
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nicholas Husin (Gerrit)
Jun 30, 2026, 4:47:42 PM (8 hours ago) Jun 30
to Nicholas Husin, goph...@pubsubhelper.golang.org, Junyang Shao, Dmitri Shuralyov, golang...@luci-project-accounts.iam.gserviceaccount.com, Dmitri Shuralyov, golang-co...@googlegroups.com
Attention needed from Junyang Shao and Nicholas Husin
Nicholas Husin voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Junyang Shao
- Nicholas Husin
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Junyang Shao (Gerrit)
Jun 30, 2026, 4:48:43 PM (8 hours ago) Jun 30
to Nicholas Husin, goph...@pubsubhelper.golang.org, Nicholas Husin, Dmitri Shuralyov, golang...@luci-project-accounts.iam.gserviceaccount.com, Dmitri Shuralyov, golang-co...@googlegroups.com
Attention needed from Nicholas Husin
Junyang Shao voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Nicholas Husin
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Junyang Shao (Gerrit)
Jun 30, 2026, 4:49:20 PM (8 hours ago) Jun 30
to Nicholas Husin, goph...@pubsubhelper.golang.org, Nicholas Husin, Dmitri Shuralyov, golang...@luci-project-accounts.iam.gserviceaccount.com, Dmitri Shuralyov, golang-co...@googlegroups.com
Attention needed from Nicholas Husin
Junyang Shao voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Nicholas Husin
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Junyang Shao (Gerrit)
Jun 30, 2026, 4:49:29 PM (8 hours ago) Jun 30
to Nicholas Husin, goph...@pubsubhelper.golang.org, Nicholas Husin, Dmitri Shuralyov, golang...@luci-project-accounts.iam.gserviceaccount.com, Dmitri Shuralyov, golang-co...@googlegroups.com
Attention needed from Nicholas Husin
Junyang Shao voted Auto-Submit+1![]( "Open in Gerrit")
| Auto-Submit | +1 |
Junyang Shao (Gerrit)
Jun 30, 2026, 4:49:40 PM (8 hours ago) Jun 30
to Nicholas Husin, goph...@pubsubhelper.golang.org, Nicholas Husin, Dmitri Shuralyov, golang...@luci-project-accounts.iam.gserviceaccount.com, Dmitri Shuralyov, golang-co...@googlegroups.com
Attention needed from Nicholas Husin
Junyang Shao voted Auto-Submit+1![]( "Open in Gerrit")
| Auto-Submit | +1 |
Related details
Attention is currently required from:
- Nicholas Husin
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gopher Robot (Gerrit)
Jun 30, 2026, 5:03:30 PM (7 hours ago) Jun 30
to Nicholas Husin, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, golang...@luci-project-accounts.iam.gserviceaccount.com, Junyang Shao, Nicholas Husin, Dmitri Shuralyov, Dmitri Shuralyov, golang-co...@googlegroups.com
Gopher Robot submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[release-branch.go1.25] net: fix TestLookupCNAME
The CNAME record for www.iana.org seems to have been changed, causing
test failures.
Change the test to just use www.golang.org, so we have more control and
awareness of such changes in the future.
For #80212
Fixes #80216
Change-Id: I7b11bb8f90fe366db019dab1f8d9a1cf6a6a6964
Reviewed-on: https://go-review.googlesource.com/c/go/+/795842
Reviewed-by: Nicholas Husin <hu...@google.com>
Auto-Submit: Junyang Shao <shaoj...@google.com>
LUCI-TryBot-Result: golang...@luci-project-accounts.iam.gserviceaccount.com <golang...@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Dmitri Shuralyov <dmit...@google.com>
Reviewed-by: Junyang Shao <shaoj...@google.com>
Files:
- M src/net/lookup_test.go
Change size: XS
Delta: 1 file changed, 2 insertions(+), 2 deletions(-)
Branch: refs/heads/release-branch.go1.25
Submit Requirements:
Code-Review: +2 by Dmitri Shuralyov, +1 by Nicholas Husin, +1 by Junyang Shao
TryBots-Pass: LUCI-TryBot-Result+1 by golang...@luci-project-accounts.iam.gserviceaccount.com
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gopher Robot (Gerrit)
Jun 30, 2026, 5:08:19 PM (7 hours ago) Jun 30
to Nicholas Husin, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, golang...@luci-project-accounts.iam.gserviceaccount.com, Junyang Shao, Nicholas Husin, Dmitri Shuralyov, Dmitri Shuralyov, golang-co...@googlegroups.com
Gopher Robot submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[release-branch.go1.26] net: fix TestLookupCNAME
The CNAME record for www.iana.org seems to have been changed, causing
test failures.
Change the test to just use www.golang.org, so we have more control and
awareness of such changes in the future.
For #80212
Fixes #80217
Change-Id: I7b11bb8f90fe366db019dab1f8d9a1cf6a6a6964
Reviewed-on: https://go-review.googlesource.com/c/go/+/795841
LUCI-TryBot-Result: golang...@luci-project-accounts.iam.gserviceaccount.com <golang...@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Dmitri Shuralyov <dmit...@google.com>
Reviewed-by: Nicholas Husin <hu...@google.com>
Reviewed-by: Junyang Shao <shaoj...@google.com>
Auto-Submit: Junyang Shao <shaoj...@google.com>
Files:
- M src/net/lookup_test.go
Change size: XS
Delta: 1 file changed, 2 insertions(+), 2 deletions(-)
Branch: refs/heads/release-branch.go1.26
Submit Requirements:
Code-Review: +2 by Dmitri Shuralyov, +1 by Junyang Shao, +1 by Nicholas Husin
TryBots-Pass: LUCI-TryBot-Result+1 by golang...@luci-project-accounts.iam.gserviceaccount.com
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages