[tools] gopls/internal/analysis/modernize: fix URL

2 views
Skip to first unread message

Kirill Kolyshkin (Gerrit)

unread,
Dec 17, 2025, 2:39:17 PM (2 days ago) Dec 17
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com

Kirill Kolyshkin has uploaded the change for review

Commit message

gopls/internal/analysis/modernize: fix URL

CL 706918 added a wrong URL to the deprecation notice, thus the
provided go run command does not work. Fix this.
Change-Id: I1e18fc1bb51752acf4539dc5c23df03e8b82c950

Change diff

diff --git a/gopls/internal/analysis/modernize/cmd/modernize/main.go b/gopls/internal/analysis/modernize/cmd/modernize/main.go
index 5a4b165..0f1f5e6 100644
--- a/gopls/internal/analysis/modernize/cmd/modernize/main.go
+++ b/gopls/internal/analysis/modernize/cmd/modernize/main.go
@@ -8,7 +8,7 @@
 // See [golang.org/x/tools/go/analysis/passes/modernize] for details.
 //
 // Deprecated: use 'go run
-// golang.org/x/tools/go/passes/modernize/cmd/modernize' instead. In
+// golang.org/x/tools/go/analysis/passes/modernize/cmd/modernize' instead. In
 // due course the modernizer suite will be accessed through "go fix";
 // see https://go.dev/issue/71859.
 package main

Change information

Files:
  • M gopls/internal/analysis/modernize/cmd/modernize/main.go
Change size: XS
Delta: 1 file changed, 1 insertion(+), 1 deletion(-)
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: tools
Gerrit-Branch: master
Gerrit-Change-Id: I1e18fc1bb51752acf4539dc5c23df03e8b82c950
Gerrit-Change-Number: 730820
Gerrit-PatchSet: 1
Gerrit-Owner: Kirill Kolyshkin <koly...@gmail.com>
unsatisfied_requirement
satisfied_requirement
open
diffy

Kirill Kolyshkin (Gerrit)

unread,
Dec 17, 2025, 2:40:10 PM (2 days ago) Dec 17
to goph...@pubsubhelper.golang.org, Alan Donovan, Robert Findley, golang-co...@googlegroups.com
Attention needed from Alan Donovan and Robert Findley

Kirill Kolyshkin voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Alan Donovan
  • Robert Findley
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: tools
Gerrit-Branch: master
Gerrit-Change-Id: I1e18fc1bb51752acf4539dc5c23df03e8b82c950
Gerrit-Change-Number: 730820
Gerrit-PatchSet: 1
Gerrit-Owner: Kirill Kolyshkin <koly...@gmail.com>
Gerrit-Reviewer: Alan Donovan <adon...@google.com>
Gerrit-Reviewer: Kirill Kolyshkin <koly...@gmail.com>
Gerrit-Reviewer: Robert Findley <rfin...@golang.org>
Gerrit-Attention: Alan Donovan <adon...@google.com>
Gerrit-Attention: Robert Findley <rfin...@golang.org>
Gerrit-Comment-Date: Wed, 17 Dec 2025 19:40:06 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
unsatisfied_requirement
satisfied_requirement
open
diffy

Alan Donovan (Gerrit)

unread,
Dec 17, 2025, 2:40:33 PM (2 days ago) Dec 17
to Kirill Kolyshkin, goph...@pubsubhelper.golang.org, Go LUCI, Robert Findley, golang-co...@googlegroups.com
Attention needed from Kirill Kolyshkin and Robert Findley

Alan Donovan voted and added 1 comment

Votes added by Alan Donovan

Auto-Submit+1
Code-Review+2
Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Alan Donovan . resolved

Thanks!

Open in Gerrit

Related details

Attention is currently required from:
  • Kirill Kolyshkin
  • Robert Findley
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: tools
Gerrit-Branch: master
Gerrit-Change-Id: I1e18fc1bb51752acf4539dc5c23df03e8b82c950
Gerrit-Change-Number: 730820
Gerrit-PatchSet: 1
Gerrit-Owner: Kirill Kolyshkin <koly...@gmail.com>
Gerrit-Reviewer: Alan Donovan <adon...@google.com>
Gerrit-Reviewer: Kirill Kolyshkin <koly...@gmail.com>
Gerrit-Reviewer: Robert Findley <rfin...@golang.org>
Gerrit-Attention: Kirill Kolyshkin <koly...@gmail.com>
Gerrit-Attention: Robert Findley <rfin...@golang.org>
Gerrit-Comment-Date: Wed, 17 Dec 2025 19:40:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Michael Knyszek (Gerrit)

unread,
Dec 18, 2025, 4:41:33 PM (18 hours ago) Dec 18
to Kirill Kolyshkin, goph...@pubsubhelper.golang.org, Go LUCI, Alan Donovan, Robert Findley, golang-co...@googlegroups.com
Attention needed from Kirill Kolyshkin and Robert Findley

Michael Knyszek voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Kirill Kolyshkin
  • Robert Findley
Submit Requirements:
    • requirement satisfiedCode-Review
    • requirement satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    • requirement satisfiedTryBots-Pass
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: tools
    Gerrit-Branch: master
    Gerrit-Change-Id: I1e18fc1bb51752acf4539dc5c23df03e8b82c950
    Gerrit-Change-Number: 730820
    Gerrit-PatchSet: 1
    Gerrit-Owner: Kirill Kolyshkin <koly...@gmail.com>
    Gerrit-Reviewer: Alan Donovan <adon...@google.com>
    Gerrit-Reviewer: Kirill Kolyshkin <koly...@gmail.com>
    Gerrit-Reviewer: Michael Knyszek <mkny...@google.com>
    Gerrit-Reviewer: Robert Findley <rfin...@golang.org>
    Gerrit-Attention: Kirill Kolyshkin <koly...@gmail.com>
    Gerrit-Attention: Robert Findley <rfin...@golang.org>
    Gerrit-Comment-Date: Thu, 18 Dec 2025 21:41:29 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Gopher Robot (Gerrit)

    unread,
    Dec 18, 2025, 4:42:02 PM (18 hours ago) Dec 18
    to Kirill Kolyshkin, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Michael Knyszek, Go LUCI, Alan Donovan, Robert Findley, golang-co...@googlegroups.com

    Gopher Robot submitted the change

    Change information

    Commit message:
    gopls/internal/analysis/modernize: fix URL

    CL 706918 added a wrong URL to the deprecation notice, thus the
    provided go run command does not work. Fix this.
    Change-Id: I1e18fc1bb51752acf4539dc5c23df03e8b82c950
    Auto-Submit: Alan Donovan <adon...@google.com>
    Reviewed-by: Alan Donovan <adon...@google.com>
    Reviewed-by: Michael Knyszek <mkny...@google.com>
    Files:
    • M gopls/internal/analysis/modernize/cmd/modernize/main.go
    Change size: XS
    Delta: 1 file changed, 1 insertion(+), 1 deletion(-)
    Branch: refs/heads/master
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Michael Knyszek, +2 by Alan Donovan
    • requirement satisfiedTryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: tools
    Gerrit-Branch: master
    Gerrit-Change-Id: I1e18fc1bb51752acf4539dc5c23df03e8b82c950
    Gerrit-Change-Number: 730820
    Gerrit-PatchSet: 2
    Gerrit-Owner: Kirill Kolyshkin <koly...@gmail.com>
    Gerrit-Reviewer: Alan Donovan <adon...@google.com>
    Gerrit-Reviewer: Gopher Robot <go...@golang.org>
    Gerrit-Reviewer: Kirill Kolyshkin <koly...@gmail.com>
    Gerrit-Reviewer: Michael Knyszek <mkny...@google.com>
    Gerrit-Reviewer: Robert Findley <rfin...@google.com>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages