[go] go/token/position.go: Fix trivial typo in comment.

2 views
Skip to first unread message

Omar Khan (Gerrit)

unread,
Sep 27, 2025, 11:58:37 PM (4 days ago) Sep 27
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com

Omar Khan has uploaded the change for review

Commit message

go/token/position.go: Fix trivial typo in comment.

Adresses https://github.com/golang/go/issues/75632
Change-Id: Ifa286b5d758fd8cbdc8a6908e2a2fba0eeb494b5

Change diff

diff --git a/src/go/token/position.go b/src/go/token/position.go
index c3816b1..39756f2 100644
--- a/src/go/token/position.go
+++ b/src/go/token/position.go
@@ -511,7 +511,7 @@
// }
//
// because all calls to AddFile must be in increasing order.
- // AddExistingFilesFiles lets us augment an existing FileSet
+ // AddExistingFiles lets us augment an existing FileSet
// sequentially, so long as all sets of files have disjoint ranges.
// This approach also does not preserve line directives.

Change information

Files:
  • M src/go/token/position.go
Change size: XS
Delta: 1 file changed, 1 insertion(+), 1 deletion(-)
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: Ifa286b5d758fd8cbdc8a6908e2a2fba0eeb494b5
Gerrit-Change-Number: 707376
Gerrit-PatchSet: 1
Gerrit-Owner: Omar Khan <omarna...@gmail.com>
unsatisfied_requirement
satisfied_requirement
open
diffy

Gopher Robot (Gerrit)

unread,
Sep 28, 2025, 12:01:29 AM (4 days ago) Sep 28
to Omar Khan, goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com

Message from Gopher Robot

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11 or adds a tag like "wait-release", it means that this CL will be
reviewed as part of the next development cycle. See https://go.dev/s/release
for more details.

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: Ifa286b5d758fd8cbdc8a6908e2a2fba0eeb494b5
Gerrit-Change-Number: 707376
Gerrit-PatchSet: 1
Gerrit-Owner: Omar Khan <omarna...@gmail.com>
Gerrit-CC: Gopher Robot <go...@golang.org>
Gerrit-Comment-Date: Sun, 28 Sep 2025 04:01:23 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
unsatisfied_requirement
satisfied_requirement
open
diffy

Robert Griesemer (Gerrit)

unread,
12:17 PM (10 hours ago) 12:17 PM
to Omar Khan, goph...@pubsubhelper.golang.org, Robert Griesemer, Gopher Robot, golang-co...@googlegroups.com
Attention needed from Omar Khan and Robert Griesemer

Robert Griesemer voted Code-Review+2

Code-Review+2
Open in Gerrit

Related details

Attention is currently required from:
  • Omar Khan
  • Robert Griesemer
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: Ifa286b5d758fd8cbdc8a6908e2a2fba0eeb494b5
Gerrit-Change-Number: 707376
Gerrit-PatchSet: 1
Gerrit-Owner: Omar Khan <omarna...@gmail.com>
Gerrit-Reviewer: Robert Griesemer <g...@golang.org>
Gerrit-Reviewer: Robert Griesemer <g...@google.com>
Gerrit-CC: Gopher Robot <go...@golang.org>
Gerrit-Attention: Omar Khan <omarna...@gmail.com>
Gerrit-Attention: Robert Griesemer <g...@golang.org>
Gerrit-Comment-Date: Wed, 01 Oct 2025 16:17:06 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages