[go] runtime: don't panic in castogscanstatus

2 views
Skip to first unread message

Michael Knyszek (Gerrit)

unread,
Nov 3, 2025, 5:31:04 PM (3 days ago) Nov 3
to goph...@pubsubhelper.golang.org, Cherry Mui, Russ Cox, golang-co...@googlegroups.com
Attention needed from Cherry Mui and Russ Cox

Michael Knyszek voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Cherry Mui
  • Russ Cox
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: I4a8e296b71bf002295a3aa1db4f723c305ed939a
Gerrit-Change-Number: 717406
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Knyszek <mkny...@google.com>
Gerrit-Reviewer: Cherry Mui <cher...@google.com>
Gerrit-Reviewer: Michael Knyszek <mkny...@google.com>
Gerrit-Reviewer: Russ Cox <r...@golang.org>
Gerrit-Attention: Russ Cox <r...@golang.org>
Gerrit-Attention: Cherry Mui <cher...@google.com>
Gerrit-Comment-Date: Mon, 03 Nov 2025 22:31:01 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
unsatisfied_requirement
satisfied_requirement
open
diffy

Cherry Mui (Gerrit)

unread,
Nov 3, 2025, 5:32:22 PM (3 days ago) Nov 3
to Michael Knyszek, goph...@pubsubhelper.golang.org, Go LUCI, Russ Cox, golang-co...@googlegroups.com
Attention needed from Michael Knyszek and Russ Cox

Cherry Mui voted Code-Review+2

Code-Review+2
Open in Gerrit

Related details

Attention is currently required from:
  • Michael Knyszek
  • Russ Cox
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: I4a8e296b71bf002295a3aa1db4f723c305ed939a
Gerrit-Change-Number: 717406
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Knyszek <mkny...@google.com>
Gerrit-Reviewer: Cherry Mui <cher...@google.com>
Gerrit-Reviewer: Michael Knyszek <mkny...@google.com>
Gerrit-Reviewer: Russ Cox <r...@golang.org>
Gerrit-Attention: Russ Cox <r...@golang.org>
Gerrit-Attention: Michael Knyszek <mkny...@google.com>
Gerrit-Comment-Date: Mon, 03 Nov 2025 22:32:17 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Michael Knyszek (Gerrit)

unread,
Nov 3, 2025, 5:50:53 PM (3 days ago) Nov 3
to goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Go LUCI, Cherry Mui, Russ Cox, golang-co...@googlegroups.com

Michael Knyszek submitted the change

Change information

Commit message:
runtime: don't panic in castogscanstatus

The panic calls gopanic which may have write barriers, but
castogscanstatus is called from //go:nowritebarrier contexts.

The panic is dead code anyway, and appears immediately before a call to
'throw'.
Change-Id: I4a8e296b71bf002295a3aa1db4f723c305ed939a
Reviewed-by: Cherry Mui <cher...@google.com>
Files:
  • M src/runtime/proc.go
Change size: XS
Delta: 1 file changed, 2 insertions(+), 2 deletions(-)
Branch: refs/heads/master
Submit Requirements:
  • requirement satisfiedCode-Review: +2 by Cherry Mui
  • requirement satisfiedTryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: I4a8e296b71bf002295a3aa1db4f723c305ed939a
Gerrit-Change-Number: 717406
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Knyszek <mkny...@google.com>
Gerrit-Reviewer: Cherry Mui <cher...@google.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages