[go] runtime: don't panic in castogscanstatus
2 views
Skip to first unread message
Michael Knyszek (Gerrit)
Nov 3, 2025, 5:31:04 PM (3 days ago) Nov 3
to goph...@pubsubhelper.golang.org, Cherry Mui, Russ Cox, golang-co...@googlegroups.com
Attention needed from Cherry Mui and Russ Cox
Michael Knyszek voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Cherry Mui
- Russ Cox
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Cherry Mui (Gerrit)
Nov 3, 2025, 5:32:22 PM (3 days ago) Nov 3
to Michael Knyszek, goph...@pubsubhelper.golang.org, Go LUCI, Russ Cox, golang-co...@googlegroups.com
Attention needed from Michael Knyszek and Russ Cox
Cherry Mui voted Code-Review+2![]( "Open in Gerrit")
Attention is currently required from:
- Michael Knyszek
- Russ Cox
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Knyszek (Gerrit)
Nov 3, 2025, 5:50:53 PM (3 days ago) Nov 3
to goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Go LUCI, Cherry Mui, Russ Cox, golang-co...@googlegroups.com
Michael Knyszek submitted the change![]( "Open in Gerrit")
Change information
Commit message:
runtime: don't panic in castogscanstatus
The panic calls gopanic which may have write barriers, but
castogscanstatus is called from //go:nowritebarrier contexts.
The panic is dead code anyway, and appears immediately before a call to
'throw'.
Change-Id: I4a8e296b71bf002295a3aa1db4f723c305ed939a
Reviewed-on: https://go-review.googlesource.com/c/go/+/717406
LUCI-TryBot-Result: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Cherry Mui <cher...@google.com>
Files:
- M src/runtime/proc.go
Change size: XS
Delta: 1 file changed, 2 insertions(+), 2 deletions(-)
Branch: refs/heads/master
Submit Requirements:
Code-Review: +2 by Cherry Mui
TryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages