[telemetry] internal/chartconfig: add gopls/setting/staticcheck counter
7 views
Skip to first unread message
Hongxiang Jiang (Gerrit)
Oct 10, 2025, 1:25:52 PMOct 10
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Hongxiang Jiang has uploaded the change for review![]( "Open in Gerrit")
Commit message
internal/chartconfig: add gopls/setting/staticcheck counter
For golang/go#75850
Change-Id: If5bc37d988ab541882d965b00f5b7ee7b12099bc
Change diff
diff --git a/internal/chartconfig/config.txt b/internal/chartconfig/config.txt
index 870b26c..287726d 100644
--- a/internal/chartconfig/config.txt
+++ b/internal/chartconfig/config.txt
@@ -324,7 +324,6 @@
program: golang.org/x/tools/gopls
module: golang.org/x/tools/gopls
version: v0.21.0
-
---
counter: gopls/renamekind:package
title: Use of Rename Package
@@ -333,4 +332,13 @@
issue: https://github.com/golang/go/issues/75612
program: golang.org/x/tools/gopls
module: golang.org/x/tools/gopls
-version: v0.20.0
\ No newline at end of file
+version: v0.20.0
+---
+counter: gopls/setting/staticcheck:{true,false}
+title: staticcheck Option Usage
+description: counts staticcheck option settings
+type: partition
+issue: https://github.com/golang/go/issues/75850
+program: golang.org/x/tools/gopls
+module: golang.org/x/tools/gopls
+version: v0.21.0
\ No newline at end of file
Change information
Files:
- M internal/chartconfig/config.txt
Change size: S
Delta: 1 file changed, 10 insertions(+), 2 deletions(-)
Related details
Attention set is empty
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Hongxiang Jiang (Gerrit)
Oct 10, 2025, 1:27:23 PMOct 10
to goph...@pubsubhelper.golang.org, Robert Findley, golang-co...@googlegroups.com
Attention needed from Robert Findley
Hongxiang Jiang voted Hold+1![]( "Open in Gerrit")
| Hold | +1 |
Related details
Attention is currently required from:
- Robert Findley
Submit Requirements:
Code-Review
No-Holds
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Hongxiang Jiang (Gerrit)
Oct 10, 2025, 1:29:03 PMOct 10
to goph...@pubsubhelper.golang.org, Ethan Lee, Alan Donovan, Robert Findley, golang-co...@googlegroups.com
Attention needed from Alan Donovan and Ethan Lee
Hongxiang Jiang voted Commit-Queue+1![]( "Open in Gerrit")
Attention is currently required from:
- Alan Donovan
- Ethan Lee
Submit Requirements:
Code-Review
No-Holds
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alan Donovan (Gerrit)
Oct 10, 2025, 1:45:36 PMOct 10
to Hongxiang Jiang, goph...@pubsubhelper.golang.org, Go LUCI, Ethan Lee, Robert Findley, golang-co...@googlegroups.com
Attention needed from Ethan Lee and Hongxiang Jiang
Alan Donovan voted and added 1 comment![]( "Open in Gerrit")
Votes added by Alan Donovan
| Hold | +1 |
1 comment
File internal/chartconfig/config.txt
Line 341, Patchset 1 (Latest):
issue: https://github.com/golang/go/issues/75850Alan Donovan . unresolved
This proposal has not yet been accepted.
Related details
Attention is currently required from:
- Ethan Lee
- Hongxiang Jiang
Submit Requirements:
Code-Review
No-Holds
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Hongxiang Jiang (Gerrit)
Oct 10, 2025, 1:55:29 PMOct 10
to goph...@pubsubhelper.golang.org, Alan Donovan, Go LUCI, Ethan Lee, Robert Findley, golang-co...@googlegroups.com
Attention needed from Alan Donovan
Hongxiang Jiang added 1 comment![]( "Open in Gerrit")
File internal/chartconfig/config.txt
Alan Donovan . unresolved
This proposal has not yet been accepted.
Hongxiang Jiang
Yes. I will send out the email next week with one of the ethan's proposal.
Related details
Attention is currently required from:
- Alan Donovan
Submit Requirements:
Code-Review
No-Holds
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ethan Lee (Gerrit)
Oct 15, 2025, 6:18:09 AMOct 15
to Hongxiang Jiang, goph...@pubsubhelper.golang.org, Go LUCI, Alan Donovan, Robert Findley, golang-co...@googlegroups.com
Attention needed from Alan Donovan and Hongxiang Jiang
Ethan Lee voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Alan Donovan
- Hongxiang Jiang
Submit Requirements:
Code-Review
No-Holds
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Hongxiang Jiang (Gerrit)
Oct 16, 2025, 7:53:57 PMOct 16
to goph...@pubsubhelper.golang.org, Ethan Lee, Go LUCI, Alan Donovan, Robert Findley, golang-co...@googlegroups.com
Attention needed from Alan Donovan
Hongxiang Jiang added 1 comment![]( "Open in Gerrit")
File internal/chartconfig/config.txt
Alan Donovan . resolved
Hongxiang JiangThis proposal has not yet been accepted.
Yes. I will send out the email next week with one of the ethan's proposal.
Hongxiang Jiang
Hi Alan, the proposal is now approved. Please take a look thanks.
Related details
Attention is currently required from:
- Alan Donovan
Submit Requirements:
Code-Review
No-Holds
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Hongxiang Jiang (Gerrit)
Nov 5, 2025, 10:08:31 AM (8 days ago) Nov 5
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Attention needed from Alan Donovan
Hongxiang Jiang uploaded new patchset![]( "Open in Gerrit")
Hongxiang Jiang uploaded patch set #2 to this change.
Following approvals got outdated and were removed:
- TryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
Related details
Attention is currently required from:
- Alan Donovan
Submit Requirements:
Code-Review
No-Holds
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Hongxiang Jiang (Gerrit)
Nov 5, 2025, 10:08:39 AM (8 days ago) Nov 5
to goph...@pubsubhelper.golang.org, Ethan Lee, Go LUCI, Alan Donovan, Robert Findley, golang-co...@googlegroups.com
Attention needed from Alan Donovan
Hongxiang Jiang voted Hold+0![]( "Open in Gerrit")
| Hold | +0 |
Related details
Attention is currently required from:
- Alan Donovan
Submit Requirements:
Code-Review
No-Holds
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alan Donovan (Gerrit)
Nov 11, 2025, 11:18:09 AM (2 days ago) Nov 11
to Hongxiang Jiang, goph...@pubsubhelper.golang.org, Ethan Lee, Go LUCI, Robert Findley, golang-co...@googlegroups.com
Attention needed from Hongxiang Jiang
Alan Donovan voted![]( "Open in Gerrit")
Attention is currently required from:
- Hongxiang Jiang
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ethan Lee (Gerrit)
Nov 11, 2025, 11:26:59 AM (2 days ago) Nov 11
to Hongxiang Jiang, goph...@pubsubhelper.golang.org, Alan Donovan, Go LUCI, Robert Findley, golang-co...@googlegroups.com
Attention needed from Hongxiang Jiang
Ethan Lee voted Code-Review+2![]( "Open in Gerrit")
| Code-Review | +2 |
Related details
Attention is currently required from:
- Hongxiang Jiang
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Hongxiang Jiang (Gerrit)
Nov 11, 2025, 4:01:25 PM (2 days ago) Nov 11
to goph...@pubsubhelper.golang.org, Alan Donovan, Ethan Lee, Go LUCI, Robert Findley, golang-co...@googlegroups.com
Hongxiang Jiang voted![]( "Open in Gerrit")
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gopher Robot (Gerrit)
Nov 11, 2025, 4:11:59 PM (2 days ago) Nov 11
to Hongxiang Jiang, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Go LUCI, Alan Donovan, Ethan Lee, Robert Findley, golang-co...@googlegroups.com
Gopher Robot submitted the change![]( "Open in Gerrit")
Change information
Commit message:
internal/chartconfig: add gopls/setting/staticcheck counter
For golang/go#75850
Change-Id: If5bc37d988ab541882d965b00f5b7ee7b12099bc
Auto-Submit: Hongxiang Jiang <hxj...@golang.org>
LUCI-TryBot-Result: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Alan Donovan <adon...@google.com>
Reviewed-by: Ethan Lee <etha...@google.com>
Files:
- M internal/chartconfig/config.txt
Change size: XS
Delta: 1 file changed, 9 insertions(+), 0 deletions(-)
Branch: refs/heads/master
Submit Requirements:
Code-Review: +2 by Ethan Lee, +2 by Alan Donovan
TryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages