[exp] event: Upgrade otel sdk version
59 views
Skip to first unread message
Gerrit Bot (Gerrit)
May 13, 2022, 4:58:36 PM5/13/22
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Gerrit Bot has uploaded this change for review.
event: Upgrade otel sdk version
go.opentelemetry.io/otel/metric v0.28.0 introduced some breaking changes.
Taking a crack at landing those changes to allow consuming the latest Otel sdk.
Change-Id: I6b05075133cde6890e6f36cd9527b415aa28f367
GitHub-Last-Rev: 01055906c5f5bde3894d4d4f2cf56ce168f5704e
GitHub-Pull-Request: golang/exp#31
---
M event/go.mod
M event/go.sum
M event/otel/metric.go
M event/otel/metric_test.go
4 files changed, 93 insertions(+), 55 deletions(-)
diff --git a/event/go.mod b/event/go.mod
index 6d6c6dc..2bee808 100644
--- a/event/go.mod
+++ b/event/go.mod
@@ -4,14 +4,15 @@
require (
github.com/go-kit/kit v0.12.0
- github.com/go-logr/logr v1.2.2
- github.com/google/go-cmp v0.5.7
+ github.com/go-logr/logr v1.2.3
+ github.com/google/go-cmp v0.5.8
github.com/rs/zerolog v1.26.1
github.com/sirupsen/logrus v1.8.1
- go.opentelemetry.io/otel v1.4.0
- go.opentelemetry.io/otel/metric v0.27.0
- go.opentelemetry.io/otel/sdk v1.4.0
- go.opentelemetry.io/otel/trace v1.4.0
+ go.opentelemetry.io/otel v1.7.0
+ go.opentelemetry.io/otel/metric v0.30.0
+ go.opentelemetry.io/otel/sdk v1.7.0
+ go.opentelemetry.io/otel/sdk/metric v0.30.0
+ go.opentelemetry.io/otel/trace v1.7.0
go.uber.org/zap v1.21.0
)
@@ -19,9 +20,8 @@
github.com/go-kit/log v0.2.0 // indirect
github.com/go-logfmt/logfmt v0.5.1 // indirect
github.com/go-logr/stdr v1.2.2 // indirect
- go.opentelemetry.io/otel/internal/metric v0.27.0 // indirect
go.uber.org/atomic v1.9.0 // indirect
- go.uber.org/multierr v1.7.0 // indirect
- golang.org/x/sys v0.0.0-20210917161153-d61c044b1678 // indirect
- golang.org/x/xerrors v0.0.0-20200804184101-5ec99f83aff1 // indirect
+ go.uber.org/multierr v1.8.0 // indirect
+ golang.org/x/sys v0.0.0-20220503163025-988cb79eb6c6 // indirect
+ golang.org/x/xerrors v0.0.0-20220411194840-2f41105eb62f // indirect
)
diff --git a/event/go.sum b/event/go.sum
index 37dbf78..e5d0bce 100644
--- a/event/go.sum
+++ b/event/go.sum
@@ -1,5 +1,6 @@
-github.com/benbjohnson/clock v1.1.0 h1:Q92kusRqC1XV2MjkWETPvjJVqKetz1OzxZB7mHJLju8=
github.com/benbjohnson/clock v1.1.0/go.mod h1:J11/hYXuz8f4ySSvYwY0FKfm+ezbsZBKZxNJlLklBHA=
+github.com/benbjohnson/clock v1.3.0 h1:ip6w0uFQkncKQ979AypyG0ER7mqUSBdKLOgAle/AT8A=
+github.com/benbjohnson/clock v1.3.0/go.mod h1:J11/hYXuz8f4ySSvYwY0FKfm+ezbsZBKZxNJlLklBHA=
github.com/coreos/go-systemd/v22 v22.3.2/go.mod h1:Y58oyj3AT4RCenI/lSvhwexgC+NSVTIJ3seZv2GcEnc=
github.com/davecgh/go-spew v1.1.0/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
github.com/davecgh/go-spew v1.1.1 h1:vj9j/u1bqnvCEfJOwUhtlOARqs3+rkHYY13jYWTU97c=
@@ -10,13 +11,16 @@
github.com/go-kit/log v0.2.0/go.mod h1:NwTd00d/i8cPZ3xOwwiv2PO5MOcx78fFErGNcVmBjv0=
github.com/go-logfmt/logfmt v0.5.1 h1:otpy5pqBCBZ1ng9RQ0dPu4PN7ba75Y/aA+UpowDyNVA=
github.com/go-logfmt/logfmt v0.5.1/go.mod h1:WYhtIu8zTZfxdn5+rREduYbwxfcBr/Vr6KEVveWlfTs=
-github.com/go-logr/logr v1.2.2 h1:ahHml/yUpnlb96Rp8HCvtYVPY8ZYpxq3g7UYchIYwbs=
github.com/go-logr/logr v1.2.2/go.mod h1:jdQByPbusPIv2/zmleS9BjJVeZ6kBagPoEUsqbVz/1A=
+github.com/go-logr/logr v1.2.3 h1:2DntVwHkVopvECVRSlL5PSo9eG+cAkDCuckLubN+rq0=
+github.com/go-logr/logr v1.2.3/go.mod h1:jdQByPbusPIv2/zmleS9BjJVeZ6kBagPoEUsqbVz/1A=
github.com/go-logr/stdr v1.2.2 h1:hSWxHoqTgW2S2qGc0LTAI563KZ5YKYRhT3MFKZMbjag=
github.com/go-logr/stdr v1.2.2/go.mod h1:mMo/vtBO5dYbehREoey6XUKy/eSumjCCveDpRre4VKE=
github.com/godbus/dbus/v5 v5.0.4/go.mod h1:xhWf0FNVPg57R7Z0UbKHbJfkEywrmjJnf7w5xrFpKfA=
github.com/google/go-cmp v0.5.7 h1:81/ik6ipDQS2aGcBfIN5dHDB36BwrStyeAQquSYCV4o=
github.com/google/go-cmp v0.5.7/go.mod h1:n+brtR0CgQNWTVd5ZUFpTBC8YFBDLK/h/bpaJ8/DtOE=
+github.com/google/go-cmp v0.5.8 h1:e6P7q2lk1O+qJJb4BtCQXlK8vWEO8V1ZeuEdJNOqZyg=
+github.com/google/go-cmp v0.5.8/go.mod h1:17dUlkBOakJ0+DkrSSNjCkIjxS6bF9zb3elmeNGIjoY=
github.com/kr/pretty v0.1.0/go.mod h1:dAy3ld7l9f0ibDNOQOHHMYYIIbhfbHSm3C4ZsoJORNo=
github.com/kr/pty v1.1.1/go.mod h1:pFQYn66WHrOpPYNljwOMqo10TkYh1fy3cYio2l3bCsQ=
github.com/kr/text v0.1.0/go.mod h1:4Jbv+DJW3UT/LiOwJeYQe1efqtUx/iVham/4vfdArNI=
@@ -33,20 +37,21 @@
github.com/stretchr/objx v0.1.0/go.mod h1:HFkY916IF+rwdDfMAkV7OtwuqBVzrE8GR6GFx+wExME=
github.com/stretchr/testify v1.2.2/go.mod h1:a8OnRcib4nhh0OaRAV+Yts87kKdq0PP7pXfy6kDkUVs=
github.com/stretchr/testify v1.3.0/go.mod h1:M5WIy9Dh21IEIfnGCwXGc5bZfKNJtfHm1UVUgZn+9EI=
-github.com/stretchr/testify v1.7.0 h1:nwc3DEeHmmLAfoZucVR881uASk0Mfjw8xYJ99tb5CcY=
github.com/stretchr/testify v1.7.0/go.mod h1:6Fq8oRcR53rry900zMqJjRRixrwX3KX962/h/Wwjteg=
+github.com/stretchr/testify v1.7.1 h1:5TQK59W5E3v0r2duFAb7P95B6hEeOyEnHRa8MjYSMTY=
+github.com/stretchr/testify v1.7.1/go.mod h1:6Fq8oRcR53rry900zMqJjRRixrwX3KX962/h/Wwjteg=
github.com/yuin/goldmark v1.3.5/go.mod h1:mwnBkeHKe2W/ZEtQ+71ViKU8L12m81fl3OWwC1Zlc8k=
github.com/yuin/goldmark v1.4.0/go.mod h1:mwnBkeHKe2W/ZEtQ+71ViKU8L12m81fl3OWwC1Zlc8k=
-go.opentelemetry.io/otel v1.4.0 h1:7ESuKPq6zpjRaY5nvVDGiuwK7VAJ8MwkKnmNJ9whNZ4=
-go.opentelemetry.io/otel v1.4.0/go.mod h1:jeAqMFKy2uLIxCtKxoFj0FAL5zAPKQagc3+GtBWakzk=
-go.opentelemetry.io/otel/internal/metric v0.27.0 h1:9dAVGAfFiiEq5NVB9FUJ5et+btbDQAUIJehJ+ikyryk=
-go.opentelemetry.io/otel/internal/metric v0.27.0/go.mod h1:n1CVxRqKqYZtqyTh9U/onvKapPGv7y/rpyOTI+LFNzw=
-go.opentelemetry.io/otel/metric v0.27.0 h1:HhJPsGhJoKRSegPQILFbODU56NS/L1UE4fS1sC5kIwQ=
-go.opentelemetry.io/otel/metric v0.27.0/go.mod h1:raXDJ7uP2/Jc0nVZWQjJtzoyssOYWu/+pjZqRzfvZ7g=
-go.opentelemetry.io/otel/sdk v1.4.0 h1:LJE4SW3jd4lQTESnlpQZcBhQ3oci0U2MLR5uhicfTHQ=
-go.opentelemetry.io/otel/sdk v1.4.0/go.mod h1:71GJPNJh4Qju6zJuYl1CrYtXbrgfau/M9UAggqiy1UE=
-go.opentelemetry.io/otel/trace v1.4.0 h1:4OOUrPZdVFQkbzl/JSdvGCWIdw5ONXXxzHlaLlWppmo=
-go.opentelemetry.io/otel/trace v1.4.0/go.mod h1:uc3eRsqDfWs9R7b92xbQbU42/eTNz4N+gLP8qJCi4aE=
+go.opentelemetry.io/otel v1.7.0 h1:Z2lA3Tdch0iDcrhJXDIlC94XE+bxok1F9B+4Lz/lGsM=
+go.opentelemetry.io/otel v1.7.0/go.mod h1:5BdUoMIz5WEs0vt0CUEMtSSaTSHBBVwrhnz7+nrD5xk=
+go.opentelemetry.io/otel/metric v0.30.0 h1:Hs8eQZ8aQgs0U49diZoaS6Uaxw3+bBE3lcMUKBFIk3c=
+go.opentelemetry.io/otel/metric v0.30.0/go.mod h1:/ShZ7+TS4dHzDFmfi1kSXMhMVubNoP0oIaBp70J6UXU=
+go.opentelemetry.io/otel/sdk v1.7.0 h1:4OmStpcKVOfvDOgCt7UriAPtKolwIhxpnSNI/yK+1B0=
+go.opentelemetry.io/otel/sdk v1.7.0/go.mod h1:uTEOTwaqIVuTGiJN7ii13Ibp75wJmYUDe374q6cZwUU=
+go.opentelemetry.io/otel/sdk/metric v0.30.0 h1:XTqQ4y3erR2Oj8xSAOL5ovO5011ch2ELg51z4fVkpME=
+go.opentelemetry.io/otel/sdk/metric v0.30.0/go.mod h1:8AKFRi5HyvTR0RRty3paN1aMC9HMT+NzcEhw/BLkLX8=
+go.opentelemetry.io/otel/trace v1.7.0 h1:O37Iogk1lEkMRXewVtZ1BBTVn5JEp8GrJvP92bJqC6o=
+go.opentelemetry.io/otel/trace v1.7.0/go.mod h1:fzLSB9nqR2eXzxPXb2JW9IKE+ScyXA48yyE4TNvoHqU=
go.uber.org/atomic v1.7.0/go.mod h1:fEN4uk6kAWBTFdckzkM89CLk9XfWZrxpCo0nPH17wJc=
go.uber.org/atomic v1.9.0 h1:ECmE8Bn/WFTYwEW/bpKD3M8VtR/zQVbavAoalC1PYyE=
go.uber.org/atomic v1.9.0/go.mod h1:fEN4uk6kAWBTFdckzkM89CLk9XfWZrxpCo0nPH17wJc=
@@ -55,6 +60,8 @@
go.uber.org/multierr v1.6.0/go.mod h1:cdWPpRnG4AhwMwsgIHip0KRBQjJy5kYEpYjJxpXp9iU=
go.uber.org/multierr v1.7.0 h1:zaiO/rmgFjbmCXdSYJWQcdvOCsthmdaHfr3Gm2Kx4Ec=
go.uber.org/multierr v1.7.0/go.mod h1:7EAYxJLBy9rStEaz58O2t4Uvip6FSURkq8/ppBp95ak=
+go.uber.org/multierr v1.8.0 h1:dg6GjLku4EH+249NNmoIciG9N/jURbDG+pFlTkhzIC8=
+go.uber.org/multierr v1.8.0/go.mod h1:7EAYxJLBy9rStEaz58O2t4Uvip6FSURkq8/ppBp95ak=
go.uber.org/zap v1.21.0 h1:WefMeulhovoZ2sYXz7st6K0sLj7bBhpiFaud4r4zST8=
go.uber.org/zap v1.21.0/go.mod h1:wjWOCqI0f2ZZrJF/UufIOkiC8ii6tm1iqIsLo76RfJw=
golang.org/x/crypto v0.0.0-20190308221718-c2843e01d9a2/go.mod h1:djNgcEr1/C05ACkg1iLfiJU5Ep61QUkGW8qpdssI0+w=
@@ -81,6 +88,8 @@
golang.org/x/sys v0.0.0-20210809222454-d867a43fc93e/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
golang.org/x/sys v0.0.0-20210917161153-d61c044b1678 h1:J27LZFQBFoihqXoegpscI10HpjZ7B5WQLLKL2FZXQKw=
golang.org/x/sys v0.0.0-20210917161153-d61c044b1678/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
+golang.org/x/sys v0.0.0-20220503163025-988cb79eb6c6 h1:nonptSpoQ4vQjyraW20DXPAglgQfVnM9ZC6MmNLMR60=
+golang.org/x/sys v0.0.0-20220503163025-988cb79eb6c6/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
golang.org/x/term v0.0.0-20201126162022-7de9c90e9dd1/go.mod h1:bj7SfCRtBDWHUb9snDiAeCFNEtKQo2Wmx5Cou7ajbmo=
golang.org/x/text v0.3.0/go.mod h1:NqM8EUOU14njkJ3fqMW+pc6Ldnwhi/IjpwHt7yyuwOQ=
golang.org/x/text v0.3.3/go.mod h1:5Zoc/QRtKVWzQhOtBMvqHzDpF6irO9z98xDceosuGiQ=
@@ -95,6 +104,8 @@
golang.org/x/xerrors v0.0.0-20191204190536-9bdfabe68543/go.mod h1:I/5z698sn9Ka8TeJc9MKroUUfqBBauWjQqLJ2OPfmY0=
golang.org/x/xerrors v0.0.0-20200804184101-5ec99f83aff1 h1:go1bK/D/BFZV2I8cIQd1NKEZ+0owSTG1fDTci4IqFcE=
golang.org/x/xerrors v0.0.0-20200804184101-5ec99f83aff1/go.mod h1:I/5z698sn9Ka8TeJc9MKroUUfqBBauWjQqLJ2OPfmY0=
+golang.org/x/xerrors v0.0.0-20220411194840-2f41105eb62f h1:GGU+dLjvlC3qDwqYgL6UgRmHXhOOgns0bZu2Ty5mm6U=
+golang.org/x/xerrors v0.0.0-20220411194840-2f41105eb62f/go.mod h1:I/5z698sn9Ka8TeJc9MKroUUfqBBauWjQqLJ2OPfmY0=
gopkg.in/check.v1 v0.0.0-20161208181325-20d25e280405/go.mod h1:Co6ibVJAznAaIkqp8huTwlJQCZ016jof/cbN4VW5Yz0=
gopkg.in/check.v1 v1.0.0-20180628173108-788fd7840127/go.mod h1:Co6ibVJAznAaIkqp8huTwlJQCZ016jof/cbN4VW5Yz0=
gopkg.in/yaml.v2 v2.2.8 h1:obN1ZagJSUGI0Ek/LBmuj4SNLPfIny3KsKFopxRdj10=
diff --git a/event/otel/metric.go b/event/otel/metric.go
index 910cc94..9ea79d6 100644
--- a/event/otel/metric.go
+++ b/event/otel/metric.go
@@ -12,6 +12,7 @@
"go.opentelemetry.io/otel/attribute"
"go.opentelemetry.io/otel/metric"
+ "go.opentelemetry.io/otel/metric/instrument"
otelunit "go.opentelemetry.io/otel/metric/unit"
"golang.org/x/exp/event"
)
@@ -19,7 +20,7 @@
// MetricHandler is an event.Handler for OpenTelemetry metrics.
// Its Event method handles Metric events and ignores all others.
type MetricHandler struct {
- meter metric.MeterMust
+ meter metric.Meter
mu sync.Mutex
// A map from event.Metrics to, effectively, otel Meters.
// But since the only thing we need from the Meter is recording a value, we
@@ -34,7 +35,7 @@
// NewMetricHandler creates a new MetricHandler.
func NewMetricHandler(m metric.Meter) *MetricHandler {
return &MetricHandler{
- meter: metric.Must(m),
+ meter: m,
recordFuncs: map[event.Metric]recordFunc{},
}
}
@@ -76,25 +77,25 @@
func (m *MetricHandler) newRecordFunc(em event.Metric) recordFunc {
opts := em.Options()
name := opts.Namespace + "/" + em.Name()
- otelOpts := []metric.InstrumentOption{
- metric.WithDescription(opts.Description),
- metric.WithUnit(otelunit.Unit(opts.Unit)), // cast OK: same strings
+ otelOpts := []instrument.Option{
+ instrument.WithDescription(opts.Description),
+ instrument.WithUnit(otelunit.Unit(opts.Unit)), // cast OK: same strings
}
switch em.(type) {
case *event.Counter:
- c := m.meter.NewInt64Counter(name, otelOpts...)
+ c, _ := m.meter.SyncInt64().Counter(name, otelOpts...)
return func(ctx context.Context, l event.Label, attrs []attribute.KeyValue) {
c.Add(ctx, l.Int64(), attrs...)
}
case *event.FloatGauge:
- g := m.meter.NewFloat64UpDownCounter(name, otelOpts...)
+ g, _ := m.meter.SyncFloat64().UpDownCounter(name, otelOpts...)
return func(ctx context.Context, l event.Label, attrs []attribute.KeyValue) {
g.Add(ctx, l.Float64(), attrs...)
}
case *event.DurationDistribution:
- r := m.meter.NewInt64Histogram(name, otelOpts...)
+ r, _ := m.meter.SyncInt64().Histogram(name, otelOpts...)
return func(ctx context.Context, l event.Label, attrs []attribute.KeyValue) {
r.Record(ctx, l.Duration().Nanoseconds(), attrs...)
}
diff --git a/event/otel/metric_test.go b/event/otel/metric_test.go
index 300f4a7..3014059 100644
--- a/event/otel/metric_test.go
+++ b/event/otel/metric_test.go
@@ -11,46 +11,57 @@
"github.com/google/go-cmp/cmp"
"go.opentelemetry.io/otel/attribute"
- "go.opentelemetry.io/otel/metric/metrictest"
- "go.opentelemetry.io/otel/metric/number"
+ "go.opentelemetry.io/otel/sdk/metric/export/aggregation"
+ "go.opentelemetry.io/otel/sdk/metric/metrictest"
+ "go.opentelemetry.io/otel/sdk/metric/number"
"golang.org/x/exp/event"
"golang.org/x/exp/event/otel"
)
func TestMeter(t *testing.T) {
ctx := context.Background()
- mp := metrictest.NewMeterProvider()
+ mp, exp := metrictest.NewTestMeterProvider()
mh := otel.NewMetricHandler(mp.Meter("test"))
ctx = event.WithExporter(ctx, event.NewExporter(mh, nil))
recordMetrics(ctx)
+ exp.Collect(ctx)
lib := metrictest.Library{InstrumentationName: "test"}
- emptyLabels := map[attribute.Key]attribute.Value{}
- got := metrictest.AsStructs(mp.MeasurementBatches)
- want := []metrictest.Measured{
+ got := exp.Records
+ want := []metrictest.ExportRecord{
{
- Name: "golang.org/x/exp/event/otel_test/hits",
- Number: number.NewInt64Number(8),
- Labels: emptyLabels,
- Library: lib,
+ InstrumentName: "golang.org/x/exp/event/otel_test/hits",
+ Sum: number.NewInt64Number(8),
+ Attributes: nil,
+ InstrumentationLibrary: lib,
+ AggregationKind: aggregation.SumKind,
+ NumberKind: number.Int64Kind,
},
{
- Name: "golang.org/x/exp/event/otel_test/temp",
- Number: number.NewFloat64Number(-100),
- Labels: map[attribute.Key]attribute.Value{"location": attribute.StringValue("Mare Imbrium")},
- Library: lib,
+ InstrumentName: "golang.org/x/exp/event/otel_test/temp",
+ Sum: number.NewFloat64Number(-100),
+ Attributes: []attribute.KeyValue{
+ {
+ Key: attribute.Key("location"),
+ Value: attribute.StringValue("Mare Imbrium"),
+ },
+ },
+ InstrumentationLibrary: lib,
+ AggregationKind: aggregation.SumKind,
+ NumberKind: number.Float64Kind,
},
{
- Name: "golang.org/x/exp/event/otel_test/latency",
- Number: number.NewInt64Number(int64(1248 * time.Millisecond)),
- Labels: emptyLabels,
- Library: lib,
- },
- {
- Name: "golang.org/x/exp/event/otel_test/latency",
- Number: number.NewInt64Number(int64(1255 * time.Millisecond)),
- Labels: emptyLabels,
- Library: lib,
+ InstrumentName: "golang.org/x/exp/event/otel_test/latency",
+ Sum: number.NewInt64Number(int64(2503 * time.Millisecond)),
+ Count: 2,
+ Attributes: nil,
+ InstrumentationLibrary: lib,
+ AggregationKind: aggregation.HistogramKind,
+ NumberKind: number.Int64Kind,
+ Histogram: aggregation.Buckets{
+ Boundaries: []float64{5000, 10000, 25000, 50000, 100000, 250000, 500000, 1e+06, 2.5e+06, 5e+06, 1e+07},
+ Counts: []uint64{0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 2},
+ },
},
}
To view, visit change 406239. To unsubscribe, or for help writing mail filters, visit settings.
Gopher Robot (Gerrit)
May 13, 2022, 4:58:58 PM5/13/22
to Gerrit Bot, goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Congratulations on opening your first change. Thank you for your contribution!
Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.
Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.
Gerrit Bot (Gerrit)
May 20, 2022, 6:39:12 PM5/20/22
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Gerrit Bot uploaded patch set #2 to this change.
event: Upgrade otel sdk version
go.opentelemetry.io/otel/metric v0.28.0 introduced some breaking changes.
Taking a crack at landing those changes to allow consuming the latest Otel sdk.
Change-Id: I6b05075133cde6890e6f36cd9527b415aa28f367
GitHub-Last-Rev: a5cf3f600fe81a9096363d68c4742b142ce88a1e
GitHub-Pull-Request: golang/exp#31
---
M event/go.mod
M event/go.sum
M event/otel/metric.go
M event/otel/metric_test.go
4 files changed, 99 insertions(+), 55 deletions(-)
To view, visit change 406239. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit Bot (Gerrit)
May 20, 2022, 7:22:52 PM5/20/22
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Gerrit Bot uploaded patch set #3 to this change.
event: Upgrade otel sdk version
go.opentelemetry.io/otel/metric v0.28.0 introduced some breaking changes.
Taking a crack at landing those changes to allow consuming the latest Otel sdk.
Change-Id: I6b05075133cde6890e6f36cd9527b415aa28f367
GitHub-Last-Rev: 19dbdf2a3ad6eeea0ff26907835847bad078aed0
GitHub-Pull-Request: golang/exp#31
---
M event/go.mod
M event/go.sum
M event/otel/metric.go
M event/otel/metric_test.go
4 files changed, 99 insertions(+), 55 deletions(-)
To view, visit change 406239. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit Bot (Gerrit)
May 25, 2022, 8:10:26 PM5/25/22
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Gerrit Bot uploaded patch set #4 to this change.
event: Upgrade otel sdk version
go.opentelemetry.io/otel/metric v0.28.0 introduced some breaking changes.
Taking a crack at landing those changes to allow consuming the latest Otel sdk.
Change-Id: I6b05075133cde6890e6f36cd9527b415aa28f367
GitHub-Last-Rev: c445f35664e43a32b0700cbfbbe36fe767fbfad3
GitHub-Pull-Request: golang/exp#31
---
M event/go.mod
M event/go.sum
M event/otel/metric.go
M event/otel/metric_test.go
4 files changed, 120 insertions(+), 53 deletions(-)
To view, visit change 406239. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit Bot (Gerrit)
May 25, 2022, 8:14:33 PM5/25/22
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Gerrit Bot uploaded patch set #5 to this change.
event: Upgrade otel sdk version
go.opentelemetry.io/otel/metric v0.28.0 introduced some breaking changes.
Taking a crack at landing those changes to allow consuming the latest Otel sdk.
Change-Id: I6b05075133cde6890e6f36cd9527b415aa28f367
GitHub-Last-Rev: 1e804bd4a3da7913ef4cc375135cf229f1d1d2d6
GitHub-Pull-Request: golang/exp#31
---
M event/go.mod
M event/go.sum
M event/otel/metric.go
M event/otel/metric_test.go
4 files changed, 136 insertions(+), 53 deletions(-)
To view, visit change 406239. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit Bot (Gerrit)
May 26, 2022, 9:09:54 PM5/26/22
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Gerrit Bot uploaded patch set #6 to this change.
event: Upgrade otel sdk version
go.opentelemetry.io/otel/metric v0.28.0 introduced some breaking changes.
Taking a crack at landing those changes to allow consuming the latest Otel sdk.
Change-Id: I6b05075133cde6890e6f36cd9527b415aa28f367
GitHub-Last-Rev: d8ebdd0f731089c49792b11154aba41fbb5c0569
GitHub-Pull-Request: golang/exp#31
---
M event/go.mod
M event/go.sum
M event/otel/metric.go
M event/otel/metric_test.go
4 files changed, 130 insertions(+), 54 deletions(-)
To view, visit change 406239. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit Bot (Gerrit)
May 26, 2022, 10:18:34 PM5/26/22
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Gerrit Bot uploaded patch set #7 to this change.
event: Upgrade otel sdk version
go.opentelemetry.io/otel/metric v0.28.0 introduced some breaking changes.
Taking a crack at landing those changes to allow consuming the latest Otel sdk.
Change-Id: I6b05075133cde6890e6f36cd9527b415aa28f367
GitHub-Last-Rev: f0c303df60df8f015f2f1e47c2c9a667361eef06
GitHub-Pull-Request: golang/exp#31
---
M event/go.mod
M event/go.sum
M event/otel/metric.go
M event/otel/metric_test.go
4 files changed, 128 insertions(+), 54 deletions(-)
To view, visit change 406239. To unsubscribe, or for help writing mail filters, visit settings.
Gopher Robot (Gerrit)
Jun 16, 2022, 6:02:57 PM6/16/22
to Gerrit Bot, goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Gopher Robot abandoned this change.
Abandoned
GitHub PR golang/exp#31 has been closed.
To view, visit change 406239. To unsubscribe, or for help writing mail filters, visit settings.
Reply all
Reply to author
Forward
0 new messages