[go] test: more tests for generic methods

1 view
Skip to first unread message

Mark Freeman (Gerrit)

unread,
Apr 8, 2026, 2:13:48 PM (10 hours ago) Apr 8
to goph...@pubsubhelper.golang.org, Robert Griesemer, golang-co...@googlegroups.com
Attention needed from Robert Griesemer

Mark Freeman voted

Auto-Submit+1
Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Robert Griesemer
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: I067206d1e97d5350d6fcc3983f5a6ef24a782214
Gerrit-Change-Number: 764200
Gerrit-PatchSet: 1
Gerrit-Owner: Mark Freeman <markf...@google.com>
Gerrit-Reviewer: Mark Freeman <markf...@google.com>
Gerrit-Reviewer: Robert Griesemer <g...@google.com>
Gerrit-Attention: Robert Griesemer <g...@google.com>
Gerrit-Comment-Date: Wed, 08 Apr 2026 18:13:43 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
unsatisfied_requirement
satisfied_requirement
open
diffy

Mark Freeman (Gerrit)

unread,
Apr 8, 2026, 3:24:49 PM (9 hours ago) Apr 8
to goph...@pubsubhelper.golang.org, Go LUCI, Robert Griesemer, golang-co...@googlegroups.com
Attention needed from Robert Griesemer

Mark Freeman voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Robert Griesemer
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: I067206d1e97d5350d6fcc3983f5a6ef24a782214
Gerrit-Change-Number: 764200
Gerrit-PatchSet: 1
Gerrit-Owner: Mark Freeman <markf...@google.com>
Gerrit-Reviewer: Mark Freeman <markf...@google.com>
Gerrit-Reviewer: Robert Griesemer <g...@google.com>
Gerrit-Attention: Robert Griesemer <g...@google.com>
Gerrit-Comment-Date: Wed, 08 Apr 2026 19:24:46 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
unsatisfied_requirement
satisfied_requirement
open
diffy

Robert Griesemer (Gerrit)

unread,
Apr 8, 2026, 6:24:40 PM (6 hours ago) Apr 8
to Mark Freeman, goph...@pubsubhelper.golang.org, Go LUCI, golang-co...@googlegroups.com
Attention needed from Mark Freeman

Robert Griesemer voted and added 5 comments

Votes added by Robert Griesemer

Code-Review+2

5 comments

File test/genmeth1.go
Line 14, Patchset 1 (Latest): f A
Robert Griesemer . unresolved

to make it easier to read. how about:

a A
b B

Line 23, Patchset 1 (Latest): var x C
Robert Griesemer . unresolved

var c C
vad d D

Line 30, Patchset 1 (Latest): for i := 0; i < len(args); i++ {
Robert Griesemer . unresolved

for i, arg := range args

Line 34, Patchset 1 (Latest): // remove "main." prefix for brevity
Robert Griesemer . unresolved

Maybe use strings.TrimPrefix(arg, "main.") to make this cleaner (speed doesn't matter).

Also, put the comment on the same line

.... // remove "main." for brevity

Line 42, Patchset 1 (Latest): type T2 int
Robert Griesemer . unresolved

use different types that always int?

Open in Gerrit

Related details

Attention is currently required from:
  • Mark Freeman
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
  • requirement satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: I067206d1e97d5350d6fcc3983f5a6ef24a782214
Gerrit-Change-Number: 764200
Gerrit-PatchSet: 1
Gerrit-Owner: Mark Freeman <markf...@google.com>
Gerrit-Reviewer: Mark Freeman <markf...@google.com>
Gerrit-Reviewer: Robert Griesemer <g...@google.com>
Gerrit-Attention: Mark Freeman <markf...@google.com>
Gerrit-Comment-Date: Wed, 08 Apr 2026 22:24:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages