[go] crypto/rsa: correct EncryptOAEP doc comment

4 views
Skip to first unread message

Gerrit Bot (Gerrit)

unread,
Mar 15, 2021, 2:16:14 PM3/15/21
to goph...@pubsubhelper.golang.org, Richard Pickering, golang-co...@googlegroups.com

Gerrit Bot has uploaded this change for review.

View Change

crypto/rsa: correct EncryptOAEP doc comment

Fixes #44777

Corrected the documentation comment on the EncryptOAEP function from
'if a given public key is used to decrypt two types of messages' to
'if a given public key is used to encrypt two types of messages'.

Change-Id: I02aff90d0414960eae72352c0e4d8ba2e8f8eca6
GitHub-Last-Rev: ea28663f8719e8fd0dcb10cf97ffbdcf4bd9674f
GitHub-Pull-Request: golang/go#45032
---
M src/crypto/rsa/rsa.go
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/crypto/rsa/rsa.go b/src/crypto/rsa/rsa.go
index 178ade6..6fd59b3 100644
--- a/src/crypto/rsa/rsa.go
+++ b/src/crypto/rsa/rsa.go
@@ -401,7 +401,7 @@
//
// The label parameter may contain arbitrary data that will not be encrypted,
// but which gives important context to the message. For example, if a given
-// public key is used to decrypt two types of messages then distinct label
+// public key is used to encrypt two types of messages then distinct label
// values could be used to ensure that a ciphertext for one purpose cannot be
// used for another by an attacker. If not required it can be empty.
//

To view, visit change 301714. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: I02aff90d0414960eae72352c0e4d8ba2e8f8eca6
Gerrit-Change-Number: 301714
Gerrit-PatchSet: 1
Gerrit-Owner: Gerrit Bot <letsus...@gmail.com>
Gerrit-CC: Richard Pickering <richard....@hotmail.co.uk>
Gerrit-MessageType: newchange

Filippo Valsorda (Gerrit)

unread,
Mar 18, 2021, 8:52:35 AM3/18/21
to Gerrit Bot, Richard Pickering, goph...@pubsubhelper.golang.org, Filippo Valsorda, Adam Langley, Katie Hockman, Roland Shoemaker, Go Bot, golang-co...@googlegroups.com

Patch set 1:Run-TryBot +1Code-Review +2

View Change

1 comment:

To view, visit change 301714. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: I02aff90d0414960eae72352c0e4d8ba2e8f8eca6
Gerrit-Change-Number: 301714
Gerrit-PatchSet: 1
Gerrit-Owner: Gerrit Bot <letsus...@gmail.com>
Gerrit-Reviewer: Filippo Valsorda <fil...@golang.org>
Gerrit-CC: Adam Langley <a...@golang.org>
Gerrit-CC: Go Bot <go...@golang.org>
Gerrit-CC: Katie Hockman <ka...@golang.org>
Gerrit-CC: Richard Pickering <richard....@hotmail.co.uk>
Gerrit-CC: Roland Shoemaker <rol...@golang.org>
Gerrit-Comment-Date: Thu, 18 Mar 2021 12:52:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Robert Findley (Gerrit)

unread,
Mar 18, 2021, 9:31:24 AM3/18/21
to Gerrit Bot, Richard Pickering, goph...@pubsubhelper.golang.org, Go Bot, Filippo Valsorda, Adam Langley, Katie Hockman, Roland Shoemaker, golang-co...@googlegroups.com

Patch set 1:Trust +1

View Change

    To view, visit change 301714. To unsubscribe, or for help writing mail filters, visit settings.

    Gerrit-Project: go
    Gerrit-Branch: master
    Gerrit-Change-Id: I02aff90d0414960eae72352c0e4d8ba2e8f8eca6
    Gerrit-Change-Number: 301714
    Gerrit-PatchSet: 1
    Gerrit-Owner: Gerrit Bot <letsus...@gmail.com>
    Gerrit-Reviewer: Filippo Valsorda <fil...@golang.org>
    Gerrit-Reviewer: Go Bot <go...@golang.org>
    Gerrit-Reviewer: Robert Findley <rfin...@google.com>
    Gerrit-CC: Adam Langley <a...@golang.org>
    Gerrit-CC: Katie Hockman <ka...@golang.org>
    Gerrit-CC: Richard Pickering <richard....@hotmail.co.uk>
    Gerrit-CC: Roland Shoemaker <rol...@golang.org>
    Gerrit-Comment-Date: Thu, 18 Mar 2021 13:31:18 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    Gerrit-MessageType: comment

    Robert Findley (Gerrit)

    unread,
    Mar 18, 2021, 9:32:01 AM3/18/21
    to Gerrit Bot, Richard Pickering, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Go Bot, Filippo Valsorda, Adam Langley, Katie Hockman, Roland Shoemaker, golang-co...@googlegroups.com

    Robert Findley submitted this change.

    View Change

    Approvals: Filippo Valsorda: Looks good to me, approved; Run TryBots Robert Findley: Trusted Go Bot: TryBots succeeded
    crypto/rsa: correct EncryptOAEP doc comment

    Fixes #44777

    Corrected the documentation comment on the EncryptOAEP function from
    'if a given public key is used to decrypt two types of messages' to
    'if a given public key is used to encrypt two types of messages'.

    Change-Id: I02aff90d0414960eae72352c0e4d8ba2e8f8eca6
    GitHub-Last-Rev: ea28663f8719e8fd0dcb10cf97ffbdcf4bd9674f
    GitHub-Pull-Request: golang/go#45032
    Reviewed-on: https://go-review.googlesource.com/c/go/+/301714
    Reviewed-by: Filippo Valsorda <fil...@golang.org>
    Run-TryBot: Filippo Valsorda <fil...@golang.org>
    TryBot-Result: Go Bot <go...@golang.org>
    Trust: Robert Findley <rfin...@google.com>

    ---
    M src/crypto/rsa/rsa.go
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/src/crypto/rsa/rsa.go b/src/crypto/rsa/rsa.go
    index 178ade6..6fd59b3 100644
    --- a/src/crypto/rsa/rsa.go
    +++ b/src/crypto/rsa/rsa.go
    @@ -401,7 +401,7 @@
    //
    // The label parameter may contain arbitrary data that will not be encrypted,
    // but which gives important context to the message. For example, if a given
    -// public key is used to decrypt two types of messages then distinct label
    +// public key is used to encrypt two types of messages then distinct label
    // values could be used to ensure that a ciphertext for one purpose cannot be
    // used for another by an attacker. If not required it can be empty.
    //

    To view, visit change 301714. To unsubscribe, or for help writing mail filters, visit settings.

    Gerrit-Project: go
    Gerrit-Branch: master
    Gerrit-Change-Id: I02aff90d0414960eae72352c0e4d8ba2e8f8eca6
    Gerrit-Change-Number: 301714
    Gerrit-PatchSet: 2
    Gerrit-Owner: Gerrit Bot <letsus...@gmail.com>
    Gerrit-Reviewer: Filippo Valsorda <fil...@golang.org>
    Gerrit-Reviewer: Go Bot <go...@golang.org>
    Gerrit-Reviewer: Robert Findley <rfin...@google.com>
    Gerrit-CC: Adam Langley <a...@golang.org>
    Gerrit-CC: Katie Hockman <ka...@golang.org>
    Gerrit-CC: Richard Pickering <richard....@hotmail.co.uk>
    Gerrit-CC: Roland Shoemaker <rol...@golang.org>
    Gerrit-MessageType: merged
    Reply all
    Reply to author
    Forward
    0 new messages