[net] icmp: fix out-of-bounds read in parseTimeExceeded

[Yahia Ben (Gerrit)]

Yahia Ben has uploaded the change for review

Commit message

icmp: fix out-of-bounds read in parseTimeExceeded

Change-Id: I8096bc2ae24d8d3df34490194a74221958f5dee3

Change diff

diff --git a/icmp/timeexceeded.go b/icmp/timeexceeded.go
index ffa986f..914f5e3 100644
--- a/icmp/timeexceeded.go
+++ b/icmp/timeexceeded.go
@@ -44,7 +44,7 @@
 
 // parseTimeExceeded parses b as an ICMP time exceeded message body.
 func parseTimeExceeded(proto int, typ Type, b []byte) (MessageBody, error) {
-	if len(b) < 4 {
+	if len(b) < 8 {
 		return nil, errMessageTooShort
 	}
 	p := &TimeExceeded{}
@@ -55,3 +55,4 @@
 	}
 	return p, nil
 }
+

Change information

Files:

• M icmp/timeexceeded.go

Change size: XS

Delta: 1 file changed, 2 insertions(+), 1 deletion(-)

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

• Code-Review
• No-Unresolved-Comments
• Review-Enforcement
• TryBots-Pass

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: newchange

Gerrit-Project: net

Gerrit-Branch: master

Gerrit-Change-Id: I8096bc2ae24d8d3df34490194a74221958f5dee3

Gerrit-Change-Number: 757140

Gerrit-PatchSet: 1

Gerrit-Owner: Yahia Ben <yahia...@gmail.com>