[go] cmd/go: avoid re-reading local wildcard matches
2 views
Skip to first unread message
Jake Bailey (Gerrit)
Jun 30, 2026, 4:06:33 PMJun 30
to goph...@pubsubhelper.golang.org, Quim Muntal, Michael Matloob, golang...@luci-project-accounts.iam.gserviceaccount.com, golang-co...@googlegroups.com
Attention needed from Michael Matloob and Quim Muntal
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Michael Matloob
- Quim Muntal
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jake Bailey (Gerrit)
Jun 30, 2026, 4:13:16 PMJun 30
to goph...@pubsubhelper.golang.org, Quim Muntal, Michael Matloob, golang...@luci-project-accounts.iam.gserviceaccount.com, golang-co...@googlegroups.com
Attention needed from Michael Matloob and Quim Muntal
Jake Bailey added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 1 (Latest):
Jake Bailey . resolved
Trybots are mad because I stacked these on top of Quim's CL that drops my case from 12s to 8s. I think that CL is old enough to have flakes master has fixed.
Quim Muntal (Gerrit)
Jun 30, 2026, 4:15:08 PMJun 30
to Jake Bailey, goph...@pubsubhelper.golang.org, Michael Matloob, golang...@luci-project-accounts.iam.gserviceaccount.com, golang-co...@googlegroups.com
Attention needed from Jake Bailey and Michael Matloob
Quim Muntal added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Jake Bailey . resolved
Trybots are mad because I stacked these on top of Quim's CL that drops my case from 12s to 8s. I think that CL is old enough to have flakes master has fixed.
Quim Muntal
Will fix them tomorrow, and also review this amazin CL stack 😊
Related details
Attention is currently required from:
- Jake Bailey
- Michael Matloob
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Matloob (Gerrit)
Jun 30, 2026, 4:16:20 PMJun 30
to Jake Bailey, goph...@pubsubhelper.golang.org, Quim Muntal, golang...@luci-project-accounts.iam.gserviceaccount.com, golang-co...@googlegroups.com
Attention needed from Jake Bailey
Michael Matloob added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Michael Matloob . resolved
Ooh this is exciting!
Related details
Attention is currently required from:
- Jake Bailey
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jake Bailey (Gerrit)
Jun 30, 2026, 4:40:46 PMJun 30
to goph...@pubsubhelper.golang.org, Quim Muntal, Michael Matloob, golang...@luci-project-accounts.iam.gserviceaccount.com, golang-co...@googlegroups.com
Attention needed from Michael Matloob and Quim Muntal
Jake Bailey added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Jake Bailey . resolved
Quim MuntalTrybots are mad because I stacked these on top of Quim's CL that drops my case from 12s to 8s. I think that CL is old enough to have flakes master has fixed.
Will fix them tomorrow, and also review this amazin CL stack 😊
Jake Bailey
Actually, no! This is a problem happening on master, entirely unrelated. https://github.com/golang/go/issues/80212
Related details
Attention is currently required from:
- Michael Matloob
- Quim Muntal
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jake Bailey (Gerrit)
Jun 30, 2026, 4:41:22 PMJun 30
to goph...@pubsubhelper.golang.org, Quim Muntal, Michael Matloob, golang...@luci-project-accounts.iam.gserviceaccount.com, golang-co...@googlegroups.com
Attention needed from Michael Matloob and Quim Muntal
Jake Bailey added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Jake Bailey . resolved
Quim MuntalTrybots are mad because I stacked these on top of Quim's CL that drops my case from 12s to 8s. I think that CL is old enough to have flakes master has fixed.
Jake BaileyWill fix them tomorrow, and also review this amazin CL stack 😊
Actually, no! This is a problem happening on master, entirely unrelated. https://github.com/golang/go/issues/80212
Jake Bailey
er, well, will still require a rebase.
Michael Matloob (Gerrit)
Jul 18, 2026, 2:26:50 PMJul 18
to Jake Bailey, goph...@pubsubhelper.golang.org, golang...@luci-project-accounts.iam.gserviceaccount.com, Quim Muntal, golang-co...@googlegroups.com
Attention needed from Jake Bailey and Quim Muntal
Michael Matloob voted and added 1 comment![]( "Open in Gerrit")
Votes added by Michael Matloob
| Code-Review | +2 |
1 comment
File src/cmd/go/internal/modload/load.go
Line 596, Patchset 2 (Latest):
func localAbsDir(dir string) string {Michael Matloob . resolved
maybe we can add a mkAbs function instead? We have mkAbs functions in cmd/go/internal/load and cmd/go/internal/exec. They're slightly different (they take the working directory as an argument) but they're a known quantity.
Related details
Attention is currently required from:
- Jake Bailey
- Quim Muntal
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Quim Muntal (Gerrit)
Jul 18, 2026, 3:06:12 PMJul 18
to Jake Bailey, goph...@pubsubhelper.golang.org, Michael Matloob, golang...@luci-project-accounts.iam.gserviceaccount.com, golang-co...@googlegroups.com
Attention needed from Jake Bailey
Quim Muntal voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Jake Bailey
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jake Bailey (Gerrit)
Jul 18, 2026, 4:47:24 PMJul 18
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Attention needed from Jake Bailey, Michael Matloob and Quim Muntal
Jake Bailey uploaded new patchset![]( "Open in Gerrit")
Jake Bailey uploaded patch set #3 to this change.
Following approvals got outdated and were removed:
- Code-Review: +2 by Michael Matloob, +1 by Quim Muntal
- TryBots-Pass: LUCI-TryBot-Result+1 by golang...@luci-project-accounts.iam.gserviceaccount.com
Related details
Attention is currently required from:
- Jake Bailey
- Michael Matloob
- Quim Muntal
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jake Bailey (Gerrit)
Jul 18, 2026, 4:48:31 PMJul 18
to goph...@pubsubhelper.golang.org, Quim Muntal, Michael Matloob, golang...@luci-project-accounts.iam.gserviceaccount.com, golang-co...@googlegroups.com
Attention needed from Michael Matloob and Quim Muntal
Jake Bailey added 1 comment![]( "Open in Gerrit")
File src/cmd/go/internal/modload/load.go
Line 596, Patchset 2:
func localAbsDir(dir string) string {Michael Matloob . resolved
maybe we can add a mkAbs function instead? We have mkAbs functions in cmd/go/internal/load and cmd/go/internal/exec. They're slightly different (they take the working directory as an argument) but they're a known quantity.
Attention is currently required from:
- Michael Matloob
- Quim Muntal
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jake Bailey (Gerrit)
Jul 18, 2026, 5:26:39 PMJul 18
to goph...@pubsubhelper.golang.org, golang...@luci-project-accounts.iam.gserviceaccount.com, Quim Muntal, Michael Matloob, golang-co...@googlegroups.com
Attention needed from Michael Matloob and Quim Muntal
Jake Bailey voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Jake Bailey (Gerrit)
3:48 PM (7 hours ago) 3:48 PM
to goph...@pubsubhelper.golang.org, golang...@luci-project-accounts.iam.gserviceaccount.com, Quim Muntal, Michael Matloob, golang-co...@googlegroups.com
Attention needed from Michael Matloob and Quim Muntal
Jake Bailey voted Auto-Submit+1![]( "Open in Gerrit")
| Auto-Submit | +1 |
Related details
Attention is currently required from:
- Michael Matloob
- Quim Muntal
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages