[go] cmd/go: avoid re-reading local wildcard matches

0 views
Skip to first unread message

Jake Bailey (Gerrit)

unread,
Jun 30, 2026, 4:06:33 PM (8 hours ago) Jun 30
to goph...@pubsubhelper.golang.org, Quim Muntal, Michael Matloob, golang...@luci-project-accounts.iam.gserviceaccount.com, golang-co...@googlegroups.com
Attention needed from Michael Matloob and Quim Muntal

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:
  • Michael Matloob
  • Quim Muntal
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: I3f5565eef54a52551666e833ca1c3a05edcca2fd
Gerrit-Change-Number: 795740
Gerrit-PatchSet: 1
Gerrit-Owner: Jake Bailey <jacob.b...@gmail.com>
Gerrit-Reviewer: Jake Bailey <jacob.b...@gmail.com>
Gerrit-Reviewer: Michael Matloob <mat...@golang.org>
Gerrit-Reviewer: Quim Muntal <quimm...@gmail.com>
Gerrit-Attention: Quim Muntal <quimm...@gmail.com>
Gerrit-Attention: Michael Matloob <mat...@golang.org>
Gerrit-Comment-Date: Tue, 30 Jun 2026 20:06:28 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
unsatisfied_requirement
satisfied_requirement
open
diffy

Jake Bailey (Gerrit)

unread,
Jun 30, 2026, 4:13:16 PM (8 hours ago) Jun 30
to goph...@pubsubhelper.golang.org, Quim Muntal, Michael Matloob, golang...@luci-project-accounts.iam.gserviceaccount.com, golang-co...@googlegroups.com
Attention needed from Michael Matloob and Quim Muntal

Jake Bailey added 1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Jake Bailey . resolved

Trybots are mad because I stacked these on top of Quim's CL that drops my case from 12s to 8s. I think that CL is old enough to have flakes master has fixed.

Gerrit-Comment-Date: Tue, 30 Jun 2026 20:13:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
unsatisfied_requirement
satisfied_requirement
open
diffy

Quim Muntal (Gerrit)

unread,
Jun 30, 2026, 4:15:08 PM (8 hours ago) Jun 30
to Jake Bailey, goph...@pubsubhelper.golang.org, Michael Matloob, golang...@luci-project-accounts.iam.gserviceaccount.com, golang-co...@googlegroups.com
Attention needed from Jake Bailey and Michael Matloob

Quim Muntal added 1 comment

Patchset-level comments
Jake Bailey . resolved

Trybots are mad because I stacked these on top of Quim's CL that drops my case from 12s to 8s. I think that CL is old enough to have flakes master has fixed.

Quim Muntal

Will fix them tomorrow, and also review this amazin CL stack 😊

Open in Gerrit

Related details

Attention is currently required from:
  • Jake Bailey
  • Michael Matloob
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: I3f5565eef54a52551666e833ca1c3a05edcca2fd
Gerrit-Change-Number: 795740
Gerrit-PatchSet: 1
Gerrit-Owner: Jake Bailey <jacob.b...@gmail.com>
Gerrit-Reviewer: Jake Bailey <jacob.b...@gmail.com>
Gerrit-Reviewer: Michael Matloob <mat...@golang.org>
Gerrit-Reviewer: Quim Muntal <quimm...@gmail.com>
Gerrit-Attention: Jake Bailey <jacob.b...@gmail.com>
Gerrit-Attention: Michael Matloob <mat...@golang.org>
Gerrit-Comment-Date: Tue, 30 Jun 2026 20:15:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jake Bailey <jacob.b...@gmail.com>
unsatisfied_requirement
satisfied_requirement
open
diffy

Michael Matloob (Gerrit)

unread,
Jun 30, 2026, 4:16:20 PM (8 hours ago) Jun 30
to Jake Bailey, goph...@pubsubhelper.golang.org, Quim Muntal, golang...@luci-project-accounts.iam.gserviceaccount.com, golang-co...@googlegroups.com
Attention needed from Jake Bailey

Michael Matloob added 1 comment

Patchset-level comments
Michael Matloob . resolved

Ooh this is exciting!

Open in Gerrit

Related details

Attention is currently required from:
  • Jake Bailey
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: I3f5565eef54a52551666e833ca1c3a05edcca2fd
Gerrit-Change-Number: 795740
Gerrit-PatchSet: 1
Gerrit-Owner: Jake Bailey <jacob.b...@gmail.com>
Gerrit-Reviewer: Jake Bailey <jacob.b...@gmail.com>
Gerrit-Reviewer: Michael Matloob <mat...@golang.org>
Gerrit-Reviewer: Quim Muntal <quimm...@gmail.com>
Gerrit-Attention: Jake Bailey <jacob.b...@gmail.com>
Gerrit-Comment-Date: Tue, 30 Jun 2026 20:16:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
unsatisfied_requirement
satisfied_requirement
open
diffy

Jake Bailey (Gerrit)

unread,
Jun 30, 2026, 4:40:46 PM (8 hours ago) Jun 30
to goph...@pubsubhelper.golang.org, Quim Muntal, Michael Matloob, golang...@luci-project-accounts.iam.gserviceaccount.com, golang-co...@googlegroups.com
Attention needed from Michael Matloob and Quim Muntal

Jake Bailey added 1 comment

Patchset-level comments
Jake Bailey . resolved

Trybots are mad because I stacked these on top of Quim's CL that drops my case from 12s to 8s. I think that CL is old enough to have flakes master has fixed.

Quim Muntal

Will fix them tomorrow, and also review this amazin CL stack 😊

Jake Bailey

Actually, no! This is a problem happening on master, entirely unrelated. https://github.com/golang/go/issues/80212

Open in Gerrit

Related details

Attention is currently required from:
  • Michael Matloob
  • Quim Muntal
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: I3f5565eef54a52551666e833ca1c3a05edcca2fd
Gerrit-Change-Number: 795740
Gerrit-PatchSet: 1
Gerrit-Owner: Jake Bailey <jacob.b...@gmail.com>
Gerrit-Reviewer: Jake Bailey <jacob.b...@gmail.com>
Gerrit-Reviewer: Michael Matloob <mat...@golang.org>
Gerrit-Reviewer: Quim Muntal <quimm...@gmail.com>
Gerrit-Attention: Quim Muntal <quimm...@gmail.com>
Gerrit-Attention: Michael Matloob <mat...@golang.org>
Gerrit-Comment-Date: Tue, 30 Jun 2026 20:40:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jake Bailey <jacob.b...@gmail.com>
Comment-In-Reply-To: Quim Muntal <quimm...@gmail.com>
unsatisfied_requirement
satisfied_requirement
open
diffy

Jake Bailey (Gerrit)

unread,
Jun 30, 2026, 4:41:22 PM (8 hours ago) Jun 30
to goph...@pubsubhelper.golang.org, Quim Muntal, Michael Matloob, golang...@luci-project-accounts.iam.gserviceaccount.com, golang-co...@googlegroups.com
Attention needed from Michael Matloob and Quim Muntal

Jake Bailey added 1 comment

Patchset-level comments
Jake Bailey . resolved

Trybots are mad because I stacked these on top of Quim's CL that drops my case from 12s to 8s. I think that CL is old enough to have flakes master has fixed.

Quim Muntal

Will fix them tomorrow, and also review this amazin CL stack 😊

Jake Bailey

Actually, no! This is a problem happening on master, entirely unrelated. https://github.com/golang/go/issues/80212

Jake Bailey

er, well, will still require a rebase.

Gerrit-Comment-Date: Tue, 30 Jun 2026 20:41:17 +0000
unsatisfied_requirement
satisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages