[vscode-go] src/goDebugFactory: increase timeout for dlv dap server start
Hyang-Ah Hana Kim (Gerrit)
Attention is currently required from: Suzy Mueller.
Hyang-Ah Hana Kim would like Suzy Mueller to review this change.
src/goDebugFactory: increase timeout for dlv dap server start
Some users are experiencing slow dlv dap server start.
The root cause of this slow start still needs investigation.
For golang/vscode-go#1693
Change-Id: Ie932bc2b9b7d273e0be2553b9fc154f2ae0b3ead
---
M src/goDebugFactory.ts
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/goDebugFactory.ts b/src/goDebugFactory.ts
index 241cee6..224e23a 100644
--- a/src/goDebugFactory.ts
+++ b/src/goDebugFactory.ts
@@ -418,13 +418,13 @@
const p = spawn(dlvPath, dlvArgs, {
cwd: dir,
env,
- stdio: ['pipe', 'pipe', 'pipe', 'pipe'] // --log-dest=3
+ stdio: onWindows ? ['pipe', 'pipe', 'pipe'] : ['pipe', 'pipe', 'pipe', 'pipe'] // --log-dest=3 if !onWindows.
});
let started = false;
- const timeoutToken: NodeJS.Timer = setTimeout(
- () => reject(new Error('timed out while waiting for DAP server to start')),
- 5_000
- );
+ const timeoutToken: NodeJS.Timer = setTimeout(() => {
+ logConsole(`Delve DAP server (PID: ${p.pid}) is not responding`);
+ reject(new Error('timed out while waiting for DAP server to start'));
+ }, 5_000);
const stopWaitingForServerToStart = () => {
clearTimeout(timeoutToken);
To view, visit change 342632. To unsubscribe, or for help writing mail filters, visit settings.
kokoro (Gerrit)
Attention is currently required from: Suzy Mueller.
Kokoro presubmit build finished with status: SUCCESS
Logs at: https://source.cloud.google.com/results/invocations/11c752d4-fd87-46af-8956-d2e41d72804b
Patch set 1:TryBot-Result +1
Suzy Mueller (Gerrit)
Attention is currently required from: Hyang-Ah Hana Kim.
1 comment:
File src/goDebugFactory.ts:
Patch Set #1, Line 427:
5_000This seems to be the same timeout as before?
To view, visit change 342632. To unsubscribe, or for help writing mail filters, visit settings.
Hyang-Ah Hana Kim (Gerrit)
Attention is currently required from: Suzy Mueller.
Patch set 2:Trust +1
1 comment:
File src/goDebugFactory.ts:
Patch Set #1, Line 427:
5_000This seems to be the same timeout as before?
huh. what I was doing. Thanks.
Changed to 30s.
To view, visit change 342632. To unsubscribe, or for help writing mail filters, visit settings.
Suzy Mueller (Gerrit)
Attention is currently required from: Hyang-Ah Hana Kim.
Patch set 2:Code-Review +2
Hyang-Ah Hana Kim (Gerrit)
Hyang-Ah Hana Kim submitted this change.
src/goDebugFactory: increase timeout for dlv dap server start
Some users are experiencing slow dlv dap server start.
The root cause of this slow start still needs investigation.
For golang/vscode-go#1693
Change-Id: Ie932bc2b9b7d273e0be2553b9fc154f2ae0b3ead
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/342632
Trust: Hyang-Ah Hana Kim <hya...@gmail.com>
Reviewed-by: Suzy Mueller <suz...@golang.org>
---
M src/goDebugFactory.ts
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/goDebugFactory.ts b/src/goDebugFactory.ts
index 241cee6..a71b53e 100644
--- a/src/goDebugFactory.ts
+++ b/src/goDebugFactory.ts
@@ -418,13 +418,13 @@
const p = spawn(dlvPath, dlvArgs, {
cwd: dir,
env,
- stdio: ['pipe', 'pipe', 'pipe', 'pipe'] // --log-dest=3
+ stdio: onWindows ? ['pipe', 'pipe', 'pipe'] : ['pipe', 'pipe', 'pipe', 'pipe'] // --log-dest=3 if !onWindows.
});
let started = false;
- const timeoutToken: NodeJS.Timer = setTimeout(
- () => reject(new Error('timed out while waiting for DAP server to start')),
- 5_000
- );
+ const timeoutToken: NodeJS.Timer = setTimeout(() => {
+ logConsole(`Delve DAP server (PID: ${p.pid}) is not responding`);
+ reject(new Error('timed out while waiting for DAP server to start'));
+ }, 30_000);
const stopWaitingForServerToStart = () => {
clearTimeout(timeoutToken);
To view, visit change 342632. To unsubscribe, or for help writing mail filters, visit settings.
Hyang-Ah Hana Kim (Gerrit)
Hyang-Ah Hana Kim has uploaded this change for review.
[release] src/goDebugFactory: increase timeout for dlv dap server start
Some users are experiencing slow dlv dap server start.
The root cause of this slow start still needs investigation.
For golang/vscode-go#1693
Change-Id: Ie932bc2b9b7d273e0be2553b9fc154f2ae0b3ead
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/342632
Trust: Hyang-Ah Hana Kim <hya...@gmail.com>
Reviewed-by: Suzy Mueller <suz...@golang.org>
(cherry picked from commit c79e0c4e664f02771330cb6741b121cfbd649021)
---
M src/goDebugFactory.ts
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/goDebugFactory.ts b/src/goDebugFactory.ts
index 01f77c1..09fceda 100644
--- a/src/goDebugFactory.ts
+++ b/src/goDebugFactory.ts
@@ -418,13 +418,13 @@
const p = spawn(dlvPath, dlvArgs, {
cwd: dir,
env,
- stdio: ['pipe', 'pipe', 'pipe', 'pipe'] // --log-dest=3
+ stdio: onWindows ? ['pipe', 'pipe', 'pipe'] : ['pipe', 'pipe', 'pipe', 'pipe'] // --log-dest=3 if !onWindows.
});
let started = false;
- const timeoutToken: NodeJS.Timer = setTimeout(
- () => reject(new Error('timed out while waiting for DAP server to start')),
- 5_000
- );
+ const timeoutToken: NodeJS.Timer = setTimeout(() => {
+ logConsole(`Delve DAP server (PID: ${p.pid}) is not responding`);
+ reject(new Error('timed out while waiting for DAP server to start'));
+ }, 30_000);
const stopWaitingForServerToStart = () => {
clearTimeout(timeoutToken);
To view, visit change 345550. To unsubscribe, or for help writing mail filters, visit settings.
Hyang-Ah Hana Kim (Gerrit)
Attention is currently required from: Suzy Mueller.
Patch set 1:Run-TryBot +1
kokoro (Gerrit)
Attention is currently required from: Suzy Mueller.
Kokoro presubmit build finished with status: SUCCESS
Logs at: https://source.cloud.google.com/results/invocations/66e312c5-c919-4159-b5d1-b58d9944ff9f
Patch set 1:TryBot-Result +1
Suzy Mueller (Gerrit)
Attention is currently required from: Hyang-Ah Hana Kim.
Patch set 1:Code-Review +2
Suzy Mueller (Gerrit)
Attention is currently required from: Hyang-Ah Hana Kim.
Patch set 1:Trust +1
Hyang-Ah Hana Kim (Gerrit)
Patch set 1:Trust +1
To view, visit change 345550. To unsubscribe, or for help writing mail filters, visit settings.
Hyang-Ah Hana Kim (Gerrit)
[release] src/goDebugFactory: increase timeout for dlv dap server start
Some users are experiencing slow dlv dap server start.
The root cause of this slow start still needs investigation.
For golang/vscode-go#1693
Change-Id: Ie932bc2b9b7d273e0be2553b9fc154f2ae0b3ead
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/342632
Trust: Hyang-Ah Hana Kim <hya...@gmail.com>
Reviewed-by: Suzy Mueller <suz...@golang.org>
(cherry picked from commit c79e0c4e664f02771330cb6741b121cfbd649021)
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/345550
Run-TryBot: Hyang-Ah Hana Kim <hya...@gmail.com>
TryBot-Result: kokoro <noreply...@google.com>
Trust: Suzy Mueller <suz...@golang.org>
To view, visit change 345550. To unsubscribe, or for help writing mail filters, visit settings.