[website] go.mod: update x/build to CL 596477

1 view
Skip to first unread message

Than McIntosh (Gerrit)

unread,
6:31 PM (3 hours ago) 6:31 PM
to goph...@pubsubhelper.golang.org, Than McIntosh, golang-co...@googlegroups.com

Than McIntosh has uploaded the change for review

Commit message

go.mod: update x/build to CL 596477

Update x/build to pick up changes for new x/oscar repo.
Change-Id: I42cee48d593b5e4b061230a83af0e7f1c1c4eeca

Change diff

diff --git a/go.mod b/go.mod
index a9ac958..4165af7 100644
--- a/go.mod
+++ b/go.mod
@@ -13,7 +13,7 @@
 	github.com/google/go-cmp v0.6.0
 	github.com/n7olkachev/imgdiff v1.0.2
 	github.com/yuin/goldmark v1.6.0
-	golang.org/x/build v0.0.0-20240520181858-75ff9ef337d5
+	golang.org/x/build v0.0.0-20240703214439-7bd85afa0cc0
 	golang.org/x/net v0.26.0
 	golang.org/x/sync v0.7.0
 	golang.org/x/tools v0.22.0
diff --git a/go.sum b/go.sum
index 06048c7..6ab7668 100644
--- a/go.sum
+++ b/go.sum
@@ -129,6 +129,8 @@
 go.opentelemetry.io/proto/otlp v0.7.0/go.mod h1:PqfVotwruBrMGOCsRd/89rSnXhoiJIqeYNgFYFoEGnI=
 golang.org/x/build v0.0.0-20240520181858-75ff9ef337d5 h1:AuX75q8YrFPUHM3PgwQukolV4h1mdj/lbDMpkRVnmnY=
 golang.org/x/build v0.0.0-20240520181858-75ff9ef337d5/go.mod h1:yz9anu0Z63yrVrqnoOxoJuyBRDwtGUoOFJwtfvs+D+U=
+golang.org/x/build v0.0.0-20240703214439-7bd85afa0cc0 h1:bEt4Fxp8oGmLycLiB+Rny/RBGGeVHEFAoXw9PcRk7ZI=
+golang.org/x/build v0.0.0-20240703214439-7bd85afa0cc0/go.mod h1:Q3Y4+jnPQCnNizilofBXOJ7EmO14lCIRAAE8pKZshic=
 golang.org/x/crypto v0.0.0-20190308221718-c2843e01d9a2/go.mod h1:djNgcEr1/C05ACkg1iLfiJU5Ep61QUkGW8qpdssI0+w=
 golang.org/x/crypto v0.0.0-20200622213623-75b288015ac9/go.mod h1:LzIPMQfyMNhhGPhUkYOs5KpL4U8rLKemX1yGLhDgUto=
 golang.org/x/crypto v0.0.0-20210921155107-089bfa567519/go.mod h1:GvvjBRRGRdwPK5ydBHafDWAxML/pGHZbMvKqRZ5+Abc=

Change information

Files:
  • M go.mod
  • M go.sum
Change size: XS
Delta: 2 files changed, 3 insertions(+), 1 deletion(-)
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: website
Gerrit-Branch: master
Gerrit-Change-Id: I42cee48d593b5e4b061230a83af0e7f1c1c4eeca
Gerrit-Change-Number: 596695
Gerrit-PatchSet: 1
Gerrit-Owner: Than McIntosh <th...@google.com>
unsatisfied_requirement
satisfied_requirement
open
diffy

Than McIntosh (Gerrit)

unread,
6:33 PM (3 hours ago) 6:33 PM
to Than McIntosh, goph...@pubsubhelper.golang.org, Dmitri Shuralyov, Russ Cox, golang-co...@googlegroups.com
Attention needed from Dmitri Shuralyov

Than McIntosh voted

Auto-Submit+1
Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Dmitri Shuralyov
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: website
Gerrit-Branch: master
Gerrit-Change-Id: I42cee48d593b5e4b061230a83af0e7f1c1c4eeca
Gerrit-Change-Number: 596695
Gerrit-PatchSet: 2
Gerrit-Owner: Than McIntosh <th...@google.com>
Gerrit-Reviewer: Dmitri Shuralyov <dmit...@golang.org>
Gerrit-Reviewer: Than McIntosh <th...@google.com>
Gerrit-CC: Russ Cox <r...@golang.org>
Gerrit-Attention: Dmitri Shuralyov <dmit...@golang.org>
Gerrit-Comment-Date: Wed, 03 Jul 2024 22:33:40 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
unsatisfied_requirement
satisfied_requirement
open
diffy

Dmitri Shuralyov (Gerrit)

unread,
6:35 PM (3 hours ago) 6:35 PM
to Than McIntosh, goph...@pubsubhelper.golang.org, Dmitri Shuralyov, Go LUCI, Russ Cox, golang-co...@googlegroups.com
Attention needed from Than McIntosh

Dmitri Shuralyov voted and added 2 comments

Votes added by Dmitri Shuralyov

Code-Review+2

2 comments

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Dmitri Shuralyov . resolved

Thanks.

File go.sum
Line 130, Patchset 2 (Latest):golang.org/x/build v0.0.0-20240520181858-75ff9ef337d5 h1:AuX75q8YrFPUHM3PgwQukolV4h1mdj/lbDMpkRVnmnY=
golang.org/x/build v0.0.0-20240520181858-75ff9ef337d5/go.mod h1:yz9anu0Z63yrVrqnoOxoJuyBRDwtGUoOFJwtfvs+D+U=
Dmitri Shuralyov . unresolved

(nit) This version is no longer used, `go mod tidy` should remove these lines.

Open in Gerrit

Related details

Attention is currently required from:
  • Than McIntosh
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: website
Gerrit-Branch: master
Gerrit-Change-Id: I42cee48d593b5e4b061230a83af0e7f1c1c4eeca
Gerrit-Change-Number: 596695
Gerrit-PatchSet: 2
Gerrit-Owner: Than McIntosh <th...@google.com>
Gerrit-Reviewer: Dmitri Shuralyov <dmit...@golang.org>
Gerrit-Reviewer: Than McIntosh <th...@google.com>
Gerrit-CC: Russ Cox <r...@golang.org>
Gerrit-Attention: Than McIntosh <th...@google.com>
Gerrit-Comment-Date: Wed, 03 Jul 2024 22:35:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Dmitri Shuralyov (Gerrit)

unread,
6:35 PM (3 hours ago) 6:35 PM
to Than McIntosh, goph...@pubsubhelper.golang.org, Dmitri Shuralyov, Go LUCI, Russ Cox, golang-co...@googlegroups.com
Attention needed from Than McIntosh

Dmitri Shuralyov voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Than McIntosh
Submit Requirements:
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    • requirement is not satisfiedTryBots-Pass
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: website
    Gerrit-Branch: master
    Gerrit-Change-Id: I42cee48d593b5e4b061230a83af0e7f1c1c4eeca
    Gerrit-Change-Number: 596695
    Gerrit-PatchSet: 2
    Gerrit-Owner: Than McIntosh <th...@google.com>
    Gerrit-Reviewer: Dmitri Shuralyov <dmit...@golang.org>
    Gerrit-Reviewer: Dmitri Shuralyov <dmit...@google.com>
    Gerrit-Reviewer: Than McIntosh <th...@google.com>
    Gerrit-CC: Russ Cox <r...@golang.org>
    Gerrit-Attention: Than McIntosh <th...@google.com>
    Gerrit-Comment-Date: Wed, 03 Jul 2024 22:35:46 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Than McIntosh (Gerrit)

    unread,
    7:24 PM (2 hours ago) 7:24 PM
    to Than McIntosh, goph...@pubsubhelper.golang.org, Go LUCI, Dmitri Shuralyov, Dmitri Shuralyov, Russ Cox, golang-co...@googlegroups.com

    Than McIntosh added 1 comment

    File go.sum
    Line 130, Patchset 2 (Latest):golang.org/x/build v0.0.0-20240520181858-75ff9ef337d5 h1:AuX75q8YrFPUHM3PgwQukolV4h1mdj/lbDMpkRVnmnY=
    golang.org/x/build v0.0.0-20240520181858-75ff9ef337d5/go.mod h1:yz9anu0Z63yrVrqnoOxoJuyBRDwtGUoOFJwtfvs+D+U=
    Dmitri Shuralyov . resolved

    (nit) This version is no longer used, `go mod tidy` should remove these lines.

    Than McIntosh

    Done

    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Review
    • requirement satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    • requirement satisfiedTryBots-Pass
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: website
    Gerrit-Branch: master
    Gerrit-Change-Id: I42cee48d593b5e4b061230a83af0e7f1c1c4eeca
    Gerrit-Change-Number: 596695
    Gerrit-PatchSet: 2
    Gerrit-Owner: Than McIntosh <th...@google.com>
    Gerrit-Reviewer: Dmitri Shuralyov <dmit...@golang.org>
    Gerrit-Reviewer: Dmitri Shuralyov <dmit...@google.com>
    Gerrit-Reviewer: Than McIntosh <th...@google.com>
    Gerrit-CC: Russ Cox <r...@golang.org>
    Gerrit-Comment-Date: Wed, 03 Jul 2024 23:23:56 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Dmitri Shuralyov <dmit...@golang.org>
    satisfied_requirement
    open
    diffy

    Than McIntosh (Gerrit)

    unread,
    7:24 PM (2 hours ago) 7:24 PM
    to Than McIntosh, goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
    Attention needed from Than McIntosh

    Than McIntosh uploaded new patchset

    Than McIntosh uploaded patch set #3 to this change.
    Following approvals got outdated and were removed:
    • TryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Than McIntosh
    Submit Requirements:
      • requirement satisfiedCode-Review
      • requirement satisfiedNo-Unresolved-Comments
      • requirement satisfiedReview-Enforcement
      • requirement is not satisfiedTryBots-Pass
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: newpatchset
      Gerrit-Project: website
      Gerrit-Branch: master
      Gerrit-Change-Id: I42cee48d593b5e4b061230a83af0e7f1c1c4eeca
      Gerrit-Change-Number: 596695
      Gerrit-PatchSet: 3
      Gerrit-Owner: Than McIntosh <th...@google.com>
      Gerrit-Reviewer: Dmitri Shuralyov <dmit...@golang.org>
      Gerrit-Reviewer: Dmitri Shuralyov <dmit...@google.com>
      Gerrit-Reviewer: Than McIntosh <th...@google.com>
      Gerrit-CC: Russ Cox <r...@golang.org>
      Gerrit-Attention: Than McIntosh <th...@google.com>
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Than McIntosh (Gerrit)

      unread,
      7:24 PM (2 hours ago) 7:24 PM
      to Than McIntosh, goph...@pubsubhelper.golang.org, Go LUCI, Dmitri Shuralyov, Dmitri Shuralyov, Russ Cox, golang-co...@googlegroups.com

      Than McIntosh voted Commit-Queue+1

      Commit-Queue+1
      Open in Gerrit

      Related details

      Attention set is empty
      Submit Requirements:
      • requirement satisfiedCode-Review
      • requirement satisfiedNo-Unresolved-Comments
      • requirement satisfiedReview-Enforcement
      • requirement is not satisfiedTryBots-Pass
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: website
      Gerrit-Branch: master
      Gerrit-Change-Id: I42cee48d593b5e4b061230a83af0e7f1c1c4eeca
      Gerrit-Change-Number: 596695
      Gerrit-PatchSet: 3
      Gerrit-Owner: Than McIntosh <th...@google.com>
      Gerrit-Reviewer: Dmitri Shuralyov <dmit...@golang.org>
      Gerrit-Reviewer: Dmitri Shuralyov <dmit...@google.com>
      Gerrit-Reviewer: Than McIntosh <th...@google.com>
      Gerrit-CC: Russ Cox <r...@golang.org>
      Gerrit-Comment-Date: Wed, 03 Jul 2024 23:24:13 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Than McIntosh (Gerrit)

      unread,
      7:39 PM (2 hours ago) 7:39 PM
      to Than McIntosh, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Go LUCI, Dmitri Shuralyov, Dmitri Shuralyov, Russ Cox, golang-co...@googlegroups.com

      Than McIntosh submitted the change with unreviewed changes

      Unreviewed changes

      2 is the latest approved patch-set.
      The change was submitted with unreviewed changes in the following files:

      ```
      The name of the file: go.sum
      Insertions: 0, Deletions: 2.

      @@ -127,8 +127,6 @@
       go.opencensus.io v0.24.0 h1:y73uSU6J157QMP2kn2r30vwW1A2W2WFwSCGnAVxeaD0=
       go.opencensus.io v0.24.0/go.mod h1:vNK8G9p7aAivkbmorf4v+7Hgx+Zs0yY+0fOtgBfjQKo=
       go.opentelemetry.io/proto/otlp v0.7.0/go.mod h1:PqfVotwruBrMGOCsRd/89rSnXhoiJIqeYNgFYFoEGnI=
      -golang.org/x/build v0.0.0-20240520181858-75ff9ef337d5 h1:AuX75q8YrFPUHM3PgwQukolV4h1mdj/lbDMpkRVnmnY=
      -golang.org/x/build v0.0.0-20240520181858-75ff9ef337d5/go.mod h1:yz9anu0Z63yrVrqnoOxoJuyBRDwtGUoOFJwtfvs+D+U=
       golang.org/x/build v0.0.0-20240703214439-7bd85afa0cc0 h1:bEt4Fxp8oGmLycLiB+Rny/RBGGeVHEFAoXw9PcRk7ZI=

       golang.org/x/build v0.0.0-20240703214439-7bd85afa0cc0/go.mod h1:Q3Y4+jnPQCnNizilofBXOJ7EmO14lCIRAAE8pKZshic=
       golang.org/x/crypto v0.0.0-20190308221718-c2843e01d9a2/go.mod h1:djNgcEr1/C05ACkg1iLfiJU5Ep61QUkGW8qpdssI0+w=
      ```

      Change information

      Commit message:
      go.mod: update x/build to CL 596477

      Update x/build to pick up changes for new x/oscar repo.
      Change-Id: I42cee48d593b5e4b061230a83af0e7f1c1c4eeca
      Reviewed-by: Dmitri Shuralyov <dmit...@google.com>
      Reviewed-by: Dmitri Shuralyov <dmit...@golang.org>
      Files:
      • M go.mod
      • M go.sum
      Change size: XS
      Delta: 2 files changed, 3 insertions(+), 3 deletions(-)
      Branch: refs/heads/master
      Submit Requirements:
      • requirement satisfiedCode-Review: +2 by Dmitri Shuralyov, +1 by Dmitri Shuralyov
      • requirement satisfiedTryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
      Open in Gerrit
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: merged
      Gerrit-Project: website
      Gerrit-Branch: master
      Gerrit-Change-Id: I42cee48d593b5e4b061230a83af0e7f1c1c4eeca
      Gerrit-Change-Number: 596695
      Gerrit-PatchSet: 4
      open
      diffy
      satisfied_requirement
      Reply all
      Reply to author
      Forward
      0 new messages