[go] cmd/compile/internal/typecheck: simplify tcSliceHeader
5 views
Skip to first unread message
Cuong Manh Le (Gerrit)
Mar 3, 2026, 11:10:32 AMMar 3
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Cuong Manh Le has uploaded the change for review![]( "Open in Gerrit")
Commit message
cmd/compile/internal/typecheck: simplify tcSliceHeader
types2 handles all constant-related bounds checks in user Go code now,
so it's safe to remove all constants checking in tcSliceHeader function.
Fixed #77919
Change-Id: Ibc137c84792d4898eb073cdeabac175684f73746
Change diff
diff --git a/src/cmd/compile/internal/typecheck/expr.go b/src/cmd/compile/internal/typecheck/expr.go
index 44a69f0..7dc2963 100644
--- a/src/cmd/compile/internal/typecheck/expr.go
+++ b/src/cmd/compile/internal/typecheck/expr.go
@@ -7,7 +7,6 @@
import (
"fmt"
"go/constant"
- "go/token"
"internal/types/errors"
"strings"
@@ -826,18 +825,6 @@
n.Len = DefaultLit(Expr(n.Len), types.Types[types.TINT])
n.Cap = DefaultLit(Expr(n.Cap), types.Types[types.TINT])
- if ir.IsConst(n.Len, constant.Int) && ir.Int64Val(n.Len) < 0 {
- base.Fatalf("len for OSLICEHEADER must be non-negative")
- }
-
- if ir.IsConst(n.Cap, constant.Int) && ir.Int64Val(n.Cap) < 0 {
- base.Fatalf("cap for OSLICEHEADER must be non-negative")
- }
-
- if ir.IsConst(n.Len, constant.Int) && ir.IsConst(n.Cap, constant.Int) && constant.Compare(n.Len.Val(), token.GTR, n.Cap.Val()) {
- base.Fatalf("len larger than cap for OSLICEHEADER")
- }
-
return n
}
diff --git a/test/fixedbugs/issue77919.go b/test/fixedbugs/issue77919.go
new file mode 100644
index 0000000..834331e
--- /dev/null
+++ b/test/fixedbugs/issue77919.go
@@ -0,0 +1,15 @@
+// compile
+
+// Copyright 2026 The Go Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style
+// license that can be found in the LICENSE file.
+
+package main
+
+var sink any
+
+func main() {
+ i := 0
+ output := make([]string, 8, i)
+ sink = output
+}
Change information
Files:
- M src/cmd/compile/internal/typecheck/expr.go
- A test/fixedbugs/issue77919.go
Change size: S
Delta: 2 files changed, 15 insertions(+), 13 deletions(-)
Related details
Attention set is empty
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Cuong Manh Le (Gerrit)
Mar 3, 2026, 11:11:00 AMMar 3
to goph...@pubsubhelper.golang.org, Keith Randall, Cherry Mui, Robert Griesemer, golang-co...@googlegroups.com
Attention needed from Cherry Mui and Keith Randall
Cuong Manh Le voted![]( "Open in Gerrit")
| Auto-Submit | +1 |
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Cherry Mui
- Keith Randall
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Keith Randall (Gerrit)
Mar 3, 2026, 12:50:28 PMMar 3
to Cuong Manh Le, goph...@pubsubhelper.golang.org, Keith Randall, Go LUCI, Cherry Mui, Robert Griesemer, golang-co...@googlegroups.com
Attention needed from Cherry Mui and Cuong Manh Le
Keith Randall voted Code-Review+2![]( "Open in Gerrit")
Attention is currently required from:
- Cherry Mui
- Cuong Manh Le
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Keith Randall (Gerrit)
Mar 3, 2026, 12:50:43 PMMar 3
to Cuong Manh Le, goph...@pubsubhelper.golang.org, Keith Randall, Go LUCI, Cherry Mui, Robert Griesemer, golang-co...@googlegroups.com
Attention needed from Cherry Mui and Cuong Manh Le
Keith Randall voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Cherry Mui
- Cuong Manh Le
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Cuong Manh Le (Gerrit)
Mar 4, 2026, 5:09:06 AMMar 4
to goph...@pubsubhelper.golang.org, Keith Randall, Keith Randall, Go LUCI, Cherry Mui, Robert Griesemer, golang-co...@googlegroups.com
Attention needed from Cherry Mui
Cuong Manh Le voted![]( "Open in Gerrit")
| Auto-Submit | +1 |
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Cherry Mui
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Cherry Mui (Gerrit)
Mar 6, 2026, 1:29:39 PM (14 days ago) Mar 6
to Cuong Manh Le, goph...@pubsubhelper.golang.org, David Chase, Go LUCI, Keith Randall, Keith Randall, Robert Griesemer, golang-co...@googlegroups.com
Attention needed from Cuong Manh Le and David Chase
Cherry Mui voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Cuong Manh Le
- David Chase
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gopher Robot (Gerrit)
Mar 6, 2026, 1:31:18 PM (14 days ago) Mar 6
to Cuong Manh Le, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Cherry Mui, David Chase, Go LUCI, Keith Randall, Keith Randall, Robert Griesemer, golang-co...@googlegroups.com
Gopher Robot submitted the change![]( "Open in Gerrit")
Unreviewed changes
1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
cmd/compile/internal/typecheck: simplify tcSliceHeader
types2 handles all constant-related bounds checks in user Go code now,
so it's safe to remove all constants checking in tcSliceHeader function.
Fixed #77919
Change-Id: Ibc137c84792d4898eb073cdeabac175684f73746
Reviewed-on: https://go-review.googlesource.com/c/go/+/751040
Reviewed-by: Keith Randall <k...@google.com>
LUCI-TryBot-Result: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Cherry Mui <cher...@google.com>
Reviewed-by: Keith Randall <k...@golang.org>
Auto-Submit: Cuong Manh Le <cuong.m...@gmail.com>
Files:
- M src/cmd/compile/internal/typecheck/expr.go
- A test/fixedbugs/issue77919.go
Change size: S
Delta: 2 files changed, 15 insertions(+), 13 deletions(-)
Branch: refs/heads/master
Submit Requirements:
Code-Review: +2 by Keith Randall, +1 by Keith Randall, +1 by Cherry Mui
TryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Cuong Manh Le (Gerrit)
Mar 10, 2026, 7:28:43 AM (10 days ago) Mar 10
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Cuong Manh Le has uploaded the change for review![]( "Open in Gerrit")
Commit message
[release-branch.go1.25] cmd/compile/internal/typecheck: simplify tcSliceHeader
types2 handles all constant-related bounds checks in user Go code now,
so it's safe to remove all constants checking in tcSliceHeader function.
Fixed #77921
Change-Id: Ibc137c84792d4898eb073cdeabac175684f73746
Reviewed-on: https://go-review.googlesource.com/c/go/+/751040
Reviewed-by: Keith Randall <k...@google.com>
LUCI-TryBot-Result: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Cherry Mui <cher...@google.com>
Reviewed-by: Keith Randall <k...@golang.org>
Auto-Submit: Cuong Manh Le <cuong.m...@gmail.com>
Change information
Files:
- M src/cmd/compile/internal/typecheck/expr.go
- A test/fixedbugs/issue77919.go
Change size: S
Delta: 2 files changed, 15 insertions(+), 13 deletions(-)
Related details
Attention set is empty
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Cuong Manh Le (Gerrit)
Mar 10, 2026, 7:29:26 AM (10 days ago) Mar 10
to goph...@pubsubhelper.golang.org, Keith Randall, Cherry Mui, golang-co...@googlegroups.com
Attention needed from Cherry Mui and Keith Randall
Cuong Manh Le voted Commit-Queue+1![]( "Open in Gerrit")
Attention is currently required from:
- Cherry Mui
- Keith Randall
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Cuong Manh Le (Gerrit)
Mar 10, 2026, 7:30:27 AM (10 days ago) Mar 10
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Cuong Manh Le has uploaded the change for review![]( "Open in Gerrit")
Commit message
[release-branch.go1.26] cmd/compile/internal/typecheck: simplify tcSliceHeader
types2 handles all constant-related bounds checks in user Go code now,
so it's safe to remove all constants checking in tcSliceHeader function.
Fixed #77922
Related details
Attention set is empty
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Cuong Manh Le (Gerrit)
Mar 10, 2026, 7:30:43 AM (10 days ago) Mar 10
to goph...@pubsubhelper.golang.org, Keith Randall, Cherry Mui, golang-co...@googlegroups.com
Attention needed from Cherry Mui and Keith Randall
Cuong Manh Le voted Commit-Queue+1![]( "Open in Gerrit")
Attention is currently required from:
- Cherry Mui
- Keith Randall
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Keith Randall (Gerrit)
Mar 10, 2026, 10:56:40 AM (10 days ago) Mar 10
to Cuong Manh Le, goph...@pubsubhelper.golang.org, Keith Randall, Go LUCI, Cherry Mui, golang-co...@googlegroups.com
Attention needed from Cherry Mui and Cuong Manh Le
Keith Randall voted Code-Review+2![]( "Open in Gerrit")
Attention is currently required from:
- Cherry Mui
- Cuong Manh Le
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Keith Randall (Gerrit)
Mar 10, 2026, 10:56:52 AM (10 days ago) Mar 10
to Cuong Manh Le, goph...@pubsubhelper.golang.org, Keith Randall, Go LUCI, Cherry Mui, golang-co...@googlegroups.com
Attention needed from Cherry Mui and Cuong Manh Le
Keith Randall voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Cherry Mui
- Cuong Manh Le
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Keith Randall (Gerrit)
Mar 10, 2026, 10:57:07 AM (10 days ago) Mar 10
to Cuong Manh Le, goph...@pubsubhelper.golang.org, Keith Randall, Go LUCI, Cherry Mui, golang-co...@googlegroups.com
Attention needed from Cherry Mui and Cuong Manh Le
Keith Randall voted Code-Review+2![]( "Open in Gerrit")
| Code-Review | +2 |
Related details
Attention is currently required from:
- Cherry Mui
- Cuong Manh Le
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Keith Randall (Gerrit)
Mar 10, 2026, 10:57:16 AM (10 days ago) Mar 10
to Cuong Manh Le, goph...@pubsubhelper.golang.org, Keith Randall, Go LUCI, Cherry Mui, golang-co...@googlegroups.com
Attention needed from Cherry Mui and Cuong Manh Le
Keith Randall voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Cherry Mui
- Cuong Manh Le
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mark Freeman (Gerrit)
Mar 10, 2026, 11:04:17 PM (9 days ago) Mar 10
to Cuong Manh Le, goph...@pubsubhelper.golang.org, Keith Randall, Keith Randall, Go LUCI, Cherry Mui, golang-co...@googlegroups.com
Attention needed from Cherry Mui and Cuong Manh Le
Mark Freeman voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Cherry Mui
- Cuong Manh Le
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mark Freeman (Gerrit)
Mar 10, 2026, 11:04:23 PM (9 days ago) Mar 10
to Cuong Manh Le, goph...@pubsubhelper.golang.org, Keith Randall, Keith Randall, Go LUCI, Cherry Mui, golang-co...@googlegroups.com
Attention needed from Cherry Mui and Cuong Manh Le
Mark Freeman voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Cherry Mui
- Cuong Manh Le
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Carlos Amedee (Gerrit)
Mar 19, 2026, 4:58:48 PM (12 hours ago) Mar 19
to Cuong Manh Le, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Mark Freeman, Keith Randall, Keith Randall, Go LUCI, Cherry Mui, golang-co...@googlegroups.com
Carlos Amedee submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[release-branch.go1.25] cmd/compile/internal/typecheck: simplify tcSliceHeader
types2 handles all constant-related bounds checks in user Go code now,
so it's safe to remove all constants checking in tcSliceHeader function.
Fixed #77921
Change-Id: Ibc137c84792d4898eb073cdeabac175684f73746
Reviewed-on: https://go-review.googlesource.com/c/go/+/751040
Reviewed-by: Keith Randall <k...@google.com>
LUCI-TryBot-Result: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Cherry Mui <cher...@google.com>
Reviewed-by: Keith Randall <k...@golang.org>
Auto-Submit: Cuong Manh Le <cuong.m...@gmail.com>
Reviewed-on: https://go-review.googlesource.com/c/go/+/753600
Reviewed-by: Mark Freeman <markf...@google.com>
Files:
- M src/cmd/compile/internal/typecheck/expr.go
- A test/fixedbugs/issue77919.go
Change size: S
Delta: 2 files changed, 15 insertions(+), 13 deletions(-)
Branch: refs/heads/release-branch.go1.25
Submit Requirements:
Code-Review: +1 by Mark Freeman, +2 by Keith Randall, +1 by Keith Randall
TryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Carlos Amedee (Gerrit)
Mar 19, 2026, 4:59:09 PM (12 hours ago) Mar 19
to Cuong Manh Le, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Mark Freeman, Keith Randall, Keith Randall, Go LUCI, Cherry Mui, golang-co...@googlegroups.com
Carlos Amedee submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[release-branch.go1.26] cmd/compile/internal/typecheck: simplify tcSliceHeader
types2 handles all constant-related bounds checks in user Go code now,
so it's safe to remove all constants checking in tcSliceHeader function.
Fixed #77922
Change-Id: Ibc137c84792d4898eb073cdeabac175684f73746
Reviewed-on: https://go-review.googlesource.com/c/go/+/751040
Reviewed-by: Keith Randall <k...@google.com>
LUCI-TryBot-Result: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Cherry Mui <cher...@google.com>
Reviewed-by: Keith Randall <k...@golang.org>
Auto-Submit: Cuong Manh Le <cuong.m...@gmail.com>
Reviewed-on: https://go-review.googlesource.com/c/go/+/753601
Reviewed-by: Mark Freeman <markf...@google.com>
Files:
- M src/cmd/compile/internal/typecheck/expr.go
- A test/fixedbugs/issue77919.go
Change size: S
Delta: 2 files changed, 15 insertions(+), 13 deletions(-)
Branch: refs/heads/release-branch.go1.26
Submit Requirements:
Code-Review: +2 by Keith Randall, +1 by Mark Freeman, +1 by Keith Randall
TryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages