[pkgsite] cmd/internal/pkgsite: fix godoc mode without -list

0 views

Skip to first unread message

Filippo Valsorda (Gerrit)

unread,

2:07 PM (5 hours ago) 2:07 PM

to goph...@pubsubhelper.golang.org, Filippo Valsorda, golang-co...@googlegroups.com

Filippo Valsorda has uploaded the change for review

Commit message

cmd/internal/pkgsite: fix godoc mode without -list

Looks like it had always been broken, since m doesn't have a useful
String() method.

Change-Id: I6ad3a60916d3611fb38982a3aaf648c46a6a6964

Change diff

diff --git a/cmd/internal/pkgsite/server.go b/cmd/internal/pkgsite/server.go
index 4dcf7e8..32986a5 100644
--- a/cmd/internal/pkgsite/server.go
+++ b/cmd/internal/pkgsite/server.go
@@ -224,7 +224,7 @@
 			patterns = append(patterns, "all")
 		} else {
 			for _, m := range modules {
-				patterns = append(patterns, fmt.Sprintf("%s/...", m))
+				patterns = append(patterns, fmt.Sprintf("%s/...", m.ModulePath))
 			}
 		}
 		mg, err := fetch.NewGoPackagesModuleGetter(ctx, dir, patterns...)

Change information

Files:

M cmd/internal/pkgsite/server.go

Change size: XS

Delta: 1 file changed, 1 insertion(+), 1 deletion(-)

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
kokoro-CI-Passes

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

unsatisfied_requirement

satisfied_requirement

open

diffy

kokoro (Gerrit)

unread,

2:33 PM (4 hours ago) 2:33 PM

to Filippo Valsorda, goph...@pubsubhelper.golang.org, Go LUCI, golang-co...@googlegroups.com

Attention needed from Filippo Valsorda

kokoro voted kokoro-CI+1

Kokoro presubmit build finished with status: SUCCESS
Logs at: https://source.cloud.google.com/results/invocations/b4f993be-8243-46c5-8342-7bcd6b0843e8

kokoro-CI

Open in Gerrit

Related details

Attention is currently required from:

Filippo Valsorda

Submit Requirements:

Code-Review
No-Unresolved-Comments
Review-Enforcement

TryBots-Pass
kokoro-CI-Passes

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

unsatisfied_requirement

satisfied_requirement

open

diffy

Reply all

Reply to author

Forward

0 new messages