[go] net: make GODEBUG=netdns=cgo force cgo as documented

177 views
Skip to first unread message

Brad Fitzpatrick (Gerrit)

unread,
Jul 22, 2015, 8:46:52 PM7/22/15
to Russ Cox, Mikio Hara, Ian Lance Taylor, Brad Fitzpatrick, golang-co...@googlegroups.com
Reviewers: Russ Cox, Mikio Hara

Brad Fitzpatrick uploaded a change:
https://go-review.googlesource.com/12544

net: make GODEBUG=netdns=cgo force cgo as documented

It wasn't working. The wrong variable was used.

This would ideally have tests. It's also DEBUG.

Fixes #11816

Change-Id: Iec42d229b81d78cece4ba5c73f3040e2356eb98f
---
M src/net/conf.go
1 file changed, 1 insertion(+), 1 deletion(-)



diff --git a/src/net/conf.go b/src/net/conf.go
index e70178d..01bb585 100644
--- a/src/net/conf.go
+++ b/src/net/conf.go
@@ -80,7 +80,7 @@
_, localDomainDefined := syscall.Getenv("LOCALDOMAIN")
if os.Getenv("RES_OPTIONS") != "" ||
os.Getenv("HOSTALIASES") != "" ||
- netCgo ||
+ confVal.netCgo ||
localDomainDefined {
confVal.forceCgoLookupHost = true
return

--
https://go-review.googlesource.com/12544
Gerrit-Reviewer: Mikio Hara <mikioh...@gmail.com>
Gerrit-Reviewer: Russ Cox <r...@golang.org>

Brad Fitzpatrick (Gerrit)

unread,
Jul 22, 2015, 9:09:46 PM7/22/15
to Brad Fitzpatrick, Russ Cox, Mikio Hara, golang-co...@googlegroups.com
Brad Fitzpatrick has posted comments on this change.

net: make GODEBUG=netdns=cgo force cgo as documented

Patch Set 1: Run-TryBot+1

--
https://go-review.googlesource.com/12544
Gerrit-Reviewer: Brad Fitzpatrick <brad...@golang.org>
Gerrit-Reviewer: Mikio Hara <mikioh...@gmail.com>
Gerrit-Reviewer: Russ Cox <r...@golang.org>
Gerrit-HasComments: No

Gobot Gobot (Gerrit)

unread,
Jul 22, 2015, 9:10:02 PM7/22/15
to Brad Fitzpatrick, Russ Cox, Mikio Hara, golang-co...@googlegroups.com
Gobot Gobot has posted comments on this change.

net: make GODEBUG=netdns=cgo force cgo as documented

Patch Set 1:

TryBots beginning. Status page: http://farmer.golang.org/try?commit=77d373fc

--
https://go-review.googlesource.com/12544
Gerrit-Reviewer: Brad Fitzpatrick <brad...@golang.org>
Gerrit-Reviewer: Gobot Gobot <go...@golang.org>
Gerrit-Reviewer: Mikio Hara <mikioh...@gmail.com>
Gerrit-Reviewer: Russ Cox <r...@golang.org>
Gerrit-HasComments: No

Ian Lance Taylor (Gerrit)

unread,
Jul 22, 2015, 9:10:12 PM7/22/15
to Brad Fitzpatrick, Russ Cox, Mikio Hara, Gobot Gobot, golang-co...@googlegroups.com
Ian Lance Taylor has posted comments on this change.

net: make GODEBUG=netdns=cgo force cgo as documented

Patch Set 1: Code-Review+2

--
https://go-review.googlesource.com/12544
Gerrit-Reviewer: Brad Fitzpatrick <brad...@golang.org>
Gerrit-Reviewer: Gobot Gobot <go...@golang.org>
Gerrit-Reviewer: Ian Lance Taylor <ia...@golang.org>
Gerrit-Reviewer: Mikio Hara <mikioh...@gmail.com>
Gerrit-Reviewer: Russ Cox <r...@golang.org>
Gerrit-HasComments: No

Gobot Gobot (Gerrit)

unread,
Jul 22, 2015, 9:24:13 PM7/22/15
to Brad Fitzpatrick, Russ Cox, Mikio Hara, Ian Lance Taylor, golang-co...@googlegroups.com
Gobot Gobot has posted comments on this change.

net: make GODEBUG=netdns=cgo force cgo as documented

Patch Set 1: TryBot-Result+1

TryBots are happy.

--
https://go-review.googlesource.com/12544
Gerrit-Reviewer: Brad Fitzpatrick <brad...@golang.org>
Gerrit-Reviewer: Gobot Gobot <go...@golang.org>
Gerrit-Reviewer: Ian Lance Taylor <ia...@golang.org>
Gerrit-Reviewer: Mikio Hara <mikioh...@gmail.com>
Gerrit-Reviewer: Russ Cox <r...@golang.org>
Gerrit-HasComments: No
Reply all
Reply to author
Forward
0 new messages