[tools] gopls/internal/lsprpc: increase test timeout 1s -> 10s
0 views
Skip to first unread message
Alan Donovan (Gerrit)
10:10 AM (5 hours ago) 10:10 AM
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Alan Donovan has uploaded the change for review![]( "Open in Gerrit")
Commit message
gopls/internal/lsprpc: increase test timeout 1s -> 10s
This should reduce test flakes.
Fixes golang/go#77831
Change-Id: If33a097b2d415a9733948112453fd24df28012d2
Change diff
diff --git a/gopls/internal/lsprpc/lsprpc_test.go b/gopls/internal/lsprpc/lsprpc_test.go
index 383384d..40939ec 100644
--- a/gopls/internal/lsprpc/lsprpc_test.go
+++ b/gopls/internal/lsprpc/lsprpc_test.go
@@ -79,7 +79,11 @@
if !matched {
t.Errorf("got log %q, want a log containing %q", got, want)
}
- case <-time.After(1 * time.Second):
+
+ case <-time.After(10 * time.Second):
+ // Any timeout we enforce here is at the mercy
+ // of the underlying operating system.
+ // 1s was occasionally flaky; 10s should be better.
t.Error("timeout waiting for client log")
}
}
Change information
Files:
- M gopls/internal/lsprpc/lsprpc_test.go
Change size: XS
Delta: 1 file changed, 5 insertions(+), 1 deletion(-)
Related details
Attention set is empty
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alan Donovan (Gerrit)
10:11 AM (5 hours ago) 10:11 AM
to goph...@pubsubhelper.golang.org, Hongxiang Jiang, Go LUCI, golang-co...@googlegroups.com
Attention needed from Hongxiang Jiang
Alan Donovan voted Auto-Submit+1![]( "Open in Gerrit")
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages