[vscode-go] extension/CHANGELOG.md: prepare for v0.42.0

10 views
Skip to first unread message

Hyang-Ah Hana Kim (Gerrit)

unread,
Jul 15, 2024, 2:52:21 PM7/15/24
to goph...@pubsubhelper.golang.org, Hyang-Ah Hana Kim, golang-co...@googlegroups.com

Hyang-Ah Hana Kim has uploaded the change for review

Commit message

extension/CHANGELOG.md: prepare for v0.42.0

For golang/vscode-go#3453
Change-Id: Iefb6aaec8688a527f506825f761dc3159761afb3

Change diff

diff --git a/extension/CHANGELOG.md b/extension/CHANGELOG.md
index 37ecf80..4aa7802 100644
--- a/extension/CHANGELOG.md
+++ b/extension/CHANGELOG.md
@@ -1,3 +1,39 @@
+## v0.42.0 - 17 Jul, 2024
+
+A comprehensive list of changes can be found in the complete [commit history](https://github.com/golang/vscode-go/compare/v0.42.0...v0.41.4).
+
+### Updates in `gopls`
+
+* Gopls v0.16: The latest Gopls version as of this release is [gopls v0.16](https://github.com/golang/tools/releases/tag/gopls%2Fv0.16.0). The extension settings documentation has been updated to align with the latest Gopls settings.
+* The gopls project provides an index of [all supported features](https://github.com/golang/tools/tree/master/gopls/doc/features). We are working on making this documentation more accessible from the extension. Please stay tuned for updates.
+
+### Updates in telemetry
+
+Like other Go toolchains, this extension continues to use Go Telemetry. We have enhanced the [Go Telemetry documentation](https://go.dev/doc/telemetry). By default, telemetry data is kept only on the local computer, but you can opt in to share it with the Go team with one of the following ways:
+
+- `go run golang.org/x/telemetry/cmd/gotelemetry@latest on` in the terminal, or
+- `go telemetry on`, from go1.23, or
+- Respond to the prompt when it appears.
+
+Once uploading is enabled, the data will be sent to https://telemetry.go.dev each week.
+
+### Changes
+
+#### Tools installation
+
+* For tools installation managed by the extension, this version requires go1.19 or a newer version. The next minor release (v0.43.0+) will require go1.21 or newer. You can still manually install the required tools or use the [`"go.toolsManagement.go"` setting](https://github.com/golang/vscode-go/wiki/settings#gotoolsmanagementgo) to make the extension use a newer Go version than your project's go version. However, we strongly encourage upgrading to the [officially supported go versions](https://go.dev/doc/devel/release#policy) to receive security updates and bug fixes.
+
+* The extension installs its required tools using the `go install` command. Starting go1.21, the `go` command allows tool authors to specify the minimum Go version required to build their tools. If the required go toolchain version is not locally available, the `go` command needs to download it like other dependencies of the tool. To ensure this toolchain switch works correctly, the extension enforces `GOTOOLCHAIN=auto` mode during tools installation. Note that this change does not affect how it builds and tests your own project. For more information about Go's toolchain switch behavior, see the [official documentation](https://go.dev/doc/toolchain).
+
+#### Debugging
+
+* The default launch.json template for "Go: Launch Package" was updated to use `"${workspaceFolder}${1:}"` instead of `"${fileDirname}"` as the default `"program"` attribute value. If the package to debug is located in the subdirectory, adjust the configuration to point to the main package path. The [official VS Code Variables Reference](https://code.visualstudio.com/docs/editor/variables-reference) lists useful substitution rules you can use in adjusting your launch.json setting.
+
+### Thanks
+
+Thanks for your contributions, @yimiaoxiehou!
+
+
## v0.41.4 - 24 Apr, 2024

This point release addresses a regression issue (spurious display of the Go welcome page) within cloud-based IDEs.

Change information

Files:
  • M extension/CHANGELOG.md
Change size: S
Delta: 1 file changed, 36 insertions(+), 0 deletions(-)
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedkokoro-CI-Passes
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: vscode-go
Gerrit-Branch: master
Gerrit-Change-Id: Iefb6aaec8688a527f506825f761dc3159761afb3
Gerrit-Change-Number: 598217
Gerrit-PatchSet: 1
Gerrit-Owner: Hyang-Ah Hana Kim <hya...@gmail.com>
Gerrit-Reviewer: Hyang-Ah Hana Kim <hya...@gmail.com>
unsatisfied_requirement
satisfied_requirement
open
diffy

kokoro (Gerrit)

unread,
Jul 15, 2024, 3:06:10 PM7/15/24
to Hyang-Ah Hana Kim, goph...@pubsubhelper.golang.org, Robert Findley, Hongxiang Jiang, golang-co...@googlegroups.com
Attention needed from Hongxiang Jiang and Robert Findley

kokoro voted kokoro-CI+1

Kokoro presubmit build finished with status: SUCCESS
Logs at: https://source.cloud.google.com/results/invocations/8acb4512-dd89-43ea-b769-42c029edba47

kokoro-CI+1
Open in Gerrit

Related details

Attention is currently required from:
  • Hongxiang Jiang
  • Robert Findley
Submit Requirements:
    • requirement is not satisfiedCode-Review
    • requirement satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    • requirement satisfiedkokoro-CI-Passes
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: vscode-go
    Gerrit-Branch: master
    Gerrit-Change-Id: Iefb6aaec8688a527f506825f761dc3159761afb3
    Gerrit-Change-Number: 598217
    Gerrit-PatchSet: 1
    Gerrit-Owner: Hyang-Ah Hana Kim <hya...@gmail.com>
    Gerrit-Reviewer: Hongxiang Jiang <hxj...@golang.org>
    Gerrit-Reviewer: Hyang-Ah Hana Kim <hya...@gmail.com>
    Gerrit-Reviewer: Robert Findley <rfin...@google.com>
    Gerrit-Reviewer: kokoro <noreply...@google.com>
    Gerrit-CC: kokoro <noreply...@google.com>
    Gerrit-Attention: Robert Findley <rfin...@google.com>
    Gerrit-Attention: Hongxiang Jiang <hxj...@golang.org>
    Gerrit-Comment-Date: Mon, 15 Jul 2024 19:06:04 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    unsatisfied_requirement
    satisfied_requirement
    open
    diffy

    Robert Findley (Gerrit)

    unread,
    Jul 15, 2024, 4:29:53 PM7/15/24
    to Hyang-Ah Hana Kim, goph...@pubsubhelper.golang.org, kokoro, Hongxiang Jiang, golang-co...@googlegroups.com
    Attention needed from Hongxiang Jiang and Hyang-Ah Hana Kim

    Robert Findley added 3 comments

    File extension/CHANGELOG.md
    Line 12, Patchset 1 (Latest):Like other Go toolchains, this extension continues to use Go Telemetry. We have enhanced the [Go Telemetry documentation](https://go.dev/doc/telemetry). By default, telemetry data is kept only on the local computer, but you can opt in to share it with the Go team with one of the following ways:
    Robert Findley . unresolved

    I don't understand this sentence -- what other Go toolchains are there?

    I suggest simplifying the first two sentences to:
    ```
    This extension continues to use [Go toolchain telemetry](https://go.dev/doc/telemetry).
    ```

    Line 18, Patchset 1 (Latest):Once uploading is enabled, the data will be sent to https://telemetry.go.dev each week.
    Robert Findley . unresolved

    s/each week/approximately once a week

    Line 24, Patchset 1 (Latest):* For tools installation managed by the extension, this version requires go1.19 or a newer version. The next minor release (v0.43.0+) will require go1.21 or newer. You can still manually install the required tools or use the [`"go.toolsManagement.go"` setting](https://github.com/golang/vscode-go/wiki/settings#gotoolsmanagementgo) to make the extension use a newer Go version than your project's go version. However, we strongly encourage upgrading to the [officially supported go versions](https://go.dev/doc/devel/release#policy) to receive security updates and bug fixes.
    Robert Findley . unresolved

    I'm a little confused by this sentence. The previous sentence mentions upgrading to a newer Go version, and then this sentence starts "However, we strongly encourage upgrading...", as if the previous sentence was about using older Go versions.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Hongxiang Jiang
    • Hyang-Ah Hana Kim
    Submit Requirements:
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedNo-Unresolved-Comments
      • requirement is not satisfiedReview-Enforcement
      • requirement satisfiedkokoro-CI-Passes
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: vscode-go
      Gerrit-Branch: master
      Gerrit-Change-Id: Iefb6aaec8688a527f506825f761dc3159761afb3
      Gerrit-Change-Number: 598217
      Gerrit-PatchSet: 1
      Gerrit-Owner: Hyang-Ah Hana Kim <hya...@gmail.com>
      Gerrit-Reviewer: Hongxiang Jiang <hxj...@golang.org>
      Gerrit-Reviewer: Hyang-Ah Hana Kim <hya...@gmail.com>
      Gerrit-Reviewer: Robert Findley <rfin...@google.com>
      Gerrit-Reviewer: kokoro <noreply...@google.com>
      Gerrit-CC: kokoro <noreply...@google.com>
      Gerrit-Attention: Hongxiang Jiang <hxj...@golang.org>
      Gerrit-Attention: Hyang-Ah Hana Kim <hya...@gmail.com>
      Gerrit-Comment-Date: Mon, 15 Jul 2024 20:29:46 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      unsatisfied_requirement
      satisfied_requirement
      open
      diffy

      Hyang-Ah Hana Kim (Gerrit)

      unread,
      Jul 15, 2024, 4:57:12 PM7/15/24
      to Hyang-Ah Hana Kim, goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
      Attention needed from Hongxiang Jiang and Hyang-Ah Hana Kim

      Hyang-Ah Hana Kim uploaded new patchset

      Hyang-Ah Hana Kim uploaded patch set #2 to this change.
      Following approvals got outdated and were removed:
      • kokoro-CI-Passes: kokoro-CI+1 by kokoro
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Hongxiang Jiang
      • Hyang-Ah Hana Kim
      Submit Requirements:
        • requirement is not satisfiedCode-Review
        • requirement is not satisfiedNo-Unresolved-Comments
        • requirement is not satisfiedReview-Enforcement
        • requirement is not satisfiedkokoro-CI-Passes
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: newpatchset
        Gerrit-Project: vscode-go
        Gerrit-Branch: master
        Gerrit-Change-Id: Iefb6aaec8688a527f506825f761dc3159761afb3
        Gerrit-Change-Number: 598217
        Gerrit-PatchSet: 2
        unsatisfied_requirement
        open
        diffy

        Hyang-Ah Hana Kim (Gerrit)

        unread,
        Jul 15, 2024, 4:59:33 PM7/15/24
        to Hyang-Ah Hana Kim, goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
        Attention needed from Hongxiang Jiang and Hyang-Ah Hana Kim

        Hyang-Ah Hana Kim uploaded new patchset

        Hyang-Ah Hana Kim uploaded patch set #3 to this change.
        Open in Gerrit

        Related details

        Attention is currently required from:
        • Hongxiang Jiang
        • Hyang-Ah Hana Kim
        Submit Requirements:
        • requirement is not satisfiedCode-Review
        • requirement is not satisfiedNo-Unresolved-Comments
        • requirement is not satisfiedReview-Enforcement
        • requirement is not satisfiedkokoro-CI-Passes
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: newpatchset
        Gerrit-Project: vscode-go
        Gerrit-Branch: master
        Gerrit-Change-Id: Iefb6aaec8688a527f506825f761dc3159761afb3
        Gerrit-Change-Number: 598217
        Gerrit-PatchSet: 3
        unsatisfied_requirement
        open
        diffy

        Hyang-Ah Hana Kim (Gerrit)

        unread,
        Jul 15, 2024, 5:00:28 PM7/15/24
        to Hyang-Ah Hana Kim, goph...@pubsubhelper.golang.org, kokoro, Robert Findley, Hongxiang Jiang, golang-co...@googlegroups.com
        Attention needed from Hongxiang Jiang and Robert Findley

        Hyang-Ah Hana Kim added 3 comments

        File extension/CHANGELOG.md
        Line 12, Patchset 1:Like other Go toolchains, this extension continues to use Go Telemetry. We have enhanced the [Go Telemetry documentation](https://go.dev/doc/telemetry). By default, telemetry data is kept only on the local computer, but you can opt in to share it with the Go team with one of the following ways:
        Robert Findley . resolved

        I don't understand this sentence -- what other Go toolchains are there?

        I suggest simplifying the first two sentences to:
        ```
        This extension continues to use [Go toolchain telemetry](https://go.dev/doc/telemetry).
        ```

        Hyang-Ah Hana Kim

        Done

        Line 18, Patchset 1:Once uploading is enabled, the data will be sent to https://telemetry.go.dev each week.
        Robert Findley . resolved

        s/each week/approximately once a week

        Hyang-Ah Hana Kim

        Done

        Line 24, Patchset 1:* For tools installation managed by the extension, this version requires go1.19 or a newer version. The next minor release (v0.43.0+) will require go1.21 or newer. You can still manually install the required tools or use the [`"go.toolsManagement.go"` setting](https://github.com/golang/vscode-go/wiki/settings#gotoolsmanagementgo) to make the extension use a newer Go version than your project's go version. However, we strongly encourage upgrading to the [officially supported go versions](https://go.dev/doc/devel/release#policy) to receive security updates and bug fixes.
        Robert Findley . unresolved

        I'm a little confused by this sentence. The previous sentence mentions upgrading to a newer Go version, and then this sentence starts "However, we strongly encourage upgrading...", as if the previous sentence was about using older Go versions.

        Hyang-Ah Hana Kim

        PTAL.

        Open in Gerrit

        Related details

        Attention is currently required from:
        • Hongxiang Jiang
        • Robert Findley
        Submit Requirements:
        • requirement is not satisfiedCode-Review
        • requirement is not satisfiedNo-Unresolved-Comments
        • requirement is not satisfiedReview-Enforcement
        • requirement is not satisfiedkokoro-CI-Passes
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: vscode-go
        Gerrit-Branch: master
        Gerrit-Change-Id: Iefb6aaec8688a527f506825f761dc3159761afb3
        Gerrit-Change-Number: 598217
        Gerrit-PatchSet: 3
        Gerrit-Owner: Hyang-Ah Hana Kim <hya...@gmail.com>
        Gerrit-Reviewer: Hongxiang Jiang <hxj...@golang.org>
        Gerrit-Reviewer: Hyang-Ah Hana Kim <hya...@gmail.com>
        Gerrit-Reviewer: Robert Findley <rfin...@google.com>
        Gerrit-Reviewer: kokoro <noreply...@google.com>
        Gerrit-CC: kokoro <noreply...@google.com>
        Gerrit-Attention: Robert Findley <rfin...@google.com>
        Gerrit-Attention: Hongxiang Jiang <hxj...@golang.org>
        Gerrit-Comment-Date: Mon, 15 Jul 2024 21:00:22 +0000
        Gerrit-HasComments: Yes
        Gerrit-Has-Labels: No
        Comment-In-Reply-To: Robert Findley <rfin...@google.com>
        unsatisfied_requirement
        open
        diffy

        Robert Findley (Gerrit)

        unread,
        Jul 15, 2024, 5:03:51 PM7/15/24
        to Hyang-Ah Hana Kim, goph...@pubsubhelper.golang.org, kokoro, Hongxiang Jiang, golang-co...@googlegroups.com
        Attention needed from Hongxiang Jiang and Hyang-Ah Hana Kim

        Robert Findley voted and added 3 comments

        Votes added by Robert Findley

        Code-Review+2

        3 comments

        File extension/CHANGELOG.md
        Line 7, Patchset 3 (Latest):* Gopls v0.16: The latest Gopls version as of this release is [gopls v0.16](https://github.com/golang/tools/releases/tag/gopls%2Fv0.16.0). The extension settings documentation has been updated to align with the latest Gopls settings.
        Robert Findley . unresolved

        s/Gopls/gopls, whenever it not the start of a sentence.

        Line 24, Patchset 1:* For tools installation managed by the extension, this version requires go1.19 or a newer version. The next minor release (v0.43.0+) will require go1.21 or newer. You can still manually install the required tools or use the [`"go.toolsManagement.go"` setting](https://github.com/golang/vscode-go/wiki/settings#gotoolsmanagementgo) to make the extension use a newer Go version than your project's go version. However, we strongly encourage upgrading to the [officially supported go versions](https://go.dev/doc/devel/release#policy) to receive security updates and bug fixes.
        Robert Findley . resolved

        I'm a little confused by this sentence. The previous sentence mentions upgrading to a newer Go version, and then this sentence starts "However, we strongly encourage upgrading...", as if the previous sentence was about using older Go versions.

        Hyang-Ah Hana Kim

        PTAL.

        Robert Findley

        Much clearer, thanks.

        Line 25, Patchset 3 (Latest):* For tools installation managed by the extension, this version requires go1.19 or a newer version. The next minor release (v0.43.0+) will require go1.21 or newer to install tools. If your project requires go1.20 or older to build, you will need to manually install [compatible versions of tools](https://github.com/golang/vscode-go/wiki/tools), or configure the [`"go.toolsManagement.go"` setting](https://github.com/golang/vscode-go/wiki/settings#gotoolsmanagementgo) to use go1.21+ when installing the tools.
        Robert Findley . unresolved

        go1.19 or newer

        Open in Gerrit

        Related details

        Attention is currently required from:
        • Hongxiang Jiang
        • Hyang-Ah Hana Kim
        Submit Requirements:
        • requirement satisfiedCode-Review
        • requirement is not satisfiedNo-Unresolved-Comments
        • requirement satisfiedReview-Enforcement
        • requirement is not satisfiedkokoro-CI-Passes
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: vscode-go
        Gerrit-Branch: master
        Gerrit-Change-Id: Iefb6aaec8688a527f506825f761dc3159761afb3
        Gerrit-Change-Number: 598217
        Gerrit-PatchSet: 3
        Gerrit-Owner: Hyang-Ah Hana Kim <hya...@gmail.com>
        Gerrit-Reviewer: Hongxiang Jiang <hxj...@golang.org>
        Gerrit-Reviewer: Hyang-Ah Hana Kim <hya...@gmail.com>
        Gerrit-Reviewer: Robert Findley <rfin...@google.com>
        Gerrit-Reviewer: kokoro <noreply...@google.com>
        Gerrit-CC: kokoro <noreply...@google.com>
        Gerrit-Attention: Hongxiang Jiang <hxj...@golang.org>
        Gerrit-Attention: Hyang-Ah Hana Kim <hya...@gmail.com>
        Gerrit-Comment-Date: Mon, 15 Jul 2024 21:03:45 +0000
        Gerrit-HasComments: Yes
        Gerrit-Has-Labels: Yes
        Comment-In-Reply-To: Robert Findley <rfin...@google.com>
        Comment-In-Reply-To: Hyang-Ah Hana Kim <hya...@gmail.com>
        satisfied_requirement
        unsatisfied_requirement
        open
        diffy

        Hyang-Ah Hana Kim (Gerrit)

        unread,
        Jul 15, 2024, 5:07:00 PM7/15/24
        to Hyang-Ah Hana Kim, goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
        Attention needed from Hongxiang Jiang and Hyang-Ah Hana Kim

        Hyang-Ah Hana Kim uploaded new patchset

        Hyang-Ah Hana Kim uploaded patch set #4 to this change.
        Open in Gerrit

        Related details

        Attention is currently required from:
        • Hongxiang Jiang
        • Hyang-Ah Hana Kim
        Submit Requirements:
        • requirement satisfiedCode-Review
        • requirement is not satisfiedNo-Unresolved-Comments
        • requirement satisfiedReview-Enforcement
        • requirement is not satisfiedkokoro-CI-Passes
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: newpatchset
        Gerrit-Project: vscode-go
        Gerrit-Branch: master
        Gerrit-Change-Id: Iefb6aaec8688a527f506825f761dc3159761afb3
        Gerrit-Change-Number: 598217
        Gerrit-PatchSet: 4
        satisfied_requirement
        unsatisfied_requirement
        open
        diffy

        kokoro (Gerrit)

        unread,
        Jul 15, 2024, 5:07:27 PM7/15/24
        to Hyang-Ah Hana Kim, goph...@pubsubhelper.golang.org, Robert Findley, Hongxiang Jiang, golang-co...@googlegroups.com
        Attention needed from Hongxiang Jiang and Hyang-Ah Hana Kim

        kokoro voted kokoro-CI+1

        Kokoro presubmit build finished with status: SUCCESS

        Open in Gerrit

        Related details

        Attention is currently required from:
        • Hongxiang Jiang
        • Hyang-Ah Hana Kim
        Submit Requirements:
        • requirement satisfiedCode-Review
        • requirement is not satisfiedNo-Unresolved-Comments
        • requirement satisfiedReview-Enforcement
        • requirement is not satisfiedkokoro-CI-Passes
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: vscode-go
        Gerrit-Branch: master
        Gerrit-Change-Id: Iefb6aaec8688a527f506825f761dc3159761afb3
        Gerrit-Change-Number: 598217
        Gerrit-PatchSet: 2
        Gerrit-Owner: Hyang-Ah Hana Kim <hya...@gmail.com>
        Gerrit-Reviewer: Hongxiang Jiang <hxj...@golang.org>
        Gerrit-Reviewer: Hyang-Ah Hana Kim <hya...@gmail.com>
        Gerrit-Reviewer: Robert Findley <rfin...@google.com>
        Gerrit-Reviewer: kokoro <noreply...@google.com>
        Gerrit-CC: kokoro <noreply...@google.com>
        Gerrit-Attention: Hongxiang Jiang <hxj...@golang.org>
        Gerrit-Attention: Hyang-Ah Hana Kim <hya...@gmail.com>
        Gerrit-Comment-Date: Mon, 15 Jul 2024 21:07:19 +0000
        Gerrit-HasComments: No
        Gerrit-Has-Labels: Yes
        satisfied_requirement
        unsatisfied_requirement
        open
        diffy

        Hyang-Ah Hana Kim (Gerrit)

        unread,
        Jul 15, 2024, 5:11:42 PM7/15/24
        to Hyang-Ah Hana Kim, goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
        Attention needed from Hongxiang Jiang and Hyang-Ah Hana Kim

        Hyang-Ah Hana Kim uploaded new patchset

        Hyang-Ah Hana Kim uploaded patch set #5 to this change.
        Open in Gerrit

        Related details

        Attention is currently required from:
        • Hongxiang Jiang
        • Hyang-Ah Hana Kim
        Submit Requirements:
        • requirement satisfiedCode-Review
        • requirement is not satisfiedNo-Unresolved-Comments
        • requirement satisfiedReview-Enforcement
        • requirement is not satisfiedkokoro-CI-Passes
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: newpatchset
        Gerrit-Project: vscode-go
        Gerrit-Branch: master
        Gerrit-Change-Id: Iefb6aaec8688a527f506825f761dc3159761afb3
        Gerrit-Change-Number: 598217
        Gerrit-PatchSet: 5
        satisfied_requirement
        unsatisfied_requirement
        open
        diffy

        Hyang-Ah Hana Kim (Gerrit)

        unread,
        Jul 15, 2024, 5:12:32 PM7/15/24
        to Hyang-Ah Hana Kim, goph...@pubsubhelper.golang.org, kokoro, Robert Findley, Hongxiang Jiang, golang-co...@googlegroups.com
        Attention needed from Hongxiang Jiang

        Hyang-Ah Hana Kim voted and added 2 comments

        Votes added by Hyang-Ah Hana Kim

        Auto-Submit+1

        2 comments

        File extension/CHANGELOG.md
        Line 7, Patchset 3:* Gopls v0.16: The latest Gopls version as of this release is [gopls v0.16](https://github.com/golang/tools/releases/tag/gopls%2Fv0.16.0). The extension settings documentation has been updated to align with the latest Gopls settings.
        Robert Findley . resolved

        s/Gopls/gopls, whenever it not the start of a sentence.

        Hyang-Ah Hana Kim

        Thanks. Done.

        Line 25, Patchset 3:* For tools installation managed by the extension, this version requires go1.19 or a newer version. The next minor release (v0.43.0+) will require go1.21 or newer to install tools. If your project requires go1.20 or older to build, you will need to manually install [compatible versions of tools](https://github.com/golang/vscode-go/wiki/tools), or configure the [`"go.toolsManagement.go"` setting](https://github.com/golang/vscode-go/wiki/settings#gotoolsmanagementgo) to use go1.21+ when installing the tools.
        Robert Findley . resolved

        go1.19 or newer

        Hyang-Ah Hana Kim

        Done

        Open in Gerrit

        Related details

        Attention is currently required from:
        • Hongxiang Jiang
        Submit Requirements:
        • requirement satisfiedCode-Review
        • requirement satisfiedNo-Unresolved-Comments
        • requirement satisfiedReview-Enforcement
        • requirement is not satisfiedkokoro-CI-Passes
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: vscode-go
        Gerrit-Branch: master
        Gerrit-Change-Id: Iefb6aaec8688a527f506825f761dc3159761afb3
        Gerrit-Change-Number: 598217
        Gerrit-PatchSet: 5
        Gerrit-Owner: Hyang-Ah Hana Kim <hya...@gmail.com>
        Gerrit-Reviewer: Hongxiang Jiang <hxj...@golang.org>
        Gerrit-Reviewer: Hyang-Ah Hana Kim <hya...@gmail.com>
        Gerrit-Reviewer: Robert Findley <rfin...@google.com>
        Gerrit-Reviewer: kokoro <noreply...@google.com>
        Gerrit-CC: kokoro <noreply...@google.com>
        Gerrit-Attention: Hongxiang Jiang <hxj...@golang.org>
        Gerrit-Comment-Date: Mon, 15 Jul 2024 21:12:28 +0000
        satisfied_requirement
        unsatisfied_requirement
        open
        diffy

        kokoro (Gerrit)

        unread,
        Jul 15, 2024, 5:19:12 PM7/15/24
        to Hyang-Ah Hana Kim, goph...@pubsubhelper.golang.org, Robert Findley, Hongxiang Jiang, golang-co...@googlegroups.com
        Attention needed from Hongxiang Jiang

        kokoro voted kokoro-CI+1

        Kokoro presubmit build finished with status: SUCCESS

        Open in Gerrit

        Related details

        Attention is currently required from:
        • Hongxiang Jiang
        Submit Requirements:
        • requirement satisfiedCode-Review
        • requirement satisfiedNo-Unresolved-Comments
        • requirement satisfiedReview-Enforcement
        • requirement is not satisfiedkokoro-CI-Passes
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: vscode-go
        Gerrit-Branch: master
        Gerrit-Change-Id: Iefb6aaec8688a527f506825f761dc3159761afb3
        Gerrit-Change-Number: 598217
        Gerrit-PatchSet: 3
        Gerrit-Owner: Hyang-Ah Hana Kim <hya...@gmail.com>
        Gerrit-Reviewer: Hongxiang Jiang <hxj...@golang.org>
        Gerrit-Reviewer: Hyang-Ah Hana Kim <hya...@gmail.com>
        Gerrit-Reviewer: Robert Findley <rfin...@google.com>
        Gerrit-Reviewer: kokoro <noreply...@google.com>
        Gerrit-CC: kokoro <noreply...@google.com>
        Gerrit-Attention: Hongxiang Jiang <hxj...@golang.org>
        Gerrit-Comment-Date: Mon, 15 Jul 2024 21:19:07 +0000
        Gerrit-HasComments: No
        Gerrit-Has-Labels: Yes
        satisfied_requirement
        unsatisfied_requirement
        open
        diffy

        kokoro (Gerrit)

        unread,
        Jul 15, 2024, 5:22:38 PM7/15/24
        to Hyang-Ah Hana Kim, goph...@pubsubhelper.golang.org, Robert Findley, Hongxiang Jiang, golang-co...@googlegroups.com
        Attention needed from Hongxiang Jiang

        kokoro voted kokoro-CI+1

        Kokoro presubmit build finished with status: SUCCESS

        Open in Gerrit

        Related details

        Attention is currently required from:
        • Hongxiang Jiang
        Submit Requirements:
        • requirement satisfiedCode-Review
        • requirement satisfiedNo-Unresolved-Comments
        • requirement satisfiedReview-Enforcement
        • requirement is not satisfiedkokoro-CI-Passes
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: vscode-go
        Gerrit-Branch: master
        Gerrit-Change-Id: Iefb6aaec8688a527f506825f761dc3159761afb3
        Gerrit-Change-Number: 598217
        Gerrit-PatchSet: 4
        Gerrit-Owner: Hyang-Ah Hana Kim <hya...@gmail.com>
        Gerrit-Reviewer: Hongxiang Jiang <hxj...@golang.org>
        Gerrit-Reviewer: Hyang-Ah Hana Kim <hya...@gmail.com>
        Gerrit-Reviewer: Robert Findley <rfin...@google.com>
        Gerrit-Reviewer: kokoro <noreply...@google.com>
        Gerrit-CC: kokoro <noreply...@google.com>
        Gerrit-Attention: Hongxiang Jiang <hxj...@golang.org>
        Gerrit-Comment-Date: Mon, 15 Jul 2024 21:22:33 +0000
        Gerrit-HasComments: No
        Gerrit-Has-Labels: Yes
        satisfied_requirement
        unsatisfied_requirement
        open
        diffy

        kokoro (Gerrit)

        unread,
        Jul 15, 2024, 5:23:33 PM7/15/24
        to Hyang-Ah Hana Kim, goph...@pubsubhelper.golang.org, Robert Findley, Hongxiang Jiang, golang-co...@googlegroups.com
        Attention needed from Hongxiang Jiang

        kokoro voted kokoro-CI+1

        Kokoro presubmit build finished with status: SUCCESS

        Related details

        Attention is currently required from:
        • Hongxiang Jiang
        Submit Requirements:
          • requirement satisfiedCode-Review
          • requirement satisfiedNo-Unresolved-Comments
          • requirement satisfiedReview-Enforcement
          • requirement satisfiedkokoro-CI-Passes
          Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
          Gerrit-MessageType: comment
          Gerrit-Project: vscode-go
          Gerrit-Branch: master
          Gerrit-Change-Id: Iefb6aaec8688a527f506825f761dc3159761afb3
          Gerrit-Change-Number: 598217
          Gerrit-PatchSet: 5
          Gerrit-Owner: Hyang-Ah Hana Kim <hya...@gmail.com>
          Gerrit-Reviewer: Hongxiang Jiang <hxj...@golang.org>
          Gerrit-Reviewer: Hyang-Ah Hana Kim <hya...@gmail.com>
          Gerrit-Reviewer: Robert Findley <rfin...@google.com>
          Gerrit-Reviewer: kokoro <noreply...@google.com>
          Gerrit-CC: kokoro <noreply...@google.com>
          Gerrit-Attention: Hongxiang Jiang <hxj...@golang.org>
          Gerrit-Comment-Date: Mon, 15 Jul 2024 21:23:29 +0000
          Gerrit-HasComments: No
          Gerrit-Has-Labels: Yes
          satisfied_requirement
          open
          diffy

          Gopher Robot (Gerrit)

          unread,
          Jul 15, 2024, 5:24:36 PM7/15/24
          to Hyang-Ah Hana Kim, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, kokoro, Robert Findley, Hongxiang Jiang, golang-co...@googlegroups.com

          Gopher Robot submitted the change with unreviewed changes

          Unreviewed changes

          3 is the latest approved patch-set.
          The change was submitted with unreviewed changes in the following files:

          ```
          The name of the file: extension/CHANGELOG.md
          Insertions: 3, Deletions: 3.

          @@ -4,7 +4,7 @@

          ### Updates in `gopls`

          -* Gopls v0.16: The latest Gopls version as of this release is [gopls v0.16](https://github.com/golang/tools/releases/tag/gopls%2Fv0.16.0). The extension settings documentation has been updated to align with the latest Gopls settings.
          +* Gopls v0.16: The latest gopls version as of this release is [gopls v0.16](https://github.com/golang/tools/releases/tag/gopls%2Fv0.16.0). The extension settings documentation has been updated to align with the latest gopls settings.

          * The gopls project provides an index of [all supported features](https://github.com/golang/tools/tree/master/gopls/doc/features). We are working on making this documentation more accessible from the extension. Please stay tuned for updates.

           ### Updates in telemetry
          @@ -22,7 +22,7 @@

          #### Tools installation

          -* For tools installation managed by the extension, this version requires go1.19 or a newer version. The next minor release (v0.43.0+) will require go1.21 or newer to install tools. If your project requires go1.20 or older to build, you will need to manually install [compatible versions of tools](https://github.com/golang/vscode-go/wiki/tools), or configure the [`"go.toolsManagement.go"` setting](https://github.com/golang/vscode-go/wiki/settings#gotoolsmanagementgo) to use go1.21+ when installing the tools.
          +* For tools installation managed by the extension, this version requires go1.19 or newer version. The next minor release (v0.43.0+) will require go1.21 or newer to install tools. If your project requires go1.20 or older to build, you will need to manually install [compatible versions of tools](https://github.com/golang/vscode-go/wiki/tools), or configure the [`"go.toolsManagement.go"` setting](https://github.com/golang/vscode-go/wiki/settings#gotoolsmanagementgo) to use go1.21+ when installing the tools.


          * The extension installs its required tools using the `go install` command. Starting go1.21, the `go` command allows tool authors to specify the minimum Go version required to build their tools. If the required go toolchain version is not locally available, the `go` command needs to download it like other dependencies of the tool. To ensure this toolchain switch works correctly, the extension enforces `GOTOOLCHAIN=auto` mode during tools installation. Note that this change does not affect how it builds and tests your own project. For more information about Go's toolchain switch behavior, see the [official documentation](https://go.dev/doc/toolchain).

          @@ -503,7 +503,7 @@

          * Activation: the extension defers commands and feature provider registrations until it runs `go version` and `go env`, and starts `gopls`. [This change](https://go-review.googlesource.com/c/vscode-go/+/398155) prevent the extension prematually export its features, but may result in a slight increase in extension activation time if those commands run slow.

          -* Survey: we show the Gopls opt-out survey prompt only when users change the setting to disable `gopls`.
          +* Survey: we show the gopls opt-out survey prompt only when users change the setting to disable `gopls`.

          * Test Explorer: fixed a bug in `go.mod` file parsing ([Issue 2171](https://github.com/golang/vscode-go/issues/2171))

          ```

          Change information

          Commit message:
          extension/CHANGELOG.md: prepare for v0.42.0

          For golang/vscode-go#3453
          Change-Id: Iefb6aaec8688a527f506825f761dc3159761afb3
          Commit-Queue: Hyang-Ah Hana Kim <hya...@gmail.com>
          Reviewed-by: Robert Findley <rfin...@google.com>
          Auto-Submit: Hyang-Ah Hana Kim <hya...@gmail.com>
          kokoro-CI: kokoro <noreply...@google.com>
          Files:
          • M extension/CHANGELOG.md
          Change size: S
          Delta: 1 file changed, 38 insertions(+), 1 deletion(-)
          Branch: refs/heads/master
          Submit Requirements:
          • requirement satisfiedCode-Review: +2 by Robert Findley
          • requirement satisfiedkokoro-CI-Passes: kokoro-CI+1 by kokoro
          Open in Gerrit
          Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
          Gerrit-MessageType: merged
          Gerrit-Project: vscode-go
          Gerrit-Branch: master
          Gerrit-Change-Id: Iefb6aaec8688a527f506825f761dc3159761afb3
          Gerrit-Change-Number: 598217
          Gerrit-PatchSet: 6
          Gerrit-Owner: Hyang-Ah Hana Kim <hya...@gmail.com>
          Gerrit-Reviewer: Gopher Robot <go...@golang.org>
          open
          diffy
          satisfied_requirement
          Reply all
          Reply to author
          Forward
          0 new messages