[vscode-go] extension: [1/N] address floating promises in async callers and UI prompts
3 views
Skip to first unread message
Hongxiang Jiang (Gerrit)
Aug 3, 2026, 6:04:23 PM (4 days ago) Aug 3
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Hongxiang Jiang voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention set is empty
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Hongxiang Jiang (Gerrit)
Aug 3, 2026, 6:45:25 PM (4 days ago) Aug 3
to goph...@pubsubhelper.golang.org, golang...@luci-project-accounts.iam.gserviceaccount.com, Madeline Kalil, Gopher Robot, golang-co...@googlegroups.com
Attention needed from Madeline Kalil
Hongxiang Jiang voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Madeline Kalil
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Hongxiang Jiang (Gerrit)
Aug 3, 2026, 7:40:12 PM (4 days ago) Aug 3
to goph...@pubsubhelper.golang.org, golang...@luci-project-accounts.iam.gserviceaccount.com, Madeline Kalil, Gopher Robot, golang-co...@googlegroups.com
Attention needed from Madeline Kalil
Hongxiang Jiang voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Madeline Kalil
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Hongxiang Jiang (Gerrit)
Aug 6, 2026, 3:13:07 PM (yesterday) Aug 6
to goph...@pubsubhelper.golang.org, Peter Weinberger, Madeline Kalil, golang...@luci-project-accounts.iam.gserviceaccount.com, Gopher Robot, golang-co...@googlegroups.com
Attention needed from Madeline Kalil and Peter Weinberger
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Madeline Kalil
- Peter Weinberger
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Hongxiang Jiang (Gerrit)
Aug 6, 2026, 3:13:11 PM (yesterday) Aug 6
to goph...@pubsubhelper.golang.org, Peter Weinberger, Madeline Kalil, golang...@luci-project-accounts.iam.gserviceaccount.com, Gopher Robot, golang-co...@googlegroups.com
Attention needed from Madeline Kalil and Peter Weinberger
Hongxiang Jiang voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Hongxiang Jiang (Gerrit)
Aug 6, 2026, 3:13:46 PM (yesterday) Aug 6
to goph...@pubsubhelper.golang.org, Peter Weinberger, Madeline Kalil, golang...@luci-project-accounts.iam.gserviceaccount.com, Gopher Robot, golang-co...@googlegroups.com
Attention needed from Madeline Kalil and Peter Weinberger
Hongxiang Jiang added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 21 (Latest):
Hongxiang Jiang . resolved
Future changes can incrementally evaluate specific call sites
where converting fire-and-forget calls to awaited operations
is desirable.
Peter Weinberger (Gerrit)
11:08 AM (11 hours ago) 11:08 AM
to Hongxiang Jiang, goph...@pubsubhelper.golang.org, golang...@luci-project-accounts.iam.gserviceaccount.com, Madeline Kalil, Gopher Robot, golang-co...@googlegroups.com
Attention needed from Hongxiang Jiang and Madeline Kalil
Peter Weinberger voted and added 2 comments![]( "Open in Gerrit")
Votes added by Peter Weinberger
| Code-Review | +2 |
2 comments
File extension/src/language/goLanguageServer.ts
Line 313, Patchset 21 (Latest):
void c.stop(2000);Peter Weinberger . unresolved
my typescript expertise is not great: Does this catch(e) catch all the errors, including those from the asynchronous execution? If not, is there some way of adding a catch to the promise?
File extension/test/gopls/survey.test.ts
Line 340, Patchset 21 (Latest):
void testCases.map(async ([testConfig, choice, wantCount], i) => {Peter Weinberger . unresolved
The AI code reviewer knows more typescript than I do, and said: "Using map here returns an array of promises (since the callback is async). While void silences the linter, using forEach is more idiomatic when the return values are ignored and you only care about side effects (like registering tests).
Also, the callback doesn't seem to await anything, so it might not even need to be async."
Related details
Attention is currently required from:
- Hongxiang Jiang
- Madeline Kalil
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Hongxiang Jiang (Gerrit)
5:56 PM (5 hours ago) 5:56 PM
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Attention needed from Hongxiang Jiang and Madeline Kalil
Hongxiang Jiang uploaded new patchset![]( "Open in Gerrit")
Hongxiang Jiang uploaded patch set #23 to this change.
Related details
Attention is currently required from:
- Hongxiang Jiang
- Madeline Kalil
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Hongxiang Jiang (Gerrit)
5:56 PM (5 hours ago) 5:56 PM
to goph...@pubsubhelper.golang.org, Peter Weinberger, golang...@luci-project-accounts.iam.gserviceaccount.com, Madeline Kalil, Gopher Robot, golang-co...@googlegroups.com
Attention needed from Madeline Kalil
Hongxiang Jiang voted and added 1 comment![]( "Open in Gerrit")
Votes added by Hongxiang Jiang
| Auto-Submit | +1 |
| Commit-Queue | +1 |
1 comment
File extension/src/language/goLanguageServer.ts
my typescript expertise is not great: Does this catch(e) catch all the errors, including those from the asynchronous execution? If not, is there some way of adding a catch to the promise?
Attention is currently required from:
- Madeline Kalil
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Hongxiang Jiang (Gerrit)
5:57 PM (5 hours ago) 5:57 PM
to goph...@pubsubhelper.golang.org, Peter Weinberger, golang...@luci-project-accounts.iam.gserviceaccount.com, Madeline Kalil, Gopher Robot, golang-co...@googlegroups.com
Attention needed from Madeline Kalil
Hongxiang Jiang added 1 comment![]( "Open in Gerrit")
File extension/test/gopls/survey.test.ts
Line 340, Patchset 21:
void testCases.map(async ([testConfig, choice, wantCount], i) => {Peter Weinberger . resolved
The AI code reviewer knows more typescript than I do, and said: "Using map here returns an array of promises (since the callback is async). While void silences the linter, using forEach is more idiomatic when the return values are ignored and you only care about side effects (like registering tests).
Also, the callback doesn't seem to await anything, so it might not even need to be async."
Hongxiang Jiang
I will make sure to ask AI review in the future before sending it over to you. sorry for the noise.
Related details
Attention is currently required from:
- Madeline Kalil
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gopher Robot (Gerrit)
6:11 PM (4 hours ago) 6:11 PM
to Hongxiang Jiang, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, golang...@luci-project-accounts.iam.gserviceaccount.com, Peter Weinberger, Madeline Kalil, golang-co...@googlegroups.com
Gopher Robot submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
21 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: extension/src/language/goLanguageServer.ts
Insertions: 2, Deletions: 4.
@@ -74,6 +74,7 @@
InteractiveFormsFeature,
InteractiveMiddleware
} from './form';
+import { GoSemanticTokensFeature } from './goSemanticTokens';
export interface LanguageServerConfig {
serverName: string;
@@ -309,11 +310,9 @@
// LanguageClient.stop may hang if the language server
// crashes during shutdown before responding to the
// shutdown request. Enforce client-side timeout.
- try {
- void c.stop(2000);
- } catch (e) {
+ c.stop(2000).catch((e) => {
c.outputChannel?.appendLine(`Failed to stop client: ${e}`);
- }
+ });
}
export function toServerInfo(res?: InitializeResult): ServerInfo | undefined {
@@ -840,6 +839,7 @@
onDidChangeVulncheckResultEmitter
);
c.registerFeature(new InteractiveFormsFeature(c));
+ c.registerFeature(new GoSemanticTokensFeature());
onDidChangeVulncheckResultEmitter.event(async (e: VulncheckEvent) => {
if (!govulncheckTerminal) {
return;
```
```
The name of the file: extension/test/gopls/survey.test.ts
Insertions: 3, Deletions: 2.
@@ -337,7 +337,8 @@
[{ prompt: true, lastDatePrompted: yesterday }, '', 0]
];
- void testCases.map(async ([testConfig, choice, wantCount], i) => {
+ for (let i = 0; i < testCases.length; i++) {
+ const [testConfig, choice, wantCount] = testCases[i];
test(`opt out: ${i}`, async () => {
const stub = sandbox.stub(vscode.window, 'showInformationMessage').resolves({ title: choice });
const getGoplsOptOutConfigStub = sandbox.stub(goLanguageServer, 'getGoplsOptOutConfig').returns(testConfig);
@@ -356,5 +357,5 @@
`unexpected lastDatePrompted: ${JSON.stringify(got.lastDatePrompted)}`
);
});
- });
+ }
});
```
Change information
Commit message:
extension: enable @typescript-eslint/no-floating-promises rule
Enable the @typescript-eslint/no-floating-promises rule in
eslint.config.mjs and mark unawaited promises with `void`.
Using `void` satisfies the linter without changing existing
runtime behavior.
Change-Id: I5fca8ec53108b8afeffd93bff6add8ff8f24ff40
Auto-Submit: Hongxiang Jiang <hxj...@golang.org>
Reviewed-by: Peter Weinberger <p...@google.com>
LUCI-TryBot-Result: golang...@luci-project-accounts.iam.gserviceaccount.com <golang...@luci-project-accounts.iam.gserviceaccount.com>
Files:
- M extension/eslint.config.js
- M extension/src/commands/applyCoverprofile.ts
- M extension/src/debugAdapter/goDebug.ts
- M extension/src/developerSurvey/prompt.ts
- M extension/src/diagnostics/goBuild.ts
- M extension/src/goCover.ts
- M extension/src/goDebugFactory.ts
- M extension/src/goEnvironmentStatus.ts
- M extension/src/goGenerateTests.ts
- M extension/src/goImpl.ts
- M extension/src/goImport.ts
- M extension/src/goInstallTools.ts
- M extension/src/goMain.ts
- M extension/src/goPackageOutline.ts
- M extension/src/goPackages.ts
- M extension/src/goPlayground.ts
- M extension/src/goSurvey.ts
- M extension/src/goTest.ts
- M extension/src/goTest/explore.ts
- M extension/src/language/goLanguageServer.ts
- M extension/src/language/legacy/goFormat.ts
- M extension/src/stateUtils.ts
- M extension/src/testUtils.ts
- M extension/src/util.ts
- M extension/test/gopls/goplsTestEnv.utils.ts
- M extension/test/gopls/survey.test.ts
- M extension/test/gopls/telemetry.test.ts
- M extension/test/integration/goDebug.test.ts
- M extension/test/integration/goDebugConfiguration.test.ts
- M extension/test/runTest.ts
Change size: M
Delta: 30 files changed, 90 insertions(+), 88 deletions(-)
Branch: refs/heads/master
Submit Requirements:
Code-Review: +2 by Peter Weinberger
TryBots-Pass: LUCI-TryBot-Result+1 by golang...@luci-project-accounts.iam.gserviceaccount.com
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages