[go] all: add go.work to .gitignore

422 views
Skip to first unread message

Hyang-Ah Hana Kim (Gerrit)

unread,
Mar 30, 2022, 7:01:17 PM3/30/22
to goph...@pubsubhelper.golang.org, Hyang-Ah Hana Kim, golang-co...@googlegroups.com

Hyang-Ah Hana Kim has uploaded this change for review.

View Change

all: add go.work to .gitignore

We don't want to check in go.work files.

Change-Id: I7ba16c56ee9635630ab2aa38aa6e0a46bd340b73
---
M .gitignore
1 file changed, 13 insertions(+), 0 deletions(-)

diff --git a/.gitignore b/.gitignore
index aa62a9f..3450d9e 100644
--- a/.gitignore
+++ b/.gitignore
@@ -19,6 +19,8 @@
_test
_testmain.go

+go.work
+
/VERSION.cache
/bin/
/build.out

To view, visit change 396916. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: I7ba16c56ee9635630ab2aa38aa6e0a46bd340b73
Gerrit-Change-Number: 396916
Gerrit-PatchSet: 1
Gerrit-Owner: Hyang-Ah Hana Kim <hya...@gmail.com>
Gerrit-Reviewer: Hyang-Ah Hana Kim <hya...@gmail.com>
Gerrit-MessageType: newchange

Ian Lance Taylor (Gerrit)

unread,
Mar 30, 2022, 7:58:20 PM3/30/22
to Hyang-Ah Hana Kim, goph...@pubsubhelper.golang.org, Ian Lance Taylor, Gopher Robot, golang-co...@googlegroups.com

Attention is currently required from: Hyang-Ah Hana Kim.

View Change

1 comment:

  • Patchset:

    • Patch Set #1:

      Note the comment at the end of the file. Is a go.work file a specific development environment? Of course maybe it's common enough that we should add it anyhow.

To view, visit change 396916. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: I7ba16c56ee9635630ab2aa38aa6e0a46bd340b73
Gerrit-Change-Number: 396916
Gerrit-PatchSet: 1
Gerrit-Owner: Hyang-Ah Hana Kim <hya...@gmail.com>
Gerrit-Reviewer: Gopher Robot <go...@golang.org>
Gerrit-Reviewer: Hyang-Ah Hana Kim <hya...@gmail.com>
Gerrit-CC: Ian Lance Taylor <ia...@golang.org>
Gerrit-Attention: Hyang-Ah Hana Kim <hya...@gmail.com>
Gerrit-Comment-Date: Wed, 30 Mar 2022 23:58:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Hyang-Ah Hana Kim (Gerrit)

unread,
Mar 30, 2022, 8:30:52 PM3/30/22
to Hyang-Ah Hana Kim, goph...@pubsubhelper.golang.org, Ian Lance Taylor, Gopher Robot, golang-co...@googlegroups.com

Attention is currently required from: Ian Lance Taylor.

View Change

1 comment:

  • Patchset:

    • Patch Set #1:

      Note the comment at the end of the file. Is a go. […]

      The Go project contains multiple modules, so the current recommendation when working with any editors that rely on `gopls` is currently to use go.work. Since `go` tools (build/list/...) already have a lot of special handling for the go project itself, another option is to make `gopls` just work even without `go.work` which I think is the best but not I am not sure what it involves to achieve that.

To view, visit change 396916. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: I7ba16c56ee9635630ab2aa38aa6e0a46bd340b73
Gerrit-Change-Number: 396916
Gerrit-PatchSet: 1
Gerrit-Owner: Hyang-Ah Hana Kim <hya...@gmail.com>
Gerrit-Reviewer: Gopher Robot <go...@golang.org>
Gerrit-Reviewer: Hyang-Ah Hana Kim <hya...@gmail.com>
Gerrit-CC: Ian Lance Taylor <ia...@golang.org>
Gerrit-Attention: Ian Lance Taylor <ia...@golang.org>
Gerrit-Comment-Date: Thu, 31 Mar 2022 00:30:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Ian Lance Taylor <ia...@golang.org>
Gerrit-MessageType: comment

Hyang-Ah Hana Kim (Gerrit)

unread,
Jan 30, 2023, 1:04:18 PM1/30/23
to Hyang-Ah Hana Kim, goph...@pubsubhelper.golang.org, Ian Lance Taylor, Gopher Robot, golang-co...@googlegroups.com

Hyang-Ah Hana Kim abandoned this change.

View Change

Abandoned

To view, visit change 396916. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: I7ba16c56ee9635630ab2aa38aa6e0a46bd340b73
Gerrit-Change-Number: 396916
Gerrit-PatchSet: 1
Gerrit-Owner: Hyang-Ah Hana Kim <hya...@gmail.com>
Gerrit-Reviewer: Gopher Robot <go...@golang.org>
Gerrit-Reviewer: Hyang-Ah Hana Kim <hya...@gmail.com>
Gerrit-CC: Ian Lance Taylor <ia...@golang.org>
Gerrit-MessageType: abandon
Reply all
Reply to author
Forward
0 new messages