[go] runtime: switch p.gcFractionalMarkTime to atomic.Int64

6 views
Skip to first unread message

Michael Pratt (Gerrit)

unread,
Oct 30, 2025, 4:36:42 PM (13 days ago) Oct 30
to Michael Pratt, goph...@pubsubhelper.golang.org, Michael Knyszek, golang-co...@googlegroups.com
Attention needed from Michael Knyszek

Michael Pratt voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Michael Knyszek
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: I6a6a636c4c3c366353f6dc8ecac473c075dd5cd9
Gerrit-Change-Number: 716700
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Pratt <mpr...@google.com>
Gerrit-Reviewer: Michael Knyszek <mkny...@google.com>
Gerrit-Reviewer: Michael Pratt <mpr...@google.com>
Gerrit-Attention: Michael Knyszek <mkny...@google.com>
Gerrit-Comment-Date: Thu, 30 Oct 2025 20:36:38 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
unsatisfied_requirement
satisfied_requirement
open
diffy

Michael Knyszek (Gerrit)

unread,
Oct 31, 2025, 10:50:27 AM (13 days ago) Oct 31
to Michael Pratt, goph...@pubsubhelper.golang.org, Go LUCI, golang-co...@googlegroups.com
Attention needed from Michael Pratt

Michael Knyszek voted Code-Review+2

Code-Review+2
Open in Gerrit

Related details

Attention is currently required from:
  • Michael Pratt
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: I6a6a636c4c3c366353f6dc8ecac473c075dd5cd9
Gerrit-Change-Number: 716700
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Pratt <mpr...@google.com>
Gerrit-Reviewer: Michael Knyszek <mkny...@google.com>
Gerrit-Reviewer: Michael Pratt <mpr...@google.com>
Gerrit-Attention: Michael Pratt <mpr...@google.com>
Gerrit-Comment-Date: Fri, 31 Oct 2025 14:50:23 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Michael Pratt (Gerrit)

unread,
Nov 11, 2025, 3:33:30 PM (2 days ago) Nov 11
to Michael Pratt, goph...@pubsubhelper.golang.org, Go LUCI, golang-co...@googlegroups.com

Michael Pratt voted

Auto-Submit+1
Commit-Queue+1
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: I6a6a636c4c3c366353f6dc8ecac473c075dd5cd9
Gerrit-Change-Number: 716700
Gerrit-PatchSet: 7
Gerrit-Owner: Michael Pratt <mpr...@google.com>
Gerrit-Reviewer: Michael Knyszek <mkny...@google.com>
Gerrit-Reviewer: Michael Pratt <mpr...@google.com>
Gerrit-Comment-Date: Tue, 11 Nov 2025 20:33:26 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Michael Pratt (Gerrit)

unread,
Nov 11, 2025, 4:05:12 PM (2 days ago) Nov 11
to Michael Pratt, goph...@pubsubhelper.golang.org, Go LUCI, golang-co...@googlegroups.com

Michael Pratt voted

Auto-Submit+1
Commit-Queue+1
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: I6a6a636c4c3c366353f6dc8ecac473c075dd5cd9
Gerrit-Change-Number: 716700
Gerrit-PatchSet: 8
Gerrit-Owner: Michael Pratt <mpr...@google.com>
Gerrit-Reviewer: Michael Knyszek <mkny...@google.com>
Gerrit-Reviewer: Michael Pratt <mpr...@google.com>
Gerrit-Comment-Date: Tue, 11 Nov 2025 21:05:09 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Michael Pratt (Gerrit)

unread,
Nov 12, 2025, 11:13:09 AM (16 hours ago) Nov 12
to Michael Pratt, goph...@pubsubhelper.golang.org, Go LUCI, golang-co...@googlegroups.com

Michael Pratt voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: I6a6a636c4c3c366353f6dc8ecac473c075dd5cd9
Gerrit-Change-Number: 716700
Gerrit-PatchSet: 8
Gerrit-Owner: Michael Pratt <mpr...@google.com>
Gerrit-Reviewer: Michael Knyszek <mkny...@google.com>
Gerrit-Reviewer: Michael Pratt <mpr...@google.com>
Gerrit-Comment-Date: Wed, 12 Nov 2025 16:13:05 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Gopher Robot (Gerrit)

unread,
Nov 12, 2025, 11:27:04 AM (15 hours ago) Nov 12
to Michael Pratt, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Go LUCI, Michael Knyszek, golang-co...@googlegroups.com

Gopher Robot submitted the change

Unreviewed changes

1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.

Change information

Commit message:
runtime: switch p.gcFractionalMarkTime to atomic.Int64

atomic.Int64 automatically maintains proper alignment, avoiding the need
to manually adjust alignment back and forth as fields above change.
Change-Id: I6a6a636c4c3c366353f6dc8ecac473c075dd5cd9
Reviewed-by: Michael Knyszek <mkny...@google.com>
Auto-Submit: Michael Pratt <mpr...@google.com>
Files:
  • M src/runtime/align_runtime_test.go
  • M src/runtime/mgc.go
  • M src/runtime/mgcpacer.go
  • M src/runtime/runtime2.go
Change size: S
Delta: 4 files changed, 5 insertions(+), 6 deletions(-)
Branch: refs/heads/master
Submit Requirements:
  • requirement satisfiedCode-Review: +2 by Michael Knyszek
  • requirement satisfiedTryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: I6a6a636c4c3c366353f6dc8ecac473c075dd5cd9
Gerrit-Change-Number: 716700
Gerrit-PatchSet: 9
Gerrit-Owner: Michael Pratt <mpr...@google.com>
Gerrit-Reviewer: Gopher Robot <go...@golang.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages