[go] cmd/dist: preserve existing GOEXPERIMENTs when running tests with additional experiments

0 views
Skip to first unread message

Quim Muntal (Gerrit)

unread,
5:11 AM (9 hours ago) 5:11 AM
to goph...@pubsubhelper.golang.org, Cherry Mui, David Chase, golang-co...@googlegroups.com
Attention needed from Cherry Mui and David Chase

Quim Muntal voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Cherry Mui
  • David Chase
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: Ib0324cd93282f6993611dea2f0c57d00ab304a33
Gerrit-Change-Number: 730360
Gerrit-PatchSet: 1
Gerrit-Owner: Quim Muntal <quimm...@gmail.com>
Gerrit-Reviewer: Cherry Mui <cher...@google.com>
Gerrit-Reviewer: David Chase <drc...@google.com>
Gerrit-Reviewer: Quim Muntal <quimm...@gmail.com>
Gerrit-Attention: Cherry Mui <cher...@google.com>
Gerrit-Attention: David Chase <drc...@google.com>
Gerrit-Comment-Date: Tue, 16 Dec 2025 10:11:42 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
unsatisfied_requirement
satisfied_requirement
open
diffy

Cherry Mui (Gerrit)

unread,
10:28 AM (4 hours ago) 10:28 AM
to Quim Muntal, goph...@pubsubhelper.golang.org, Go LUCI, David Chase, golang-co...@googlegroups.com
Attention needed from David Chase and Quim Muntal

Cherry Mui voted and added 2 comments

Votes added by Cherry Mui

Code-Review+1

2 comments

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Cherry Mui . resolved

This CL looks fine. But I'm wondering what the purpose is. Is this for doing something or handling some failures on Go's CI, or your CI, or for running all.bash with GOEXPERIMENT manually set?

Thanks.

File src/cmd/dist/test.go
Line 1900, Patchset 1 (Latest): goexperiment := goexperiment // don't override existing GOEXPERIMENTs
Cherry Mui . unresolved

It is probably clearer just using a different name.

Open in Gerrit

Related details

Attention is currently required from:
  • David Chase
  • Quim Muntal
Submit Requirements:
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    • requirement satisfiedTryBots-Pass
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: go
    Gerrit-Branch: master
    Gerrit-Change-Id: Ib0324cd93282f6993611dea2f0c57d00ab304a33
    Gerrit-Change-Number: 730360
    Gerrit-PatchSet: 1
    Gerrit-Owner: Quim Muntal <quimm...@gmail.com>
    Gerrit-Reviewer: Cherry Mui <cher...@google.com>
    Gerrit-Reviewer: David Chase <drc...@google.com>
    Gerrit-Reviewer: Quim Muntal <quimm...@gmail.com>
    Gerrit-Attention: Quim Muntal <quimm...@gmail.com>
    Gerrit-Attention: David Chase <drc...@google.com>
    Gerrit-Comment-Date: Tue, 16 Dec 2025 15:28:24 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    unsatisfied_requirement
    satisfied_requirement
    open
    diffy

    Quim Muntal (Gerrit)

    unread,
    10:29 AM (4 hours ago) 10:29 AM
    to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
    Attention needed from David Chase and Quim Muntal

    Quim Muntal uploaded new patchset

    Quim Muntal uploaded patch set #2 to this change.
    Following approvals got outdated and were removed:
    • TryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
    Open in Gerrit

    Related details

    Attention is currently required from:
    • David Chase
    • Quim Muntal
    Submit Requirements:
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedNo-Unresolved-Comments
      • requirement is not satisfiedReview-Enforcement
      • requirement is not satisfiedTryBots-Pass
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: newpatchset
      Gerrit-Project: go
      Gerrit-Branch: master
      Gerrit-Change-Id: Ib0324cd93282f6993611dea2f0c57d00ab304a33
      Gerrit-Change-Number: 730360
      Gerrit-PatchSet: 2
      unsatisfied_requirement
      open
      diffy

      Quim Muntal (Gerrit)

      unread,
      10:32 AM (4 hours ago) 10:32 AM
      to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
      Attention needed from David Chase and Quim Muntal

      Quim Muntal uploaded new patchset

      Quim Muntal uploaded patch set #3 to this change.
      Open in Gerrit

      Related details

      Attention is currently required from:
      • David Chase
      • Quim Muntal
      Submit Requirements:
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedNo-Unresolved-Comments
      • requirement is not satisfiedReview-Enforcement
      • requirement is not satisfiedTryBots-Pass
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: newpatchset
      Gerrit-Project: go
      Gerrit-Branch: master
      Gerrit-Change-Id: Ib0324cd93282f6993611dea2f0c57d00ab304a33
      Gerrit-Change-Number: 730360
      Gerrit-PatchSet: 3
      unsatisfied_requirement
      open
      diffy

      Quim Muntal (Gerrit)

      unread,
      10:33 AM (4 hours ago) 10:33 AM
      to goph...@pubsubhelper.golang.org, Cherry Mui, Go LUCI, David Chase, golang-co...@googlegroups.com
      Attention needed from Cherry Mui and David Chase

      Quim Muntal voted and added 2 comments

      Votes added by Quim Muntal

      Commit-Queue+1

      2 comments

      Patchset-level comments
      Cherry Mui . resolved

      This CL looks fine. But I'm wondering what the purpose is. Is this for doing something or handling some failures on Go's CI, or your CI, or for running all.bash with GOEXPERIMENT manually set?

      Thanks.

      Quim Muntal

      I've updated the CL description with some additional context. Thanks for the quick review!

      File src/cmd/dist/test.go
      Line 1900, Patchset 1: goexperiment := goexperiment // don't override existing GOEXPERIMENTs
      Cherry Mui . resolved

      It is probably clearer just using a different name.

      Quim Muntal

      Done

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Cherry Mui
      • David Chase
      Submit Requirements:
        • requirement is not satisfiedCode-Review
        • requirement satisfiedNo-Unresolved-Comments
        • requirement is not satisfiedReview-Enforcement
        • requirement is not satisfiedTryBots-Pass
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: go
        Gerrit-Branch: master
        Gerrit-Change-Id: Ib0324cd93282f6993611dea2f0c57d00ab304a33
        Gerrit-Change-Number: 730360
        Gerrit-PatchSet: 3
        Gerrit-Owner: Quim Muntal <quimm...@gmail.com>
        Gerrit-Reviewer: Cherry Mui <cher...@google.com>
        Gerrit-Reviewer: David Chase <drc...@google.com>
        Gerrit-Reviewer: Quim Muntal <quimm...@gmail.com>
        Gerrit-Attention: Cherry Mui <cher...@google.com>
        Gerrit-Attention: David Chase <drc...@google.com>
        Gerrit-Comment-Date: Tue, 16 Dec 2025 15:33:09 +0000
        Gerrit-HasComments: Yes
        Gerrit-Has-Labels: Yes
        Comment-In-Reply-To: Cherry Mui <cher...@google.com>
        unsatisfied_requirement
        satisfied_requirement
        open
        diffy

        Cherry Mui (Gerrit)

        unread,
        10:40 AM (4 hours ago) 10:40 AM
        to Quim Muntal, goph...@pubsubhelper.golang.org, Go LUCI, David Chase, golang-co...@googlegroups.com
        Attention needed from David Chase and Quim Muntal

        Cherry Mui voted Code-Review+2

        Code-Review+2
        Open in Gerrit

        Related details

        Attention is currently required from:
        • David Chase
        • Quim Muntal
        Submit Requirements:
        • requirement satisfiedCode-Review
        • requirement satisfiedNo-Unresolved-Comments
        • requirement is not satisfiedReview-Enforcement
        • requirement is not satisfiedTryBots-Pass
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: go
        Gerrit-Branch: master
        Gerrit-Change-Id: Ib0324cd93282f6993611dea2f0c57d00ab304a33
        Gerrit-Change-Number: 730360
        Gerrit-PatchSet: 3
        Gerrit-Owner: Quim Muntal <quimm...@gmail.com>
        Gerrit-Reviewer: Cherry Mui <cher...@google.com>
        Gerrit-Reviewer: David Chase <drc...@google.com>
        Gerrit-Reviewer: Quim Muntal <quimm...@gmail.com>
        Gerrit-Attention: Quim Muntal <quimm...@gmail.com>
        Gerrit-Attention: David Chase <drc...@google.com>
        Gerrit-Comment-Date: Tue, 16 Dec 2025 15:40:42 +0000
        Gerrit-HasComments: No
        Gerrit-Has-Labels: Yes
        satisfied_requirement
        unsatisfied_requirement
        open
        diffy

        Michael Knyszek (Gerrit)

        unread,
        11:16 AM (3 hours ago) 11:16 AM
        to Quim Muntal, goph...@pubsubhelper.golang.org, Go LUCI, Cherry Mui, David Chase, golang-co...@googlegroups.com
        Attention needed from David Chase and Quim Muntal

        Michael Knyszek voted Code-Review+1

        Code-Review+1
        Open in Gerrit

        Related details

        Attention is currently required from:
        • David Chase
        • Quim Muntal
        Submit Requirements:
          • requirement satisfiedCode-Review
          • requirement satisfiedNo-Unresolved-Comments
          • requirement satisfiedReview-Enforcement
          • requirement satisfiedTryBots-Pass
          Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
          Gerrit-MessageType: comment
          Gerrit-Project: go
          Gerrit-Branch: master
          Gerrit-Change-Id: Ib0324cd93282f6993611dea2f0c57d00ab304a33
          Gerrit-Change-Number: 730360
          Gerrit-PatchSet: 3
          Gerrit-Owner: Quim Muntal <quimm...@gmail.com>
          Gerrit-Reviewer: Cherry Mui <cher...@google.com>
          Gerrit-Reviewer: David Chase <drc...@google.com>
          Gerrit-Reviewer: Michael Knyszek <mkny...@google.com>
          Gerrit-Reviewer: Quim Muntal <quimm...@gmail.com>
          Gerrit-Attention: Quim Muntal <quimm...@gmail.com>
          Gerrit-Attention: David Chase <drc...@google.com>
          Gerrit-Comment-Date: Tue, 16 Dec 2025 16:16:55 +0000
          Gerrit-HasComments: No
          Gerrit-Has-Labels: Yes
          satisfied_requirement
          open
          diffy

          Quim Muntal (Gerrit)

          unread,
          11:17 AM (3 hours ago) 11:17 AM
          to goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Michael Knyszek, Go LUCI, Cherry Mui, David Chase, golang-co...@googlegroups.com

          Quim Muntal submitted the change

          Change information

          Commit message:
          cmd/dist: preserve existing GOEXPERIMENTs when running tests with additional experiments

          Some tests require enabling specific Go experiments via the GOEXPERIMENT
          , like "jsonv2", "runtimesecret", or "simd".

          When running these tests, we should preserve any existing GOEXPERIMENT
          settings, so that multiple experiments can be tested together.

          I've found this limitation while working in my own Go fork, where in
          some situations I pass additional experiments to the tests that alter
          the Go runtime and other core packages.
          Change-Id: Ib0324cd93282f6993611dea2f0c57d00ab304a33
          Reviewed-by: Cherry Mui <cher...@google.com>
          Reviewed-by: Michael Knyszek <mkny...@google.com>
          Files:
          • M src/cmd/dist/test.go
          Change size: S
          Delta: 1 file changed, 19 insertions(+), 3 deletions(-)
          Branch: refs/heads/master
          Submit Requirements:
          • requirement satisfiedCode-Review: +2 by Cherry Mui, +1 by Michael Knyszek
          • requirement satisfiedTryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
          Open in Gerrit
          Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
          Gerrit-MessageType: merged
          Gerrit-Project: go
          Gerrit-Branch: master
          Gerrit-Change-Id: Ib0324cd93282f6993611dea2f0c57d00ab304a33
          Gerrit-Change-Number: 730360
          Gerrit-PatchSet: 4
          open
          diffy
          satisfied_requirement
          Reply all
          Reply to author
          Forward
          0 new messages