[go] net/netip: remove incorrect comment in Prefix.AppendTo
1 view
Skip to first unread message
Tobias Klauser (Gerrit)
4:44 AM (3 hours ago) 4:44 AM
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Tobias Klauser has uploaded the change for review![]( "Open in Gerrit")
Commit message
net/netip: remove incorrect comment in Prefix.AppendTo
p.ip is a value type and cannot ever by nil.
Change-Id: I28d54ff1f70d0965fe42cb9f02a7359efd9c9740
Change diff
diff --git a/src/net/netip/netip.go b/src/net/netip/netip.go
index 5a78820..75042bf 100644
--- a/src/net/netip/netip.go
+++ b/src/net/netip/netip.go
@@ -1490,7 +1490,6 @@
return append(b, "invalid Prefix"...)
}
- // p.ip is non-nil, because p is valid.
if p.ip.z == z4 {
b = p.ip.appendTo4(b)
} else {
Change information
Files:
- M src/net/netip/netip.go
Change size: XS
Delta: 1 file changed, 0 insertions(+), 1 deletion(-)
Related details
Attention set is empty
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Florian Lehner (Gerrit)
7:37 AM (1 hour ago) 7:37 AM
to Tobias Klauser, goph...@pubsubhelper.golang.org, golang...@luci-project-accounts.iam.gserviceaccount.com, Damien Neil, Nicholas Husin, Ian Lance Taylor, Gopher Robot, golang-co...@googlegroups.com
Attention needed from Damien Neil, Ian Lance Taylor, Nicholas Husin and Tobias Klauser
Florian Lehner voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Damien Neil
- Ian Lance Taylor
- Nicholas Husin
- Tobias Klauser
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages