[tools] gopls/internal/telemetry: skip the telemetry test on Plan 9
3 views
Skip to first unread message
David du Colombier (Gerrit)
Jun 26, 2026, 2:08:00 PM (17 hours ago) Jun 26
to Hyang-Ah Hana Kim, Richard Miller, Robert Findley, goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Attention needed from Hyang-Ah Hana Kim, Richard Miller and Robert Findley
David du Colombier has uploaded the change for review![]( "Open in Gerrit")
David du Colombier would like Hyang-Ah Hana Kim, Richard Miller and Robert Findley to review this change.
Commit message
gopls/internal/telemetry: skip the telemetry test on Plan 9
The telemetry test relies on the counters from
golang.org/x/telemetry, which are stored in
memory-mapped files.
Plan 9 does not support mmap, so the counters are
never persisted and always read back as zero, like
on js/wasm and wasip1, which are already excluded.
Add plan9 to the build constraint.
Change-Id: I356f9d0115ace200de8c4ffa3a192ca18babeaba
Change diff
diff --git a/gopls/internal/telemetry/telemetry_test.go b/gopls/internal/telemetry/telemetry_test.go
index a8cf2b8..a5e7c6f 100644
--- a/gopls/internal/telemetry/telemetry_test.go
+++ b/gopls/internal/telemetry/telemetry_test.go
@@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style
// license that can be found in the LICENSE file.
-//go:build !openbsd && !js && !wasip1 && !solaris && !android && !386
+//go:build !openbsd && !js && !wasip1 && !solaris && !android && !386 && !plan9
package telemetry_test
Change information
Files:
- M gopls/internal/telemetry/telemetry_test.go
Change size: XS
Delta: 1 file changed, 1 insertion(+), 1 deletion(-)
Related details
Attention is currently required from:
- Hyang-Ah Hana Kim
- Richard Miller
- Robert Findley
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Richard Miller (Gerrit)
Jun 26, 2026, 2:44:56 PM (16 hours ago) Jun 26
to David du Colombier, goph...@pubsubhelper.golang.org, Hyang-Ah Hana Kim, Robert Findley, golang-co...@googlegroups.com
Attention needed from David du Colombier, Hyang-Ah Hana Kim and Robert Findley
Richard Miller voted Code-Review+2![]( "Open in Gerrit")
Attention is currently required from:
- David du Colombier
- Hyang-Ah Hana Kim
- Robert Findley
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Richard Miller (Gerrit)
Jun 26, 2026, 2:45:20 PM (16 hours ago) Jun 26
to David du Colombier, goph...@pubsubhelper.golang.org, Hyang-Ah Hana Kim, Robert Findley, golang-co...@googlegroups.com
Attention needed from David du Colombier, Hyang-Ah Hana Kim and Robert Findley
Richard Miller added 1 comment![]( "Open in Gerrit")
Patchset-level comments
David du Colombier (Gerrit)
Jun 26, 2026, 3:27:02 PM (15 hours ago) Jun 26
to goph...@pubsubhelper.golang.org, Richard Miller, Hyang-Ah Hana Kim, Robert Findley, golang-co...@googlegroups.com
Attention needed from Hyang-Ah Hana Kim and Robert Findley
David du Colombier voted Commit-Queue+1![]( "Open in Gerrit")
Attention is currently required from:
- Hyang-Ah Hana Kim
- Robert Findley
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
David du Colombier (Gerrit)
Jun 26, 2026, 4:19:29 PM (15 hours ago) Jun 26
to goph...@pubsubhelper.golang.org, golang...@luci-project-accounts.iam.gserviceaccount.com, Richard Miller, Hyang-Ah Hana Kim, Robert Findley, golang-co...@googlegroups.com
Attention needed from Hyang-Ah Hana Kim and Robert Findley
David du Colombier voted Auto-Submit+1![]( "Open in Gerrit")
| Auto-Submit | +1 |
Related details
Attention is currently required from:
- Hyang-Ah Hana Kim
- Robert Findley
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dmitri Shuralyov (Gerrit)
Jun 26, 2026, 7:58:07 PM (11 hours ago) Jun 26
to David du Colombier, goph...@pubsubhelper.golang.org, Dmitri Shuralyov, golang...@luci-project-accounts.iam.gserviceaccount.com, Richard Miller, Hyang-Ah Hana Kim, Robert Findley, golang-co...@googlegroups.com
Attention needed from Hyang-Ah Hana Kim
Dmitri Shuralyov voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Hyang-Ah Hana Kim
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Hyang-Ah Hana Kim (Gerrit)
Jun 26, 2026, 8:48:19 PM (10 hours ago) Jun 26
to David du Colombier, goph...@pubsubhelper.golang.org, Hyang-Ah Hana Kim, Dmitri Shuralyov, Dmitri Shuralyov, golang...@luci-project-accounts.iam.gserviceaccount.com, Richard Miller, Robert Findley, golang-co...@googlegroups.com
Attention needed from David du Colombier
Hyang-Ah Hana Kim voted Code-Review+2![]( "Open in Gerrit")
Attention is currently required from:
- David du Colombier
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gopher Robot (Gerrit)
Jun 26, 2026, 8:50:33 PM (10 hours ago) Jun 26
to David du Colombier, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Hyang-Ah Hana Kim, Dmitri Shuralyov, Dmitri Shuralyov, golang...@luci-project-accounts.iam.gserviceaccount.com, Richard Miller, Robert Findley, golang-co...@googlegroups.com
Gopher Robot submitted the change![]( "Open in Gerrit")
Change information
Commit message:
gopls/internal/telemetry: skip the telemetry test on Plan 9
The telemetry test relies on the counters from
golang.org/x/telemetry, which are stored in
memory-mapped files.
Plan 9 does not support mmap, so the counters are
never persisted and always read back as zero, like
on js/wasm and wasip1, which are already excluded.
Add plan9 to the build constraint.
Change-Id: I356f9d0115ace200de8c4ffa3a192ca18babeaba
Reviewed-on: https://go-review.googlesource.com/c/tools/+/794821
Reviewed-by: Dmitri Shuralyov <dmit...@google.com>
LUCI-TryBot-Result: golang...@luci-project-accounts.iam.gserviceaccount.com <golang...@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: David du Colombier <0in...@gmail.com>
Reviewed-by: Hyang-Ah Hana Kim <hya...@gmail.com>
Reviewed-by: Richard Miller <millerr...@gmail.com>
Files:
- M gopls/internal/telemetry/telemetry_test.go
Change size: XS
Delta: 1 file changed, 1 insertion(+), 1 deletion(-)
Branch: refs/heads/master
Submit Requirements:
Code-Review: +1 by Dmitri Shuralyov, +2 by Richard Miller, +2 by Hyang-Ah Hana Kim
TryBots-Pass: LUCI-TryBot-Result+1 by golang...@luci-project-accounts.iam.gserviceaccount.com
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages