[go] net: correctly handle non-nil empty cmsg buffer on windows

6 views
Skip to first unread message

Ian Chen (Gerrit)

unread,
Mar 1, 2026, 11:49:09 AMMar 1
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com

Ian Chen has uploaded the change for review

Commit message

net: correctly handle non-nil empty cmsg buffer on windows

Fixes #77875.
Change-Id: I0ed91be7ed10c04ddea3af55548a8dbf0be5f3a8

Change diff

diff --git a/src/internal/poll/fd_windows.go b/src/internal/poll/fd_windows.go
index 6875557..4fa912d 100644
--- a/src/internal/poll/fd_windows.go
+++ b/src/internal/poll/fd_windows.go
@@ -167,9 +167,11 @@
 	msg := wsaMsgPool.Get().(*windows.WSAMsg)
 	msg.Buffers.Len = uint32(len(p))
 	msg.Buffers.Buf = unsafe.SliceData(p)
-	msg.Control = syscall.WSABuf{
-		Len: uint32(len(oob)),
-		Buf: unsafe.SliceData(oob),
+	if len(oob) > 0 {
+		msg.Control = syscall.WSABuf{
+			Len: uint32(len(oob)),
+			Buf: unsafe.SliceData(oob),
+		}
 	}
 	msg.Flags = uint32(flags)
 	if unconnected {
diff --git a/src/net/udpsock_test.go b/src/net/udpsock_test.go
index a79e9f8..1700eba 100644
--- a/src/net/udpsock_test.go
+++ b/src/net/udpsock_test.go
@@ -750,3 +750,45 @@
 		t.Errorf("conn.WriteMsgUDPAddrPort(buf, nil, daddr6) should have failed, but got no error")
 	}
 }
+
+// TestReadWriteMsgUDPAddrPortEmptyCmsg verifies that ReadMsgUDPAddrPort and
+// WriteMsgUDPAddrPort won't fail when the cmsg buffer (the oob parameter) is
+// non-nil but empty.
+//
+// This is a regression test for https://golang.org/issue/77875.
+func TestReadWriteMsgUDPAddrPortEmptyCmsg(t *testing.T) {
+	switch runtime.GOOS {
+	case "plan9":
+		t.Skipf("not supported on %s", runtime.GOOS)
+	}
+
+	if !testableNetwork("udp4") {
+		t.Skipf("skipping: udp4 not available")
+	}
+
+	conn, err := ListenUDP("udp4", &UDPAddr{IP: IPv4(127, 0, 0, 1)})
+	if err != nil {
+		t.Fatal(err)
+	}
+	defer conn.Close()
+
+	buf := make([]byte, 8)
+	cmsgBuf := make([]byte, 8)[:0]
+	daddr := conn.LocalAddr().(*UDPAddr).AddrPort()
+
+	_, cmsgn, err := conn.WriteMsgUDPAddrPort(buf, cmsgBuf, daddr)
+	if err != nil {
+		t.Fatalf("WriteMsgUDPAddrPort failed: %v", err)
+	}
+	if cmsgn != 0 {
+		t.Errorf("WriteMsgUDPAddrPort wrote %d cmsg bytes; want 0", cmsgn)
+	}
+
+	_, cmsgn, _, _, err = conn.ReadMsgUDPAddrPort(buf, cmsgBuf)
+	if err != nil {
+		t.Fatalf("ReadMsgUDPAddrPort failed: %v", err)
+	}
+	if cmsgn != 0 {
+		t.Errorf("ReadMsgUDPAddrPort read %d cmsg bytes; want 0", cmsgn)
+	}
+}

Change information

Files:
  • M src/internal/poll/fd_windows.go
  • M src/net/udpsock_test.go
Change size: M
Delta: 2 files changed, 47 insertions(+), 3 deletions(-)
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: I0ed91be7ed10c04ddea3af55548a8dbf0be5f3a8
Gerrit-Change-Number: 750420
Gerrit-PatchSet: 1
Gerrit-Owner: Ian Chen <databa...@gmail.com>
unsatisfied_requirement
satisfied_requirement
open
diffy

Quim Muntal (Gerrit)

unread,
Mar 1, 2026, 12:44:42 PMMar 1
to Ian Chen, goph...@pubsubhelper.golang.org, Ian Lance Taylor, Michael Pratt, Damien Neil, Gopher Robot, golang-co...@googlegroups.com
Attention needed from Damien Neil, Ian Chen, Ian Lance Taylor and Michael Pratt

Quim Muntal voted and added 1 comment

Votes added by Quim Muntal

Code-Review+1
Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Quim Muntal . resolved

Thanks!

Open in Gerrit

Related details

Attention is currently required from:
  • Damien Neil
  • Ian Chen
  • Ian Lance Taylor
  • Michael Pratt
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: I0ed91be7ed10c04ddea3af55548a8dbf0be5f3a8
Gerrit-Change-Number: 750420
Gerrit-PatchSet: 1
Gerrit-Owner: Ian Chen <databa...@gmail.com>
Gerrit-Reviewer: Damien Neil <dn...@google.com>
Gerrit-Reviewer: Ian Lance Taylor <ia...@golang.org>
Gerrit-Reviewer: Michael Pratt <mpr...@google.com>
Gerrit-Reviewer: Quim Muntal <quimm...@gmail.com>
Gerrit-CC: Gopher Robot <go...@golang.org>
Gerrit-Attention: Ian Chen <databa...@gmail.com>
Gerrit-Attention: Ian Lance Taylor <ia...@golang.org>
Gerrit-Attention: Michael Pratt <mpr...@google.com>
Gerrit-Attention: Damien Neil <dn...@google.com>
Gerrit-Comment-Date: Sun, 01 Mar 2026 17:44:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
unsatisfied_requirement
satisfied_requirement
open
diffy

Quim Muntal (Gerrit)

unread,
Mar 1, 2026, 2:46:08 PMMar 1
to Ian Chen, goph...@pubsubhelper.golang.org, Go LUCI, Ian Lance Taylor, Michael Pratt, Damien Neil, Gopher Robot, golang-co...@googlegroups.com
Attention needed from Damien Neil, Ian Chen, Ian Lance Taylor and Michael Pratt

Quim Muntal voted Code-Review+2

Code-Review+2
Open in Gerrit

Related details

Attention is currently required from:
  • Damien Neil
  • Ian Chen
  • Ian Lance Taylor
  • Michael Pratt
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: I0ed91be7ed10c04ddea3af55548a8dbf0be5f3a8
Gerrit-Change-Number: 750420
Gerrit-PatchSet: 1
Gerrit-Owner: Ian Chen <databa...@gmail.com>
Gerrit-Reviewer: Damien Neil <dn...@google.com>
Gerrit-Reviewer: Ian Lance Taylor <ia...@golang.org>
Gerrit-Reviewer: Michael Pratt <mpr...@google.com>
Gerrit-Reviewer: Quim Muntal <quimm...@gmail.com>
Gerrit-CC: Gopher Robot <go...@golang.org>
Gerrit-Attention: Ian Chen <databa...@gmail.com>
Gerrit-Attention: Ian Lance Taylor <ia...@golang.org>
Gerrit-Attention: Michael Pratt <mpr...@google.com>
Gerrit-Attention: Damien Neil <dn...@google.com>
Gerrit-Comment-Date: Sun, 01 Mar 2026 19:46:01 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

David Chase (Gerrit)

unread,
Mar 1, 2026, 11:57:10 PMMar 1
to Ian Chen, goph...@pubsubhelper.golang.org, Go LUCI, Quim Muntal, Ian Lance Taylor, Michael Pratt, Damien Neil, Gopher Robot, golang-co...@googlegroups.com
Attention needed from Damien Neil, Ian Chen, Ian Lance Taylor and Michael Pratt

David Chase voted Code-Review+2

Code-Review+2
Open in Gerrit

Related details

Attention is currently required from:
  • Damien Neil
  • Ian Chen
  • Ian Lance Taylor
  • Michael Pratt
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: I0ed91be7ed10c04ddea3af55548a8dbf0be5f3a8
Gerrit-Change-Number: 750420
Gerrit-PatchSet: 1
Gerrit-Owner: Ian Chen <databa...@gmail.com>
Gerrit-Reviewer: Damien Neil <dn...@google.com>
Gerrit-Reviewer: David Chase <drc...@google.com>
Gerrit-Reviewer: Ian Lance Taylor <ia...@golang.org>
Gerrit-Reviewer: Michael Pratt <mpr...@google.com>
Gerrit-Reviewer: Quim Muntal <quimm...@gmail.com>
Gerrit-CC: Gopher Robot <go...@golang.org>
Gerrit-Attention: Ian Chen <databa...@gmail.com>
Gerrit-Attention: Ian Lance Taylor <ia...@golang.org>
Gerrit-Attention: Michael Pratt <mpr...@google.com>
Gerrit-Attention: Damien Neil <dn...@google.com>
Gerrit-Comment-Date: Mon, 02 Mar 2026 04:57:06 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Damien Neil (Gerrit)

unread,
Mar 2, 2026, 12:56:43 PMMar 2
to Ian Chen, goph...@pubsubhelper.golang.org, David Chase, Go LUCI, Quim Muntal, Ian Lance Taylor, Michael Pratt, Gopher Robot, golang-co...@googlegroups.com
Attention needed from Ian Chen, Ian Lance Taylor and Michael Pratt

Damien Neil voted Code-Review+2

Code-Review+2
Open in Gerrit

Related details

Attention is currently required from:
  • Ian Chen
  • Ian Lance Taylor
  • Michael Pratt
Submit Requirements:
    • requirement satisfiedCode-Review
    • requirement satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    • requirement satisfiedTryBots-Pass
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: go
    Gerrit-Branch: master
    Gerrit-Change-Id: I0ed91be7ed10c04ddea3af55548a8dbf0be5f3a8
    Gerrit-Change-Number: 750420
    Gerrit-PatchSet: 1
    Gerrit-Owner: Ian Chen <databa...@gmail.com>
    Gerrit-Reviewer: Damien Neil <dn...@google.com>
    Gerrit-Reviewer: David Chase <drc...@google.com>
    Gerrit-Reviewer: Ian Lance Taylor <ia...@golang.org>
    Gerrit-Reviewer: Michael Pratt <mpr...@google.com>
    Gerrit-Reviewer: Quim Muntal <quimm...@gmail.com>
    Gerrit-CC: Gopher Robot <go...@golang.org>
    Gerrit-Attention: Ian Chen <databa...@gmail.com>
    Gerrit-Attention: Ian Lance Taylor <ia...@golang.org>
    Gerrit-Attention: Michael Pratt <mpr...@google.com>
    Gerrit-Comment-Date: Mon, 02 Mar 2026 17:56:40 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Ian Chen (Gerrit)

    unread,
    Mar 9, 2026, 5:19:16 AM (11 days ago) Mar 9
    to goph...@pubsubhelper.golang.org, Damien Neil, David Chase, Go LUCI, Quim Muntal, Ian Lance Taylor, Michael Pratt, Gopher Robot, golang-co...@googlegroups.com
    Attention needed from Ian Lance Taylor and Michael Pratt

    Ian Chen added 1 comment

    Patchset-level comments
    Ian Chen . resolved

    Can someone please submit this CL or put a Auto-Submit on it? I have no permission to submit changes. Thanks.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Ian Lance Taylor
    • Michael Pratt
    Submit Requirements:
    • requirement satisfiedCode-Review
    • requirement satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    • requirement satisfiedTryBots-Pass
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: go
    Gerrit-Branch: master
    Gerrit-Change-Id: I0ed91be7ed10c04ddea3af55548a8dbf0be5f3a8
    Gerrit-Change-Number: 750420
    Gerrit-PatchSet: 1
    Gerrit-Owner: Ian Chen <databa...@gmail.com>
    Gerrit-Reviewer: Damien Neil <dn...@google.com>
    Gerrit-Reviewer: David Chase <drc...@google.com>
    Gerrit-Reviewer: Ian Lance Taylor <ia...@golang.org>
    Gerrit-Reviewer: Michael Pratt <mpr...@google.com>
    Gerrit-Reviewer: Quim Muntal <quimm...@gmail.com>
    Gerrit-CC: Gopher Robot <go...@golang.org>
    Gerrit-Attention: Ian Lance Taylor <ia...@golang.org>
    Gerrit-Attention: Michael Pratt <mpr...@google.com>
    Gerrit-Comment-Date: Mon, 09 Mar 2026 09:19:11 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    open
    diffy

    Quim Muntal (Gerrit)

    unread,
    Mar 9, 2026, 5:24:17 AM (11 days ago) Mar 9
    to Ian Chen, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Damien Neil, David Chase, Go LUCI, Ian Lance Taylor, Michael Pratt, Gopher Robot, golang-co...@googlegroups.com

    Quim Muntal submitted the change

    Change information

    Commit message:
    net: correctly handle non-nil empty cmsg buffer on windows

    Fixes #77875.
    Change-Id: I0ed91be7ed10c04ddea3af55548a8dbf0be5f3a8
    Reviewed-by: Quim Muntal <quimm...@gmail.com>
    Reviewed-by: Damien Neil <dn...@google.com>
    Reviewed-by: David Chase <drc...@google.com>
    Files:
    • M src/internal/poll/fd_windows.go
    • M src/net/udpsock_test.go
    Change size: M
    Delta: 2 files changed, 47 insertions(+), 3 deletions(-)
    Branch: refs/heads/master
    Submit Requirements:
    • requirement satisfiedCode-Review: +2 by David Chase, +2 by Damien Neil, +2 by Quim Muntal
    • requirement satisfiedTryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: go
    Gerrit-Branch: master
    Gerrit-Change-Id: I0ed91be7ed10c04ddea3af55548a8dbf0be5f3a8
    Gerrit-Change-Number: 750420
    Gerrit-PatchSet: 2
    open
    diffy
    satisfied_requirement

    Quim Muntal (Gerrit)

    unread,
    Mar 9, 2026, 5:24:59 AM (11 days ago) Mar 9
    to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com

    Quim Muntal has uploaded the change for review

    Commit message

    [release-branch.go1.26] net: correctly handle non-nil empty cmsg buffer on windows

    Updates #77875
    Fixes #77885


    Change-Id: I0ed91be7ed10c04ddea3af55548a8dbf0be5f3a8
    Reviewed-on: https://go-review.googlesource.com/c/go/+/750420
    Reviewed-by: Quim Muntal <quimm...@gmail.com>
    Reviewed-by: Damien Neil <dn...@google.com>
    Reviewed-by: David Chase <drc...@google.com>
    LUCI-TryBot-Result: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>
    (cherry picked from commit 9e0b5684e1f7166d6427635673001c80218ac9f4)

    Change diff

    diff --git a/src/internal/poll/fd_windows.go b/src/internal/poll/fd_windows.go
    index edad656..2ba967f9 100644
    --- a/src/internal/poll/fd_windows.go
    +++ b/src/internal/poll/fd_windows.go
    @@ -159,9 +159,11 @@
    Change information
    Files:
    • M src/internal/poll/fd_windows.go
    • M src/net/udpsock_test.go
    Change size: M
    Delta: 2 files changed, 47 insertions(+), 3 deletions(-)
     Open in Gerrit
    Related details
    Attention set is empty
    Submit Requirements:
    • requirement is not satisfiedCode-Review
    • requirement satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    • requirement is not satisfiedTryBots-Pass
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    


     Gerrit-MessageType: newchange 
    

     Gerrit-Project: go 
    

     Gerrit-Branch: release-branch.go1.26 
    

     Gerrit-Change-Id: I0ed91be7ed10c04ddea3af55548a8dbf0be5f3a8 
    

     Gerrit-Change-Number: 753060 
    

     Gerrit-PatchSet: 1 
    

     Gerrit-Owner: Quim Muntal <quimm...@gmail.com> 
    


    unsatisfied_requirement
    satisfied_requirement
    open
    diffy
    Quim Muntal (Gerrit)
    unread,
    Mar 9, 2026, 5:25:29 AM (11 days ago) Mar 9
    to goph...@pubsubhelper.golang.org, Damien Neil, Dmitri Shuralyov, golang-co...@googlegroups.com
    Attention needed from Damien Neil and Dmitri Shuralyov
    Quim Muntal voted Commit-Queue+1
    Commit-Queue+1
    Open in Gerrit
    Related details
    Attention is currently required from:
    • Damien Neil
    • Dmitri Shuralyov
    Submit Requirements:
    • requirement is not satisfiedCode-Review
    • requirement satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    • requirement is not satisfiedTryBots-Pass
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    


     Gerrit-MessageType: comment 
    

     Gerrit-Project: go 
    

     Gerrit-Branch: release-branch.go1.26 
    

     Gerrit-Change-Id: I0ed91be7ed10c04ddea3af55548a8dbf0be5f3a8 
    

     Gerrit-Change-Number: 753060 
    

     Gerrit-PatchSet: 1 
    

     Gerrit-Owner: Quim Muntal <quimm...@gmail.com> 
    

     Gerrit-Reviewer: Damien Neil <dn...@google.com> 
    

     Gerrit-Reviewer: Dmitri Shuralyov <dmit...@golang.org> 
    

     Gerrit-Reviewer: Quim Muntal <quimm...@gmail.com> 
    

     Gerrit-Attention: Dmitri Shuralyov <dmit...@golang.org> 
    

     Gerrit-Attention: Damien Neil <dn...@google.com> 
    

     Gerrit-Comment-Date: Mon, 09 Mar 2026 09:25:23 +0000 
    

     Gerrit-HasComments: No 
    

     Gerrit-Has-Labels: Yes 
    


    unsatisfied_requirement
    satisfied_requirement
    open
    diffy
    Damien Neil (Gerrit)
    unread,
    Mar 9, 2026, 11:54:47 AM (10 days ago) Mar 9
    to Quim Muntal, goph...@pubsubhelper.golang.org, Go LUCI, Dmitri Shuralyov, golang-co...@googlegroups.com
    Attention needed from Dmitri Shuralyov and Quim Muntal
    Damien Neil voted Code-Review+2
    Code-Review+2
    Open in Gerrit
    Related details
    Attention is currently required from:
    • Dmitri Shuralyov
    • Quim Muntal
    Submit Requirements:
    • requirement satisfiedCode-Review
    • requirement satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    • requirement satisfiedTryBots-Pass
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    


     Gerrit-MessageType: comment 
    

     Gerrit-Project: go 
    

     Gerrit-Branch: release-branch.go1.26 
    

     Gerrit-Change-Id: I0ed91be7ed10c04ddea3af55548a8dbf0be5f3a8 
    

     Gerrit-Change-Number: 753060 
    

     Gerrit-PatchSet: 1 
    

     Gerrit-Owner: Quim Muntal <quimm...@gmail.com> 
    

     Gerrit-Reviewer: Damien Neil <dn...@google.com> 
    

     Gerrit-Reviewer: Dmitri Shuralyov <dmit...@golang.org> 
    

    

     Gerrit-Reviewer: Quim Muntal <quimm...@gmail.com> 
    

     Gerrit-Attention: Quim Muntal <quimm...@gmail.com> 
    

     Gerrit-Attention: Dmitri Shuralyov <dmit...@golang.org> 
    

     Gerrit-Comment-Date: Mon, 09 Mar 2026 15:54:43 +0000 
    

     Gerrit-HasComments: No 
    

     Gerrit-Has-Labels: Yes 
    


    satisfied_requirement
    unsatisfied_requirement
    open
    diffy
    Dmitri Shuralyov (Gerrit)
    unread,
    Mar 10, 2026, 11:00:02 AM (9 days ago) Mar 10
    to Quim Muntal, goph...@pubsubhelper.golang.org, Damien Neil, Go LUCI, Dmitri Shuralyov, golang-co...@googlegroups.com
    Dmitri Shuralyov voted Code-Review+1
    Code-Review+1
    Open in Gerrit
    Related details
    Attention set is empty
    Submit Requirements:
      • requirement satisfiedCode-Review
      • requirement satisfiedNo-Unresolved-Comments
      • requirement satisfiedReview-Enforcement
      • requirement satisfiedTryBots-Pass
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      


       Gerrit-MessageType: comment 
      

       Gerrit-Project: go 
      

       Gerrit-Branch: release-branch.go1.26 
      

       Gerrit-Change-Id: I0ed91be7ed10c04ddea3af55548a8dbf0be5f3a8 
      

       Gerrit-Change-Number: 753060 
      

       Gerrit-PatchSet: 1 
      

       Gerrit-Owner: Quim Muntal <quimm...@gmail.com> 
      

       Gerrit-Reviewer: Damien Neil <dn...@google.com> 
      

       Gerrit-Reviewer: Dmitri Shuralyov <dmit...@golang.org> 
      

       Gerrit-Reviewer: Dmitri Shuralyov <dmit...@google.com> 
      


       Gerrit-Reviewer: Quim Muntal <quimm...@gmail.com> 
      

       Gerrit-Comment-Date: Tue, 10 Mar 2026 14:59:59 +0000 
      

       Gerrit-HasComments: No 
      

       Gerrit-Has-Labels: Yes 
      


      satisfied_requirement
      open
      diffy
      Carlos Amedee (Gerrit)
      unread,
      5:02 PM (5 hours ago) 5:02 PM
      to Quim Muntal, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Dmitri Shuralyov, Damien Neil, Go LUCI, Dmitri Shuralyov, golang-co...@googlegroups.com
      Carlos Amedee submitted the change
      Change information
      Commit message:
      [release-branch.go1.26] net: correctly handle non-nil empty cmsg buffer on windows

      Updates #77875
      Fixes #77885

      Change-Id: I0ed91be7ed10c04ddea3af55548a8dbf0be5f3a8
      Reviewed-on: https://go-review.googlesource.com/c/go/+/750420
      Reviewed-by: Quim Muntal <quimm...@gmail.com>
      Reviewed-by: Damien Neil <dn...@google.com>
      Reviewed-by: David Chase <drc...@google.com>
      LUCI-TryBot-Result: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>
      (cherry picked from commit 9e0b5684e1f7166d6427635673001c80218ac9f4)
      Reviewed-on: https://go-review.googlesource.com/c/go/+/753060
      Reviewed-by: Dmitri Shuralyov <dmit...@google.com>
      Files:
      • M src/internal/poll/fd_windows.go
      • M src/net/udpsock_test.go
      Change size: M
      Delta: 2 files changed, 47 insertions(+), 3 deletions(-)
      Branch: refs/heads/release-branch.go1.26
      Submit Requirements:
      • requirement satisfiedCode-Review: +2 by Damien Neil, +1 by Dmitri Shuralyov
      • requirement satisfiedTryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      


       Gerrit-MessageType: merged 
      

       Gerrit-Project: go 
      

       Gerrit-Branch: release-branch.go1.26 
      

       Gerrit-Change-Id: I0ed91be7ed10c04ddea3af55548a8dbf0be5f3a8 
      

       Gerrit-Change-Number: 753060 
      

       Gerrit-PatchSet: 2 
      

       Gerrit-Owner: Quim Muntal <quimm...@gmail.com> 
      

       Gerrit-Reviewer: Carlos Amedee <car...@golang.org> 
      open
      diffy
      satisfied_requirement
      Reply all
      Reply to author
      Forward
      0 new messages