[go] cmd/go: inject state parameter into `fmtcmd.runFmt`

4 views
Skip to first unread message

Ian Alexander (Gerrit)

unread,
Oct 8, 2025, 6:27:10 AM (8 days ago) Oct 8
to goph...@pubsubhelper.golang.org, Michael Matloob, Go LUCI, golang-co...@googlegroups.com
Attention needed from Michael Matloob

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:
  • Michael Matloob
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: Ib6692aba37a2cbc5b52d3bb705ec2b442afd26eb
Gerrit-Change-Number: 709989
Gerrit-PatchSet: 1
Gerrit-Owner: Ian Alexander <ji...@google.com>
Gerrit-Reviewer: Ian Alexander <ji...@google.com>
Gerrit-Reviewer: Michael Matloob <mat...@golang.org>
Gerrit-Attention: Michael Matloob <mat...@golang.org>
Gerrit-Comment-Date: Wed, 08 Oct 2025 10:27:06 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
unsatisfied_requirement
satisfied_requirement
open
diffy

Ian Alexander (Gerrit)

unread,
Oct 11, 2025, 3:56:39 PM (4 days ago) Oct 11
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Attention needed from Michael Matloob

Ian Alexander uploaded new patchset

Ian Alexander uploaded patch set #4 to this change.
Open in Gerrit

Related details

Attention is currently required from:
  • Michael Matloob
Submit Requirements:
    • requirement is not satisfiedCode-Review
    • requirement satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    • requirement is not satisfiedTryBots-Pass
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: newpatchset
    Gerrit-Project: go
    Gerrit-Branch: master
    Gerrit-Change-Id: Ib6692aba37a2cbc5b52d3bb705ec2b442afd26eb
    Gerrit-Change-Number: 709989
    Gerrit-PatchSet: 4
    unsatisfied_requirement
    satisfied_requirement
    open
    diffy

    Ian Alexander (Gerrit)

    unread,
    Oct 11, 2025, 7:45:11 PM (4 days ago) Oct 11
    to goph...@pubsubhelper.golang.org, Michael Matloob, Go LUCI, golang-co...@googlegroups.com
    Attention needed from Michael Matloob

    Ian Alexander voted Commit-Queue+1

    Commit-Queue+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Michael Matloob
    Submit Requirements:
    • requirement is not satisfiedCode-Review
    • requirement satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    • requirement is not satisfiedTryBots-Pass
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: go
    Gerrit-Branch: master
    Gerrit-Change-Id: Ib6692aba37a2cbc5b52d3bb705ec2b442afd26eb
    Gerrit-Change-Number: 709989
    Gerrit-PatchSet: 4
    Gerrit-Owner: Ian Alexander <ji...@google.com>
    Gerrit-Reviewer: Ian Alexander <ji...@google.com>
    Gerrit-Reviewer: Michael Matloob <mat...@golang.org>
    Gerrit-Attention: Michael Matloob <mat...@golang.org>
    Gerrit-Comment-Date: Sat, 11 Oct 2025 23:45:07 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    unsatisfied_requirement
    satisfied_requirement
    open
    diffy

    Ian Alexander (Gerrit)

    unread,
    Oct 13, 2025, 10:45:38 AM (3 days ago) Oct 13
    to goph...@pubsubhelper.golang.org, Go LUCI, Michael Matloob, golang-co...@googlegroups.com
    Attention needed from Michael Matloob

    Ian Alexander voted Commit-Queue+1

    Commit-Queue+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Michael Matloob
    Submit Requirements:
    • requirement is not satisfiedCode-Review
    • requirement satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    • requirement is not satisfiedTryBots-Pass
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: go
    Gerrit-Branch: master
    Gerrit-Change-Id: Ib6692aba37a2cbc5b52d3bb705ec2b442afd26eb
    Gerrit-Change-Number: 709989
    Gerrit-PatchSet: 5
    Gerrit-Owner: Ian Alexander <ji...@google.com>
    Gerrit-Reviewer: Ian Alexander <ji...@google.com>
    Gerrit-Reviewer: Michael Matloob <mat...@golang.org>
    Gerrit-Attention: Michael Matloob <mat...@golang.org>
    Gerrit-Comment-Date: Mon, 13 Oct 2025 14:45:34 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    unsatisfied_requirement
    satisfied_requirement
    open
    diffy

    Michael Matloob (Gerrit)

    unread,
    2:47 PM (9 hours ago) 2:47 PM
    to Ian Alexander, goph...@pubsubhelper.golang.org, Go LUCI, golang-co...@googlegroups.com
    Attention needed from Ian Alexander

    Michael Matloob voted and added 1 comment

    Votes added by Michael Matloob

    Code-Review+2

    1 comment

    File src/cmd/go/internal/fmtcmd/fmt.go
    Line 53, Patchset 6: moduleLoaderState := modload.NewState()
    Michael Matloob . unresolved

    we're going to want to rename this variable at some point. i wonder if we can pick a good name for it early on so we don't have to come back and find all of them.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Ian Alexander
    Submit Requirements:
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    • requirement is not satisfiedTryBots-Pass
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: go
    Gerrit-Branch: master
    Gerrit-Change-Id: Ib6692aba37a2cbc5b52d3bb705ec2b442afd26eb
    Gerrit-Change-Number: 709989
    Gerrit-PatchSet: 9
    Gerrit-Owner: Ian Alexander <ji...@google.com>
    Gerrit-Reviewer: Ian Alexander <ji...@google.com>
    Gerrit-Reviewer: Michael Matloob <mat...@golang.org>
    Gerrit-Attention: Ian Alexander <ji...@google.com>
    Gerrit-Comment-Date: Wed, 15 Oct 2025 18:47:36 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Ian Alexander (Gerrit)

    unread,
    8:19 PM (4 hours ago) 8:19 PM
    to goph...@pubsubhelper.golang.org, Michael Matloob, Go LUCI, golang-co...@googlegroups.com
    Attention needed from Michael Matloob

    Ian Alexander added 1 comment

    File src/cmd/go/internal/fmtcmd/fmt.go
    Line 53, Patchset 6: moduleLoaderState := modload.NewState()
    Michael Matloob . unresolved

    we're going to want to rename this variable at some point. i wonder if we can pick a good name for it early on so we don't have to come back and find all of them.

    Ian Alexander

    I agree that is not the ideal variable name. I chose it specifically so that we could more easily go back with an 'rf' refactor and change it. My reasoning is that the 'rf inject' command auto-chooses the variable name "loaderstate", and that should probably be changed to something like "s". We should be able to do both transformations in a follow-up commit.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Michael Matloob
    Submit Requirements:
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    • requirement is not satisfiedTryBots-Pass
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: go
    Gerrit-Branch: master
    Gerrit-Change-Id: Ib6692aba37a2cbc5b52d3bb705ec2b442afd26eb
    Gerrit-Change-Number: 709989
    Gerrit-PatchSet: 9
    Gerrit-Owner: Ian Alexander <ji...@google.com>
    Gerrit-Reviewer: Ian Alexander <ji...@google.com>
    Gerrit-Reviewer: Michael Matloob <mat...@golang.org>
    Gerrit-Attention: Michael Matloob <mat...@golang.org>
    Gerrit-Comment-Date: Thu, 16 Oct 2025 00:19:17 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Michael Matloob <mat...@golang.org>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages