Michael Matloob (Gerrit)

unread,

Aug 6, 2026, 2:47:00 PM (6 days ago) Aug 6

to goph...@pubsubhelper.golang.org, Dmitri Shuralyov, Russ Cox, golang...@luci-project-accounts.iam.gserviceaccount.com, golang-co...@googlegroups.com

Attention needed from Dmitri Shuralyov

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:

Dmitri Shuralyov

Submit Requirements:

Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

unsatisfied_requirement

satisfied_requirement

open

diffy

Michael Matloob (Gerrit)

unread,

Aug 6, 2026, 6:08:01 PM (5 days ago) Aug 6

to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com

Attention needed from Dmitri Shuralyov and Michael Matloob

Michael Matloob uploaded new patchset

Michael Matloob uploaded patch set #3 to this change.

Following approvals got outdated and were removed:

TryBots-Pass: LUCI-TryBot-Result-1 by golang...@luci-project-accounts.iam.gserviceaccount.com

Open in Gerrit

Related details

Attention is currently required from:

Dmitri Shuralyov
Michael Matloob

Submit Requirements:

Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

unsatisfied_requirement

satisfied_requirement

open

diffy

Dmitri Shuralyov (Gerrit)

unread,

Aug 6, 2026, 7:34:10 PM (5 days ago) Aug 6

to Michael Matloob, goph...@pubsubhelper.golang.org, golang...@luci-project-accounts.iam.gserviceaccount.com, Dmitri Shuralyov, Russ Cox, golang-co...@googlegroups.com

Attention needed from Michael Matloob

Dmitri Shuralyov added 2 comments

Commit Message

Line 15, Patchset 3 (Latest):that are run in all.bash. That will allow usersn running make.bash to

Dmitri Shuralyov . unresolved

s/usersn/users/

File src/cmd/dist/build.go

Line 1586, Patchset 3 (Latest): if vflag > 0 {

Dmitri Shuralyov . unresolved

Is the block comment above still up to date?

Open in Gerrit

Related details

Attention is currently required from:

Michael Matloob

Submit Requirements:

Code-Review

No-Unresolved-Comments

Review-Enforcement

TryBots-Pass

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

unsatisfied_requirement

satisfied_requirement

open

diffy

Michael Matloob (Gerrit)

unread,

Aug 6, 2026, 7:45:32 PM (5 days ago) Aug 6

to goph...@pubsubhelper.golang.org, golang...@luci-project-accounts.iam.gserviceaccount.com, Dmitri Shuralyov, Russ Cox, golang-co...@googlegroups.com

Attention needed from Dmitri Shuralyov

Michael Matloob added 2 comments

Commit Message

Line 15, Patchset 3:that are run in all.bash. That will allow usersn running make.bash to

Dmitri Shuralyov . resolved

s/usersn/users/

Michael Matloob

Done

File src/cmd/dist/build.go

Line 1586, Patchset 3: if vflag > 0 {

Dmitri Shuralyov . unresolved

Is the block comment above still up to date?

Michael Matloob

Yes, I think so? I guess we can also say that toolchain3 is the final converged toolchain?

Open in Gerrit

Related details

Attention is currently required from:

Dmitri Shuralyov

Submit Requirements:

Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

unsatisfied_requirement

satisfied_requirement

open

diffy

Michael Matloob (Gerrit)

unread,

Aug 6, 2026, 7:45:33 PM (5 days ago) Aug 6

to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com

Attention needed from Dmitri Shuralyov

Michael Matloob uploaded new patchset

Michael Matloob uploaded patch set #4 to this change.

Open in Gerrit

Related details

Attention is currently required from:

Dmitri Shuralyov

Submit Requirements:

Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

unsatisfied_requirement

satisfied_requirement

open

diffy

Michael Matloob (Gerrit)

unread,

Aug 10, 2026, 3:33:49 PM (2 days ago) Aug 10

to Michael Matloob, goph...@pubsubhelper.golang.org, golang...@luci-project-accounts.iam.gserviceaccount.com, Dmitri Shuralyov, Russ Cox, golang-co...@googlegroups.com

Attention needed from Dmitri Shuralyov and Michael Matloob

Michael Matloob voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Dmitri Shuralyov
Michael Matloob

Submit Requirements:

Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

unsatisfied_requirement

satisfied_requirement

open

diffy

Dmitri Shuralyov (Gerrit)

unread,

Aug 11, 2026, 12:35:37 PM (15 hours ago) Aug 11

to Michael Matloob, goph...@pubsubhelper.golang.org, Dmitri Shuralyov, Michael Matloob, golang...@luci-project-accounts.iam.gserviceaccount.com, Russ Cox, golang-co...@googlegroups.com

Attention needed from Michael Matloob

Dmitri Shuralyov voted and added 3 comments

Votes added by Dmitri Shuralyov

Code-Review

+2

3 comments

Patchset-level comments

File-level comment, Patchset 6 (Latest):

Dmitri Shuralyov . resolved

Thanks.

File src/cmd/dist/build.go

Line 1586, Patchset 3: if vflag > 0 {

Dmitri Shuralyov . resolved

Is the block comment above still up to date?

Michael Matloob

Yes, I think so? I guess we can also say that toolchain3 is the final converged toolchain?

Dmitri Shuralyov

Thanks for checking. I asked because keeping these comments up to date will help with future maintenance of this sequence, and it seemed worth some extra attention.

Line 1609, Patchset 6 (Latest): // Finish GOHOSTOS/GOHOSTARCH installation and then

Dmitri Shuralyov . unresolved

This part seems out of date given that line 1629 was deleted, so the GOHOSTOS/GOHOSTARCH installation isn't being done anymore (only staleness check). (The second half 'run GOOS/GOARCH installation' is still being done, so that matches.)

Open in Gerrit

Related details

Attention is currently required from:

Michael Matloob

Submit Requirements:

Code-Review

No-Unresolved-Comments
Review-Enforcement
TryBots-Pass

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Dmitri Shuralyov (Gerrit)

unread,

Aug 11, 2026, 12:35:50 PM (15 hours ago) Aug 11

to Michael Matloob, goph...@pubsubhelper.golang.org, Dmitri Shuralyov, Michael Matloob, golang...@luci-project-accounts.iam.gserviceaccount.com, Russ Cox, golang-co...@googlegroups.com

Attention needed from Michael Matloob

Dmitri Shuralyov voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Michael Matloob

Submit Requirements:

Code-Review
No-Unresolved-Comments

Review-Enforcement
TryBots-Pass

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Michael Matloob (Gerrit)

unread,

Aug 11, 2026, 12:47:02 PM (15 hours ago) Aug 11

to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com

Attention needed from Michael Matloob

Michael Matloob uploaded new patchset

Michael Matloob uploaded patch set #7 to this change.

Following approvals got outdated and were removed:

TryBots-Pass: LUCI-TryBot-Result+1 by golang...@luci-project-accounts.iam.gserviceaccount.com

Open in Gerrit

Related details

Attention is currently required from:

Michael Matloob

Submit Requirements:

Code-Review
No-Unresolved-Comments
Review-Enforcement

TryBots-Pass

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Michael Matloob (Gerrit)

unread,

Aug 11, 2026, 12:47:19 PM (15 hours ago) Aug 11

to goph...@pubsubhelper.golang.org, Dmitri Shuralyov, Dmitri Shuralyov, Michael Matloob, golang...@luci-project-accounts.iam.gserviceaccount.com, Russ Cox, golang-co...@googlegroups.com

Michael Matloob added 1 comment

File src/cmd/dist/build.go

Line 1609, Patchset 6: // Finish GOHOSTOS/GOHOSTARCH installation and then

Dmitri Shuralyov . resolved

This part seems out of date given that line 1629 was deleted, so the GOHOSTOS/GOHOSTARCH installation isn't being done anymore (only staleness check). (The second half 'run GOOS/GOARCH installation' is still being done, so that matches.)

Michael Matloob

Done

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Review
No-Unresolved-Comments

Review-Enforcement
TryBots-Pass

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Michael Matloob (Gerrit)

unread,

Aug 11, 2026, 12:47:24 PM (15 hours ago) Aug 11

to goph...@pubsubhelper.golang.org, Dmitri Shuralyov, Dmitri Shuralyov, Michael Matloob, golang...@luci-project-accounts.iam.gserviceaccount.com, Russ Cox, golang-co...@googlegroups.com

Michael Matloob voted Auto-Submit+1

Auto-Submit

+1

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Gopher Robot (Gerrit)

unread,

Aug 11, 2026, 1:10:34 PM (14 hours ago) Aug 11

to Michael Matloob, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, golang...@luci-project-accounts.iam.gserviceaccount.com, Dmitri Shuralyov, Dmitri Shuralyov, Michael Matloob, Russ Cox, golang-co...@googlegroups.com

Gopher Robot submitted the change with unreviewed changes

Unreviewed changes

6 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:

```
The name of the file: src/cmd/dist/build.go
Insertions: 1, Deletions: 1.

@@ -1606,7 +1606,7 @@
 		xprintf("Checking command staleness for %s/%s.\n", goos, goarch)
 	} else {
 		// GOOS/GOARCH does not match GOHOSTOS/GOHOSTARCH.
-		// Finish GOHOSTOS/GOHOSTARCH installation and then
+		// Check the GOHOSTOS/GOHOSTARCH build and then
 		// run GOOS/GOARCH installation.
 		timelog("build", "host toolchain")
 		if vflag > 0 {
```

Change information

Commit message:

cmd/dist: don't rebuild the toolchain with a clean cache

The toolchain converges at toolchain3, so we can stop there and avoid
a rebuild that builds the exact same toolchain again. The comments
say that we're priming the cache, but when a user tries to build the
toolchain again with go install, they will build a different toolchain
because cgo may be enabled. We would also build the stdlib in make.bash
but it makes more sense to just let it be built lazily or by the tests
that are run in all.bash. That will allow users running make.bash to
get to a working toolchain that's been verified to converge as soon
as possible.

Note that for toolchain3 to properly converge, toolchain2 should have
been built with pgo, so we need to build preprofile with toolchain1.

Fixes #80773

Change-Id: I174db99337ddc538aa65d94a32a626c06a6a6964

Reviewed-on: https://go-review.googlesource.com/c/go/+/811700

LUCI-TryBot-Result: golang...@luci-project-accounts.iam.gserviceaccount.com <golang...@luci-project-accounts.iam.gserviceaccount.com>

Reviewed-by: Michael Matloob <mat...@google.com>

Reviewed-by: Dmitri Shuralyov <dmit...@google.com>

Reviewed-by: Dmitri Shuralyov <dmit...@golang.org>

Auto-Submit: Michael Matloob <mat...@golang.org>

Files:

M src/cmd/dist/build.go
M src/cmd/dist/buildtool.go

Change size: S

Delta: 2 files changed, 11 insertions(+), 28 deletions(-)

Branch: refs/heads/master

Submit Requirements:

Code-Review: +2 by Dmitri Shuralyov, +1 by Michael Matloob, +1 by Dmitri Shuralyov
TryBots-Pass: LUCI-TryBot-Result+1 by golang...@luci-project-accounts.iam.gserviceaccount.com

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Robert Griesemer (Gerrit)

unread,

Aug 11, 2026, 6:20:20 PM (9 hours ago) Aug 11

to Michael Matloob, Gopher Robot, goph...@pubsubhelper.golang.org, golang...@luci-project-accounts.iam.gserviceaccount.com, Dmitri Shuralyov, Dmitri Shuralyov, Michael Matloob, Russ Cox, golang-co...@googlegroups.com

Robert Griesemer added 1 comment

Patchset-level comments

File-level comment, Patchset 8 (Latest):

Robert Griesemer . resolved

FYI. This CL appears to cause a problem with the linux-amd-64-runtimefreegc build.

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Review

No-Unresolved-Comments
Review-Enforcement

TryBots-Pass

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Michael Matloob (Gerrit)

unread,

Aug 11, 2026, 10:19:24 PM (5 hours ago) Aug 11

to Michael Matloob, Gopher Robot, goph...@pubsubhelper.golang.org, Robert Griesemer, golang...@luci-project-accounts.iam.gserviceaccount.com, Dmitri Shuralyov, Dmitri Shuralyov, Russ Cox, golang-co...@googlegroups.com

Michael Matloob added 1 comment

Patchset-level comments

File-level comment, Patchset 8 (Latest):

Robert Griesemer . resolved

FYI. This CL appears to cause a problem with the linux-amd-64-runtimefreegc build.

Michael Matloob

Fix CL 813380 should be in soon.

satisfied_requirement

open

diffy

Reply all

Reply to author

Forward

[go] cmd/dist: don't rebuild the toolchain with a clean cache

Michael Matloob (Gerrit)

New activity on the change

Related details

Michael Matloob (Gerrit)

Michael Matloob uploaded new patchset

Related details

Dmitri Shuralyov (Gerrit)

Dmitri Shuralyov added 2 comments

Related details

Michael Matloob (Gerrit)

Michael Matloob added 2 comments

Related details

Michael Matloob (Gerrit)

Michael Matloob uploaded new patchset

Related details

Michael Matloob (Gerrit)

Michael Matloob voted Code-Review+1

Related details

Dmitri Shuralyov (Gerrit)

Dmitri Shuralyov voted and added 3 comments

Votes added by Dmitri Shuralyov

3 comments

Related details

Dmitri Shuralyov (Gerrit)

Dmitri Shuralyov voted Code-Review+1

Related details

Michael Matloob (Gerrit)

Michael Matloob uploaded new patchset

Related details

Michael Matloob (Gerrit)

Michael Matloob added 1 comment

Related details

Michael Matloob (Gerrit)

Michael Matloob voted Auto-Submit+1

Related details

Gopher Robot (Gerrit)

Gopher Robot submitted the change with unreviewed changes

Unreviewed changes

Change information

Robert Griesemer (Gerrit)

Robert Griesemer added 1 comment

Related details

Michael Matloob (Gerrit)

Michael Matloob added 1 comment