[go] doc/go1.21: mention math.Compare and Compare32

6 views
Skip to first unread message

Ian Lance Taylor (Gerrit)

unread,
May 26, 2023, 8:05:13 PM5/26/23
to Eli Bendersky, goph...@pubsubhelper.golang.org, Ian Lance Taylor, golang-co...@googlegroups.com

Attention is currently required from: Eli Bendersky.

Ian Lance Taylor would like Eli Bendersky to review this change.

View Change

doc/go1.21: mention math.Compare and Compare32

For #56491

Change-Id: Ifee968d45d66df4d05319b4fef27bb1d3d6781f3
---
M doc/go1.21.html
1 file changed, 6 insertions(+), 10 deletions(-)

diff --git a/doc/go1.21.html b/doc/go1.21.html
index 3758d28..b5c6330 100644
--- a/doc/go1.21.html
+++ b/doc/go1.21.html
@@ -541,16 +541,12 @@

<dl id="math"><dt><a href="/pkg/math/">math</a></dt>
<dd>
- <p><!-- https://go.dev/issue/56491 -->
- TODO: <a href="https://go.dev/issue/56491">https://go.dev/issue/56491</a>: add Compare and Compare32
- </p>
-
- <p><!-- CL 459435 -->
- TODO: <a href="https://go.dev/cl/459435">https://go.dev/cl/459435</a>: math: add Compare and Compare32; modified api/next/56491.txt
- </p>
-
- <p><!-- CL 467515 -->
- TODO: <a href="https://go.dev/cl/467515">https://go.dev/cl/467515</a>: math: add Compare and Compare32; modified api/next/56491.txt
+ <p><!-- https://go.dev/issue/56491, CL 459435, CL 467515 -->
+ The new functions
+ <a href="/pkg/meth/#Compare"><code>Compare</code></a> and
+ <a href="/pkg/meth/#Compare32"><code>Compare32</code></a> may be
+ used to compare floating-point values using the
+ total-ordering predicate defined by IEEE-754.
</p>
</dd>
</dl><!-- math -->

To view, visit change 498776. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-MessageType: newchange
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: Ifee968d45d66df4d05319b4fef27bb1d3d6781f3
Gerrit-Change-Number: 498776
Gerrit-PatchSet: 1
Gerrit-Owner: Ian Lance Taylor <ia...@golang.org>
Gerrit-Reviewer: Eli Bendersky <eli...@google.com>
Gerrit-Reviewer: Ian Lance Taylor <ia...@golang.org>
Gerrit-Attention: Eli Bendersky <eli...@google.com>

Akhil Indurti (Gerrit)

unread,
May 26, 2023, 10:14:02 PM5/26/23
to Ian Lance Taylor, goph...@pubsubhelper.golang.org, Gopher Robot, Eli Bendersky, golang-co...@googlegroups.com

Attention is currently required from: Eli Bendersky, Ian Lance Taylor.

View Change

1 comment:

To view, visit change 498776. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-MessageType: comment
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: Ifee968d45d66df4d05319b4fef27bb1d3d6781f3
Gerrit-Change-Number: 498776
Gerrit-PatchSet: 1
Gerrit-Owner: Ian Lance Taylor <ia...@golang.org>
Gerrit-Reviewer: Eli Bendersky <eli...@google.com>
Gerrit-Reviewer: Gopher Robot <go...@golang.org>
Gerrit-Reviewer: Ian Lance Taylor <ia...@golang.org>
Gerrit-CC: Akhil Indurti <aind...@gmail.com>
Gerrit-Attention: Eli Bendersky <eli...@google.com>
Gerrit-Attention: Ian Lance Taylor <ia...@golang.org>
Gerrit-Comment-Date: Sat, 27 May 2023 02:13:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No

Ian Lance Taylor (Gerrit)

unread,
May 29, 2023, 7:08:50 PM5/29/23
to Ian Lance Taylor, goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com

Attention is currently required from: Eli Bendersky, Ian Lance Taylor.

Ian Lance Taylor uploaded patch set #2 to this change.

View Change

The following approvals got outdated and were removed: Run-TryBot+1 by Ian Lance Taylor, TryBot-Result+1 by Gopher Robot

doc/go1.21: mention math.Compare and Compare32

For #56491

Change-Id: Ifee968d45d66df4d05319b4fef27bb1d3d6781f3
---
M doc/go1.21.html
1 file changed, 6 insertions(+), 10 deletions(-)

To view, visit change 498776. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-MessageType: newpatchset
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: Ifee968d45d66df4d05319b4fef27bb1d3d6781f3
Gerrit-Change-Number: 498776
Gerrit-PatchSet: 2

Ian Lance Taylor (Gerrit)

unread,
May 29, 2023, 7:08:56 PM5/29/23
to Ian Lance Taylor, goph...@pubsubhelper.golang.org, Akhil Indurti, Gopher Robot, Eli Bendersky, golang-co...@googlegroups.com

Attention is currently required from: Akhil Indurti, Eli Bendersky.

Patch set 1:Run-TryBot +1

View Change

1 comment:

  • File doc/go1.21.html:

    • Done, thanks.

To view, visit change 498776. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-MessageType: comment
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: Ifee968d45d66df4d05319b4fef27bb1d3d6781f3
Gerrit-Change-Number: 498776
Gerrit-PatchSet: 1
Gerrit-Owner: Ian Lance Taylor <ia...@golang.org>
Gerrit-Reviewer: Eli Bendersky <eli...@google.com>
Gerrit-Reviewer: Gopher Robot <go...@golang.org>
Gerrit-Reviewer: Ian Lance Taylor <ia...@golang.org>
Gerrit-CC: Akhil Indurti <aind...@gmail.com>
Gerrit-Attention: Eli Bendersky <eli...@google.com>
Gerrit-Attention: Akhil Indurti <aind...@gmail.com>
Gerrit-Comment-Date: Mon, 29 May 2023 23:08:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Akhil Indurti <aind...@gmail.com>

Eli Bendersky (Gerrit)

unread,
May 30, 2023, 9:02:23 AM5/30/23
to Ian Lance Taylor, goph...@pubsubhelper.golang.org, Gopher Robot, Akhil Indurti, golang-co...@googlegroups.com

Attention is currently required from: Akhil Indurti, Ian Lance Taylor.

View Change

1 comment:

  • Patchset:

    • Patch Set #2:

      It's probably worth mentioning here (and likely in the comment of the new functions) how this interplays with cmp.Compare -- in fact their semantics seem to mismatch in some ways, which annoying given that both functions are called Compare

To view, visit change 498776. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-MessageType: comment
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: Ifee968d45d66df4d05319b4fef27bb1d3d6781f3
Gerrit-Change-Number: 498776
Gerrit-PatchSet: 2
Gerrit-Owner: Ian Lance Taylor <ia...@golang.org>
Gerrit-Reviewer: Eli Bendersky <eli...@google.com>
Gerrit-Reviewer: Gopher Robot <go...@golang.org>
Gerrit-Reviewer: Ian Lance Taylor <ia...@golang.org>
Gerrit-CC: Akhil Indurti <aind...@gmail.com>
Gerrit-Attention: Ian Lance Taylor <ia...@golang.org>
Gerrit-Attention: Akhil Indurti <aind...@gmail.com>
Gerrit-Comment-Date: Tue, 30 May 2023 13:02:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No

Eli Bendersky (Gerrit)

unread,
May 30, 2023, 9:03:29 AM5/30/23
to Ian Lance Taylor, goph...@pubsubhelper.golang.org, Gopher Robot, Akhil Indurti, golang-co...@googlegroups.com

Attention is currently required from: Akhil Indurti, Ian Lance Taylor.

View Change

1 comment:

  • Patchset:

    • Patch Set #2:

      It's probably worth mentioning here (and likely in the comment of the new functions) how this interp […]

      <unresolve>

To view, visit change 498776. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-MessageType: comment
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: Ifee968d45d66df4d05319b4fef27bb1d3d6781f3
Gerrit-Change-Number: 498776
Gerrit-PatchSet: 2
Gerrit-Owner: Ian Lance Taylor <ia...@golang.org>
Gerrit-Reviewer: Eli Bendersky <eli...@google.com>
Gerrit-Reviewer: Gopher Robot <go...@golang.org>
Gerrit-Reviewer: Ian Lance Taylor <ia...@golang.org>
Gerrit-CC: Akhil Indurti <aind...@gmail.com>
Gerrit-Attention: Ian Lance Taylor <ia...@golang.org>
Gerrit-Attention: Akhil Indurti <aind...@gmail.com>
Gerrit-Comment-Date: Tue, 30 May 2023 13:03:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Eli Bendersky <eli...@google.com>

Ian Lance Taylor (Gerrit)

unread,
May 30, 2023, 12:06:17 PM5/30/23
to Ian Lance Taylor, goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com

Attention is currently required from: Akhil Indurti, Ian Lance Taylor.

Ian Lance Taylor uploaded patch set #3 to this change.

View Change

The following approvals got outdated and were removed: Run-TryBot+1 by Ian Lance Taylor, TryBot-Result+1 by Gopher Robot

doc/go1.21: mention math.Compare and Compare32

For #56491

Change-Id: Ifee968d45d66df4d05319b4fef27bb1d3d6781f3
---
M doc/go1.21.html
1 file changed, 10 insertions(+), 10 deletions(-)

To view, visit change 498776. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-MessageType: newpatchset
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: Ifee968d45d66df4d05319b4fef27bb1d3d6781f3
Gerrit-Change-Number: 498776
Gerrit-PatchSet: 3

Ian Lance Taylor (Gerrit)

unread,
May 30, 2023, 12:06:24 PM5/30/23
to Ian Lance Taylor, goph...@pubsubhelper.golang.org, Gopher Robot, Akhil Indurti, Eli Bendersky, golang-co...@googlegroups.com

Attention is currently required from: Akhil Indurti, Eli Bendersky.

Patch set 2:Run-TryBot +1

View Change

1 comment:

To view, visit change 498776. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-MessageType: comment
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: Ifee968d45d66df4d05319b4fef27bb1d3d6781f3
Gerrit-Change-Number: 498776
Gerrit-PatchSet: 2
Gerrit-Owner: Ian Lance Taylor <ia...@golang.org>
Gerrit-Reviewer: Eli Bendersky <eli...@google.com>
Gerrit-Reviewer: Gopher Robot <go...@golang.org>
Gerrit-Reviewer: Ian Lance Taylor <ia...@golang.org>
Gerrit-CC: Akhil Indurti <aind...@gmail.com>
Gerrit-Attention: Eli Bendersky <eli...@google.com>
Gerrit-Attention: Akhil Indurti <aind...@gmail.com>
Gerrit-Comment-Date: Tue, 30 May 2023 16:06:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Eli Bendersky <eli...@google.com>

Eli Bendersky (Gerrit)

unread,
May 30, 2023, 1:37:00 PM5/30/23
to Ian Lance Taylor, goph...@pubsubhelper.golang.org, Gopher Robot, Akhil Indurti, golang-co...@googlegroups.com

Attention is currently required from: Akhil Indurti, Ian Lance Taylor.

Patch set 3:Hold +1

View Change

1 comment:

To view, visit change 498776. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-MessageType: comment
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: Ifee968d45d66df4d05319b4fef27bb1d3d6781f3
Gerrit-Change-Number: 498776
Gerrit-PatchSet: 3
Gerrit-Owner: Ian Lance Taylor <ia...@golang.org>
Gerrit-Reviewer: Eli Bendersky <eli...@google.com>
Gerrit-Reviewer: Gopher Robot <go...@golang.org>
Gerrit-Reviewer: Ian Lance Taylor <ia...@golang.org>
Gerrit-CC: Akhil Indurti <aind...@gmail.com>
Gerrit-Attention: Ian Lance Taylor <ia...@golang.org>
Gerrit-Attention: Akhil Indurti <aind...@gmail.com>
Gerrit-Comment-Date: Tue, 30 May 2023 17:36:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes

Ian Lance Taylor (Gerrit)

unread,
May 30, 2023, 1:44:53 PM5/30/23
to Ian Lance Taylor, goph...@pubsubhelper.golang.org, Eli Bendersky, Gopher Robot, Akhil Indurti, golang-co...@googlegroups.com

Attention is currently required from: Akhil Indurti.

Patch set 3:Hold +1

View Change

1 comment:

To view, visit change 498776. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-MessageType: comment
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: Ifee968d45d66df4d05319b4fef27bb1d3d6781f3
Gerrit-Change-Number: 498776
Gerrit-PatchSet: 3
Gerrit-Owner: Ian Lance Taylor <ia...@golang.org>
Gerrit-Reviewer: Eli Bendersky <eli...@google.com>
Gerrit-Reviewer: Gopher Robot <go...@golang.org>
Gerrit-Reviewer: Ian Lance Taylor <ia...@golang.org>
Gerrit-CC: Akhil Indurti <aind...@gmail.com>
Gerrit-Attention: Akhil Indurti <aind...@gmail.com>
Gerrit-Comment-Date: Tue, 30 May 2023 17:44:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes

Ian Lance Taylor (Gerrit)

unread,
May 31, 2023, 5:20:07 PM5/31/23
to Ian Lance Taylor, goph...@pubsubhelper.golang.org, Eli Bendersky, Gopher Robot, Akhil Indurti, golang-co...@googlegroups.com

Ian Lance Taylor abandoned this change.

View Change

Abandoned Not doing this, per #60519.

To view, visit change 498776. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-MessageType: abandon
Reply all
Reply to author
Forward
0 new messages