[build] internal/task: use relmeta definitions

0 views
Skip to first unread message

Neal Patel (Gerrit)

unread,
Apr 28, 2026, 5:51:36 PM (11 hours ago) Apr 28
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com

Neal Patel has uploaded the change for review

Commit message

internal/task: use relmeta definitions

Updates golang/go#76157
Updates golang/go#77214
Change-Id: I4a3b284a999f62a7648280df1aa2132ea111bde0

Change diff

diff --git a/internal/task/security_release_coalesce.go b/internal/task/security_release_coalesce.go
index 8281a2b..93dd1f0 100644
--- a/internal/task/security_release_coalesce.go
+++ b/internal/task/security_release_coalesce.go
@@ -18,6 +18,7 @@
 	"golang.org/x/build/gerrit"
 	"golang.org/x/build/internal/relui/groups"
 	wf "golang.org/x/build/internal/workflow"
+	"golang.org/x/build/relmeta"
 	yaml "gopkg.in/yaml.v3"
 )
 
@@ -146,27 +147,6 @@
 	}
 }
 
-// ReleaseMilestone contains all
-// patches and their respective
-// metadata for a given release.
-//
-// TODO(nealpatel): Replace with relmeta package
-type ReleaseMilestone struct {
-	BuganizerID int              `yaml:"buganizer_id"`
-	Patches     []*SecurityPatch `yaml:"security_patches"`
-}
-
-// SecurityPatch is a subset of the
-// required metadata to release all
-// patches contained by a milestone.
-//
-// TODO(nealpatel): Replace with relmeta package
-type SecurityPatch struct {
-	Changelists      []string `yaml:"changelists"`
-	TargetedReleases []string `yaml:"target_releases"`
-	Track            string   `yaml:"track"`
-}
-
 func (x *SecurityReleaseCoalesceTask) GetPrivateChangelists(ctx *wf.TaskContext, milestoneNum string) ([]string, error) {
 	const project = "security-metadata"
 
@@ -180,7 +160,7 @@
 		return nil, err
 	}
 
-	var rm ReleaseMilestone
+	var rm relmeta.ReleaseMilestone
 	if err := yaml.NewDecoder(bytes.NewReader(buf)).Decode(&rm); err != nil {
 		return nil, fmt.Errorf("cannot read milestone: %v", err)
 	}

Change information

Files:
  • M internal/task/security_release_coalesce.go
Change size: S
Delta: 1 file changed, 2 insertions(+), 22 deletions(-)
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: build
Gerrit-Branch: master
Gerrit-Change-Id: I4a3b284a999f62a7648280df1aa2132ea111bde0
Gerrit-Change-Number: 771601
Gerrit-PatchSet: 1
Gerrit-Owner: Neal Patel <neal...@google.com>
unsatisfied_requirement
satisfied_requirement
open
diffy

Neal Patel (Gerrit)

unread,
Apr 28, 2026, 5:51:49 PM (11 hours ago) Apr 28
to goph...@pubsubhelper.golang.org, Dmitri Shuralyov, Nicholas Husin, golang-co...@googlegroups.com
Attention needed from Dmitri Shuralyov

Neal Patel voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Dmitri Shuralyov
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: build
Gerrit-Branch: master
Gerrit-Change-Id: I4a3b284a999f62a7648280df1aa2132ea111bde0
Gerrit-Change-Number: 771601
Gerrit-PatchSet: 1
Gerrit-Owner: Neal Patel <neal...@google.com>
Gerrit-Reviewer: Dmitri Shuralyov <dmit...@golang.org>
Gerrit-Reviewer: Neal Patel <neal...@google.com>
Gerrit-CC: Nicholas Husin <n...@golang.org>
Gerrit-Attention: Dmitri Shuralyov <dmit...@golang.org>
Gerrit-Comment-Date: Tue, 28 Apr 2026 21:51:47 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
unsatisfied_requirement
satisfied_requirement
open
diffy

Neal Patel (Gerrit)

unread,
Apr 28, 2026, 5:59:17 PM (11 hours ago) Apr 28
to goph...@pubsubhelper.golang.org, golang...@luci-project-accounts.iam.gserviceaccount.com, Dmitri Shuralyov, Nicholas Husin, golang-co...@googlegroups.com
Attention needed from Dmitri Shuralyov and Neal Patel

Neal Patel voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Dmitri Shuralyov
  • Neal Patel
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: build
Gerrit-Branch: master
Gerrit-Change-Id: I4a3b284a999f62a7648280df1aa2132ea111bde0
Gerrit-Change-Number: 771601
Gerrit-PatchSet: 2
Gerrit-Owner: Neal Patel <neal...@google.com>
Gerrit-Reviewer: Dmitri Shuralyov <dmit...@golang.org>
Gerrit-Reviewer: Neal Patel <neal...@google.com>
Gerrit-CC: Nicholas Husin <n...@golang.org>
Gerrit-Attention: Dmitri Shuralyov <dmit...@golang.org>
Gerrit-Attention: Neal Patel <neal...@google.com>
Gerrit-Comment-Date: Tue, 28 Apr 2026 21:59:13 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
unsatisfied_requirement
satisfied_requirement
open
diffy

Dmitri Shuralyov (Gerrit)

unread,
Apr 28, 2026, 6:16:04 PM (11 hours ago) Apr 28
to Neal Patel, goph...@pubsubhelper.golang.org, Dmitri Shuralyov, golang...@luci-project-accounts.iam.gserviceaccount.com, Nicholas Husin, golang-co...@googlegroups.com
Attention needed from Neal Patel

Dmitri Shuralyov voted and added 2 comments

Votes added by Dmitri Shuralyov

Code-Review+2

2 comments

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Dmitri Shuralyov . resolved

Thanks.

File internal/task/security_release_coalesce.go
Line 170, Patchset 1: if patch.Track == "PUBLIC" {
Dmitri Shuralyov . unresolved

Since there's now a named constant, consider using it here:

```suggestion
		if patch.Track == relmeta.Public {
```
Open in Gerrit

Related details

Attention is currently required from:
  • Neal Patel
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: build
Gerrit-Branch: master
Gerrit-Change-Id: I4a3b284a999f62a7648280df1aa2132ea111bde0
Gerrit-Change-Number: 771601
Gerrit-PatchSet: 2
Gerrit-Owner: Neal Patel <neal...@google.com>
Gerrit-Reviewer: Dmitri Shuralyov <dmit...@golang.org>
Gerrit-Reviewer: Neal Patel <neal...@google.com>
Gerrit-CC: Nicholas Husin <n...@golang.org>
Gerrit-Attention: Neal Patel <neal...@google.com>
Gerrit-Comment-Date: Tue, 28 Apr 2026 22:16:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Dmitri Shuralyov (Gerrit)

unread,
Apr 28, 2026, 6:16:23 PM (11 hours ago) Apr 28
to Neal Patel, goph...@pubsubhelper.golang.org, Dmitri Shuralyov, golang...@luci-project-accounts.iam.gserviceaccount.com, Nicholas Husin, golang-co...@googlegroups.com
Attention needed from Neal Patel

Dmitri Shuralyov voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Neal Patel
Submit Requirements:
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    • requirement satisfiedTryBots-Pass
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: build
    Gerrit-Branch: master
    Gerrit-Change-Id: I4a3b284a999f62a7648280df1aa2132ea111bde0
    Gerrit-Change-Number: 771601
    Gerrit-PatchSet: 2
    Gerrit-Owner: Neal Patel <neal...@google.com>
    Gerrit-Reviewer: Dmitri Shuralyov <dmit...@golang.org>
    Gerrit-Reviewer: Dmitri Shuralyov <dmit...@google.com>
    Gerrit-Reviewer: Neal Patel <neal...@google.com>
    Gerrit-CC: Nicholas Husin <n...@golang.org>
    Gerrit-Attention: Neal Patel <neal...@google.com>
    Gerrit-Comment-Date: Tue, 28 Apr 2026 22:16:20 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Neal Patel (Gerrit)

    unread,
    Apr 28, 2026, 8:43:46 PM (9 hours ago) Apr 28
    to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
    Attention needed from Dmitri Shuralyov, Dmitri Shuralyov and Neal Patel

    Neal Patel uploaded new patchset

    Neal Patel uploaded patch set #3 to this change.
    Following approvals got outdated and were removed:
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Dmitri Shuralyov
    • Dmitri Shuralyov
    • Neal Patel
    Submit Requirements:
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    • requirement is not satisfiedTryBots-Pass
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: newpatchset
    Gerrit-Project: build
    Gerrit-Branch: master
    Gerrit-Change-Id: I4a3b284a999f62a7648280df1aa2132ea111bde0
    Gerrit-Change-Number: 771601
    Gerrit-PatchSet: 3
    Gerrit-Owner: Neal Patel <neal...@google.com>
    Gerrit-Reviewer: Dmitri Shuralyov <dmit...@golang.org>
    Gerrit-Reviewer: Dmitri Shuralyov <dmit...@google.com>
    Gerrit-Reviewer: Neal Patel <neal...@google.com>
    Gerrit-CC: Nicholas Husin <n...@golang.org>
    Gerrit-Attention: Dmitri Shuralyov <dmit...@google.com>
    unsatisfied_requirement
    open
    diffy

    Neal Patel (Gerrit)

    unread,
    Apr 28, 2026, 8:44:39 PM (9 hours ago) Apr 28
    to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
    Attention needed from Dmitri Shuralyov, Dmitri Shuralyov and Neal Patel

    Neal Patel uploaded new patchset

    Neal Patel uploaded patch set #4 to this change.
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Dmitri Shuralyov
    • Dmitri Shuralyov
    • Neal Patel
    Submit Requirements:
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    • requirement is not satisfiedTryBots-Pass
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: newpatchset
    Gerrit-Project: build
    Gerrit-Branch: master
    Gerrit-Change-Id: I4a3b284a999f62a7648280df1aa2132ea111bde0
    Gerrit-Change-Number: 771601
    Gerrit-PatchSet: 4
    unsatisfied_requirement
    open
    diffy

    Neal Patel (Gerrit)

    unread,
    Apr 28, 2026, 8:44:57 PM (9 hours ago) Apr 28
    to goph...@pubsubhelper.golang.org, Dmitri Shuralyov, Dmitri Shuralyov, golang...@luci-project-accounts.iam.gserviceaccount.com, Nicholas Husin, golang-co...@googlegroups.com
    Attention needed from Dmitri Shuralyov and Dmitri Shuralyov

    Neal Patel voted and added 1 comment

    Votes added by Neal Patel

    Commit-Queue+1

    1 comment

    File internal/task/security_release_coalesce.go
    Line 170, Patchset 1: if patch.Track == "PUBLIC" {
    Dmitri Shuralyov . resolved

    Since there's now a named constant, consider using it here:

    ```suggestion
    		if patch.Track == relmeta.Public {
    ```
    Neal Patel

    Done

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Dmitri Shuralyov
    • Dmitri Shuralyov
    Submit Requirements:
      • requirement is not satisfiedCode-Review
      • requirement satisfiedNo-Unresolved-Comments
      • requirement is not satisfiedReview-Enforcement
      • requirement is not satisfiedTryBots-Pass
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: build
      Gerrit-Branch: master
      Gerrit-Change-Id: I4a3b284a999f62a7648280df1aa2132ea111bde0
      Gerrit-Change-Number: 771601
      Gerrit-PatchSet: 4
      Gerrit-Owner: Neal Patel <neal...@google.com>
      Gerrit-Reviewer: Dmitri Shuralyov <dmit...@golang.org>
      Gerrit-Reviewer: Dmitri Shuralyov <dmit...@google.com>
      Gerrit-Reviewer: Neal Patel <neal...@google.com>
      Gerrit-CC: Nicholas Husin <n...@golang.org>
      Gerrit-Attention: Dmitri Shuralyov <dmit...@google.com>
      Gerrit-Attention: Dmitri Shuralyov <dmit...@golang.org>
      Gerrit-Comment-Date: Wed, 29 Apr 2026 00:44:54 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      Comment-In-Reply-To: Dmitri Shuralyov <dmit...@golang.org>
      unsatisfied_requirement
      satisfied_requirement
      open
      diffy

      Neal Patel (Gerrit)

      unread,
      Apr 28, 2026, 8:45:34 PM (9 hours ago) Apr 28
      to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
      Attention needed from Dmitri Shuralyov, Dmitri Shuralyov and Neal Patel

      Neal Patel uploaded new patchset

      Neal Patel uploaded patch set #5 to this change.
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Dmitri Shuralyov
      • Dmitri Shuralyov
      • Neal Patel
      Submit Requirements:
      • requirement is not satisfiedCode-Review
      • requirement satisfiedNo-Unresolved-Comments
      • requirement is not satisfiedReview-Enforcement
      • requirement is not satisfiedTryBots-Pass
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: newpatchset
      Gerrit-Project: build
      Gerrit-Branch: master
      Gerrit-Change-Id: I4a3b284a999f62a7648280df1aa2132ea111bde0
      Gerrit-Change-Number: 771601
      Gerrit-PatchSet: 5
      Gerrit-Owner: Neal Patel <neal...@google.com>
      Gerrit-Reviewer: Dmitri Shuralyov <dmit...@golang.org>
      Gerrit-Reviewer: Dmitri Shuralyov <dmit...@google.com>
      Gerrit-Reviewer: Neal Patel <neal...@google.com>
      Gerrit-CC: Nicholas Husin <n...@golang.org>
      Gerrit-Attention: Dmitri Shuralyov <dmit...@google.com>
      Gerrit-Attention: Dmitri Shuralyov <dmit...@golang.org>
      Gerrit-Attention: Neal Patel <neal...@google.com>
      unsatisfied_requirement
      satisfied_requirement
      open
      diffy

      Neal Patel (Gerrit)

      unread,
      Apr 28, 2026, 8:45:55 PM (9 hours ago) Apr 28
      to goph...@pubsubhelper.golang.org, golang...@luci-project-accounts.iam.gserviceaccount.com, Dmitri Shuralyov, Dmitri Shuralyov, Nicholas Husin, golang-co...@googlegroups.com
      Attention needed from Dmitri Shuralyov and Dmitri Shuralyov

      Neal Patel voted Commit-Queue+1

      Commit-Queue+1
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Dmitri Shuralyov
      • Dmitri Shuralyov
      Submit Requirements:
      • requirement is not satisfiedCode-Review
      • requirement satisfiedNo-Unresolved-Comments
      • requirement is not satisfiedReview-Enforcement
      • requirement is not satisfiedTryBots-Pass
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: build
      Gerrit-Branch: master
      Gerrit-Change-Id: I4a3b284a999f62a7648280df1aa2132ea111bde0
      Gerrit-Change-Number: 771601
      Gerrit-PatchSet: 5
      Gerrit-Owner: Neal Patel <neal...@google.com>
      Gerrit-Reviewer: Dmitri Shuralyov <dmit...@golang.org>
      Gerrit-Reviewer: Dmitri Shuralyov <dmit...@google.com>
      Gerrit-Reviewer: Neal Patel <neal...@google.com>
      Gerrit-CC: Nicholas Husin <n...@golang.org>
      Gerrit-Attention: Dmitri Shuralyov <dmit...@google.com>
      Gerrit-Attention: Dmitri Shuralyov <dmit...@golang.org>
      Gerrit-Comment-Date: Wed, 29 Apr 2026 00:45:52 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      unsatisfied_requirement
      satisfied_requirement
      open
      diffy
      Reply all
      Reply to author
      Forward
      0 new messages