[go] cmd/dist/test: add debug logging to net/http/pprof

5 views
Skip to first unread message

Johan Brandhorst-Satzkorn (Gerrit)

unread,
May 3, 2023, 1:01:54 AM5/3/23
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com

Johan Brandhorst-Satzkorn has uploaded this change for review.

View Change

cmd/dist/test: add debug logging to net/http/pprof

This is in an effort to help understand the wasmtime failure.

DO NOT MERGE

Change-Id: I96bf3debd8c9851270f48bc02ffe95ff15ec50a3
---
M src/cmd/dist/test.go
1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/src/cmd/dist/test.go b/src/cmd/dist/test.go
index 31eb691..aa3815a 100644
--- a/src/cmd/dist/test.go
+++ b/src/cmd/dist/test.go
@@ -554,11 +554,15 @@
break
}
}
- return (&goTest{
+ tst := &goTest{
timeout: timeoutSec,
gcflags: gcflags,
pkgs: stdMatches,
- }).run(t)
+ }
+ if pkg == "net/http/pprof" {
+ tst.testFlags = append(tst.testFlags, "-v")
+ }
+ return tst.run(t)
},
})
}

To view, visit change 491855. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-MessageType: newchange
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: I96bf3debd8c9851270f48bc02ffe95ff15ec50a3
Gerrit-Change-Number: 491855
Gerrit-PatchSet: 1
Gerrit-Owner: Johan Brandhorst-Satzkorn <johan.br...@gmail.com>

Johan Brandhorst-Satzkorn (Gerrit)

unread,
May 3, 2023, 1:12:50 AM5/3/23
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com

Patch set 1:Run-TryBot +1Hold +1

View Change

1 comment:

To view, visit change 491855. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-MessageType: comment
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: I96bf3debd8c9851270f48bc02ffe95ff15ec50a3
Gerrit-Change-Number: 491855
Gerrit-PatchSet: 1
Gerrit-Owner: Johan Brandhorst-Satzkorn <johan.br...@gmail.com>
Gerrit-Reviewer: Johan Brandhorst-Satzkorn <johan.br...@gmail.com>
Gerrit-Comment-Date: Wed, 03 May 2023 05:12:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes

Johan Brandhorst-Satzkorn (Gerrit)

unread,
May 18, 2023, 12:47:11 AM5/18/23
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com

Attention is currently required from: Johan Brandhorst-Satzkorn.

Johan Brandhorst-Satzkorn uploaded patch set #2 to this change.

View Change

The following approvals got outdated and were removed: Run-TryBot+1 by Johan Brandhorst-Satzkorn, TryBot-Result-1 by Gopher Robot

cmd/dist/test: add debug logging to wasmtime


This is in an effort to help understand the wasmtime failure.

DO NOT MERGE

Change-Id: I96bf3debd8c9851270f48bc02ffe95ff15ec50a3
---
M misc/wasm/go_wasip1_wasm_exec
M src/cmd/dist/test.go
2 files changed, 7 insertions(+), 2 deletions(-)

To view, visit change 491855. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-MessageType: newpatchset
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: I96bf3debd8c9851270f48bc02ffe95ff15ec50a3
Gerrit-Change-Number: 491855
Gerrit-PatchSet: 2
Gerrit-Owner: Johan Brandhorst-Satzkorn <johan.br...@gmail.com>
Gerrit-Reviewer: Gopher Robot <go...@golang.org>
Gerrit-Reviewer: Johan Brandhorst-Satzkorn <johan.br...@gmail.com>
Gerrit-Attention: Johan Brandhorst-Satzkorn <johan.br...@gmail.com>

Johan Brandhorst-Satzkorn (Gerrit)

unread,
May 18, 2023, 12:47:52 AM5/18/23
to goph...@pubsubhelper.golang.org, Gopher Robot, golang-co...@googlegroups.com

Patch set 2:Run-TryBot +1Hold +1

View Change

1 comment:

To view, visit change 491855. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-MessageType: comment
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: I96bf3debd8c9851270f48bc02ffe95ff15ec50a3
Gerrit-Change-Number: 491855
Gerrit-PatchSet: 2
Gerrit-Owner: Johan Brandhorst-Satzkorn <johan.br...@gmail.com>
Gerrit-Reviewer: Gopher Robot <go...@golang.org>
Gerrit-Reviewer: Johan Brandhorst-Satzkorn <johan.br...@gmail.com>
Gerrit-Comment-Date: Thu, 18 May 2023 04:47:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes

Johan Brandhorst-Satzkorn (Gerrit)

unread,
May 18, 2023, 1:11:48 AM5/18/23
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com

Attention is currently required from: Johan Brandhorst-Satzkorn.

Johan Brandhorst-Satzkorn uploaded patch set #3 to this change.

View Change

The following approvals got outdated and were removed: Run-TryBot+1 by Johan Brandhorst-Satzkorn, TryBot-Result-1 by Gopher Robot

cmd/dist/test: add debug logging to wasmtime

This is in an effort to help understand the wasmtime failure.

DO NOT MERGE

Change-Id: I96bf3debd8c9851270f48bc02ffe95ff15ec50a3
---
M misc/wasm/go_wasip1_wasm_exec
M src/cmd/dist/test.go
2 files changed, 8 insertions(+), 3 deletions(-)

To view, visit change 491855. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-MessageType: newpatchset
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: I96bf3debd8c9851270f48bc02ffe95ff15ec50a3
Gerrit-Change-Number: 491855
Gerrit-PatchSet: 3
Gerrit-Owner: Johan Brandhorst-Satzkorn <johan.br...@gmail.com>
Gerrit-Reviewer: Gopher Robot <go...@golang.org>
Gerrit-Reviewer: Johan Brandhorst-Satzkorn <johan.br...@gmail.com>
Gerrit-Attention: Johan Brandhorst-Satzkorn <johan.br...@gmail.com>

Johan Brandhorst-Satzkorn (Gerrit)

unread,
May 18, 2023, 1:12:22 AM5/18/23
to goph...@pubsubhelper.golang.org, Gopher Robot, golang-co...@googlegroups.com

Patch set 3:Run-TryBot +1Hold +1

View Change

1 comment:

To view, visit change 491855. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-MessageType: comment
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: I96bf3debd8c9851270f48bc02ffe95ff15ec50a3
Gerrit-Change-Number: 491855
Gerrit-PatchSet: 3
Gerrit-Owner: Johan Brandhorst-Satzkorn <johan.br...@gmail.com>
Gerrit-Reviewer: Gopher Robot <go...@golang.org>
Gerrit-Reviewer: Johan Brandhorst-Satzkorn <johan.br...@gmail.com>
Gerrit-Comment-Date: Thu, 18 May 2023 05:12:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes

Johan Brandhorst-Satzkorn (Gerrit)

unread,
May 18, 2023, 1:18:56 AM5/18/23
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com

Attention is currently required from: Johan Brandhorst-Satzkorn.

Johan Brandhorst-Satzkorn uploaded patch set #4 to this change.

View Change

The following approvals got outdated and were removed: Run-TryBot+1 by Johan Brandhorst-Satzkorn, TryBot-Result-1 by Gopher Robot

cmd/dist/test: add debug logging to wasmtime

This is in an effort to help understand the wasmtime failure.

DO NOT MERGE

Change-Id: I96bf3debd8c9851270f48bc02ffe95ff15ec50a3
---
M misc/wasm/go_wasip1_wasm_exec
M src/cmd/dist/test.go
2 files changed, 8 insertions(+), 3 deletions(-)

To view, visit change 491855. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-MessageType: newpatchset
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: I96bf3debd8c9851270f48bc02ffe95ff15ec50a3
Gerrit-Change-Number: 491855
Gerrit-PatchSet: 4
Gerrit-Owner: Johan Brandhorst-Satzkorn <johan.br...@gmail.com>
Gerrit-Reviewer: Gopher Robot <go...@golang.org>
Gerrit-Reviewer: Johan Brandhorst-Satzkorn <johan.br...@gmail.com>
Gerrit-Attention: Johan Brandhorst-Satzkorn <johan.br...@gmail.com>

Johan Brandhorst-Satzkorn (Gerrit)

unread,
May 18, 2023, 1:19:16 AM5/18/23
to goph...@pubsubhelper.golang.org, Gopher Robot, golang-co...@googlegroups.com

Patch set 4:Run-TryBot +1Hold +1

View Change

1 comment:

To view, visit change 491855. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-MessageType: comment
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: I96bf3debd8c9851270f48bc02ffe95ff15ec50a3
Gerrit-Change-Number: 491855
Gerrit-PatchSet: 4
Gerrit-Owner: Johan Brandhorst-Satzkorn <johan.br...@gmail.com>
Gerrit-Reviewer: Gopher Robot <go...@golang.org>
Gerrit-Reviewer: Johan Brandhorst-Satzkorn <johan.br...@gmail.com>
Gerrit-Comment-Date: Thu, 18 May 2023 05:19:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes

Johan Brandhorst-Satzkorn (Gerrit)

unread,
May 18, 2023, 1:29:08 AM5/18/23
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com

Attention is currently required from: Johan Brandhorst-Satzkorn.

Johan Brandhorst-Satzkorn uploaded patch set #5 to this change.

View Change

The following approvals got outdated and were removed: Run-TryBot+1 by Johan Brandhorst-Satzkorn, TryBot-Result-1 by Gopher Robot

cmd/dist/test: add debug logging to wasmtime

This is in an effort to help understand the wasmtime failure.

DO NOT MERGE

Change-Id: I96bf3debd8c9851270f48bc02ffe95ff15ec50a3
---
M misc/wasm/go_wasip1_wasm_exec
M src/cmd/dist/test.go
M src/syscall/fs_wasip1.go
3 files changed, 9 insertions(+), 3 deletions(-)

To view, visit change 491855. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-MessageType: newpatchset
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: I96bf3debd8c9851270f48bc02ffe95ff15ec50a3
Gerrit-Change-Number: 491855
Gerrit-PatchSet: 5
Gerrit-Owner: Johan Brandhorst-Satzkorn <johan.br...@gmail.com>
Gerrit-Reviewer: Gopher Robot <go...@golang.org>
Gerrit-Reviewer: Johan Brandhorst-Satzkorn <johan.br...@gmail.com>
Gerrit-Attention: Johan Brandhorst-Satzkorn <johan.br...@gmail.com>

Johan Brandhorst-Satzkorn (Gerrit)

unread,
May 18, 2023, 1:29:25 AM5/18/23
to goph...@pubsubhelper.golang.org, Gopher Robot, golang-co...@googlegroups.com

Patch set 5:Run-TryBot +1Hold +1

View Change

1 comment:

To view, visit change 491855. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-MessageType: comment
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: I96bf3debd8c9851270f48bc02ffe95ff15ec50a3
Gerrit-Change-Number: 491855
Gerrit-PatchSet: 5
Gerrit-Owner: Johan Brandhorst-Satzkorn <johan.br...@gmail.com>
Gerrit-Reviewer: Gopher Robot <go...@golang.org>
Gerrit-Reviewer: Johan Brandhorst-Satzkorn <johan.br...@gmail.com>
Gerrit-Comment-Date: Thu, 18 May 2023 05:29:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes

Johan Brandhorst-Satzkorn (Gerrit)

unread,
May 28, 2023, 11:15:17 AM5/28/23
to goph...@pubsubhelper.golang.org, Gopher Robot, golang-co...@googlegroups.com

Johan Brandhorst-Satzkorn abandoned this change.

View Change

Abandoned

To view, visit change 491855. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-MessageType: abandon
Reply all
Reply to author
Forward
0 new messages