[sys] windows: drop arm
qiu laidongfeng (Gerrit)
qiu laidongfeng has uploaded the change for review![]( "Open in Gerrit")
Commit message
windows: drop arm
Fixes golang/go#71671
Change diff
diff --git a/windows/types_windows_arm.go b/windows/types_windows_arm.go
deleted file mode 100644
index 321872c..0000000
--- a/windows/types_windows_arm.go
+++ /dev/null
@@ -1,35 +0,0 @@
-// Copyright 2018 The Go Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style
-// license that can be found in the LICENSE file.
-
-package windows
-
-type WSAData struct {
- Version uint16
- HighVersion uint16
- Description [WSADESCRIPTION_LEN + 1]byte
- SystemStatus [WSASYS_STATUS_LEN + 1]byte
- MaxSockets uint16
- MaxUdpDg uint16
- VendorInfo *byte
-}
-
-type Servent struct {
- Name *byte
- Aliases **byte
- Port uint16
- Proto *byte
-}
-
-type JOBOBJECT_BASIC_LIMIT_INFORMATION struct {
- PerProcessUserTimeLimit int64
- PerJobUserTimeLimit int64
- LimitFlags uint32
- MinimumWorkingSetSize uintptr
- MaximumWorkingSetSize uintptr
- ActiveProcessLimit uint32
- Affinity uintptr
- PriorityClass uint32
- SchedulingClass uint32
- _ uint32 // pad to 8 byte boundary
-}
Change information
- D windows/types_windows_arm.go
Related details
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
qiu laidongfeng (Gerrit)
qiu laidongfeng voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Cherry Mui (Gerrit)
Cherry Mui added 1 comment![]( "Open in Gerrit")
In theory x/sys supports all supported versions of Go, which are Go 1.24 and later, when Go 1.25 is released. Perhaps we want to delay this until Go 1.24 is end of support?
However, if the port is too broken and it never works, perhaps it is fine to do now?
Related details
- Alex Brainman
- Brad Fitzpatrick
- Dmitri Shuralyov
- Quim Muntal
- qiu laidongfeng
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dmitri Shuralyov (Gerrit)
Dmitri Shuralyov added 1 comment![]( "Open in Gerrit")
In theory x/sys supports all supported versions of Go, which are Go 1.24 and later, when Go 1.25 is released. Perhaps we want to delay this until Go 1.24 is end of support?
However, if the port is too broken and it never works, perhaps it is fine to do now?
Since Go 1.25 is the last release that contains the broken windows/arm port, and the port is removed in Go 1.26, perhaps for now we should add a `//go:build !go1.26` constraint here? (Later on, once Go 1.27.0 is released and the go.mod's go directive is bumped up to 1.26.0, this file will be a no-op and can be deleted.)
Related details
- Alex Brainman
- Brad Fitzpatrick
- Quim Muntal
- qiu laidongfeng
Dmitri Shuralyov (Gerrit)
Dmitri Shuralyov added 1 comment![]( "Open in Gerrit")
@26454...@qq.com Friendly ping. Are you able to resolve the remaining open thread? Thanks.
qiu laidongfeng (Gerrit)
qiu laidongfeng added 1 comment![]( "Open in Gerrit")
Dmitri ShuralyovIn theory x/sys supports all supported versions of Go, which are Go 1.24 and later, when Go 1.25 is released. Perhaps we want to delay this until Go 1.24 is end of support?
However, if the port is too broken and it never works, perhaps it is fine to do now?
Since Go 1.25 is the last release that contains the broken windows/arm port, and the port is removed in Go 1.26, perhaps for now we should add a `//go:build !go1.26` constraint here? (Later on, once Go 1.27.0 is released and the go.mod's go directive is bumped up to 1.26.0, this file will be a no-op and can be deleted.)
Sorry for delay response. Recently, many things have taken up my time. I think it would be simpler to sumbit this CL when go1.27 released.
Note: that cmd/go only matches known GOOS/GOARCH to build，and set windows/arm，go build output unspported GOOS/GOARCH pair window/arm，even if no hava build tag,the file will ignore.
Related details
- Cherry Mui
- Dmitri Shuralyov
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dmitri Shuralyov (Gerrit)
Dmitri Shuralyov voted and added 2 comments![]( "Open in Gerrit")
Votes added by Dmitri Shuralyov
| Code-Review | +2 |
| Hold | +1 |
2 comments
Dmitri ShuralyovIn theory x/sys supports all supported versions of Go, which are Go 1.24 and later, when Go 1.25 is released. Perhaps we want to delay this until Go 1.24 is end of support?
However, if the port is too broken and it never works, perhaps it is fine to do now?
qiu laidongfengSince Go 1.25 is the last release that contains the broken windows/arm port, and the port is removed in Go 1.26, perhaps for now we should add a `//go:build !go1.26` constraint here? (Later on, once Go 1.27.0 is released and the go.mod's go directive is bumped up to 1.26.0, this file will be a no-op and can be deleted.)
Sorry for delay response. Recently, many things have taken up my time. I think it would be simpler to sumbit this CL when go1.27 released.
Note: that cmd/go only matches known GOOS/GOARCH to build，and set windows/arm，go build output unspported GOOS/GOARCH pair window/arm，even if no hava build tag,the file will ignore.
Sounds good, let's leave this for when Go 1.27 is released then.
Related details
Code-Review
No-Holds
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dmitri Shuralyov (Gerrit)
Dmitri Shuralyov voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Code-Review
No-Holds
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |