[website] _content/doc/gc-guide: clarify space/time tradeoff example
4 views
Skip to first unread message
Michael Knyszek (Gerrit)
Nov 3, 2025, 1:55:08 PM (3 days ago) Nov 3
to goph...@pubsubhelper.golang.org, Cherry Mui, golang-co...@googlegroups.com
Attention needed from Cherry Mui
Michael Knyszek voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Cherry Mui
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Cherry Mui (Gerrit)
Nov 3, 2025, 6:19:03 PM (2 days ago) Nov 3
to Michael Knyszek, goph...@pubsubhelper.golang.org, Go LUCI, golang-co...@googlegroups.com
Attention needed from Michael Knyszek
Cherry Mui voted and added 1 comment![]( "Open in Gerrit")
Votes added by Cherry Mui
| Code-Review | +2 |
1 comment
File _content/doc/gc-guide.html
Line 387, Patchset 1 (Latest):
Recall that the GC's only needs to walk the live heap, not the whole heap.Cherry Mui . unresolved
Remove `'s`?
Related details
Attention is currently required from:
- Michael Knyszek
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Knyszek (Gerrit)
Nov 3, 2025, 6:25:45 PM (2 days ago) Nov 3
to goph...@pubsubhelper.golang.org, Cherry Mui, Go LUCI, golang-co...@googlegroups.com
Michael Knyszek voted and added 1 comment![]( "Open in Gerrit")
Votes added by Michael Knyszek
| Auto-Submit | +1 |
| Commit-Queue | +1 |
1 comment
File _content/doc/gc-guide.html
Line 387, Patchset 1:
Recall that the GC's only needs to walk the live heap, not the whole heap.Cherry Mui . resolved
Michael KnyszekRemove `'s`?
Done
Related details
Attention set is empty
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gopher Robot (Gerrit)
Nov 3, 2025, 6:35:40 PM (2 days ago) Nov 3
to Michael Knyszek, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Go LUCI, Cherry Mui, golang-co...@googlegroups.com
Gopher Robot submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
1 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: _content/doc/gc-guide.html
Insertions: 1, Deletions: 1.
@@ -384,7 +384,7 @@
10 MiB of additional memory, resulting in a 20 MiB total heap size.
And with every GC cycle, the GC will spend 0.1 cpu-seconds scanning the
10 MiB live heap, resulting in a 10% CPU overhead.
-Recall that the GC's only needs to walk the live heap, not the whole heap.
+Recall that the GC only needs to walk the live heap, not the whole heap.
(Note: a constant live heap does not mean that all newly allocated memory is
dead.
It means that, after the GC runs, <i>some mix</i> of old and new heap memory
```
Change information
Commit message:
_content/doc/gc-guide: clarify space/time tradeoff example
Based on suggestions from #76147.
Fixes #76147.
Change-Id: I297b120c08ae760b148574b29aa21dba2699f7d6
Reviewed-by: Cherry Mui <cher...@google.com>
LUCI-TryBot-Result: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Michael Knyszek <mkny...@google.com>
Files:
- M _content/doc/gc-guide.html
Change size: S
Delta: 1 file changed, 22 insertions(+), 14 deletions(-)
Branch: refs/heads/master
Submit Requirements:
Code-Review: +2 by Cherry Mui
TryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages