[build] devapp/owners: add rsc as owner of x/oscar

0 views
Skip to first unread message

Than McIntosh (Gerrit)

unread,
5:31 PM (4 hours ago) 5:31 PM
to goph...@pubsubhelper.golang.org, Than McIntosh, golang-co...@googlegroups.com

Than McIntosh has uploaded the change for review

Commit message

devapp/owners: add rsc as owner of x/oscar
Change-Id: I205ec67c50a303b60220c709e3c5f9687b7fa491

Change diff

diff --git a/devapp/owners/table.go b/devapp/owners/table.go
index 0c490be..1295235 100644
--- a/devapp/owners/table.go
+++ b/devapp/owners/table.go
@@ -796,6 +796,9 @@
 	"oauth2": {
 		Secondary: []Owner{jbd, shinfan, codyoss},
 	},
+	"oscar": {
+		Primary: []Owner{rsc},
+	},
 	"perf": {
 		Primary: []Owner{runtimeTeam, releaseTeam},
 	},

Change information

Files:
  • M devapp/owners/table.go
Change size: XS
Delta: 1 file changed, 3 insertions(+), 0 deletions(-)
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: build
Gerrit-Branch: master
Gerrit-Change-Id: I205ec67c50a303b60220c709e3c5f9687b7fa491
Gerrit-Change-Number: 596477
Gerrit-PatchSet: 1
Gerrit-Owner: Than McIntosh <th...@google.com>
unsatisfied_requirement
satisfied_requirement
open
diffy

Than McIntosh (Gerrit)

unread,
5:31 PM (4 hours ago) 5:31 PM
to Than McIntosh, goph...@pubsubhelper.golang.org, Dmitri Shuralyov, Russ Cox, golang-co...@googlegroups.com
Attention needed from Dmitri Shuralyov

Than McIntosh voted

Auto-Submit+1
Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Dmitri Shuralyov
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: build
Gerrit-Branch: master
Gerrit-Change-Id: I205ec67c50a303b60220c709e3c5f9687b7fa491
Gerrit-Change-Number: 596477
Gerrit-PatchSet: 1
Gerrit-Owner: Than McIntosh <th...@google.com>
Gerrit-Reviewer: Dmitri Shuralyov <dmit...@golang.org>
Gerrit-Reviewer: Than McIntosh <th...@google.com>
Gerrit-CC: Russ Cox <r...@golang.org>
Gerrit-Attention: Dmitri Shuralyov <dmit...@golang.org>
Gerrit-Comment-Date: Wed, 03 Jul 2024 21:31:52 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
unsatisfied_requirement
satisfied_requirement
open
diffy

Dmitri Shuralyov (Gerrit)

unread,
5:33 PM (4 hours ago) 5:33 PM
to Than McIntosh, goph...@pubsubhelper.golang.org, Dmitri Shuralyov, Go LUCI, Russ Cox, golang-co...@googlegroups.com
Attention needed from Than McIntosh

Dmitri Shuralyov voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Than McIntosh
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: build
Gerrit-Branch: master
Gerrit-Change-Id: I205ec67c50a303b60220c709e3c5f9687b7fa491
Gerrit-Change-Number: 596477
Gerrit-PatchSet: 1
Gerrit-Owner: Than McIntosh <th...@google.com>
Gerrit-Reviewer: Dmitri Shuralyov <dmit...@golang.org>
Gerrit-Reviewer: Dmitri Shuralyov <dmit...@google.com>
Gerrit-Reviewer: Than McIntosh <th...@google.com>
Gerrit-CC: Russ Cox <r...@golang.org>
Gerrit-Attention: Than McIntosh <th...@google.com>
Gerrit-Comment-Date: Wed, 03 Jul 2024 21:32:55 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Dmitri Shuralyov (Gerrit)

unread,
5:33 PM (4 hours ago) 5:33 PM
to Than McIntosh, goph...@pubsubhelper.golang.org, Dmitri Shuralyov, Go LUCI, Russ Cox, golang-co...@googlegroups.com
Attention needed from Than McIntosh

Dmitri Shuralyov voted and added 1 comment

Votes added by Dmitri Shuralyov

Code-Review+2

1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Dmitri Shuralyov . resolved

Thanks.

Open in Gerrit

Related details

Attention is currently required from:
  • Than McIntosh
Submit Requirements:
    • requirement satisfiedCode-Review
    • requirement satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    • requirement is not satisfiedTryBots-Pass
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: build
    Gerrit-Branch: master
    Gerrit-Change-Id: I205ec67c50a303b60220c709e3c5f9687b7fa491
    Gerrit-Change-Number: 596477
    Gerrit-PatchSet: 1
    Gerrit-Owner: Than McIntosh <th...@google.com>
    Gerrit-Reviewer: Dmitri Shuralyov <dmit...@golang.org>
    Gerrit-Reviewer: Than McIntosh <th...@google.com>
    Gerrit-CC: Russ Cox <r...@golang.org>
    Gerrit-Attention: Than McIntosh <th...@google.com>
    Gerrit-Comment-Date: Wed, 03 Jul 2024 21:32:48 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Gopher Robot (Gerrit)

    unread,
    5:44 PM (4 hours ago) 5:44 PM
    to Than McIntosh, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Go LUCI, Dmitri Shuralyov, Dmitri Shuralyov, Russ Cox, golang-co...@googlegroups.com

    Gopher Robot submitted the change

    Change information

    Commit message:
    devapp/owners: add rsc as owner of x/oscar
    Change-Id: I205ec67c50a303b60220c709e3c5f9687b7fa491
    Reviewed-by: Dmitri Shuralyov <dmit...@google.com>
    Reviewed-by: Dmitri Shuralyov <dmit...@golang.org>
    Auto-Submit: Than McIntosh <th...@google.com>
    Files:
    • M devapp/owners/table.go
    Change size: XS
    Delta: 1 file changed, 3 insertions(+), 0 deletions(-)
    Branch: refs/heads/master
    Submit Requirements:
    • requirement satisfiedCode-Review: +2 by Dmitri Shuralyov, +1 by Dmitri Shuralyov
    • requirement satisfiedTryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: build
    Gerrit-Branch: master
    Gerrit-Change-Id: I205ec67c50a303b60220c709e3c5f9687b7fa491
    Gerrit-Change-Number: 596477
    Gerrit-PatchSet: 2
    Gerrit-Owner: Than McIntosh <th...@google.com>
    Gerrit-Reviewer: Dmitri Shuralyov <dmit...@golang.org>
    Gerrit-Reviewer: Dmitri Shuralyov <dmit...@google.com>
    Gerrit-Reviewer: Gopher Robot <go...@golang.org>
    Gerrit-Reviewer: Than McIntosh <th...@google.com>
    Gerrit-CC: Russ Cox <r...@golang.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages