[net] http2: initialize Transport on NewClientConn
2 views
Skip to first unread message
Damien Neil (Gerrit)
12:47 AM (22 hours ago) 12:47 AM
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Damien Neil voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention set is empty
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Damien Neil (Gerrit)
11:21 AM (11 hours ago) 11:21 AM
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Attention needed from Nicholas Husin and Tom Bergan
Damien Neil uploaded new patchset![]( "Open in Gerrit")
Damien Neil uploaded patch set #2 to this change.
Related details
Attention is currently required from:
- Nicholas Husin
- Tom Bergan
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Damien Neil (Gerrit)
11:21 AM (11 hours ago) 11:21 AM
to goph...@pubsubhelper.golang.org, Tom Bergan, Nicholas Husin, Gopher Robot, golang...@luci-project-accounts.iam.gserviceaccount.com, golang-co...@googlegroups.com
Attention needed from Nicholas Husin
Damien Neil removed Tom Bergan from this change![]( "Open in Gerrit")
Deleted Reviewers:
- Tom Bergan
Related details
Attention is currently required from:
- Nicholas Husin
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nicholas Husin (Gerrit)
2:54 PM (8 hours ago) 2:54 PM
to Damien Neil, goph...@pubsubhelper.golang.org, Gopher Robot, golang...@luci-project-accounts.iam.gserviceaccount.com, golang-co...@googlegroups.com
Attention needed from Damien Neil
Nicholas Husin voted Code-Review+2![]( "Open in Gerrit")
Attention is currently required from:
- Damien Neil
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nicholas Husin (Gerrit)
2:54 PM (8 hours ago) 2:54 PM
to Damien Neil, goph...@pubsubhelper.golang.org, Nicholas Husin, Gopher Robot, golang...@luci-project-accounts.iam.gserviceaccount.com, golang-co...@googlegroups.com
Attention needed from Damien Neil
Nicholas Husin voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Damien Neil
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Russ Cox (Gerrit)
3:16 PM (7 hours ago) 3:16 PM
to Damien Neil, goph...@pubsubhelper.golang.org, Russ Cox, Nicholas Husin, Nicholas Husin, Gopher Robot, golang...@luci-project-accounts.iam.gserviceaccount.com, golang-co...@googlegroups.com
Attention needed from Damien Neil
Russ Cox added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 2 (Latest):
Russ Cox . unresolved
It should be possible to at least write a test like in the bug report, declaring and using a zeroed Transport?
Related details
Attention is currently required from:
- Damien Neil
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Damien Neil (Gerrit)
4:51 PM (6 hours ago) 4:51 PM
to goph...@pubsubhelper.golang.org, Russ Cox, Nicholas Husin, Nicholas Husin, Gopher Robot, golang...@luci-project-accounts.iam.gserviceaccount.com, golang-co...@googlegroups.com
Attention needed from Russ Cox
Damien Neil voted and added 1 comment![]( "Open in Gerrit")
Votes added by Damien Neil
| Auto-Submit | +1 |
1 comment
Patchset-level comments
Russ Cox . resolved
It should be possible to at least write a test like in the bug report, declaring and using a zeroed Transport?
Damien Neil
A zeroed Transport is actually impossible to test hermetically, since it'll only use TLS and will validate server certificates.
I can write a test that exercises the bug with a modified Transport that either uses TCP or doesn't validate the server certificate. This should probably be several tests, exercising other functions than just NewClientConn. And then I've got to figure out where to draw the line between these tests and the existing, fairly comprehensive, test suite.
I'll see if I can find something reasonable to add in a followup, submitting this since I don't want to block fixing the actual bug on finding perfection in testing.
Related details
Attention is currently required from:
- Russ Cox
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gopher Robot (Gerrit)
4:52 PM (6 hours ago) 4:52 PM
to Damien Neil, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Russ Cox, Nicholas Husin, Nicholas Husin, golang...@luci-project-accounts.iam.gserviceaccount.com, golang-co...@googlegroups.com
Gopher Robot submitted the change![]( "Open in Gerrit")
Change information
Commit message:
http2: initialize Transport on NewClientConn
Add a missing init call in the NewClientConn path.
Missing init calls are hard to write a test for, since the
Transport test infrastructure causes the Transport to be
initialized before the test begins. So instead, make it harder
to forget the call: init now returns the net/http *Transport,
so code which uses it needs to call init to get it.
Fixes golang/go#80198
Change-Id: Ib6465b863bb0be3cd3d02d9c1bb349526a6a6964
Reviewed-on: https://go-review.googlesource.com/c/net/+/795600
LUCI-TryBot-Result: golang...@luci-project-accounts.iam.gserviceaccount.com <golang...@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Nicholas Husin <n...@golang.org>
Auto-Submit: Damien Neil <dn...@google.com>
Reviewed-by: Nicholas Husin <hu...@google.com>
Files:
- M http2/export_wrap_test.go
- M http2/transport_wrap.go
Change size: S
Delta: 2 files changed, 14 insertions(+), 13 deletions(-)
Branch: refs/heads/master
Submit Requirements:
Code-Review: +2 by Nicholas Husin, +1 by Nicholas Husin
TryBots-Pass: LUCI-TryBot-Result+1 by golang...@luci-project-accounts.iam.gserviceaccount.com
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages