[exp] event: replace deprecated reflect.StringHeader
1 view
Skip to first unread message
Florian Lehner (Gerrit)
5:02 AM (10 hours ago) 5:02 AM
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Florian Lehner has uploaded the change for review![]( "Open in Gerrit")
Commit message
event: replace deprecated reflect.StringHeader
reflect.StringHeader was declared deprecated with Go 1.21. Replace its
use with functionality from package unsafe.
Change-Id: I7007de5d850c4f38eb1f7904ba55009e5a223745
Change diff
diff --git a/event/label.go b/event/label.go
index 57307cc..1237c3d 100644
--- a/event/label.go
+++ b/event/label.go
@@ -103,8 +103,7 @@
// String returns a new Value for a string.
func String(name string, s string) Label {
- hdr := (*reflect.StringHeader)(unsafe.Pointer(&s))
- return Label{Name: name, packed: uint64(hdr.Len), untyped: stringptr(hdr.Data)}
+ return Label{Name: name, packed: uint64(len(s)), untyped: stringptr(unsafe.StringData(s))}
}
// String returns the value as a string.
@@ -112,11 +111,7 @@
// representation of the value in all cases.
func (v Label) String() string {
if sp, ok := v.untyped.(stringptr); ok {
- var s string
- hdr := (*reflect.StringHeader)(unsafe.Pointer(&s))
- hdr.Data = uintptr(sp)
- hdr.Len = int(v.packed)
- return s
+ return unsafe.String((*byte)(unsafe.Pointer(sp)), int(v.packed))
}
// not a string, convert to one
switch {
Change information
Files:
- M event/label.go
Change size: XS
Delta: 1 file changed, 2 insertions(+), 7 deletions(-)
Related details
Attention set is empty
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Sean Liao (Gerrit)
7:50 AM (7 hours ago) 7:50 AM
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Attention needed from Florian Lehner
Sean Liao voted![]( "Open in Gerrit")
| Auto-Submit | +1 |
| Code-Review | +2 |
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Florian Lehner
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages