[go] net: avoid wrapping io.EOF in UnixConn read methods

[Basavaraj P (Gerrit)]

Basavaraj P has uploaded the change for review

Commit message

net: avoid wrapping io.EOF in UnixConn read methods

The io.Reader contract requires that Read methods return io.EOF
directly instead of wrapping it in another error.

Currently UnixConn.ReadFromUnix, ReadFrom, and ReadMsgUnix wrap
io.EOF inside net.OpError, causing callers checking for io.EOF
to fail.

Fix by avoiding wrapping when err == io.EOF.

Fixes #78137

Change-Id: Ibb4e67cfb4c727c668ad79d1fb9e205f9b7e1903

Change diff

diff --git a/src/net/unixsock.go b/src/net/unixsock.go
index 0ee79f3..d1bf1d3 100644
--- a/src/net/unixsock.go
+++ b/src/net/unixsock.go
@@ -108,7 +108,7 @@
 		return 0, nil, syscall.EINVAL
 	}
 	n, addr, err := c.readFrom(b)
-	if err != nil {
+	if err != nil && err != io.EOF {
 		err = &OpError{Op: "read", Net: c.fd.net, Source: c.fd.laddr, Addr: c.fd.raddr, Err: err}
 	}
 	return n, addr, err
@@ -120,7 +120,7 @@
 		return 0, nil, syscall.EINVAL
 	}
 	n, addr, err := c.readFrom(b)
-	if err != nil {
+	if err != nil && err != io.EOF {
 		err = &OpError{Op: "read", Net: c.fd.net, Source: c.fd.laddr, Addr: c.fd.raddr, Err: err}
 	}
 	if addr == nil {
@@ -141,7 +141,7 @@
 		return 0, 0, 0, nil, syscall.EINVAL
 	}
 	n, oobn, flags, addr, err = c.readMsg(b, oob)
-	if err != nil {
+	if err != nil && err != io.EOF {
 		err = &OpError{Op: "read", Net: c.fd.net, Source: c.fd.laddr, Addr: c.fd.raddr, Err: err}
 	}
 	return

Change information

Files:

• M src/net/unixsock.go

Change size: XS

Delta: 1 file changed, 3 insertions(+), 3 deletions(-)

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

• Code-Review
• No-Unresolved-Comments
• Review-Enforcement
• TryBots-Pass

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: newchange

Gerrit-Project: go

Gerrit-Branch: master

Gerrit-Change-Id: Ibb4e67cfb4c727c668ad79d1fb9e205f9b7e1903

Gerrit-Change-Number: 754960

Gerrit-PatchSet: 1

Gerrit-Owner: Basavaraj P <basavaraj...@gmail.com>

[qiu laidongfeng (Gerrit)]

Attention needed from Basavaraj P, Damien Neil and Ian Lance Taylor

qiu laidongfeng voted Commit-Queue+1

Commit-Queue

+1

Open in Gerrit

Related details

Attention is currently required from:

• Basavaraj P
• Damien Neil
• Ian Lance Taylor

Submit Requirements:

• Code-Review
• No-Unresolved-Comments
• Review-Enforcement
• TryBots-Pass

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: go

Gerrit-Branch: master

Gerrit-Change-Id: Ibb4e67cfb4c727c668ad79d1fb9e205f9b7e1903

Gerrit-Change-Number: 754960

Gerrit-PatchSet: 1

Gerrit-Owner: Basavaraj P <basavaraj...@gmail.com>

Gerrit-Reviewer: Damien Neil <dn...@google.com>

Gerrit-Reviewer: Ian Lance Taylor <ia...@golang.org>

Gerrit-Reviewer: qiu laidongfeng <26454...@qq.com>

Gerrit-CC: Gopher Robot <go...@golang.org>

Gerrit-Attention: Ian Lance Taylor <ia...@golang.org>

Gerrit-Attention: Damien Neil <dn...@google.com>

Gerrit-Attention: Basavaraj P <basavaraj...@gmail.com>

Gerrit-Comment-Date: Fri, 13 Mar 2026 06:40:57 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Ian Lance Taylor (Gerrit)]

Attention needed from Basavaraj P, Damien Neil and qiu laidongfeng

Ian Lance Taylor added 1 comment

Patchset-level comments

File-level comment, Patchset 1 (Latest):

Ian Lance Taylor . resolved

A change like this should have a test case. It also needs a release note. Thanks.

Open in Gerrit

Related details

Attention is currently required from:

• Basavaraj P
• Damien Neil
• qiu laidongfeng

Submit Requirements:

• Code-Review
• No-Unresolved-Comments
• Review-Enforcement
• TryBots-Pass

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: go

Gerrit-Branch: master

Gerrit-Change-Id: Ibb4e67cfb4c727c668ad79d1fb9e205f9b7e1903

Gerrit-Change-Number: 754960

Gerrit-PatchSet: 1

Gerrit-Owner: Basavaraj P <basavaraj...@gmail.com>

Gerrit-Reviewer: Damien Neil <dn...@google.com>

Gerrit-Reviewer: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Reviewer: Ian Lance Taylor <ia...@golang.org>

Gerrit-Reviewer: qiu laidongfeng <26454...@qq.com>

Gerrit-CC: Gopher Robot <go...@golang.org>

Gerrit-Attention: qiu laidongfeng <26454...@qq.com>

Gerrit-Attention: Damien Neil <dn...@google.com>

Gerrit-Attention: Basavaraj P <basavaraj...@gmail.com>

Gerrit-Comment-Date: Fri, 13 Mar 2026 06:59:17 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Basavaraj P (Gerrit)]

Attention needed from Basavaraj P, Damien Neil and qiu laidongfeng

Basavaraj P uploaded new patchset

Basavaraj P uploaded patch set #2 to this change.

Following approvals got outdated and were removed:

• TryBots-Pass: LUCI-TryBot-Result-1 by Go LUCI

Open in Gerrit

Related details

Attention is currently required from:

• Basavaraj P
• Damien Neil
• qiu laidongfeng

Submit Requirements:

• Code-Review
• No-Unresolved-Comments
• Review-Enforcement
• TryBots-Pass

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: newpatchset

Gerrit-Project: go

Gerrit-Branch: master

Gerrit-Change-Id: Ibb4e67cfb4c727c668ad79d1fb9e205f9b7e1903

Gerrit-Change-Number: 754960

Gerrit-PatchSet: 2

[Nicholas Husin (Gerrit)]

Attention needed from Basavaraj P, Damien Neil and qiu laidongfeng

Nicholas Husin added 1 comment

File src/net/unixsock_eof_test.go

Line 1, Patchset 2 (Latest):func TestUnixConnReadMsgUnixEOF(t *testing.T) {


Nicholas Husin . unresolved

Thanks for the CL!

I don't think we need a new dedicated test file here. Let's just put this in `net/unixsock_test.go`.

Also, let's exercise all the `Read` methods in the test rather than just `ReadMsgUnix`.

Open in Gerrit

Related details

Attention is currently required from:

• Basavaraj P
• Damien Neil
• qiu laidongfeng

Submit Requirements:

• Code-Review

• No-Unresolved-Comments

• Review-Enforcement
• TryBots-Pass

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: go

Gerrit-Branch: master

Gerrit-Change-Id: Ibb4e67cfb4c727c668ad79d1fb9e205f9b7e1903

Gerrit-Change-Number: 754960

Gerrit-PatchSet: 2

Gerrit-Owner: Basavaraj P <basavaraj...@gmail.com>

Gerrit-Reviewer: Damien Neil <dn...@google.com>

Gerrit-Reviewer: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Reviewer: Ian Lance Taylor <ia...@golang.org>

Gerrit-Reviewer: qiu laidongfeng <26454...@qq.com>

Gerrit-CC: Gopher Robot <go...@golang.org>

Gerrit-CC: Nicholas Husin <n...@golang.org>

Gerrit-Attention: qiu laidongfeng <26454...@qq.com>

Gerrit-Attention: Damien Neil <dn...@google.com>

Gerrit-Attention: Basavaraj P <basavaraj...@gmail.com>

Gerrit-Comment-Date: Mon, 16 Mar 2026 21:00:05 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Basavaraj P (Gerrit)]

Attention needed from Basavaraj P, Damien Neil and qiu laidongfeng

Basavaraj P uploaded new patchset

Basavaraj P uploaded patch set #3 to this change.

Open in Gerrit

Related details

Attention is currently required from:

• Basavaraj P
• Damien Neil
• qiu laidongfeng

Submit Requirements:

• Code-Review
• No-Unresolved-Comments
• Review-Enforcement
• TryBots-Pass

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: newpatchset

Gerrit-Project: go

Gerrit-Branch: master

Gerrit-Change-Id: Ibb4e67cfb4c727c668ad79d1fb9e205f9b7e1903

Gerrit-Change-Number: 754960

Gerrit-PatchSet: 3

[Basavaraj P (Gerrit)]

Attention needed from Damien Neil, Nicholas Husin and qiu laidongfeng

Basavaraj P added 1 comment

File src/net/unixsock_eof_test.go

Line 1, Patchset 2:func TestUnixConnReadMsgUnixEOF(t *testing.T) {


Nicholas Husin . resolved

Thanks for the CL!

I don't think we need a new dedicated test file here. Let's just put this in `net/unixsock_test.go`.

Also, let's exercise all the `Read` methods in the test rather than just `ReadMsgUnix`.

Basavaraj P

Marked as resolved.

Open in Gerrit

Related details

Attention is currently required from:

• Damien Neil
• Nicholas Husin
• qiu laidongfeng

Submit Requirements:

• Code-Review

• No-Unresolved-Comments

• Review-Enforcement
• TryBots-Pass

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: go

Gerrit-Branch: master

Gerrit-Change-Id: Ibb4e67cfb4c727c668ad79d1fb9e205f9b7e1903

Gerrit-Change-Number: 754960

Gerrit-PatchSet: 3

Gerrit-Owner: Basavaraj P <basavaraj...@gmail.com>

Gerrit-Reviewer: Damien Neil <dn...@google.com>

Gerrit-Reviewer: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Reviewer: Ian Lance Taylor <ia...@golang.org>

Gerrit-Reviewer: qiu laidongfeng <26454...@qq.com>

Gerrit-CC: Gopher Robot <go...@golang.org>

Gerrit-CC: Nicholas Husin <n...@golang.org>

Gerrit-Attention: qiu laidongfeng <26454...@qq.com>

Gerrit-Attention: Damien Neil <dn...@google.com>

Gerrit-Attention: Nicholas Husin <n...@golang.org>

Gerrit-Comment-Date: Tue, 17 Mar 2026 05:55:34 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Nicholas Husin <n...@golang.org>

[Basavaraj P (Gerrit)]

Attention needed from Damien Neil, Nicholas Husin and qiu laidongfeng

Basavaraj P uploaded new patchset

Basavaraj P uploaded patch set #4 to this change.

Open in Gerrit

Related details

Attention is currently required from:

• Damien Neil
• Nicholas Husin
• qiu laidongfeng

Submit Requirements:

• Code-Review
• No-Unresolved-Comments
• Review-Enforcement
• TryBots-Pass

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: newpatchset

Gerrit-Project: go

Gerrit-Branch: master

Gerrit-Change-Id: Ibb4e67cfb4c727c668ad79d1fb9e205f9b7e1903

Gerrit-Change-Number: 754960

Gerrit-PatchSet: 4

[Basavaraj P (Gerrit)]

Attention needed from Damien Neil, Nicholas Husin and qiu laidongfeng

Basavaraj P added 1 comment

Patchset-level comments

File-level comment, Patchset 4 (Latest):

Basavaraj P . resolved

src/go.mod and src/make.bash were accidentally deleted in the patchset 3.
Restored them in this patchset.

Open in Gerrit

Related details

Attention is currently required from:

• Damien Neil
• Nicholas Husin
• qiu laidongfeng

Submit Requirements:

• Code-Review
• No-Unresolved-Comments
• Review-Enforcement
• TryBots-Pass

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: go

Gerrit-Branch: master

Gerrit-Change-Id: Ibb4e67cfb4c727c668ad79d1fb9e205f9b7e1903

Gerrit-Change-Number: 754960

Gerrit-PatchSet: 4

Gerrit-Owner: Basavaraj P <basavaraj...@gmail.com>

Gerrit-Reviewer: Damien Neil <dn...@google.com>

Gerrit-Reviewer: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Reviewer: Ian Lance Taylor <ia...@golang.org>

Gerrit-Reviewer: qiu laidongfeng <26454...@qq.com>

Gerrit-CC: Gopher Robot <go...@golang.org>

Gerrit-CC: Nicholas Husin <n...@golang.org>

Gerrit-Attention: qiu laidongfeng <26454...@qq.com>

Gerrit-Attention: Damien Neil <dn...@google.com>

Gerrit-Attention: Nicholas Husin <n...@golang.org>

Gerrit-Comment-Date: Tue, 17 Mar 2026 06:08:58 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Ian Lance Taylor (Gerrit)]

Attention needed from Basavaraj P, Damien Neil, Nicholas Husin and qiu laidongfeng

Ian Lance Taylor voted and added 2 comments

Votes added by Ian Lance Taylor

Commit-Queue

+1

2 comments

File doc/next/78137.md

Line 1, Patchset 4 (Latest):net: UnixConn read methods now return io.EOF directly instead of wrapping it in net.OpError when the underlying read reaches EOF.

Ian Lance Taylor . unresolved

Add a line break.
s/reaches EOF/returns EOF/

File src/net/unixsock_test.go

Line 488, Patchset 4 (Latest): switch runtime.GOOS {

Ian Lance Taylor . unresolved

It's not necessarily a problem for this CL but it's kind of weird that this switch is not handled by testableNetwork. Or, more specifically, supportsUnixSocket.

Open in Gerrit

Related details

Attention is currently required from:

• Basavaraj P

• Damien Neil
• Nicholas Husin
• qiu laidongfeng

Submit Requirements:

• Code-Review

• No-Unresolved-Comments

• Review-Enforcement
• TryBots-Pass

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: go

Gerrit-Branch: master

Gerrit-Change-Id: Ibb4e67cfb4c727c668ad79d1fb9e205f9b7e1903

Gerrit-Change-Number: 754960

Gerrit-PatchSet: 4

Gerrit-Owner: Basavaraj P <basavaraj...@gmail.com>

Gerrit-Reviewer: Damien Neil <dn...@google.com>

Gerrit-Reviewer: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Reviewer: Ian Lance Taylor <ia...@golang.org>

Gerrit-Reviewer: qiu laidongfeng <26454...@qq.com>

Gerrit-CC: Gopher Robot <go...@golang.org>

Gerrit-CC: Nicholas Husin <n...@golang.org>

Gerrit-Attention: qiu laidongfeng <26454...@qq.com>

Gerrit-Attention: Damien Neil <dn...@google.com>

Gerrit-Attention: Nicholas Husin <n...@golang.org>

Gerrit-Attention: Basavaraj P <basavaraj...@gmail.com>

Gerrit-Comment-Date: Tue, 17 Mar 2026 07:59:23 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Basavaraj P (Gerrit)]

Attention needed from Basavaraj P, Damien Neil, Ian Lance Taylor, Nicholas Husin and qiu laidongfeng

Basavaraj P uploaded new patchset

Basavaraj P uploaded patch set #5 to this change.

Following approvals got outdated and were removed:

• TryBots-Pass: LUCI-TryBot-Result-1 by Go LUCI

Open in Gerrit

Related details

Attention is currently required from:

• Basavaraj P
• Damien Neil
• Ian Lance Taylor
• Nicholas Husin
• qiu laidongfeng

Submit Requirements:

• Code-Review
• No-Unresolved-Comments
• Review-Enforcement
• TryBots-Pass

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: newpatchset

Gerrit-Project: go

Gerrit-Branch: master

Gerrit-Change-Id: Ibb4e67cfb4c727c668ad79d1fb9e205f9b7e1903

Gerrit-Change-Number: 754960

Gerrit-PatchSet: 5

Gerrit-Owner: Basavaraj P <basavaraj...@gmail.com>

Gerrit-Reviewer: Damien Neil <dn...@google.com>

Gerrit-Reviewer: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Reviewer: Ian Lance Taylor <ia...@golang.org>

Gerrit-Reviewer: qiu laidongfeng <26454...@qq.com>

Gerrit-CC: Gopher Robot <go...@golang.org>

Gerrit-CC: Nicholas Husin <n...@golang.org>

Gerrit-Attention: qiu laidongfeng <26454...@qq.com>

Gerrit-Attention: Ian Lance Taylor <ia...@golang.org>

[Basavaraj P (Gerrit)]

Attention needed from Damien Neil, Ian Lance Taylor, Nicholas Husin and qiu laidongfeng

Basavaraj P added 2 comments

File doc/next/78137.md

Line 1, Patchset 4:net: UnixConn read methods now return io.EOF directly instead of wrapping it in net.OpError when the underlying read reaches EOF.

Ian Lance Taylor . resolved

Add a line break.
s/reaches EOF/returns EOF/

Basavaraj P

Done

File src/net/unixsock_test.go

Line 488, Patchset 4: switch runtime.GOOS {

Ian Lance Taylor . resolved

It's not necessarily a problem for this CL but it's kind of weird that this switch is not handled by testableNetwork. Or, more specifically, supportsUnixSocket.

Basavaraj P

Done

Open in Gerrit

Related details

Attention is currently required from:

• Damien Neil
• Ian Lance Taylor
• Nicholas Husin
• qiu laidongfeng

Submit Requirements:

• Code-Review

• No-Unresolved-Comments

• Review-Enforcement
• TryBots-Pass

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: go

Gerrit-Branch: master

Gerrit-Change-Id: Ibb4e67cfb4c727c668ad79d1fb9e205f9b7e1903

Gerrit-Change-Number: 754960

Gerrit-PatchSet: 5

Gerrit-Owner: Basavaraj P <basavaraj...@gmail.com>

Gerrit-Reviewer: Damien Neil <dn...@google.com>

Gerrit-Reviewer: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Reviewer: Ian Lance Taylor <ia...@golang.org>

Gerrit-Reviewer: qiu laidongfeng <26454...@qq.com>

Gerrit-CC: Gopher Robot <go...@golang.org>

Gerrit-CC: Nicholas Husin <n...@golang.org>

Gerrit-Attention: qiu laidongfeng <26454...@qq.com>

Gerrit-Attention: Ian Lance Taylor <ia...@golang.org>

Gerrit-Attention: Damien Neil <dn...@google.com>

Gerrit-Attention: Nicholas Husin <n...@golang.org>

Gerrit-Comment-Date: Tue, 17 Mar 2026 08:27:55 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Ian Lance Taylor <ia...@golang.org>

[Ian Lance Taylor (Gerrit)]

Attention needed from Basavaraj P, Damien Neil, Nicholas Husin and qiu laidongfeng

Ian Lance Taylor voted Commit-Queue+1

Commit-Queue

+1

Open in Gerrit

Related details

Attention is currently required from:

• Basavaraj P
• Damien Neil
• Nicholas Husin
• qiu laidongfeng

Submit Requirements:

• Code-Review
• No-Unresolved-Comments
• Review-Enforcement
• TryBots-Pass

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: go

Gerrit-Branch: master

Gerrit-Change-Id: Ibb4e67cfb4c727c668ad79d1fb9e205f9b7e1903

Gerrit-Change-Number: 754960

Gerrit-PatchSet: 5

Gerrit-Owner: Basavaraj P <basavaraj...@gmail.com>

Gerrit-Reviewer: Damien Neil <dn...@google.com>

Gerrit-Reviewer: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Reviewer: Ian Lance Taylor <ia...@golang.org>

Gerrit-Reviewer: qiu laidongfeng <26454...@qq.com>

Gerrit-CC: Gopher Robot <go...@golang.org>

Gerrit-CC: Nicholas Husin <n...@golang.org>

Gerrit-Attention: qiu laidongfeng <26454...@qq.com>

Gerrit-Attention: Damien Neil <dn...@google.com>

Gerrit-Attention: Nicholas Husin <n...@golang.org>

Gerrit-Attention: Basavaraj P <basavaraj...@gmail.com>

Gerrit-Comment-Date: Wed, 18 Mar 2026 08:05:15 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Basavaraj P (Gerrit)]

Attention needed from Basavaraj P, Damien Neil, Ian Lance Taylor, Nicholas Husin and qiu laidongfeng

Basavaraj P uploaded new patchset

Basavaraj P uploaded patch set #6 to this change.

Following approvals got outdated and were removed:

• TryBots-Pass: LUCI-TryBot-Result-1 by Go LUCI

Open in Gerrit

Related details

Attention is currently required from:

• Basavaraj P
• Damien Neil
• Ian Lance Taylor
• Nicholas Husin
• qiu laidongfeng

Submit Requirements:

• Code-Review
• No-Unresolved-Comments
• Review-Enforcement
• TryBots-Pass

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: newpatchset

Gerrit-Project: go

Gerrit-Branch: master

Gerrit-Change-Id: Ibb4e67cfb4c727c668ad79d1fb9e205f9b7e1903

Gerrit-Change-Number: 754960

Gerrit-PatchSet: 6

Gerrit-Owner: Basavaraj P <basavaraj...@gmail.com>

Gerrit-Reviewer: Damien Neil <dn...@google.com>

Gerrit-Reviewer: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Reviewer: Ian Lance Taylor <ia...@golang.org>

Gerrit-Reviewer: qiu laidongfeng <26454...@qq.com>

Gerrit-CC: Gopher Robot <go...@golang.org>

Gerrit-CC: Nicholas Husin <n...@golang.org>

Gerrit-Attention: qiu laidongfeng <26454...@qq.com>

Gerrit-Attention: Ian Lance Taylor <ia...@golang.org>

[Basavaraj P (Gerrit)]

Attention needed from Damien Neil, Ian Lance Taylor, Nicholas Husin and qiu laidongfeng

Basavaraj P voted and added 1 comment

Votes added by Basavaraj P

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 6 (Latest):

Basavaraj P . resolved

Skip test on Windows to avoid unix socket incompatibility. Also removed the redundant GOOS switch as suggested.

Open in Gerrit

Related details

Attention is currently required from:

• Damien Neil
• Ian Lance Taylor
• Nicholas Husin
• qiu laidongfeng

Submit Requirements:

• Code-Review
• No-Unresolved-Comments
• Review-Enforcement
• TryBots-Pass

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: go

Gerrit-Branch: master

Gerrit-Change-Id: Ibb4e67cfb4c727c668ad79d1fb9e205f9b7e1903

Gerrit-Change-Number: 754960

Gerrit-PatchSet: 6

Gerrit-Owner: Basavaraj P <basavaraj...@gmail.com>

Gerrit-Reviewer: Basavaraj P <basavaraj...@gmail.com>

Gerrit-Reviewer: Damien Neil <dn...@google.com>

Gerrit-Reviewer: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Reviewer: Ian Lance Taylor <ia...@golang.org>

Gerrit-Reviewer: qiu laidongfeng <26454...@qq.com>

Gerrit-CC: Gopher Robot <go...@golang.org>

Gerrit-CC: Nicholas Husin <n...@golang.org>

Gerrit-Attention: qiu laidongfeng <26454...@qq.com>

Gerrit-Attention: Ian Lance Taylor <ia...@golang.org>

Gerrit-Attention: Damien Neil <dn...@google.com>

Gerrit-Attention: Nicholas Husin <n...@golang.org>

Gerrit-Comment-Date: Wed, 18 Mar 2026 11:55:07 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Ian Lance Taylor (Gerrit)]

Attention needed from Basavaraj P, Damien Neil, Nicholas Husin and qiu laidongfeng

Ian Lance Taylor voted Commit-Queue+1

Commit-Queue

+1

Open in Gerrit

Related details

Attention is currently required from:

• Basavaraj P
• Damien Neil
• Nicholas Husin
• qiu laidongfeng

Submit Requirements:

• Code-Review
• No-Unresolved-Comments
• Review-Enforcement
• TryBots-Pass

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: go

Gerrit-Branch: master

Gerrit-Change-Id: Ibb4e67cfb4c727c668ad79d1fb9e205f9b7e1903

Gerrit-Change-Number: 754960

Gerrit-PatchSet: 6

Gerrit-Owner: Basavaraj P <basavaraj...@gmail.com>

Gerrit-Reviewer: Basavaraj P <basavaraj...@gmail.com>

Gerrit-Reviewer: Damien Neil <dn...@google.com>

Gerrit-Reviewer: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Reviewer: Ian Lance Taylor <ia...@golang.org>

Gerrit-Reviewer: qiu laidongfeng <26454...@qq.com>

Gerrit-CC: Gopher Robot <go...@golang.org>

Gerrit-CC: Nicholas Husin <n...@golang.org>

Gerrit-Attention: qiu laidongfeng <26454...@qq.com>

Gerrit-Attention: Damien Neil <dn...@google.com>

Gerrit-Attention: Nicholas Husin <n...@golang.org>

Gerrit-Attention: Basavaraj P <basavaraj...@gmail.com>

Gerrit-Comment-Date: Wed, 18 Mar 2026 17:33:35 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes