[go] debug/buildinfo: remove macho/elf DataStart fallback code

0 views
Skip to first unread message

Michael Matloob (Gerrit)

unread,
3:20 PM (7 hours ago) 3:20 PM
to goph...@pubsubhelper.golang.org, Cherry Mui, Go LUCI, Dmitri Shuralyov, golang-co...@googlegroups.com
Attention needed from Cherry Mui and Dmitri Shuralyov

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:
  • Cherry Mui
  • Dmitri Shuralyov
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: I5d593d5724323351aef3ff04e04f7df96a6a6964
Gerrit-Change-Number: 756421
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Matloob <mat...@golang.org>
Gerrit-Reviewer: Cherry Mui <cher...@google.com>
Gerrit-Reviewer: Dmitri Shuralyov <dmit...@golang.org>
Gerrit-Reviewer: Michael Matloob <mat...@golang.org>
Gerrit-Attention: Cherry Mui <cher...@google.com>
Gerrit-Attention: Dmitri Shuralyov <dmit...@golang.org>
Gerrit-Comment-Date: Thu, 19 Mar 2026 19:20:55 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
unsatisfied_requirement
satisfied_requirement
open
diffy

Dmitri Shuralyov (Gerrit)

unread,
5:43 PM (5 hours ago) 5:43 PM
to Michael Matloob, goph...@pubsubhelper.golang.org, Dmitri Shuralyov, Cherry Mui, Go LUCI, golang-co...@googlegroups.com
Attention needed from Cherry Mui

Dmitri Shuralyov voted and added 3 comments

Votes added by Dmitri Shuralyov

Code-Review+1

3 comments

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Dmitri Shuralyov . resolved

This generally looks good to me, leaving +1 so that Cherry can also look.

Commit Message
Line 15, Patchset 1 (Latest):golang.org/cl/173343 for the code added to go1.13 which would look for a
Dmitri Shuralyov . resolved

A side note: if you'd like, URLs like this can be shortened by using Go website's newer domain, such as go.dev/cl/173343. (The "CL 173343" form is also linked, at least in Gerrit.)

File src/debug/buildinfo/buildinfo.go
Line 104, Patchset 1 (Latest): // or the first writable non-zero data segment.
Dmitri Shuralyov . resolved

If I understand it right, this still applies to PE, XCOFF, and what Plan 9 uses. The specially named section seems to be only for macho + elf, which is where the fallback is no longer needed nor used.

Open in Gerrit

Related details

Attention is currently required from:
  • Cherry Mui
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: I5d593d5724323351aef3ff04e04f7df96a6a6964
Gerrit-Change-Number: 756421
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Matloob <mat...@golang.org>
Gerrit-Reviewer: Cherry Mui <cher...@google.com>
Gerrit-Reviewer: Dmitri Shuralyov <dmit...@golang.org>
Gerrit-Reviewer: Michael Matloob <mat...@golang.org>
Gerrit-Attention: Cherry Mui <cher...@google.com>
Gerrit-Comment-Date: Thu, 19 Mar 2026 21:43:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
unsatisfied_requirement
satisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages