[go] math: use shared signMask constant
4 views
Skip to first unread message
Wanbiao Ye (Gerrit)
Dec 22, 2025, 9:59:21 PM (2 days ago) Dec 22
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Wanbiao Ye has uploaded the change for review![]( "Open in Gerrit")
Commit message
math: use shared signMask constant
In abs.go and copysign.go, magic numbers and local constants are
used for the sign bit mask (1 << 63), even though a shared constant
signMask already exists in bits.go.
Change-Id: Ic3aeb9b52674538443cbe074acfeb373a3c74a8e
Change diff
diff --git a/src/math/abs.go b/src/math/abs.go
index 08be145..945cbd5 100644
--- a/src/math/abs.go
+++ b/src/math/abs.go
@@ -11,5 +11,5 @@
// Abs(±Inf) = +Inf
// Abs(NaN) = NaN
func Abs(x float64) float64 {
- return Float64frombits(Float64bits(x) &^ (1 << 63))
+ return Float64frombits(Float64bits(x) &^ signMask)
}
diff --git a/src/math/copysign.go b/src/math/copysign.go
index 3a30afb..ae9ae35 100644
--- a/src/math/copysign.go
+++ b/src/math/copysign.go
@@ -7,6 +7,5 @@
// Copysign returns a value with the magnitude of f
// and the sign of sign.
func Copysign(f, sign float64) float64 {
- const signBit = 1 << 63
- return Float64frombits(Float64bits(f)&^signBit | Float64bits(sign)&signBit)
+ return Float64frombits(Float64bits(f)&^signMask | Float64bits(sign)&signMask)
}
Change information
Files:
- M src/math/abs.go
- M src/math/copysign.go
Change size: XS
Delta: 2 files changed, 2 insertions(+), 3 deletions(-)
Related details
Attention set is empty
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Robert Griesemer (Gerrit)
Dec 23, 2025, 2:40:39 PM (yesterday) Dec 23
to Wanbiao Ye, goph...@pubsubhelper.golang.org, Robert Griesemer, Russ Cox, Gopher Robot, golang-co...@googlegroups.com
Attention needed from Robert Griesemer, Russ Cox and Wanbiao Ye
Robert Griesemer voted and added 1 comment![]( "Open in Gerrit")
Votes added by Robert Griesemer
| Auto-Submit | +1 |
| Code-Review | +2 |
| Commit-Queue | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Robert Griesemer
- Russ Cox
- Wanbiao Ye
Submit Requirements:
Code-Review
No-Unresolved-Comments
No-Wait-Release
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages