[go] runtime: increase repeat count for alloc test
0 views
Skip to first unread message
Keith Randall (Gerrit)
4:33 PM (7 hours ago) 4:33 PM
to Cherry Mui, goph...@pubsubhelper.golang.org, Keith Randall, golang-co...@googlegroups.com
Attention needed from Cherry Mui
Keith Randall has uploaded the change for review![]( "Open in Gerrit")
Keith Randall would like Cherry Mui to review this change.
Commit message
runtime: increase repeat count for alloc test
To make sure a single spurious alloc doesn't flake the test.
Fixes #75858
Change-Id: I055b37ad5668459bfa7ab1dac97025c997c68f1a
Change diff
diff --git a/src/runtime/iface_test.go b/src/runtime/iface_test.go
index 06f6eeb..5bc209c 100644
--- a/src/runtime/iface_test.go
+++ b/src/runtime/iface_test.go
@@ -60,7 +60,7 @@
t.Skip("skipping on non-gc compiler")
}
- n := testing.AllocsPerRun(1, func() {
+ n := testing.AllocsPerRun(100, func() {
_ = e == ts
_ = i1 == ts
_ = e == 1
Change information
Files:
- M src/runtime/iface_test.go
Change size: XS
Delta: 1 file changed, 1 insertion(+), 1 deletion(-)
Related details
Attention is currently required from:
- Cherry Mui
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Cherry Mui (Gerrit)
4:38 PM (7 hours ago) 4:38 PM
to Keith Randall, goph...@pubsubhelper.golang.org, Go LUCI, golang-co...@googlegroups.com
Attention needed from Keith Randall
Cherry Mui voted Code-Review+2![]( "Open in Gerrit")
Attention is currently required from:
- Keith Randall
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Keith Randall (Gerrit)
6:00 PM (6 hours ago) 6:00 PM
to Keith Randall, goph...@pubsubhelper.golang.org, Go LUCI, Cherry Mui, golang-co...@googlegroups.com
Keith Randall voted Commit-Queue+1![]( "Open in Gerrit")
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Keith Randall (Gerrit)
6:23 PM (5 hours ago) 6:23 PM
to Keith Randall, goph...@pubsubhelper.golang.org, Go LUCI, Cherry Mui, golang-co...@googlegroups.com
Attention needed from Keith Randall
Keith Randall voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Keith Randall
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Keith Randall (Gerrit)
6:23 PM (5 hours ago) 6:23 PM
to Keith Randall, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Keith Randall, Go LUCI, Cherry Mui, golang-co...@googlegroups.com
Keith Randall submitted the change![]( "Open in Gerrit")
Change information
Commit message:
runtime: increase repeat count for alloc test
To make sure a single spurious alloc doesn't flake the test.
Fixes #75858
Change-Id: I055b37ad5668459bfa7ab1dac97025c997c68f1a
Reviewed-on: https://go-review.googlesource.com/c/go/+/712201
LUCI-TryBot-Result: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Cherry Mui <cher...@google.com>
Reviewed-by: Keith Randall <k...@google.com>
Files:
- M src/runtime/iface_test.go
Change size: XS
Delta: 1 file changed, 1 insertion(+), 1 deletion(-)
Branch: refs/heads/master
Submit Requirements:
Code-Review: +1 by Keith Randall, +2 by Cherry Mui
TryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages