[pkgsite] tests: update docs for updating screenshot tests

3 views
Skip to first unread message

Ethan Lee (Gerrit)

unread,
Dec 17, 2025, 10:39:00 PM (2 days ago) Dec 17
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com

Ethan Lee has uploaded the change for review

Commit message

tests: update docs for updating screenshot tests
Change-Id: I85997dce21dae9c40ca68eb4007e7a724e519094

Change diff

diff --git a/tests/README.md b/tests/README.md
index 7f9fdfb..9b1d2bd 100644
--- a/tests/README.md
+++ b/tests/README.md
@@ -94,6 +94,13 @@
are suitable for tests with data that is consistent between environments or
static pages.

+### Updating the tests
+
+Update screen shot diffs using the following:
+
+1. Run `./tests/screentest/run.sh ci -update` to collect the updated screenshots.
+2. Copy the new screenshots from `./tests/screentest/output` into `./tests/screentest/testdata/testcases`
+
### Understanding Test Failures

If the tests fail with diffs, a file with the diffs will be created in the

Change information

Files:
  • M tests/README.md
Change size: XS
Delta: 1 file changed, 7 insertions(+), 0 deletions(-)
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
  • requirement is not satisfiedkokoro-CI-Passes
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: pkgsite
Gerrit-Branch: master
Gerrit-Change-Id: I85997dce21dae9c40ca68eb4007e7a724e519094
Gerrit-Change-Number: 731021
Gerrit-PatchSet: 1
Gerrit-Owner: Ethan Lee <etha...@google.com>
unsatisfied_requirement
satisfied_requirement
open
diffy

Jonathan Amsterdam (Gerrit)

unread,
Dec 18, 2025, 8:45:13 AM (yesterday) Dec 18
to Ethan Lee, goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Attention needed from Ethan Lee

Jonathan Amsterdam voted and added 1 comment

Votes added by Jonathan Amsterdam

Code-Review+2

1 comment

File tests/README.md
Line 101, Patchset 1 (Latest):1. Run `./tests/screentest/run.sh ci -update` to collect the updated screenshots.
Jonathan Amsterdam . unresolved

Mention `-run`.

Open in Gerrit

Related details

Attention is currently required from:
  • Ethan Lee
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
  • requirement is not satisfiedkokoro-CI-Passes
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: pkgsite
Gerrit-Branch: master
Gerrit-Change-Id: I85997dce21dae9c40ca68eb4007e7a724e519094
Gerrit-Change-Number: 731021
Gerrit-PatchSet: 1
Gerrit-Owner: Ethan Lee <etha...@google.com>
Gerrit-Reviewer: Jonathan Amsterdam <j...@google.com>
Gerrit-Attention: Ethan Lee <etha...@google.com>
Gerrit-Comment-Date: Thu, 18 Dec 2025 13:45:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Ethan Lee (Gerrit)

unread,
Dec 18, 2025, 3:11:19 PM (20 hours ago) Dec 18
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Attention needed from Ethan Lee

Ethan Lee uploaded new patchset

Ethan Lee uploaded patch set #3 to this change.
Open in Gerrit

Related details

Attention is currently required from:
  • Ethan Lee
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
  • requirement is not satisfiedkokoro-CI-Passes
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newpatchset
Gerrit-Project: pkgsite
Gerrit-Branch: master
Gerrit-Change-Id: I85997dce21dae9c40ca68eb4007e7a724e519094
Gerrit-Change-Number: 731021
Gerrit-PatchSet: 3
satisfied_requirement
unsatisfied_requirement
open
diffy

Ethan Lee (Gerrit)

unread,
Dec 18, 2025, 3:12:00 PM (19 hours ago) Dec 18
to goph...@pubsubhelper.golang.org, Jonathan Amsterdam, golang-co...@googlegroups.com

Ethan Lee voted and added 2 comments

Votes added by Ethan Lee

Auto-Submit+1
Commit-Queue+1

2 comments

Patchset-level comments
File-level comment, Patchset 3 (Latest):
Ethan Lee . resolved

kokoro rerun

File tests/README.md
Line 101, Patchset 1:1. Run `./tests/screentest/run.sh ci -update` to collect the updated screenshots.
Jonathan Amsterdam . resolved

Mention `-run`.

Ethan Lee

Done

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
  • requirement is not satisfiedkokoro-CI-Passes
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: pkgsite
Gerrit-Branch: master
Gerrit-Change-Id: I85997dce21dae9c40ca68eb4007e7a724e519094
Gerrit-Change-Number: 731021
Gerrit-PatchSet: 3
Gerrit-Owner: Ethan Lee <etha...@google.com>
Gerrit-Reviewer: Ethan Lee <etha...@google.com>
Gerrit-Reviewer: Jonathan Amsterdam <j...@google.com>
Gerrit-Comment-Date: Thu, 18 Dec 2025 20:11:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Jonathan Amsterdam <j...@google.com>
satisfied_requirement
unsatisfied_requirement
open
diffy

Ethan Lee (Gerrit)

unread,
Dec 18, 2025, 3:20:39 PM (19 hours ago) Dec 18
to goph...@pubsubhelper.golang.org, Go LUCI, Jonathan Amsterdam, golang-co...@googlegroups.com

Ethan Lee voted and added 1 comment

Votes added by Ethan Lee

Auto-Submit+1
Commit-Queue+1

1 comment

Patchset-level comments
Ethan Lee . resolved

kokoro rerun

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
  • requirement is not satisfiedkokoro-CI-Passes
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: pkgsite
Gerrit-Branch: master
Gerrit-Change-Id: I85997dce21dae9c40ca68eb4007e7a724e519094
Gerrit-Change-Number: 731021
Gerrit-PatchSet: 4
Gerrit-Owner: Ethan Lee <etha...@google.com>
Gerrit-Reviewer: Ethan Lee <etha...@google.com>
Gerrit-Reviewer: Jonathan Amsterdam <j...@google.com>
Gerrit-Comment-Date: Thu, 18 Dec 2025 20:20:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages