[go] internal/runtime/sys: improve DIT assembly

4 views
Skip to first unread message

Roland Shoemaker (Gerrit)

unread,
Dec 12, 2025, 6:55:47 PM (4 days ago) Dec 12
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com

Roland Shoemaker voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: I1b3ecbd95ed42bfd10d646125704abf4e80b6d2e
Gerrit-Change-Number: 729800
Gerrit-PatchSet: 4
Gerrit-Owner: Roland Shoemaker <rol...@golang.org>
Gerrit-Reviewer: Roland Shoemaker <rol...@golang.org>
Gerrit-Comment-Date: Fri, 12 Dec 2025 23:55:41 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
unsatisfied_requirement
satisfied_requirement
open
diffy

Roland Shoemaker (Gerrit)

unread,
Dec 12, 2025, 7:06:23 PM (4 days ago) Dec 12
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Attention needed from Austin Clements, Keith Randall and Roland Shoemaker

Roland Shoemaker uploaded new patchset

Roland Shoemaker uploaded patch set #5 to this change.
Following approvals got outdated and were removed:
  • TryBots-Pass: LUCI-TryBot-Result-1 by Go LUCI
Open in Gerrit

Related details

Attention is currently required from:
  • Austin Clements
  • Keith Randall
  • Roland Shoemaker
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newpatchset
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: I1b3ecbd95ed42bfd10d646125704abf4e80b6d2e
Gerrit-Change-Number: 729800
Gerrit-PatchSet: 5
Gerrit-Owner: Roland Shoemaker <rol...@golang.org>
Gerrit-Reviewer: Austin Clements <aus...@google.com>
Gerrit-Reviewer: Keith Randall <k...@golang.org>
Gerrit-Reviewer: Roland Shoemaker <rol...@golang.org>
Gerrit-CC: Gopher Robot <go...@golang.org>
Gerrit-Attention: Keith Randall <k...@golang.org>
Gerrit-Attention: Roland Shoemaker <rol...@golang.org>
Gerrit-Attention: Austin Clements <aus...@google.com>
unsatisfied_requirement
satisfied_requirement
open
diffy

Roland Shoemaker (Gerrit)

unread,
Dec 12, 2025, 7:06:41 PM (4 days ago) Dec 12
to goph...@pubsubhelper.golang.org, Austin Clements, Keith Randall, Gopher Robot, Go LUCI, golang-co...@googlegroups.com
Attention needed from Austin Clements and Keith Randall

Roland Shoemaker voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Austin Clements
  • Keith Randall
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: I1b3ecbd95ed42bfd10d646125704abf4e80b6d2e
Gerrit-Change-Number: 729800
Gerrit-PatchSet: 5
Gerrit-Owner: Roland Shoemaker <rol...@golang.org>
Gerrit-Reviewer: Austin Clements <aus...@google.com>
Gerrit-Reviewer: Keith Randall <k...@golang.org>
Gerrit-Reviewer: Roland Shoemaker <rol...@golang.org>
Gerrit-CC: Gopher Robot <go...@golang.org>
Gerrit-Attention: Keith Randall <k...@golang.org>
Gerrit-Attention: Austin Clements <aus...@google.com>
Gerrit-Comment-Date: Sat, 13 Dec 2025 00:06:36 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
unsatisfied_requirement
satisfied_requirement
open
diffy

Keith Randall (Gerrit)

unread,
Dec 12, 2025, 7:49:26 PM (4 days ago) Dec 12
to Roland Shoemaker, goph...@pubsubhelper.golang.org, Go LUCI, Austin Clements, Keith Randall, Gopher Robot, golang-co...@googlegroups.com
Attention needed from Austin Clements and Roland Shoemaker

Keith Randall added 1 comment

File src/internal/runtime/sys/dit_arm64.s
Line 31, Patchset 5 (Latest): MRS DIT, R0
Keith Randall . unresolved

I thought we would only call DisableDIT when we know it has been previously enabled. So how could this code ever trigger?

Open in Gerrit

Related details

Attention is currently required from:
  • Austin Clements
  • Roland Shoemaker
Submit Requirements:
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    • requirement satisfiedTryBots-Pass
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: go
    Gerrit-Branch: master
    Gerrit-Change-Id: I1b3ecbd95ed42bfd10d646125704abf4e80b6d2e
    Gerrit-Change-Number: 729800
    Gerrit-PatchSet: 5
    Gerrit-Owner: Roland Shoemaker <rol...@golang.org>
    Gerrit-Reviewer: Austin Clements <aus...@google.com>
    Gerrit-Reviewer: Keith Randall <k...@golang.org>
    Gerrit-Reviewer: Roland Shoemaker <rol...@golang.org>
    Gerrit-CC: Gopher Robot <go...@golang.org>
    Gerrit-Attention: Roland Shoemaker <rol...@golang.org>
    Gerrit-Attention: Austin Clements <aus...@google.com>
    Gerrit-Comment-Date: Sat, 13 Dec 2025 00:49:22 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    unsatisfied_requirement
    satisfied_requirement
    open
    diffy

    Roland Shoemaker (Gerrit)

    unread,
    Dec 15, 2025, 1:55:40 PM (yesterday) Dec 15
    to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
    Attention needed from Austin Clements and Keith Randall

    Roland Shoemaker uploaded new patchset

    Roland Shoemaker uploaded patch set #6 to this change.
    Following approvals got outdated and were removed:
    • TryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Austin Clements
    • Keith Randall
    Submit Requirements:
      • requirement is not satisfiedCode-Review
      • requirement satisfiedNo-Unresolved-Comments
      • requirement is not satisfiedReview-Enforcement
      • requirement is not satisfiedTryBots-Pass
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: newpatchset
      Gerrit-Project: go
      Gerrit-Branch: master
      Gerrit-Change-Id: I1b3ecbd95ed42bfd10d646125704abf4e80b6d2e
      Gerrit-Change-Number: 729800
      Gerrit-PatchSet: 6
      Gerrit-Owner: Roland Shoemaker <rol...@golang.org>
      Gerrit-Reviewer: Austin Clements <aus...@google.com>
      Gerrit-Reviewer: Keith Randall <k...@golang.org>
      Gerrit-Reviewer: Roland Shoemaker <rol...@golang.org>
      Gerrit-CC: Gopher Robot <go...@golang.org>
      unsatisfied_requirement
      satisfied_requirement
      open
      diffy

      Roland Shoemaker (Gerrit)

      unread,
      Dec 15, 2025, 1:55:41 PM (yesterday) Dec 15
      to goph...@pubsubhelper.golang.org, Go LUCI, Austin Clements, Keith Randall, Gopher Robot, golang-co...@googlegroups.com
      Attention needed from Austin Clements and Keith Randall

      Roland Shoemaker added 1 comment

      File src/internal/runtime/sys/dit_arm64.s
      Line 31, Patchset 5: MRS DIT, R0
      Keith Randall . resolved

      I thought we would only call DisableDIT when we know it has been previously enabled. So how could this code ever trigger?

      Roland Shoemaker

      Hm, good point. I thought there was one case where we try to disable when it's already disabled, but I don't think that path exists anymore (now that we update state on cgo/go transition boundaries). Removed.

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Austin Clements
      • Keith Randall
      Submit Requirements:
      • requirement is not satisfiedCode-Review
      • requirement satisfiedNo-Unresolved-Comments
      • requirement is not satisfiedReview-Enforcement
      • requirement is not satisfiedTryBots-Pass
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: go
      Gerrit-Branch: master
      Gerrit-Change-Id: I1b3ecbd95ed42bfd10d646125704abf4e80b6d2e
      Gerrit-Change-Number: 729800
      Gerrit-PatchSet: 6
      Gerrit-Owner: Roland Shoemaker <rol...@golang.org>
      Gerrit-Reviewer: Austin Clements <aus...@google.com>
      Gerrit-Reviewer: Keith Randall <k...@golang.org>
      Gerrit-Reviewer: Roland Shoemaker <rol...@golang.org>
      Gerrit-CC: Gopher Robot <go...@golang.org>
      Gerrit-Attention: Keith Randall <k...@golang.org>
      Gerrit-Attention: Austin Clements <aus...@google.com>
      Gerrit-Comment-Date: Mon, 15 Dec 2025 18:55:35 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      Comment-In-Reply-To: Keith Randall <k...@golang.org>
      unsatisfied_requirement
      satisfied_requirement
      open
      diffy

      Roland Shoemaker (Gerrit)

      unread,
      Dec 15, 2025, 4:49:36 PM (22 hours ago) Dec 15
      to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
      Attention needed from Austin Clements and Keith Randall

      Roland Shoemaker uploaded new patchset

      Roland Shoemaker uploaded patch set #7 to this change.
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Austin Clements
      • Keith Randall
      Submit Requirements:
      • requirement is not satisfiedCode-Review
      • requirement satisfiedNo-Unresolved-Comments
      • requirement is not satisfiedReview-Enforcement
      • requirement is not satisfiedTryBots-Pass
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: newpatchset
      Gerrit-Project: go
      Gerrit-Branch: master
      Gerrit-Change-Id: I1b3ecbd95ed42bfd10d646125704abf4e80b6d2e
      Gerrit-Change-Number: 729800
      Gerrit-PatchSet: 7
      unsatisfied_requirement
      satisfied_requirement
      open
      diffy

      Roland Shoemaker (Gerrit)

      unread,
      Dec 15, 2025, 4:49:41 PM (22 hours ago) Dec 15
      to goph...@pubsubhelper.golang.org, Go LUCI, Austin Clements, Keith Randall, Gopher Robot, golang-co...@googlegroups.com
      Attention needed from Austin Clements and Keith Randall

      Roland Shoemaker voted Commit-Queue+1

      Commit-Queue+1
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Austin Clements
      • Keith Randall
      Submit Requirements:
      • requirement is not satisfiedCode-Review
      • requirement satisfiedNo-Unresolved-Comments
      • requirement is not satisfiedReview-Enforcement
      • requirement is not satisfiedTryBots-Pass
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: go
      Gerrit-Branch: master
      Gerrit-Change-Id: I1b3ecbd95ed42bfd10d646125704abf4e80b6d2e
      Gerrit-Change-Number: 729800
      Gerrit-PatchSet: 7
      Gerrit-Owner: Roland Shoemaker <rol...@golang.org>
      Gerrit-Reviewer: Austin Clements <aus...@google.com>
      Gerrit-Reviewer: Keith Randall <k...@golang.org>
      Gerrit-Reviewer: Roland Shoemaker <rol...@golang.org>
      Gerrit-CC: Gopher Robot <go...@golang.org>
      Gerrit-Attention: Keith Randall <k...@golang.org>
      Gerrit-Attention: Austin Clements <aus...@google.com>
      Gerrit-Comment-Date: Mon, 15 Dec 2025 21:49:37 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      unsatisfied_requirement
      satisfied_requirement
      open
      diffy
      Reply all
      Reply to author
      Forward
      0 new messages