[build] dashboard: remove android-amd64-emu from main go repo's TryBot set
Dmitri Shuralyov (Gerrit)
Dmitri Shuralyov has uploaded this change for review.
dashboard: remove android-amd64-emu from main go repo's TryBot set
This builder is known to run into errors while running runtime tests,
as tracked in go.dev/issue/51001. This causes more disruption because
the builder is a default TryBot.
Since GOOS=android is not a first-class port, remove the builder from
the default TryBot set while the issue is investigated so that it
doesn't need to block the Go 1.19 release. Once that issue is fixed,
this builder can be re-added as a TryBot if that's helpful.
For golang/go#51001.
Change-Id: I44ee5454bfe2de15e2f41a82900ee2acc37cd211
---
M dashboard/builders.go
M dashboard/builders_test.go
2 files changed, 25 insertions(+), 9 deletions(-)
diff --git a/dashboard/builders.go b/dashboard/builders.go
index 9fa8fd5..f80fefe 100644
--- a/dashboard/builders.go
+++ b/dashboard/builders.go
@@ -2436,7 +2436,7 @@
addBuilder(BuildConfig{
Name: "android-386-emu",
HostType: "host-android-amd64-emu", // same amd64 host is used for 386 builder
- Notes: "Android emulator on GCE",
+ Notes: "Android emulator on GCE. (GOOS=android GOARCH=386)",
buildsRepo: func(repo, branch, goBranch string) bool {
b := buildRepoByDefault(repo)
switch repo {
@@ -2458,11 +2458,11 @@
addBuilder(BuildConfig{
Name: "android-amd64-emu",
HostType: "host-android-amd64-emu",
- Notes: "Android emulator on GCE",
+ Notes: "Android emulator on GCE. (GOOS=android GOARCH=amd64)",
numTryTestHelpers: 3,
tryBot: func(repo, branch, goBranch string) bool {
switch repo {
- case "go", "mobile", "sys", "net", "tools", "crypto", "sync", "text", "time":
+ case "mobile", "sys", "net", "tools", "crypto", "sync", "text", "time":
return true
}
return false
diff --git a/dashboard/builders_test.go b/dashboard/builders_test.go
index b3eba3a..641dfe2 100644
--- a/dashboard/builders_test.go
+++ b/dashboard/builders_test.go
@@ -92,7 +92,6 @@
repo: "go",
branch: "master",
want: []string{
- "android-amd64-emu",
"freebsd-amd64-12_3",
"js-wasm",
"linux-386",
@@ -129,7 +128,6 @@
repo: "go",
branch: "dev.typeparams",
want: []string{
- "android-amd64-emu",
"freebsd-amd64-12_3",
"js-wasm",
"linux-386",
@@ -166,7 +164,6 @@
repo: "go",
branch: "release-branch.go1.17",
want: []string{
- "android-amd64-emu",
"freebsd-amd64-12_3",
"js-wasm",
"linux-386",
@@ -206,7 +203,6 @@
repo: "go",
branch: "release-branch.go1.16",
want: []string{
- "android-amd64-emu",
"freebsd-amd64-12_3",
"js-wasm",
"linux-386",
@@ -431,7 +427,7 @@
{b("linux-386...@go1.18", "crypto"), onlyPost},
{b("linux-386...@go1.17", "crypto"), onlyPost},
- {b("android-amd64-emu", "go"), both},
+ {b("android-amd64-emu", "go"), onlyPost},
{b("android-amd64-emu", "mobile"), both},
{b("android-amd64-emu", "crypto"), both},
{b("android-amd64-emu", "net"), both},
@@ -540,7 +536,7 @@
{b("android-386-emu", "mobile"), onlyPost},
{b("android-amd64-emu", "net"), both},
{b("android-386-emu", "net"), onlyPost},
- {b("android-amd64-emu", "go"), both},
+ {b("android-amd64-emu", "go"), onlyPost},
{b("android-386-emu", "go"), onlyPost},
// Only test tip for js/wasm, and only for some repos:
To view, visit change 407615. To unsubscribe, or for help writing mail filters, visit settings.
Dmitri Shuralyov (Gerrit)
Patch set 1:Run-TryBot +1Auto-Submit +1
Dmitri Shuralyov (Gerrit)
Attention is currently required from: Dmitri Shuralyov.
Patch set 1:Code-Review +1
Dmitri Shuralyov (Gerrit)
Attention is currently required from: Dmitri Shuralyov, Dmitri Shuralyov.
Dmitri Shuralyov uploaded patch set #2 to this change.
The following approvals got outdated and were removed: Auto-Submit+1 by Dmitri Shuralyov, Run-TryBot+1 by Dmitri Shuralyov, Run-TryBot+1 by Dmitri Shuralyov, TryBot-Result+1 by Gopher Robot
dashboard: exclude android-amd64-emu from main go repo's TryBot set
This builder is known to run into errors while running runtime tests,
as tracked in go.dev/issue/51001. This causes more disruption because
the builder is a default TryBot.
Since GOOS=android is not a first-class port, remove the builder from
the default TryBot set while the issue is investigated so that it
doesn't need to block the Go 1.19 release. Once that issue is fixed,
this builder can be re-added as a TryBot if that's helpful.
For golang/go#51001.
Change-Id: I44ee5454bfe2de15e2f41a82900ee2acc37cd211
---
M dashboard/builders.go
M dashboard/builders_test.go
2 files changed, 25 insertions(+), 9 deletions(-)
To view, visit change 407615. To unsubscribe, or for help writing mail filters, visit settings.
Dmitri Shuralyov (Gerrit)
Attention is currently required from: Dmitri Shuralyov.
Patch set 2:Run-TryBot +1Auto-Submit +1
To view, visit change 407615. To unsubscribe, or for help writing mail filters, visit settings.
Bryan Mills (Gerrit)
Attention is currently required from: Dmitri Shuralyov.
Patch set 2:Code-Review +1
Bryan Mills (Gerrit)
Attention is currently required from: Dmitri Shuralyov.
1 comment:
Commit Message:
Patch Set #2, Line 18:
For golang/go#51001.golang/go#53377
To view, visit change 407615. To unsubscribe, or for help writing mail filters, visit settings.
Dmitri Shuralyov (Gerrit)
Attention is currently required from: Dmitri Shuralyov.
Dmitri Shuralyov removed a vote from this change.
To view, visit change 407615. To unsubscribe, or for help writing mail filters, visit settings.
Dmitri Shuralyov (Gerrit)
Attention is currently required from: Dmitri Shuralyov.
Dmitri Shuralyov removed a vote from this change.
Dmitri Shuralyov (Gerrit)
Attention is currently required from: Dmitri Shuralyov.
Dmitri Shuralyov uploaded patch set #3 to this change.
The following approvals got outdated and were removed: -Auto-Submit by Dmitri Shuralyov, Run-TryBot+1 by Dmitri Shuralyov, TryBot-Result+1 by Gopher Robot
dashboard: exclude android-amd64-emu from main go repo's TryBot set
This builder is known to run into errors while running runtime tests,
as tracked in go.dev/issue/51001. This causes more disruption because
the builder is a default TryBot.
Since GOOS=android is not a first-class port, remove the builder from
the default TryBot set while the issue is investigated so that it
doesn't need to block the Go 1.19 release. Once that issue is fixed,
this builder can be re-added as a TryBot if that's helpful.
For golang/go#53377.
DO NOT SUBMIT: Need to resolve a merge conflict and update the commit
message. This CL is waiting on a decision on the issue.
Change-Id: I44ee5454bfe2de15e2f41a82900ee2acc37cd211
---
M dashboard/builders.go
M dashboard/builders_test.go
2 files changed, 28 insertions(+), 9 deletions(-)
To view, visit change 407615. To unsubscribe, or for help writing mail filters, visit settings.
Cherry Mui (Gerrit)
Attention is currently required from: Dmitri Shuralyov.
Patch set 3:Code-Review +1
1 comment:
File dashboard/builders.go:
Patch Set #3, Line 2465:
case "mobile", "sys", "net", "tools", "crypto", "sync", "text", "time":I would think we may want to remove it from trybots for all repos.
To view, visit change 407615. To unsubscribe, or for help writing mail filters, visit settings.
Bryan Mills (Gerrit)
Attention is currently required from: Cherry Mui, Dmitri Shuralyov.
File dashboard/builders.go:
Patch Set #3, Line 2465:
case "mobile", "sys", "net", "tools", "crypto", "sync", "text", "time":I would think we may want to remove it from trybots for all repos.
It may be worth keeping as a TryBot for the `mobile` repo in particular, since commits in the `mobile` repo are more likely to break Android tests, and also more likely to care about not breaking them (and be willing to tolerate more TryBot noise in order to obtain that information).
To view, visit change 407615. To unsubscribe, or for help writing mail filters, visit settings.
Cherry Mui (Gerrit)
Attention is currently required from: Bryan Mills, Dmitri Shuralyov.
1 comment:
File dashboard/builders.go:
Patch Set #3, Line 2465:
case "mobile", "sys", "net", "tools", "crypto", "sync", "text", "time":
It may be worth keeping as a TryBot for the `mobile` repo in particular, since commits in the `mobil […]
Yeah, TryBot for the mobile repo sounds fine to me. Thanks.
To view, visit change 407615. To unsubscribe, or for help writing mail filters, visit settings.
Dmitri Shuralyov (Gerrit)
Attention is currently required from: Bryan Mills, Cherry Mui.
Dmitri Shuralyov uploaded patch set #4 to this change.
dashboard: configure android-amd64-emu as post-submit only
It has been decided in go.dev/issue/53377 for this builder to start
being post-submit only. Update the builder configuration accordingly.
Keep it as a TryBot only in x/mobile, where its signal should still
be a net positive contribution despite the noise in its results.
Fixes golang/go#53377.
Change-Id: I44ee5454bfe2de15e2f41a82900ee2acc37cd211
---
M dashboard/builders.go
M dashboard/builders_test.go
2 files changed, 33 insertions(+), 18 deletions(-)
To view, visit change 407615. To unsubscribe, or for help writing mail filters, visit settings.
Dmitri Shuralyov (Gerrit)
Attention is currently required from: Bryan Mills, Cherry Mui.
2 comments:
Commit Message:
Patch Set #2, Line 18:
For golang/go#51001.golang/go#53377
Done.
File dashboard/builders.go:
Patch Set #3, Line 2465:
case "mobile", "sys", "net", "tools", "crypto", "sync", "text", "time":
I would think we may want to remove it from trybots for all repos.
Thanks for making these suggestions, I agree.
Issue #53377 has moved to NeedsFix state, updated the CL accordingly.
To view, visit change 407615. To unsubscribe, or for help writing mail filters, visit settings.
Bryan Mills (Gerrit)
Attention is currently required from: Cherry Mui, Dmitri Shuralyov.
Patch set 4:Code-Review +2
Dmitri Shuralyov (Gerrit)
Attention is currently required from: Cherry Mui.
Patch set 4:Auto-Submit +1
Gopher Robot (Gerrit)
Gopher Robot submitted this change.
dashboard: configure android-amd64-emu as post-submit only
It has been decided in go.dev/issue/53377 for this builder to start
being post-submit only. Update the builder configuration accordingly.
Keep it as a TryBot only in x/mobile, where its signal should still
be a net positive contribution despite the noise in its results.
Fixes golang/go#53377.
Change-Id: I44ee5454bfe2de15e2f41a82900ee2acc37cd211
Reviewed-on: https://go-review.googlesource.com/c/build/+/407615
Run-TryBot: Dmitri Shuralyov <dmit...@golang.org>
Auto-Submit: Dmitri Shuralyov <dmit...@golang.org>
Reviewed-by: Dmitri Shuralyov <dmit...@google.com>
Reviewed-by: Cherry Mui <cher...@google.com>
TryBot-Result: Gopher Robot <go...@golang.org>
Reviewed-by: Bryan Mills <bcm...@google.com>
---
M dashboard/builders.go
M dashboard/builders_test.go
2 files changed, 40 insertions(+), 18 deletions(-)
diff --git a/dashboard/builders.go b/dashboard/builders.go
index 04f76db..729edd9 100644
--- a/dashboard/builders.go
+++ b/dashboard/builders.go
@@ -2437,7 +2437,7 @@
addBuilder(BuildConfig{
Name: "android-386-emu",
HostType: "host-android-amd64-emu", // same amd64 host is used for 386 builder
- Notes: "Android emulator on GCE",
+ Notes: "Android emulator on GCE (GOOS=android GOARCH=386)",
buildsRepo: func(repo, branch, goBranch string) bool {
b := buildRepoByDefault(repo)
switch repo {
@@ -2460,11 +2460,12 @@
addBuilder(BuildConfig{
Name: "android-amd64-emu",
HostType: "host-android-amd64-emu",
- Notes: "Android emulator on GCE",
+ Notes: "Android emulator on GCE (GOOS=android GOARCH=amd64)",
numTryTestHelpers: 3,
tryBot: func(repo, branch, goBranch string) bool {
+ // See discussion in go.dev/issue/53377.
switch repo {
- case "go", "mobile", "sys", "net", "tools", "crypto", "sync", "text", "time":
+ case "mobile":
return true
}
return false
diff --git a/dashboard/builders_test.go b/dashboard/builders_test.go
index c404eba..8d11b5b 100644
--- a/dashboard/builders_test.go
+++ b/dashboard/builders_test.go
@@ -92,7 +92,6 @@
repo: "go",
branch: "master",
want: []string{
- "android-amd64-emu",
"freebsd-amd64-12_3",
"js-wasm",
"linux-386",
@@ -129,7 +128,6 @@
repo: "go",
branch: "release-branch.go1.17",
want: []string{
- "android-amd64-emu",
"freebsd-amd64-12_3",
"js-wasm",
"linux-386",
@@ -169,7 +167,6 @@
repo: "go",
branch: "release-branch.go1.16",
want: []string{
- "android-amd64-emu",
"freebsd-amd64-12_3",
"js-wasm",
"linux-386",
@@ -216,7 +213,6 @@
repo: "sys",
branch: "master",
want: []string{
- "android-amd64-emu",
"freebsd-386-13_0",
"freebsd-amd64-12_3",
"freebsd-amd64-13_0",
@@ -394,19 +390,20 @@
{b("linux-386...@go1.18", "crypto"), onlyPost},
{b("linux-386...@go1.17", "crypto"), onlyPost},
- {b("android-amd64-emu", "go"), both},
+ {b("android-amd64-emu", "go"), onlyPost},
{b("android-amd64-emu", "mobile"), both},
- {b("android-amd64-emu", "crypto"), both},
- {b("android-amd64-emu", "net"), both},
- {b("android-amd64-emu", "sync"), both},
- {b("android-amd64-emu", "sys"), both},
- {b("android-amd64-emu", "text"), both},
- {b("android-amd64-emu", "time"), both},
- {b("android-amd64-emu", "tools"), both},
+ {b("android-amd64-emu", "crypto"), onlyPost},
+ {b("android-amd64-emu", "net"), onlyPost},
+ {b("android-amd64-emu", "sync"), onlyPost},
+ {b("android-amd64-emu", "sys"), onlyPost},
+ {b("android-amd64-emu", "text"), onlyPost},
+ {b("android-amd64-emu", "time"), onlyPost},
+ {b("android-amd64-emu", "tools"), onlyPost},
{b("android-amd64-emu", "website"), none},
{b("android-386-emu", "go"), onlyPost},
{b("android-386-emu", "mobile"), onlyPost},
+ {b("android-386-emu", "crypto"), onlyPost},
{b("linux-amd64", "net"), both},
{b("linux-amd64", "n...@1.12"), both},
@@ -498,12 +495,12 @@
// a device attached.
{b("linux-amd64-androidemu", "mobile"), both},
- // But the emulators run all:
+ // The Android emulator builders can test all repos.
{b("android-amd64-emu", "mobile"), both},
{b("android-386-emu", "mobile"), onlyPost},
- {b("android-amd64-emu", "net"), both},
+ {b("android-amd64-emu", "net"), onlyPost},
{b("android-386-emu", "net"), onlyPost},
- {b("android-amd64-emu", "go"), both},
+ {b("android-amd64-emu", "go"), onlyPost},
{b("android-386-emu", "go"), onlyPost},
// Only test tip for js/wasm, and only for some repos:
To view, visit change 407615. To unsubscribe, or for help writing mail filters, visit settings.