[vscode-go] extension: add followExec and followExecRegex options in launch request

5 views
Skip to first unread message

Gerrit Bot (Gerrit)

unread,
Dec 6, 2025, 9:51:03 PM (10 days ago) Dec 6
to Qingwei Li, goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com

Gerrit Bot uploaded new patchset

Gerrit Bot uploaded patch set #4 to this change.
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newpatchset
Gerrit-Project: vscode-go
Gerrit-Branch: master
Gerrit-Change-Id: I6f759356851938547a5db35c39309899e0200428
Gerrit-Change-Number: 696795
Gerrit-PatchSet: 4
Gerrit-Owner: Gerrit Bot <letsus...@gmail.com>
Gerrit-CC: Gopher Robot <go...@golang.org>
Gerrit-CC: Qingwei Li <lqw332...@mail.ustc.edu.cn>
unsatisfied_requirement
satisfied_requirement
open
diffy

Qingwei Li (Gerrit)

unread,
Dec 6, 2025, 9:53:52 PM (10 days ago) Dec 6
to Gerrit Bot, goph...@pubsubhelper.golang.org, Hongxiang Jiang, Madeline Kalil, Gopher Robot, golang-co...@googlegroups.com
Attention needed from Hongxiang Jiang and Madeline Kalil

Qingwei Li added 1 comment

Patchset-level comments
File-level comment, Patchset 4 (Latest):
Qingwei Li . resolved

Do I need to add tests in extension/test/integration/goDebugConfiguration.test.ts and extension/test/integration/goDebug.test.ts?

Open in Gerrit

Related details

Attention is currently required from:
  • Hongxiang Jiang
  • Madeline Kalil
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: vscode-go
Gerrit-Branch: master
Gerrit-Change-Id: I6f759356851938547a5db35c39309899e0200428
Gerrit-Change-Number: 696795
Gerrit-PatchSet: 4
Gerrit-Owner: Gerrit Bot <letsus...@gmail.com>
Gerrit-Reviewer: Hongxiang Jiang <hxj...@golang.org>
Gerrit-Reviewer: Madeline Kalil <mka...@google.com>
Gerrit-CC: Gopher Robot <go...@golang.org>
Gerrit-CC: Qingwei Li <lqw332...@mail.ustc.edu.cn>
Gerrit-Attention: Madeline Kalil <mka...@google.com>
Gerrit-Attention: Hongxiang Jiang <hxj...@golang.org>
Gerrit-Comment-Date: Sun, 07 Dec 2025 02:53:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
unsatisfied_requirement
satisfied_requirement
open
diffy

Hongxiang Jiang (Gerrit)

unread,
Dec 7, 2025, 3:16:24 AM (9 days ago) Dec 7
to Qingwei Li, Gerrit Bot, goph...@pubsubhelper.golang.org, Madeline Kalil, Gopher Robot, golang-co...@googlegroups.com
Attention needed from Madeline Kalil

Hongxiang Jiang voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Madeline Kalil
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: vscode-go
Gerrit-Branch: master
Gerrit-Change-Id: I6f759356851938547a5db35c39309899e0200428
Gerrit-Change-Number: 696795
Gerrit-PatchSet: 4
Gerrit-Owner: Gerrit Bot <letsus...@gmail.com>
Gerrit-Reviewer: Hongxiang Jiang <hxj...@golang.org>
Gerrit-Reviewer: Madeline Kalil <mka...@google.com>
Gerrit-CC: Gopher Robot <go...@golang.org>
Gerrit-CC: Qingwei Li <lqw332...@mail.ustc.edu.cn>
Gerrit-Attention: Madeline Kalil <mka...@google.com>
Gerrit-Comment-Date: Sun, 07 Dec 2025 08:16:14 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
unsatisfied_requirement
satisfied_requirement
open
diffy

Hongxiang Jiang (Gerrit)

unread,
Dec 8, 2025, 9:17:08 PM (8 days ago) Dec 8
to Qingwei Li, Gerrit Bot, goph...@pubsubhelper.golang.org, Go LUCI, Madeline Kalil, Gopher Robot, golang-co...@googlegroups.com
Attention needed from Madeline Kalil

Hongxiang Jiang voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Madeline Kalil
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: vscode-go
Gerrit-Branch: master
Gerrit-Change-Id: I6f759356851938547a5db35c39309899e0200428
Gerrit-Change-Number: 696795
Gerrit-PatchSet: 4
Gerrit-Owner: Gerrit Bot <letsus...@gmail.com>
Gerrit-Reviewer: Hongxiang Jiang <hxj...@golang.org>
Gerrit-Reviewer: Madeline Kalil <mka...@google.com>
Gerrit-CC: Gopher Robot <go...@golang.org>
Gerrit-CC: Qingwei Li <lqw332...@mail.ustc.edu.cn>
Gerrit-Attention: Madeline Kalil <mka...@google.com>
Gerrit-Comment-Date: Tue, 09 Dec 2025 02:17:02 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
unsatisfied_requirement
satisfied_requirement
open
diffy

Qingwei Li (Gerrit)

unread,
Dec 11, 2025, 9:18:31 PM (5 days ago) Dec 11
to Gerrit Bot, goph...@pubsubhelper.golang.org, Go LUCI, Hongxiang Jiang, Madeline Kalil, Gopher Robot, golang-co...@googlegroups.com
Attention needed from Hongxiang Jiang and Madeline Kalil

Qingwei Li added 1 comment

Patchset-level comments
Qingwei Li . unresolved

I ran `go test integration_test.go` in `build` directory locally. I also got `test timed out after 10m0s`. I inspected the container build log, and I found that the step to "Install xvfb jq" took 17m to finish with output "debconf: delaying package configuration, since apt-utils is not installed". Is there something to do to optimize the step?
Besides, I notice that in the first CI test, go1.25 is passed but gotip is not passed. Are these test results random?

Open in Gerrit

Related details

Attention is currently required from:
  • Hongxiang Jiang
  • Madeline Kalil
Submit Requirements:
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    • requirement is not satisfiedTryBots-Pass
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: vscode-go
    Gerrit-Branch: master
    Gerrit-Change-Id: I6f759356851938547a5db35c39309899e0200428
    Gerrit-Change-Number: 696795
    Gerrit-PatchSet: 4
    Gerrit-Owner: Gerrit Bot <letsus...@gmail.com>
    Gerrit-Reviewer: Hongxiang Jiang <hxj...@golang.org>
    Gerrit-Reviewer: Madeline Kalil <mka...@google.com>
    Gerrit-CC: Gopher Robot <go...@golang.org>
    Gerrit-CC: Qingwei Li <lqw332...@mail.ustc.edu.cn>
    Gerrit-Attention: Madeline Kalil <mka...@google.com>
    Gerrit-Attention: Hongxiang Jiang <hxj...@golang.org>
    Gerrit-Comment-Date: Fri, 12 Dec 2025 02:18:24 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    unsatisfied_requirement
    open
    diffy

    Hongxiang Jiang (Gerrit)

    unread,
    Dec 15, 2025, 10:19:32 PM (16 hours ago) Dec 15
    to Qingwei Li, Gerrit Bot, goph...@pubsubhelper.golang.org, Go LUCI, Madeline Kalil, Gopher Robot, golang-co...@googlegroups.com
    Attention needed from Madeline Kalil

    Hongxiang Jiang voted Commit-Queue+1

    Commit-Queue+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Madeline Kalil
    Submit Requirements:
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    • requirement is not satisfiedTryBots-Pass
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: vscode-go
    Gerrit-Branch: master
    Gerrit-Change-Id: I6f759356851938547a5db35c39309899e0200428
    Gerrit-Change-Number: 696795
    Gerrit-PatchSet: 4
    Gerrit-Owner: Gerrit Bot <letsus...@gmail.com>
    Gerrit-Reviewer: Hongxiang Jiang <hxj...@golang.org>
    Gerrit-Reviewer: Madeline Kalil <mka...@google.com>
    Gerrit-CC: Gopher Robot <go...@golang.org>
    Gerrit-CC: Qingwei Li <lqw332...@mail.ustc.edu.cn>
    Gerrit-Attention: Madeline Kalil <mka...@google.com>
    Gerrit-Comment-Date: Tue, 16 Dec 2025 03:19:25 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    unsatisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages