[go] cmd/go: parse test files in parallel

2 views
Skip to first unread message

Jake Bailey (Gerrit)

unread,
Jun 30, 2026, 4:06:53 PMJun 30
to goph...@pubsubhelper.golang.org, Quim Muntal, Michael Matloob, golang...@luci-project-accounts.iam.gserviceaccount.com, golang-co...@googlegroups.com
Attention needed from Michael Matloob and Quim Muntal

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:
  • Michael Matloob
  • Quim Muntal
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: If5d7efcf46156fac624d542c639db460d5d49c5f
Gerrit-Change-Number: 795742
Gerrit-PatchSet: 1
Gerrit-Owner: Jake Bailey <jacob.b...@gmail.com>
Gerrit-Reviewer: Jake Bailey <jacob.b...@gmail.com>
Gerrit-Reviewer: Michael Matloob <mat...@golang.org>
Gerrit-Reviewer: Quim Muntal <quimm...@gmail.com>
Gerrit-Attention: Quim Muntal <quimm...@gmail.com>
Gerrit-Attention: Michael Matloob <mat...@golang.org>
Gerrit-Comment-Date: Tue, 30 Jun 2026 20:06:48 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
unsatisfied_requirement
satisfied_requirement
open
diffy

Jake Bailey (Gerrit)

unread,
Jun 30, 2026, 4:28:00 PMJun 30
to goph...@pubsubhelper.golang.org, Quim Muntal, Michael Matloob, golang...@luci-project-accounts.iam.gserviceaccount.com, golang-co...@googlegroups.com
Attention needed from Michael Matloob and Quim Muntal

Jake Bailey added 1 comment

File src/cmd/go/internal/load/test.go
Line 656, Patchset 1 (Latest): t.Tests = append(t.Tests, r.funcs.Tests...)
Jake Bailey . resolved

I will note that an even better thing on top of this stack is to store this info in modindex like other info; that drops the load time in my example from 1s to 0.2s. But it's a bigger change for sure and does have perf implications for that cache.

Gerrit-Comment-Date: Tue, 30 Jun 2026 20:27:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
unsatisfied_requirement
satisfied_requirement
open
diffy

Jake Bailey (Gerrit)

unread,
3:48 PM (7 hours ago) 3:48 PM
to goph...@pubsubhelper.golang.org, golang...@luci-project-accounts.iam.gserviceaccount.com, Quim Muntal, Michael Matloob, golang-co...@googlegroups.com
Attention needed from Michael Matloob and Quim Muntal

Jake Bailey voted Auto-Submit+1

Auto-Submit+1
Open in Gerrit

Related details

Attention is currently required from:
  • Michael Matloob
  • Quim Muntal
Submit Requirements:
    • requirement is not satisfiedCode-Review
    • requirement satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    • requirement satisfiedTryBots-Pass
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: go
    Gerrit-Branch: master
    Gerrit-Change-Id: If5d7efcf46156fac624d542c639db460d5d49c5f
    Gerrit-Change-Number: 795742
    Gerrit-PatchSet: 3
    Gerrit-Owner: Jake Bailey <jacob.b...@gmail.com>
    Gerrit-Reviewer: Jake Bailey <jacob.b...@gmail.com>
    Gerrit-Reviewer: Michael Matloob <mat...@golang.org>
    Gerrit-Reviewer: Quim Muntal <quimm...@gmail.com>
    Gerrit-Attention: Quim Muntal <quimm...@gmail.com>
    Gerrit-Attention: Michael Matloob <mat...@golang.org>
    Gerrit-Comment-Date: Fri, 07 Aug 2026 19:48:04 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    unsatisfied_requirement
    satisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages