[go] doc/go1.21: mention multipath TCP support
Ian Lance Taylor (Gerrit)
Attention is currently required from: Eli Bendersky.
Ian Lance Taylor would like Eli Bendersky to review this change.
doc/go1.21: mention multipath TCP support
For #56539
For #59166
Change-Id: Ief392464916a1a74a8fcc6c3c7bdb213e8c6ef98
---
M doc/go1.21.html
1 file changed, 20 insertions(+), 17 deletions(-)
diff --git a/doc/go1.21.html b/doc/go1.21.html
index 3758d28..8c0d927 100644
--- a/doc/go1.21.html
+++ b/doc/go1.21.html
@@ -568,24 +568,27 @@
<dl id="net"><dt><a href="/pkg/net/">net</a></dt>
<dd>
- <p><!-- https://go.dev/issue/56539 -->
- TODO: <a href="https://go.dev/issue/56539">https://go.dev/issue/56539</a>: add support for MPTCP
+ <p>
+ <!-- https://go.dev/issue/59166, https://go.dev/issue/56539 -->
+ <!-- CL 471136, CL 471137, CL 471140 -->
+ On Linux, the <a href="/pkg/net/">net</a> package can now use
+ Multipath TCP when the kernel supports it. It is not used by
+ default. To use Multipath TCP when possible, call the
+ <a href="/pkg/net/#Dialer.SetMultipathTCP"><code>Dialer.SetMultipathTCP</code></a>
+ method before calling the
+ <a href="/pkg/net/#Dialer.Dial"><code>Dialer.Dial</code></a> or
+ <a href="/pkg/net/#Dialer.DialContext"><code>Dialer.DialContext</code></a>
+ methods. Specify the network as <code>"tcp"</code>
+ or <code>"tcp4"</code> or <code>"tcp6"</code> as usual. If
+ Multipath TCP is not supported by the kernel or the remote host,
+ the connection will silently fall back to TCP. To test whether a
+ particular connection is using Multipath TCP, use the
+ <a href="/pkg/net/#TCPConn.MultipathTCP"><code>TCPConn.MultipathTCP</code></a>
+ method.
</p>
-
- <p><!-- https://go.dev/issue/59166 -->
- TODO: <a href="https://go.dev/issue/59166">https://go.dev/issue/59166</a>: add func (*TCPConn) MultipathTCP() (bool, error)
- </p>
-
- <p><!-- CL 471136 -->
- TODO: <a href="https://go.dev/cl/471136">https://go.dev/cl/471136</a>: net: mptcp: implement dialMPTCP; modified api/next/56539.txt
- </p>
-
- <p><!-- CL 471137 -->
- TODO: <a href="https://go.dev/cl/471137">https://go.dev/cl/471137</a>: net: mptcp: implement listenMPTCP; modified api/next/56539.txt
- </p>
-
- <p><!-- CL 471140 -->
- TODO: <a href="https://go.dev/cl/471140">https://go.dev/cl/471140</a>: net: mptcp: add TCPConn's MultipathTCP checker; modified api/next/59166.txt
+ <p>
+ In the future Go 1.22 release, we may enable Multipath TCP by
+ default on systems that support it.
</p>
</dd>
</dl><!-- net -->
To view, visit change 498601. To unsubscribe, or for help writing mail filters, visit settings.
Matthieu Baerts (Gerrit)
Attention is currently required from: Eli Bendersky, Ian Lance Taylor.
2 comments:
Patchset:
Thank you for having looked at that!
File doc/go1.21.html:
To use Multipath TCP when possible, call the
<a href="/pkg/net/#Dialer.SetMultipathTCP"><code>Dialer.SetMultipathTCP</code></a>
method before calling the
<a href="/pkg/net/#Dialer.Dial"><code>Dialer.Dial</code></a> or
<a href="/pkg/net/#Dialer.DialContext"><code>Dialer.DialContext</code></a>
methods.
Should there be a note about the listener part? (similarly by using `ListenConfig.SetMultipathTCP` method before calling `Listen`?)
To view, visit change 498601. To unsubscribe, or for help writing mail filters, visit settings.
Ian Lance Taylor (Gerrit)
Attention is currently required from: Eli Bendersky, Ian Lance Taylor.
Ian Lance Taylor uploaded patch set #2 to this change.
The following approvals got outdated and were removed: Run-TryBot+1 by Ian Lance Taylor, TryBot-Result+1 by Gopher Robot
doc/go1.21: mention multipath TCP support
For #56539
For #59166
Change-Id: Ief392464916a1a74a8fcc6c3c7bdb213e8c6ef98
---
M doc/go1.21.html
1 file changed, 26 insertions(+), 17 deletions(-)
To view, visit change 498601. To unsubscribe, or for help writing mail filters, visit settings.
Ian Lance Taylor (Gerrit)
Attention is currently required from: Eli Bendersky, Matthieu Baerts.
Patch set 1:Run-TryBot +1
1 comment:
File doc/go1.21.html:
To use Multipath TCP when possible, call the
<a href="/pkg/net/#Dialer.SetMultipathTCP"><code>Dialer.SetMultipathTCP</code></a>
method before calling the
<a href="/pkg/net/#Dialer.Dial"><code>Dialer.Dial</code></a> or
<a href="/pkg/net/#Dialer.DialContext"><code>Dialer.DialContext</code></a>
methods.
Should there be a note about the listener part? (similarly by using `ListenConfig. […]
Done, thanks.
To view, visit change 498601. To unsubscribe, or for help writing mail filters, visit settings.
Matthieu Baerts (Gerrit)
Attention is currently required from: Eli Bendersky, Ian Lance Taylor.
Patch set 2:Code-Review +1
1 comment:
Patchset:
Thanks for the update!
To view, visit change 498601. To unsubscribe, or for help writing mail filters, visit settings.
Eli Bendersky (Gerrit)
Attention is currently required from: Ian Lance Taylor.
Patch set 2:Code-Review +2
1 comment:
File doc/go1.21.html:
Patch Set #2, Line 636:
In the future Go 1.22 release, we may enable Multipath TCP byNit: do we typically make specific version promises like this one in release notes? Should it just say "In a future Go release, ..."?
To view, visit change 498601. To unsubscribe, or for help writing mail filters, visit settings.
Ian Lance Taylor (Gerrit)
Attention is currently required from: Ian Lance Taylor.
Ian Lance Taylor uploaded patch set #3 to this change.
The following approvals got outdated and were removed: Run-TryBot+1 by Ian Lance Taylor, TryBot-Result+1 by Gopher Robot
doc/go1.21: mention multipath TCP support
For #56539
For #59166
Change-Id: Ief392464916a1a74a8fcc6c3c7bdb213e8c6ef98
---
M doc/go1.21.html
1 file changed, 26 insertions(+), 17 deletions(-)
To view, visit change 498601. To unsubscribe, or for help writing mail filters, visit settings.
Ian Lance Taylor (Gerrit)
Patch Set #2, Line 636:
In the future Go 1.22 release, we may enable Multipath TCP by
Nit: do we typically make specific version promises like this one in release notes? Should it just s […]
Done
To view, visit change 498601. To unsubscribe, or for help writing mail filters, visit settings.
Ian Lance Taylor (Gerrit)
Attention is currently required from: Ian Lance Taylor.
Patch set 3:Run-TryBot +1Auto-Submit +1Code-Review +1
Gopher Robot (Gerrit)
Gopher Robot submitted this change.
2 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: doc/go1.21.html
Insertions: 2, Deletions: 2.
@@ -633,8 +633,8 @@
method.
</p>
<p>
- In the future Go 1.22 release, we may enable Multipath TCP by
- default on systems that support it.
+ In a future Go release we may enable Multipath TCP by default on
+ systems that support it.
</p>
</dd>
</dl><!-- net -->
```
doc/go1.21: mention multipath TCP support
For #56539
For #59166
Change-Id: Ief392464916a1a74a8fcc6c3c7bdb213e8c6ef98
Reviewed-on: https://go-review.googlesource.com/c/go/+/498601
Run-TryBot: Ian Lance Taylor <ia...@google.com>
Run-TryBot: Ian Lance Taylor <ia...@golang.org>
Reviewed-by: Ian Lance Taylor <ia...@google.com>
Auto-Submit: Ian Lance Taylor <ia...@google.com>
Reviewed-by: Eli Bendersky <eli...@google.com>
TryBot-Result: Gopher Robot <go...@golang.org>
Reviewed-by: Matthieu Baerts <matthie...@tessares.net>
---
M doc/go1.21.html
1 file changed, 26 insertions(+), 17 deletions(-)
diff --git a/doc/go1.21.html b/doc/go1.21.html
index 075cee5..d3d79a2 100644
--- a/doc/go1.21.html
+++ b/doc/go1.21.html
@@ -608,24 +608,33 @@
<dl id="net"><dt><a href="/pkg/net/">net</a></dt>
<dd>
- <p><!-- https://go.dev/issue/56539 -->
- TODO: <a href="https://go.dev/issue/56539">https://go.dev/issue/56539</a>: add support for MPTCP
+ <p>
+ <!-- https://go.dev/issue/59166, https://go.dev/issue/56539 -->
+ <!-- CL 471136, CL 471137, CL 471140 -->
+ On Linux, the <a href="/pkg/net/">net</a> package can now use
+ Multipath TCP when the kernel supports it. It is not used by
+ default. To use Multipath TCP when available on a client, call
+ the
+ <a href="/pkg/net/#Dialer.SetMultipathTCP"><code>Dialer.SetMultipathTCP</code></a>
+ method before calling the
+ <a href="/pkg/net/#Dialer.Dial"><code>Dialer.Dial</code></a> or
+ <a href="/pkg/net/#Dialer.DialContext"><code>Dialer.DialContext</code></a>
+ methods. To use Multipath TCP when available on a server, call
+ the
+ <a href="/pkg/net/#ListenConfig.SetMultipathTCP"><code>ListenConfig.SetMultipathTCP</code></a>
+ method before calling the
+ <a href="/pkg/net/#ListenConfig.Listen"><code>ListenConfig.Listen</code></a>
+ method. Specify the network as <code>"tcp"</code> or
+ <code>"tcp4"</code> or <code>"tcp6"</code> as usual. If
+ Multipath TCP is not supported by the kernel or the remote host,
+ the connection will silently fall back to TCP. To test whether a
+ particular connection is using Multipath TCP, use the
+ <a href="/pkg/net/#TCPConn.MultipathTCP"><code>TCPConn.MultipathTCP</code></a>
+ method.
</p>
-
- <p><!-- https://go.dev/issue/59166 -->
- TODO: <a href="https://go.dev/issue/59166">https://go.dev/issue/59166</a>: add func (*TCPConn) MultipathTCP() (bool, error)
- </p>
-
- <p><!-- CL 471136 -->
- TODO: <a href="https://go.dev/cl/471136">https://go.dev/cl/471136</a>: net: mptcp: implement dialMPTCP; modified api/next/56539.txt
- </p>
-
- <p><!-- CL 471137 -->
- TODO: <a href="https://go.dev/cl/471137">https://go.dev/cl/471137</a>: net: mptcp: implement listenMPTCP; modified api/next/56539.txt
- </p>
-
- <p><!-- CL 471140 -->
- TODO: <a href="https://go.dev/cl/471140">https://go.dev/cl/471140</a>: net: mptcp: add TCPConn's MultipathTCP checker; modified api/next/59166.txt
+ <p>
+ In a future Go release we may enable Multipath TCP by default on
+ systems that support it.
</p>
</dd>
</dl><!-- net -->
To view, visit change 498601. To unsubscribe, or for help writing mail filters, visit settings.