[go] crypto/sha3: ensure unwrapped *sha3.Digest are usable
2 views
Skip to first unread message
Neal Patel (Gerrit)
Feb 19, 2026, 1:41:44 PMFeb 19
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Neal Patel has uploaded the change for review![]( "Open in Gerrit")
Commit message
crypto/sha3: ensure unwrapped *sha3.Digest are usable
Updates #75154
Change-Id: I57508b1360702d66a89d44b5bd2728decd075305
Change diff
diff --git a/src/crypto/hmac/hmac_test.go b/src/crypto/hmac/hmac_test.go
index 4046a95..d595205 100644
--- a/src/crypto/hmac/hmac_test.go
+++ b/src/crypto/hmac/hmac_test.go
@@ -7,9 +7,11 @@
import (
"crypto/internal/boring"
"crypto/internal/cryptotest"
+ "crypto/internal/fips140hash"
"crypto/md5"
"crypto/sha1"
"crypto/sha256"
+ "crypto/sha3"
"crypto/sha512"
"errors"
"fmt"
@@ -596,6 +598,34 @@
}
}
+func TestSHA3Hash(t *testing.T) {
+ for _, tc := range []struct {
+ name string
+ fn func() hash.Hash
+ }{
+ {
+ "sha3 zero init hash",
+ func() hash.Hash { return justHash{&sha3.SHA3{}} },
+ },
+ {
+ "sha3 zero init hash by linkname",
+ func() hash.Hash { return justHash{fips140hash.Unwrap(&sha3.SHA3{})} },
+ },
+ } {
+ t.Run(tc.name, func(t *testing.T) {
+ h := New(tc.fn, []byte("key"))
+ if _, ok := h.(hash.Cloner); !ok {
+ t.Skip("no Cloner support")
+ }
+ h.Write([]byte("test"))
+ _, err := h.(hash.Cloner).Clone()
+ if !errors.Is(err, errors.ErrUnsupported) {
+ t.Errorf("Clone() = %v, want ErrUnsupported", err)
+ }
+ })
+ }
+}
+
func TestNonUniqueHash(t *testing.T) {
if boring.Enabled {
t.Skip("hash.Hash provided by boringcrypto are not comparable")
diff --git a/src/crypto/sha3/sha3.go b/src/crypto/sha3/sha3.go
index 48c67e9..4711f18 100644
--- a/src/crypto/sha3/sha3.go
+++ b/src/crypto/sha3/sha3.go
@@ -104,6 +104,7 @@
//go:linkname fips140hash_sha3Unwrap crypto/internal/fips140hash.sha3Unwrap
func fips140hash_sha3Unwrap(sha3 *SHA3) *sha3.Digest {
+ sha3.init()
return &sha3.s
}
Change information
Files:
- M src/crypto/hmac/hmac_test.go
- M src/crypto/sha3/sha3.go
Change size: S
Delta: 2 files changed, 31 insertions(+), 0 deletions(-)
Related details
Attention set is empty
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Neal Patel (Gerrit)
Feb 19, 2026, 1:41:51 PMFeb 19
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Neal Patel voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention set is empty
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Neal Patel (Gerrit)
Feb 19, 2026, 1:45:22 PMFeb 19
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Attention needed from Neal Patel
Neal Patel uploaded new patchset![]( "Open in Gerrit")
Neal Patel uploaded patch set #2 to this change.
Related details
Attention is currently required from:
- Neal Patel
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Neal Patel (Gerrit)
Feb 19, 2026, 1:45:35 PMFeb 19
to goph...@pubsubhelper.golang.org, Go LUCI, golang-co...@googlegroups.com
Neal Patel voted Commit-Queue+1![]( "Open in Gerrit")
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Neal Patel (Gerrit)
Feb 19, 2026, 1:55:28 PMFeb 19
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Attention needed from Neal Patel
Neal Patel uploaded new patchset![]( "Open in Gerrit")
Attention is currently required from:
- Neal Patel
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Neal Patel (Gerrit)
Feb 19, 2026, 1:55:49 PMFeb 19
to goph...@pubsubhelper.golang.org, Go LUCI, Roland Shoemaker, Quim Muntal, Filippo Valsorda, golang-co...@googlegroups.com
Neal Patel voted Commit-Queue+1![]( "Open in Gerrit")
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Neal Patel (Gerrit)
Feb 19, 2026, 1:56:17 PMFeb 19
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Attention needed from Neal Patel and Roland Shoemaker
Neal Patel uploaded new patchset![]( "Open in Gerrit")
Attention is currently required from:
- Neal Patel
- Roland Shoemaker
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Neal Patel (Gerrit)
Feb 19, 2026, 1:56:43 PMFeb 19
to goph...@pubsubhelper.golang.org, Go LUCI, Roland Shoemaker, Quim Muntal, Filippo Valsorda, golang-co...@googlegroups.com
Attention needed from Roland Shoemaker
Neal Patel voted Commit-Queue+1![]( "Open in Gerrit")
Attention is currently required from:
- Roland Shoemaker
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Neal Patel (Gerrit)
Apr 8, 2026, 7:56:01 PM (6 hours ago) Apr 8
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Attention needed from Filippo Valsorda and Roland Shoemaker
Neal Patel uploaded new patchset![]( "Open in Gerrit")
Neal Patel uploaded patch set #5 to this change.
Following approvals got outdated and were removed:
- TryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
Related details
Attention is currently required from:
- Filippo Valsorda
- Roland Shoemaker
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Neal Patel (Gerrit)
Apr 8, 2026, 7:56:13 PM (6 hours ago) Apr 8
to goph...@pubsubhelper.golang.org, Filippo Valsorda, Go LUCI, Roland Shoemaker, Quim Muntal, golang-co...@googlegroups.com
Attention needed from Filippo Valsorda and Roland Shoemaker
Neal Patel voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Filippo Valsorda
- Roland Shoemaker
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages