[net] quic: return an error from Accept after PacketConn reader exists
2 views
Skip to first unread message
Damien Neil (Gerrit)
Jul 20, 2026, 6:02:05 PM (yesterday) Jul 20
to goph...@pubsubhelper.golang.org, Nicholas Husin, golang-co...@googlegroups.com
Attention needed from Nicholas Husin
Damien Neil voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Nicholas Husin
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Damien Neil (Gerrit)
Jul 20, 2026, 7:20:32 PM (yesterday) Jul 20
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Attention needed from Damien Neil and Nicholas Husin
Damien Neil uploaded new patchset![]( "Open in Gerrit")
Damien Neil uploaded patch set #2 to this change.
Following approvals got outdated and were removed:
- TryBots-Pass: LUCI-TryBot-Result-1 by golang...@luci-project-accounts.iam.gserviceaccount.com
Related details
Attention is currently required from:
- Damien Neil
- Nicholas Husin
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Damien Neil (Gerrit)
Jul 20, 2026, 7:20:46 PM (yesterday) Jul 20
to goph...@pubsubhelper.golang.org, golang...@luci-project-accounts.iam.gserviceaccount.com, Nicholas Husin, golang-co...@googlegroups.com
Attention needed from Nicholas Husin
Damien Neil voted Commit-Queue+1![]( "Open in Gerrit")
Attention is currently required from:
- Nicholas Husin
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nicholas Husin (Gerrit)
11:29 AM (11 hours ago) 11:29 AM
to Damien Neil, goph...@pubsubhelper.golang.org, golang...@luci-project-accounts.iam.gserviceaccount.com, golang-co...@googlegroups.com
Attention needed from Damien Neil
Nicholas Husin voted and added 2 comments![]( "Open in Gerrit")
Votes added by Nicholas Husin
| Code-Review | +2 |
2 comments
Commit Message
Line 7, Patchset 2 (Latest):
quic: return an error from Accept after PacketConn reader existsNicholas Husin . unresolved
Typo.
File quic/endpoint_test.go
Line 149, Patchset 2 (Latest):
t.Errorf("Accept succeded; want error")Nicholas Husin . unresolved
"succeeded" I think.
Related details
Attention is currently required from:
- Damien Neil
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nicholas Husin (Gerrit)
11:29 AM (11 hours ago) 11:29 AM
to Damien Neil, goph...@pubsubhelper.golang.org, Nicholas Husin, golang...@luci-project-accounts.iam.gserviceaccount.com, golang-co...@googlegroups.com
Attention needed from Damien Neil
Nicholas Husin voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Damien Neil
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Damien Neil (Gerrit)
11:55 AM (11 hours ago) 11:55 AM
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Attention needed from Damien Neil
Damien Neil uploaded new patchset![]( "Open in Gerrit")
Damien Neil uploaded patch set #3 to this change.
Following approvals got outdated and were removed:
- TryBots-Pass: LUCI-TryBot-Result+1 by golang...@luci-project-accounts.iam.gserviceaccount.com
Related details
Attention is currently required from:
- Damien Neil
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Damien Neil (Gerrit)
11:56 AM (11 hours ago) 11:56 AM
to goph...@pubsubhelper.golang.org, Nicholas Husin, Nicholas Husin, golang...@luci-project-accounts.iam.gserviceaccount.com, golang-co...@googlegroups.com
Damien Neil voted and added 2 comments![]( "Open in Gerrit")
Votes added by Damien Neil
| Auto-Submit | +1 |
| Commit-Queue | +1 |
2 comments
Commit Message
Line 7, Patchset 2:
quic: return an error from Accept after PacketConn reader existsNicholas Husin . resolved
Damien NeilTypo.
Done
File quic/endpoint_test.go
Line 149, Patchset 2:
t.Errorf("Accept succeded; want error")Nicholas Husin . resolved
Damien Neil"succeeded" I think.
Done
Related details
Attention set is empty
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gopher Robot (Gerrit)
5:47 PM (5 hours ago) 5:47 PM
to Damien Neil, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, golang...@luci-project-accounts.iam.gserviceaccount.com, Nicholas Husin, Nicholas Husin, golang-co...@googlegroups.com
Gopher Robot submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
2 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: quic/endpoint_test.go
Insertions: 1, Deletions: 1.
@@ -146,7 +146,7 @@
udpConn.Close()
if _, err := e.e.Accept(t.Context()); err == nil {
- t.Errorf("Accept succeded; want error")
+ t.Errorf("Accept succeeded; want error")
}
})
}
```
Change information
Commit message:
quic: return an error from Accept after PacketConn reader exits
If we encounter an error reading from an endpoint's PacketConn,
the reader exits and the endpoint becomes unusable.
Return an error from Accept, rather than blocking forever.
Change-Id: Ia3c306d37d93c857be05999b9c642f456a6a6964
Reviewed-on: https://go-review.googlesource.com/c/net/+/803300
Auto-Submit: Damien Neil <dn...@google.com>
LUCI-TryBot-Result: golang...@luci-project-accounts.iam.gserviceaccount.com <golang...@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Nicholas Husin <hu...@google.com>
Reviewed-by: Nicholas Husin <n...@golang.org>
Files:
- M quic/endpoint.go
- M quic/endpoint_test.go
- M quic/udp_msg.go
- M quic/udp_other.go
- M quic/udp_packetconn.go
Change size: S
Delta: 5 files changed, 31 insertions(+), 11 deletions(-)
Branch: refs/heads/master
Submit Requirements:
Code-Review: +2 by Nicholas Husin, +1 by Nicholas Husin
TryBots-Pass: LUCI-TryBot-Result+1 by golang...@luci-project-accounts.iam.gserviceaccount.com
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages