[go] cmd/go: emit coverage for selected build dependencies
5 views
Skip to first unread message
Harjoth Khara (Gerrit)
Jul 16, 2026, 2:06:04 AM (6 days ago) Jul 16
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Message from Harjoth Khara![]( "Open in Gerrit")
Set Ready For Review
Related details
Attention set is empty
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Sean Liao (Gerrit)
Jul 19, 2026, 11:37:34 AM (2 days ago) Jul 19
to Harjoth Khara, goph...@pubsubhelper.golang.org, Michael Matloob, golang-co...@googlegroups.com
Attention needed from Harjoth Khara and Michael Matloob
Sean Liao added 1 comment![]( "Open in Gerrit")
File src/cmd/go/internal/load/pkg.go
Line 3584, Patchset 1 (Latest):
if !haveMatch && (!includeMain || p.Name != "main") {Sean Liao . unresolved
I think this is too many negatives to read.
Instead, move the cmode declaration and the main override block at 3627 before this check.
Related details
Attention is currently required from:
- Harjoth Khara
- Michael Matloob
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Harjoth Khara (Gerrit)
Jul 19, 2026, 1:57:19 PM (2 days ago) Jul 19
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Attention needed from Harjoth Khara and Michael Matloob
Harjoth Khara uploaded new patchset![]( "Open in Gerrit")
Harjoth Khara uploaded patch set #2 to this change.
Related details
Attention is currently required from:
- Harjoth Khara
- Michael Matloob
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Harjoth Khara (Gerrit)
Jul 19, 2026, 1:58:16 PM (2 days ago) Jul 19
to goph...@pubsubhelper.golang.org, Michael Matloob, golang-co...@googlegroups.com
Attention needed from Michael Matloob and Sean Liao
Harjoth Khara added 1 comment![]( "Open in Gerrit")
File src/cmd/go/internal/load/pkg.go
Line 3584, Patchset 2 (Latest):
// detector to be invoked before it has been initialized. NoteHarjoth Khara . resolved
Thanks, that does read better. Moved cmode and the main override above the check so it's just if !haveMatch now.
Related details
Attention is currently required from:
- Michael Matloob
- Sean Liao
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Sean Liao (Gerrit)
Jul 19, 2026, 2:24:02 PM (2 days ago) Jul 19
to Harjoth Khara, goph...@pubsubhelper.golang.org, Michael Matloob, golang-co...@googlegroups.com
Attention needed from Harjoth Khara and Michael Matloob
Sean Liao voted![]( "Open in Gerrit")
Attention is currently required from:
- Harjoth Khara
- Michael Matloob
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Sean Liao (Gerrit)
Jul 19, 2026, 2:53:15 PM (2 days ago) Jul 19
to Harjoth Khara, goph...@pubsubhelper.golang.org, golang...@luci-project-accounts.iam.gserviceaccount.com, Michael Matloob, golang-co...@googlegroups.com
Attention needed from Harjoth Khara and Michael Matloob
Sean Liao voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Harjoth Khara
- Michael Matloob
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Matloob (Gerrit)
Jul 20, 2026, 12:29:51 PM (yesterday) Jul 20
to Harjoth Khara, goph...@pubsubhelper.golang.org, golang...@luci-project-accounts.iam.gserviceaccount.com, golang-co...@googlegroups.com
Attention needed from Harjoth Khara
Michael Matloob voted Code-Review+2![]( "Open in Gerrit")
| Code-Review | +2 |
Related details
Attention is currently required from:
- Harjoth Khara
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Matloob (Gerrit)
Jul 20, 2026, 12:31:24 PM (yesterday) Jul 20
to Harjoth Khara, goph...@pubsubhelper.golang.org, Michael Matloob, golang...@luci-project-accounts.iam.gserviceaccount.com, golang-co...@googlegroups.com
Attention needed from Harjoth Khara
Michael Matloob voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Harjoth Khara
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Harjoth Khara (Gerrit)
Jul 20, 2026, 1:06:45 PM (yesterday) Jul 20
to goph...@pubsubhelper.golang.org, Michael Matloob, Michael Matloob, golang...@luci-project-accounts.iam.gserviceaccount.com, golang-co...@googlegroups.com
Attention needed from Michael Matloob
Message from Harjoth Khara![]( "Open in Gerrit")
Attention is currently required from:
- Michael Matloob
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Matloob (Gerrit)
Jul 20, 2026, 2:22:40 PM (yesterday) Jul 20
to Harjoth Khara, goph...@pubsubhelper.golang.org, Michael Matloob, golang...@luci-project-accounts.iam.gserviceaccount.com, golang-co...@googlegroups.com
Attention needed from Harjoth Khara and Michael Matloob
Michael Matloob added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 2 (Latest):
Michael Matloob . resolved
There's no need to add someone. We have a list of CLs that need an extra +1 (go.dev/s/needs-review) and have a rotation that looks at it and adds +1s.
Related details
Attention is currently required from:
- Harjoth Khara
- Michael Matloob
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Carlos Amedee (Gerrit)
5:37 PM (5 hours ago) 5:37 PM
to Harjoth Khara, goph...@pubsubhelper.golang.org, Michael Matloob, Michael Matloob, golang...@luci-project-accounts.iam.gserviceaccount.com, golang-co...@googlegroups.com
Attention needed from Harjoth Khara
Carlos Amedee voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Harjoth Khara
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Sean Liao (Gerrit)
6:03 PM (5 hours ago) 6:03 PM
to Harjoth Khara, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Carlos Amedee, Michael Matloob, Michael Matloob, golang...@luci-project-accounts.iam.gserviceaccount.com, golang-co...@googlegroups.com
Sean Liao submitted the change![]( "Open in Gerrit")
Change information
Commit message:
cmd/go: emit coverage for selected build dependencies
When -coverpkg excludes the main package, SelectCoverPackages returns
before the existing regonly path can add the main package's coverage
registration hook. Allow unmatched main packages through that gate so
covered dependencies can emit metadata and counters.
Add a script regression for building with coverage limited to an
external dependency, and align the fixture's required module with its
imported package for deterministic cold-cache resolution.
Fixes #80307
Change-Id: I8867cd40069a897a52a89085acbfc743f531aec5
Reviewed-on: https://go-review.googlesource.com/c/go/+/801381
LUCI-TryBot-Result: golang...@luci-project-accounts.iam.gserviceaccount.com <golang...@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Michael Matloob <mat...@google.com>
Reviewed-by: Michael Matloob <mat...@golang.org>
Reviewed-by: Sean Liao <se...@liao.dev>
Reviewed-by: Carlos Amedee <car...@golang.org>
Files:
- M src/cmd/go/internal/load/pkg.go
- M src/cmd/go/testdata/script/cover_build_pkg_select.txt
Change size: M
Delta: 2 files changed, 47 insertions(+), 24 deletions(-)
Branch: refs/heads/master
Submit Requirements:
Code-Review: +1 by Michael Matloob, +1 by Carlos Amedee, +2 by Sean Liao, +2 by Michael Matloob
TryBots-Pass: LUCI-TryBot-Result+1 by golang...@luci-project-accounts.iam.gserviceaccount.com
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages