[go] cmd/go/internal/vcs: use 0o for octal

3 views
Skip to first unread message

Josh Bleecher Snyder (Gerrit)

unread,
Jan 14, 2026, 5:04:58 PM (3 days ago) Jan 14
to goph...@pubsubhelper.golang.org, Josh Bleecher Snyder, golang-co...@googlegroups.com

Josh Bleecher Snyder has uploaded the change for review

Commit message

cmd/go/internal/vcs: use 0o for octal
Change-Id: I011cd7e1c2c614e2c5c4a0fadf062ac9be2266aa

Change diff

diff --git a/src/cmd/go/internal/vcs/vcs.go b/src/cmd/go/internal/vcs/vcs.go
index 7c198c5..88aeee5 100644
--- a/src/cmd/go/internal/vcs/vcs.go
+++ b/src/cmd/go/internal/vcs/vcs.go
@@ -755,7 +755,7 @@
 	if !cfg.ModulesEnabled {
 		dir = filepath.Join(cfg.BuildContext.GOPATH, "src")
 	}
-	os.MkdirAll(dir, 0777) // Ignore errors — if unsuccessful, the command will likely fail.
+	os.MkdirAll(dir, 0o777) // Ignore errors — if unsuccessful, the command will likely fail.
 
 	release, err := base.AcquireNet()
 	if err != nil {

Change information

Files:
  • M src/cmd/go/internal/vcs/vcs.go
Change size: XS
Delta: 1 file changed, 1 insertion(+), 1 deletion(-)
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: I011cd7e1c2c614e2c5c4a0fadf062ac9be2266aa
Gerrit-Change-Number: 736440
Gerrit-PatchSet: 1
Gerrit-Owner: Josh Bleecher Snyder <josh...@gmail.com>
unsatisfied_requirement
satisfied_requirement
open
diffy

Ian Lance Taylor (Gerrit)

unread,
Jan 14, 2026, 5:36:36 PM (3 days ago) Jan 14
to Josh Bleecher Snyder, goph...@pubsubhelper.golang.org, Ian Lance Taylor, golang-co...@googlegroups.com
Attention needed from Josh Bleecher Snyder

Ian Lance Taylor voted and added 1 comment

Votes added by Ian Lance Taylor

Code-Review+2
Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Ian Lance Taylor . resolved

Thanks.

Open in Gerrit

Related details

Attention is currently required from:
  • Josh Bleecher Snyder
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: I011cd7e1c2c614e2c5c4a0fadf062ac9be2266aa
Gerrit-Change-Number: 736440
Gerrit-PatchSet: 1
Gerrit-Owner: Josh Bleecher Snyder <josh...@gmail.com>
Gerrit-Reviewer: Ian Lance Taylor <ia...@golang.org>
Gerrit-Attention: Josh Bleecher Snyder <josh...@gmail.com>
Gerrit-Comment-Date: Wed, 14 Jan 2026 22:36:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Ian Lance Taylor (Gerrit)

unread,
Jan 14, 2026, 5:59:31 PM (3 days ago) Jan 14
to Josh Bleecher Snyder, goph...@pubsubhelper.golang.org, Ian Lance Taylor, Go LUCI, golang-co...@googlegroups.com
Attention needed from Josh Bleecher Snyder

Ian Lance Taylor voted

Code-Review+2
Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Josh Bleecher Snyder
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: I011cd7e1c2c614e2c5c4a0fadf062ac9be2266aa
Gerrit-Change-Number: 736440
Gerrit-PatchSet: 2
Gerrit-Owner: Josh Bleecher Snyder <josh...@gmail.com>
Gerrit-Reviewer: Ian Lance Taylor <ia...@golang.org>
Gerrit-Attention: Josh Bleecher Snyder <josh...@gmail.com>
Gerrit-Comment-Date: Wed, 14 Jan 2026 22:59:28 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Florian Lehner (Gerrit)

unread,
Jan 15, 2026, 7:33:50 AM (2 days ago) Jan 15
to Josh Bleecher Snyder, goph...@pubsubhelper.golang.org, Go LUCI, Ian Lance Taylor, golang-co...@googlegroups.com
Attention needed from Josh Bleecher Snyder

Florian Lehner voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Josh Bleecher Snyder
Submit Requirements:
    • requirement satisfiedCode-Review
    • requirement satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    • requirement satisfiedTryBots-Pass
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: go
    Gerrit-Branch: master
    Gerrit-Change-Id: I011cd7e1c2c614e2c5c4a0fadf062ac9be2266aa
    Gerrit-Change-Number: 736440
    Gerrit-PatchSet: 2
    Gerrit-Owner: Josh Bleecher Snyder <josh...@gmail.com>
    Gerrit-Reviewer: Florian Lehner <lehner.f...@gmail.com>
    Gerrit-Reviewer: Ian Lance Taylor <ia...@golang.org>
    Gerrit-Attention: Josh Bleecher Snyder <josh...@gmail.com>
    Gerrit-Comment-Date: Thu, 15 Jan 2026 12:33:43 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Michael Pratt (Gerrit)

    unread,
    Jan 16, 2026, 4:32:18 PM (yesterday) Jan 16
    to Josh Bleecher Snyder, goph...@pubsubhelper.golang.org, Michael Pratt, Go LUCI, Ian Lance Taylor, golang-co...@googlegroups.com
    Attention needed from Josh Bleecher Snyder

    Michael Pratt voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Josh Bleecher Snyder
    Submit Requirements:
      • requirement satisfiedCode-Review
      • requirement satisfiedNo-Unresolved-Comments
      • requirement is not satisfiedNo-Wait-Release
      • requirement is not satisfiedReview-Enforcement
      • requirement satisfiedTryBots-Pass
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: go
      Gerrit-Branch: master
      Gerrit-Change-Id: I011cd7e1c2c614e2c5c4a0fadf062ac9be2266aa
      Gerrit-Change-Number: 736440
      Gerrit-PatchSet: 2
      Gerrit-Owner: Josh Bleecher Snyder <josh...@gmail.com>
      Gerrit-Reviewer: Florian Lehner <lehner.f...@gmail.com>
      Gerrit-Reviewer: Ian Lance Taylor <ia...@golang.org>
      Gerrit-Reviewer: Michael Pratt <mpr...@google.com>
      Gerrit-Attention: Josh Bleecher Snyder <josh...@gmail.com>
      Gerrit-Comment-Date: Fri, 16 Jan 2026 21:32:15 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Junyang Shao (Gerrit)

      unread,
      Jan 16, 2026, 4:42:20 PM (yesterday) Jan 16
      to Josh Bleecher Snyder, goph...@pubsubhelper.golang.org, Michael Pratt, Go LUCI, Ian Lance Taylor, golang-co...@googlegroups.com
      Attention needed from Josh Bleecher Snyder

      Junyang Shao voted Code-Review+2

      Code-Review+2
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Josh Bleecher Snyder
      Submit Requirements:
        • requirement satisfiedCode-Review
        • requirement satisfiedNo-Unresolved-Comments
        • requirement is not satisfiedNo-Wait-Release
        • requirement satisfiedReview-Enforcement
        • requirement satisfiedTryBots-Pass
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: go
        Gerrit-Branch: master
        Gerrit-Change-Id: I011cd7e1c2c614e2c5c4a0fadf062ac9be2266aa
        Gerrit-Change-Number: 736440
        Gerrit-PatchSet: 2
        Gerrit-Owner: Josh Bleecher Snyder <josh...@gmail.com>
        Gerrit-Reviewer: Florian Lehner <lehner.f...@gmail.com>
        Gerrit-Reviewer: Ian Lance Taylor <ia...@golang.org>
        Gerrit-Reviewer: Junyang Shao <shaoj...@google.com>
        Gerrit-Reviewer: Michael Pratt <mpr...@google.com>
        Gerrit-Attention: Josh Bleecher Snyder <josh...@gmail.com>
        Gerrit-Comment-Date: Fri, 16 Jan 2026 21:42:17 +0000
        Gerrit-HasComments: No
        Gerrit-Has-Labels: Yes
        satisfied_requirement
        unsatisfied_requirement
        open
        diffy

        Junyang Shao (Gerrit)

        unread,
        Jan 16, 2026, 4:42:39 PM (yesterday) Jan 16
        to Josh Bleecher Snyder, goph...@pubsubhelper.golang.org, Michael Pratt, Go LUCI, Ian Lance Taylor, golang-co...@googlegroups.com
        Attention needed from Josh Bleecher Snyder

        Junyang Shao voted Code-Review+1

        Code-Review+1
        Gerrit-Comment-Date: Fri, 16 Jan 2026 21:42:34 +0000
        Gerrit-HasComments: No
        Gerrit-Has-Labels: Yes
        satisfied_requirement
        unsatisfied_requirement
        open
        diffy
        Reply all
        Reply to author
        Forward
        0 new messages